- 21 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/nPjEGC7iC_JZPS-2t6OXpyqtoD_uxii0UigGyO6p6ToC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/158654343,b/165394926,b/165748389,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: If707950d26252fa151c73089f6efdbc1dc5893c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800734}
-
Ali Juma authored
This adds integration tests for real-time Safe Browsing checks. In order to test real-time lookups without making network requests to Safe Browsing servers, this adds a "--mark_as_real_time_phishing" command-line flag for treating a given URL as unsafe. This works by adding an unsafe verdict for this URL to VerdictCacheManager. This also adds a "--mark_as_allowed" command-line flag for treating a URL as safe according to the allowlist used by real-time lookups. Bug: 1111414 Change-Id: Id72c6a4f4ffe2186a71e680b34df9a1c4d0a7a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357553 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#800733}
-
Thomas Guilbert authored
This CL allows the WebCodecs feature flag to be controlled by origin trial infrastructure. It also bumps up WebCodecs to be part of the experimental Web Platform features. Bug: 1120704 Change-Id: I1ce31847ba467bdfd00e5ff2c6f4289c6d69fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368232 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#800732}
-
Stephanie Kim authored
Changes Mac Builder Next os to be 11.0, sets up Mac11.0 Tests thin tester, and sets up mac 11.0 trybots Bug: 1066875 Change-Id: Ic8355cae637464a6f056bbf5cbe46bdd98f24a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330737 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800731}
-
Etienne Pierre-doray authored
It's possible for a thread to re-enqueue a JobTaskSource right before the job is canceled/joined and will sill end up in the queue (the main thread may try to remove it before it's added again). The fix is simply to avoid calling user callback if the job has the cancel bit set. In addition, a job that's joined needs to be marked as canceled. Bug: 1120686 Change-Id: I1ca9458a22eda71c400cfb6f0ef42efc85e38e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369435Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#800730}
-
Andres Calderon Jaramillo authored
This CL adds some CHECKs to assert that duping dma-buf FDs is successful. See referenced bug for more details. Bug: 1097956 Test: None Change-Id: I766a8729cf34635892c69b297f4b09b2d8a9c471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366293Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800729}
-
Sinan Sahin authored
This is still flaky Bug: 1109965 Change-Id: I60297eeebd90cd73a088c51e3552479b78cb3ca8 Tbr: twellington@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369514Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#800728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f80c4be2. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ice04f0e0e3cb6779d5aa4708bc5740c6d52976a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369003Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800727}
-
Zentaro Kavanagh authored
These are used to track usage of Display features Bug: 1088714 Change-Id: I5bf1cd0c11fedb24035ed3ce49230677705129bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363697Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#800726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/12559f038590..a2193f8a8b70 2020-08-21 cduvall@chromium.org Add support for running WebLayer perf tests against bundles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: zhanliang@google.com Change-Id: I8f6e53e3ca4bd4f96971c63f59bf17b0d4bb7cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800725}
-
Jonah Ryan-Davis authored
These tests are crashing the ASAN bot. Skip for now until we can triage further. Bug: chromium:1119939 Change-Id: Ieff9bde84643ac6677bea77a73112ddaa373a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368499Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#800724}
-
evliu authored
This CL splits the SODA component into a single SODA binary component and multiple language pack components. Todo: Update the settings UI reflect the download progress of the SODA binary and the language pack(s). Todo: Verify that the SODA binary component and the language pack component is installed before launching the Live caption feature. Change-Id: Ia82ac3b46da2d37ce1e0fae9d6cd7fb541d67d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340873Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#800723}
-
Richard Knoll authored
This will filter any further TransferMetadata updates afterr receiving a final status one. Bug: 1085067 Change-Id: I75fa89ad57f61cf81ed7738c6b646218f3823e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368598Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800722}
-
Trent Begin authored
This change adds user visible strings for the network diagnostic routine problems. Bug: chromium:1098405 Change-Id: Ib482f2d27f2200639930023c0c797ef9ff1edafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363948 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#800721}
-
Ted Meyer authored
Causal statuses are required to be non-ok-statuses, but the conditions as written could allow a causal status to be generated from a successful HRESULT. This breaks the conditions up, and moves one of the checks from !SUCCEEDED() to FAILED() for consistency Bug: 1120094 Change-Id: I47c2524c2ee5ae4984f1616fb26f02386bfbe6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369434 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#800720}
-
Juliet Levesque authored
Resolved CSS pre-submit errors and added TODO comments for missing border on the Contacts tab and HTTP Messages tab. Bug: 1093634 Change-Id: I1c7425eb1d8f32e7a9b2f80ccc05fb5586e1494b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368823Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#800719}
-
Ken Rockot authored
This adds support for a new [UnlimitedSize] attribute on mojom interface methods, allowing them to bypass size-checking constraints in cases where the possibility of an occasional very large message is a known issue and is either awaiting a fix or is deemed acceptable as-is. Bug: None Change-Id: I6a2f884c71bf912e8804ed40afd22132b4d8e969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368429 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#800718}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9869f187b5ea..c86d8fb76ac3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iafaaa81b45bfcc5f55de59f7349c312a2989116c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369493Reviewed-by:
-
Zentaro Kavanagh authored
Use push_back where equivalent - see https://abseil.io/tips/112 Bug: None Change-Id: I98e6180eb7ec7eb3823ea2d1ad9deb47dcc31ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368317Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#800716}
-
Marijn Kruisselbrink authored
This ensures we always do a rename instead of a copy+delete. Also losens the checks in MoveFileLocal to actually allow this, FileSystemURL::IsSameFileSystem is stricter than necessary, as long as two FileSystemURLs share the same origin and final file system type a local move should be fine, regardless of what filesystem_id either URL has. Bug: 1120291 Change-Id: Ic06bbbb9a7b03c856272e1fb1e50dd026606e448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369352Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#800715}
-
Tom Anderson authored
BUG=1066670 R=nickdiego Change-Id: I9704a5903eee64b875831b845da5807bd23f50c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353576 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#800714}
-
Justin Cohen authored
Bug: 954232 Change-Id: Ib50e4199094ac2bc429bdf51342e11f77e6381c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369572 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be1455850c3c..8bd6c9830dd4 2020-08-21 bungeman@google.com Fixup fontmgr_bounds gm for variable fonts 2020-08-21 csmartdalton@google.com Reland "Add utilities to SkGeometry for quad and cubic rotation angles" 2020-08-21 johnstiles@google.com Add missing headers to .gn files. 2020-08-21 bsalomon@google.com Fix -Wstring-concatenation warnings in clang 12 2020-08-21 bsalomon@google.com Test performance of ANGLE ES3 on nanobench bots. 2020-08-21 egdaniel@google.com Add image usage flags to GrVkImageInfo 2020-08-21 brianosman@google.com Fix two null dereference bugs in SkSL visitor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I6e2f52f03ac3817b66dd686d7582f7bc783564f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368185Reviewed-by:
-
Dana Fried authored
As per request from UX, we are using: - linear-in for fling animations - shorter time for fling animations based on the amount of distance to the end of the animation TODO: consider basing animation time on fling speed, but fling speed seems to be highly unreliable and dependent on system event handling. Bug: 1116651 Change-Id: Ie768e83463532de841a4b80abb80a4d5ff9afedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368106 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800711}
-
Alex Chau authored
- Used NearbyFileHandler to properly delete PayloadPtr - Added base::ScopedDisallowBlocking to the test to ensure the class won't use blocking code except in thread pool - Moved creation of input payload file into NearbyFileHandler - Added various variable clearign to NearbyConnectionsManagerImpl::Reset Bug: 1076008 Change-Id: I2c35ddb3d01ae23186416b0175fbdb48d295251e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367682 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800710}
-
Joshua Pawlicki authored
Bug: 1119671 Change-Id: I3343d2d2520ba2cbea13ee9eae250a292eabe466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366666 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800709}
-
Maksim Sisov authored
Wayland may supply xkb layout engine with a keymap that it creates from a buffer. However, when I ran events_unittests with asan, it noticed a memory leak, which was caused by not freed keymap object. As long as we can have only one keymap from buffer at a time, store each keymap after a new context is created as unique_ptr that will be freed with a custom deleter on either dtor or when another keymap is created. Bug: 1120270 Change-Id: I741a6cb74713424f54dd858f84c0fec413cd6c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367938Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800708}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8125d936f9e0..fa27bc456b38 $ git log 8125d936f..fa27bc456 --date=short --no-merges --format='%ad %ae %s' 2020-08-20 jiejiang system_api: bluetooth: Add AddressType constants 2020-08-19 yichengli system_api: Add start/end fingerprint auth session method constants Created with: roll-dep src/third_party/cros_system_api Change-Id: I3470f9706149ade42c7026f769246ad522eca3b4 Bug: b:156258540, b:144861739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369001 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800707}
-
Lambros Lambrou authored
WebRTC provides a native C++ API for getting notified of changes to the selected ICE candidate-pair. This CL uses it to notify the HostStatusObserver of route changes, which enables the HostEventLogger to log the connecting client's IP address. Bug: 1119960 Change-Id: Ifa22faaeeddbf4f19e8ed422a581b840ec4caa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368428 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#800706}
-
Pranav Batra authored
This is a reland of 81e8107c. An extra colon in the PPD string for one of the unit tests that resulted in the CUPS PPD API using an uninitialized value and being terminated by MSAN has been removed. Original change's description: > Add Linux support for printer resolutions > > Add Linux support for PPD resolution options. > > Test: ./printing_unittests > Change-Id: I15d2245567e37938633c72daa2edc66cfa6f4b22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360472 > Commit-Queue: Pranav Batra <batrapranav@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800424} Change-Id: I0ec422f96e2b8df1a5e6829110f87fde7d7dbe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369371 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Auto-Submit: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800705}
-
Dan Sanders authored
WebCodecs expects AVC-formatted H.264 streams, but our decoders expect Annex B. Bug: 1119947 Change-Id: I8a0d92450890a9d625d1b2a67b1ea20377bdfd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368162 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/74161f485b5d54fe963cbd3d081b718ec84d2e00..c947efabcbc38dcf93e8ad0e6a76206cf0ec8072 Bug: none Change-Id: Ide8b6736f47d363190082cacf23ac52794107086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365093Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#800703}
-
Tommy Li authored
In the omnibox, if you mouse your mouse fast off of a row, while exiting via a child View, sometimes the whole row would stay hovered. This manifested itself by both exiting near the remove button, the suggestion button row, and the expand/collapse chevron button for header rows. This CL creates a new OmniboxMouseEnterExitHandler that generalizes the robliao/ssigwart solution to all of the row controls. It's also the same pattern used by: ArcNotificationContentView::MouseEnterExitHandler So maybe the Views team wants take over this utility class in the future. Bug: 1109473, 893183 Change-Id: Ibf3118c3cbe2231c1356778050764c93c93eb016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367396Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800702}
-
adoneria authored
Bug: 1109373 Change-Id: Ia86eb8fd1811948e765a3ceb80acb02de85f76ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368450Reviewed-by:
-
Jesse Schettler authored
PrintSessionImpl checks every 100ms for a subframe that has a PDF extension loaded. When it finds the subframe and sees that it's done loading, it waits 100ms for the PDF to finish rendering and then launches print preview. Recent changes increased the amount of time it takes for the PDF to render, so slower devices are launching print preview too early. Increase the time to wait for the PDF to render from 100ms to 500ms to ensure slower devices can render the PDF before launching print preview. Bug: b:165927343 Test: arc.Print Change-Id: If3e20fc2ffa3feb74e112e1e88c8248f164e80bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369613Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea7fbfb9665b..bce19cd0eefc 2020-08-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4591d36d..6cc8efac (800155:800536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ab4b27db6d0b5841411a69262c31707a5121146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369164Reviewed-by:
-
Xinghui Lu authored
Currently the help button is linked to the general Chrome help center. We'd like it to be linked to the Safe Browsing help page directly. The Safe Browsing help page was already added in go/mobilehelprecs. To reuse more code, create an abstract class named SafeBrowsingSettingsFragmentBase. This class handles help and menu related logic. SecuritySettingsFragment, StandardProtectionSettingsFragment and EnhancedProtectionSettingsFragment inherit from this base class. Bug: 1115758 Change-Id: I0fbe28eb21c46e6a0171ea987f1f1f5595111d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353563Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800698}
-
Jose Dapena Paz authored
It is not enough to make StrongAlias noexcept. TokenType needs to also provide noexcept move constructor. Bug: 819294 Change-Id: Ib85faa18f66b41053fb71ecee32e818e05685080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369180Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598010867-4aa503022e102f1aa007637f80b234f543663e29.profdata to chrome-mac-master-1598032222-bdae3e34bfdfdc02a739bd58b074dbcf46af85d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I893db2b8c433894570d038d445d4fd3c090c038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369552Reviewed-by:
-
Chris Lu authored
This change also removes a DCHECK since a test is more robust. Bug: 1030357 Change-Id: I939a4ec7ed4d4e60ef3518d293cd91f4d759c138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368141 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#800695}
-
