GitLab

This test has a pretty brittle expectation of failure for 0 != -0/
This is of course nonsense. (The astute reader will no doubt notice
that 0 does indeed exactly equal -0).

Fortunately there was already the idea of epsilon differences in the
test that were unused. Turning them on fixes the problem and allows up
to delete the expectation.

Also, in testharness assert_approx_equals(Infinity, Infinity, epsilon)
and assert_approx_equals(NaN, NaN, epsilon) were both returning false.
Considering assert_equals(Infinity, Infinity) and assert_equals(NaN, NaN)
are both true, this seems silly.

Bug: 1140535
Change-Id: Ie8a3977b3d97b920903a08a6301705c8c14fc6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498791Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821249}

This CL updates the customSeparator leading anchor according to the
text's leading anchor of each cells.

see: https://drive.google.com/file/d/1fzYGSTxmrU2iGN-GFd_NmXwHXj4i42_M/view?usp=sharing

Bug: 922511
Change-Id: Iddb7d1875ea8f169e7608c5a4f2c59fa2c78e48a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460893
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821248}

Change-Id: Ia1811f4126991402d59ad06e0b2c1c25313ab288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502670Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821247}

Fold

  SVGResourcesCache::ClientDestroyed,
  SVGResourcesCache::ClientWillBeRemovedFromTree and
  SVGResourcesCache::ClientWasAddedToTree

replacing the two former with a more direct RemoveResources(), and the
last with a similar acting AddResources().

Bug: 1028063
Change-Id: Ibf5eba0dc906d75967d9eaddb06ff01025d018e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501844
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821246}

NOTRY=true
TBR=kbr@chromium.org

Bug: chromium:982294
Change-Id: I7a58e763b70225f452b18ff8f2d50e5c4a9d76d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502951Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821245}

BUG=1142609

Change-Id: I24efcd9c895068c45817fe115d03e8beea526ac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500367
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821244}

When navigating back (through history navigation) to a srcdoc iframe,
we should expect the iframe to apply the same referrer policy it had
originally, even if in the mean time the referrer policy of the main
frame changed.

This CL adds a web platform test for this behaviour. Although the test
is failing at the moment in Chrome, we plan to fix this with the
Policy Container (https://crbug.com/1130587).

Bug: 1130587
Change-Id: I843808fddfc0c6fa5d65ce88599bce51471aa691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475033
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821243}

This caused a suite of tests to fail based on multiple test objects
mocking servers that don't expect extra connections. Rather than fixing
various test fixtures, we disable the search engine preconnect
behavior by default since it has good test coverage by itself. By
disabling the test in the constructor of in process browser test,
any sub tests should be able to override the behavior with their own
feature list.

Also re-enables test that was recently disabled.

Bug: 1128033
Change-Id: I998b4d0f801cf7d8aecde3a68be2f19f7f51cc12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494609Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821242}

Remove the handle bar that appears under the Omnibox when the thumb
strip feature is enabled.

Bug: 1094335
Change-Id: Ib07d307540412e22ee096eb0155583f3e51f7149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485499
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Cr-Commit-Position: refs/heads/master@{#821241}

This test failed on a single CI bot last time, for an unclear reason. I
am hoping that maybe crrev.com/c/2489918 will help.

Fixed: chromium:1135654, chromium:1124358
Change-Id: I3f98ec8bc46fd8af0a5f613411169f8600de077b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494763Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821240}

This CL was uploaded by git cl split.

R=bsep@chromium.org

Bug: 1142671
Change-Id: I7b1fdd8a277ab829520a07e0781a02325d9f43fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500612
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821239}

With this change, it becomes possible to filter element by computed CSS
property, for example, to find button that has not been hidden using
CSS, do:
  filters { css_selector: "button" }
  filters {
    css_style {
      property: "visibility"
      value { re2: "visible" }
    }
  }

The implementation is based on window.getComputedStyle.

Bug: b/171464032
Change-Id: Ic89219f969c614258edabec91705e9c37348138c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498484
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#821238}

This adds parsing support for a "SameParty" cookie attribute, which is a
boolean attribute (similar to "Secure" or "HttpOnly") to ParsedCookie.
Nothing uses this attribute yet.

Bug: 1142606
Change-Id: Ib1543df24ceefb1bb67be7fefd436a322d278f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500481Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821237}

Now that we have migrated the PageMsg_SetRendererPrefs legacy IPC to
Mojo and the ownership of blink::RendererPreferences to WebViewImpl,
we can also move this mojo RemoteSet to WebViewImpl as well, enabling
us to move even more code from RenderViewImpl into Blink.

Thus, this CL moves |renderer_preferences_watcher| into WebViewImpl by
defining a new WebView::RegisterRendererPreferenceWatcher() method that
would receive a CrossVariantMojoRemote as parameter to bind the remote
in Blink. With that in place WebViewImpl::SetRendererPreferences() does
no longer rely on RenderViewImpl::DidUpdateRendererPreferences() to
notify the watchers, getting us one step closer to entirely remove that
method from WebViewClient and its only implementor i.e. RenderViewImpl.

Bug: 1102442
Change-Id: If35c5302616e6411198965d35f55f04683a73db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498503
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821236}

This CL was uploaded by git cl split.

R=wjmaclean@chromium.org

Bug: 1142671
Change-Id: Ia735d1813d5f28dbe9c65f89e3d15285e57b410d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500573
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821235}

This CL was uploaded by git cl split.

R=wjmaclean@chromium.org

Bug: 1142671
Change-Id: I5fa2ec983348148bb2628281c61d2c0a9e213e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500574
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821234}

This CL was uploaded by git cl split.

R=bbudge@chromium.org

Bug: 1142671
Change-Id: I49c4cbda8bad1f164956289c7ee1bb9533330d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500492
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821233}

This CL was uploaded by git cl split.

R=wjmaclean@chromium.org

Bug: 1142671
Change-Id: If0a13494ab772d5f980c13fe37cfab186f99e26c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501122
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821232}

A few lint fixes; no functional changes.

Bug: 1010217
Change-Id: I26fac87d0bf50d95eef51eccd73cd1bc17c74330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488619Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821231}

This change adds a comment that existing usages of base::ListValue
should be replaced by std::vector<base::Value>.

Bug: 646113
Change-Id: I7f2210f7f68d3bac5aa220041411e37db88ab097
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502021Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821230}

for wpt-expectations-updater (used by wpt-importer)

100% was too strict, as renaming/moving a file would usually require
changing the paths in the file. 90% *should* be enough for the most
basic cases (e.g. reference, resources), while still conservative enough
not to cause confusion caused by shared boilerplate between a deleted
test and a newly added test.

Also removed an unnecessary "-M" flag for deletion detection.

Drive-by: some stylistic fixes (by pylint and `git cl format`)

Bug: 1141061
Change-Id: I9196d0739eb3e93b63dbb29d6b271c07df5b7357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500722Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821229}

This patch enables offset-from-point-complex-scripts.html on Mac because
the test is no longer failed on these days[1].

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&showExpectations=true&tests=editing%2Fselection%2Foffset-from-point-complex-scripts.html

Bug: 864888
Change-Id: Iecee744df60dc3956e97d73ba94d1ccbb30e3830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497743
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821228}

Roll Chrome Mac PGO profile from chrome-mac-master-1603777504-1efb0ca1330464e38ca172c34d8ac2b307218a42.profdata to chrome-mac-master-1603799921-5641a8e4cf3ceccb7c3fad2e0b8caf839faa62b9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia6e42841cd48fcab80cf3e9a3ae0c180dd9fcf11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821227}

We are deprecating attestation methods by CryptohomeClient.

BUG=b:158955123
TEST=unit_tests.

Change-Id: I4a046aa0c11b720ecb1d6fee99afdba025234537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497390
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821226}

Roll Chrome Linux PGO profile from chrome-linux-master-1603777504-e29f505cee8cadd0b5b5127539f147bff09e64be.profdata to chrome-linux-master-1603799921-18f2bb90aa116c4ca4ae138df9ceaff090340372.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I3cb45ba8313f331ba2a7f48df496172223435dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821225}

This CL add in some extra condition in updating scopes_route_cache_.
A node should not be considered as an scoped routes node if it does not
has any children that is a named routes node. This will solved the
problem of not triggering edge transitions when scoped routes node is
unchanged but its children come and go.

Test: build cast_shell and unittest
Bug: b/171499941, b/168548001
Change-Id: I3b48179762871d8d9faa5df9afff0a2ac3c935c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495913
Commit-Queue: Yuanyao Zhong <yyzhong@google.com>
Reviewed-by: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821224}

Bug: 1109316
Change-Id: Ieb94246f7aabc11a9a6092e67dba67a6610c4147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500451
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821223}

Signature-based Resource Loading Restrictions is an experimental
feature of Content Security Policies for allowing execution of
scripts only if they have a valid signature. The feature was
prototyped, but it looks like we are not shipping it as it is
for the time being.

Let's remove it from now, we will get it back in the future when
we decide to come back to this.

Bug: 753349
Change-Id: I8fb808999144c32d6fa94ae5bf9299e1da275e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494882
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821222}

We are deprecating attestation methods by CryptohomeClient.

BUG=b:158955123
TEST=unit_tests.

Change-Id: I0a4761f41efb4f4a904933e1177431615c19d036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497388
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821221}

Add fieldtrial entry for safety check on iOS for experimenting in
Beta.

Bug: 1078782
Change-Id: I9be9b7e8f5d3d65edfe9a386f83433d054793247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498545Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821220}

Bug: None
Change-Id: I5bbedbf640528bf5b62cd5f38db615e4ae6a9f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498528Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821219}

Currently UpdateBoxSizeAndCheckTransformAxisAlignment loops over all
animations in ElementAnimations, including otherwise-unreachable ones
which have not been garbage collected yet, which can cause the function
to loop over and test/update many completed animations unnecessarily,
hurting performance. Add a fast check to exclude animations no longer
current or in effect.

Bug: 1142176, 1142666
Change-Id: I3f489fa022df173d9dc20b198c0894dabb7bfdc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500604Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821218}

This class is not necessary anymore because we don't use cryptohome
client to perform attested key deletion.

BUG=b:158955123
TEST=build.

Change-Id: I155bacc851ee27a5c96264230b0169753b17ce31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497387
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Michael Ershov <miersh@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821217}

This change disables Done button in case entered password is empty.

Bug: 1137475
Change-Id: I3e110654695c07336d6c85c01b3463d3da5c1b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485493
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821216}

This CL was uploaded by git cl split.

R=antrim@chromium.org

Bug: 1142671
Change-Id: I19f9ac69a3da5fb06c5bb76f365e037b411d7eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500214
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821215}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/011cbddc5cdb..4af02fc0ad4a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC droger@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: droger@google.com
Change-Id: I11f23d9bb3ba460d5e7df4a1c3cc9a3d9c9db741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501731Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821214}

Since V8 and Renderer CL cannot be glued a separate CL includes the changes to V8:
https://chromium-review.googlesource.com/c/v8/v8/+/2494706

Screenshot: https://i.imgur.com/rTIchch.png, https://i.imgur.com/knMTmMm.png
Bug: chromium:1048143
Change-Id: I59ba1735b83da3eac328cff31dd1729ec3b16e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494761
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821213}

Roll Chrome Win64 PGO profile from chrome-win64-master-1603701931-6f855b80e1fee5d14d084f4dde5311562280349a.profdata to chrome-win64-master-1603767556-44fda54b3a92e9d2336119e8c5ad34567957992b.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I23e2847f4b1a97d97f680155061ca41641996926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501361Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821212}

This change simplifies PasswordFormGenerationData by turning it into an
aggregate struct. This allows the removal of explicitly listing
constructors, assignment operators and destructors, and also allows the
usage of designated initializers for more type safety.

Bug: 1075444
Change-Id: I9bab98cebb43d45e8a0ea29702a1e326f1bd63d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498595Reviewed-by: Maria Kazinova <kazinova@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821211}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I7d45f7b58da0b18ec2eb152b859e3f0a8933d86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501664Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821210}