GitLab

TBR=mmoss@chromium.org

Change-Id: I1c1ea7e2a0e09f5afd36e6ccbda5d11dd566b0a3
Reviewed-on: https://chromium-review.googlesource.com/804561Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521197}

This class was copied into 4 different egtest files. Move it to
a shared location where it can be re-used.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I729755a9b211374a301923d2b9777a3ede2ca17c
Reviewed-on: https://chromium-review.googlesource.com/779943
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521196}

With this change user can update return value when paused at
return position.

Bug: chromium:656150
Change-Id: I8e31799461be21d839e256cc63f8bf8748875fc1
Reviewed-on: https://chromium-review.googlesource.com/802695
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521195}

Previously we always re-created the whole CompsositorFilterOperations in
FragmentPaintPropertyTreeBuilder::UpdateFilter(). Because we don't have
value-comparing == operator for reference filters, re-created reference
filter wouldn't equal to the previous one even if there was no actual
change in the filter, causing we always treated a FilterPaintPropertyNode
as changed when it was updated.

This caused different results for some layout tests with DCHECK enabled
and disabled, because forced update by FindPropertiesNeedingUpdate forced
re-creation of CompositorFilterOperations.

We can't use CompositorFilerOperations::EqualsIgnoringRefrenceFilters()
when detecting paint property change because it will cause false
negatives.

It requires much code to implement deep value-comparing == operator for
reference filters, and the comparison would be also expensive. It's also
unnecessary to re-create CompositorFilterOperations then detect its
change if the filter style and reference box don't change.

Now let PaintLayer record filter changed status. If the filter and the
reference box didn't change, we reuse the cached CompositorFilterOperations.
In this way we simply use the current pointer-comparison of reference
filters.

Bug: 771643

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8a872270c10562d8243ce46c3d2861c83531c074
Reviewed-on: https://chromium-review.googlesource.com/791919Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521194}

There are several uses (some indirect) of base::File which either
use errno or ::GetLastError() when the file open fails. Indirect
users (like callers of CreateTemporaryFileInDir()) don't have
access to File::error_details(). Setting errno, or calling
::SetLastError() to enable these clients to properly handle/log
the cause of failure.

Bug: none
Change-Id: Ifc580068a08ce8e726faa645468c1e9b1c57936c
Reviewed-on: https://chromium-review.googlesource.com/802617Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521193}

This CL allows empty functors on base::BindOnce and base::Repeating, and
adds base::BindLambdaForTesting that is a test-only variant of Bind that
binds any callable object to a RepeatingCallback.

Bug: 789805
Change-Id: I7fa34acd2a6b79e8c26d3f6ded67e91bd8d6b966
Reviewed-on: https://chromium-review.googlesource.com/798817
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521192}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership complex.

After this CL, the clock instances are always un-owned by injectees.
Instead, an injecter owned one is used on testing, and the shared
instance is used on production path.

Bug: 789079
Change-Id: Ic91e3cbb16c8d66131936b6b4c6e74ed212602c2
Reviewed-on: https://chromium-review.googlesource.com/803154Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521191}

It doesn't make sense we open the lib and create a subset of bindings and use
our own code to do context related GPUInfo collection. We should just use the
same code on any other platforms.

We saw a surge of crashes related to this piece of code, my suspicion is the
current code path isn't doing the right thing. Let's see if we switch path and
order, situation changes.

BUG=787737,738414
TEST=bots
R=piman@chromium.org,kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If1e094faa38777c051d6e8fa559d133cce444c1a
Reviewed-on: https://chromium-review.googlesource.com/804659Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521190}

This change does two things:
1. Improves error handling to ignore InvalidNetworkGuid errors which
   may happen e.g. when a device is disabled.
2. Uses 'set' to property update an active network state and notify
   observers.

Bug: 781776
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I37e584870c63676a885d19167f1c2bdadf7be6b3
Reviewed-on: https://chromium-review.googlesource.com/804595Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521189}

This CL adds several process model tests for hosted apps and tries
to keep same-site iframes in the hosted app's process.  There are
additional ways to improve --site-per-process behavior around hosted
apps (e.g., same-site popups), but this CL doesn't address them yet.

This CL is a continuation of creis@'s
https://chromium-review.googlesource.com/c/chromium/src/+/792605.

Bug: 718516
Change-Id: I10c6ecc6799aa92bbd789efb5e8dcfebd1aa90da
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/798120
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521188}

https://chromium.googlesource.com/catapult.git/+log/c8947ecc4964..c796cbc3a6e6

$ git log c8947ecc4..c796cbc3a --date=short --no-merges --format='%ad %ae %s'
2017-12-01 rnephew [Telemetry/TADA] Make TADA parser return structured data instead of dictionary.
2017-12-01 nednguyen Fix startup browser breakage when clear_sytem_cache_for_browser_and_profile_on_start is set

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9660ec3acb5116decaef72cbecddd43195c52fe7
Reviewed-on: https://chromium-review.googlesource.com/804938
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521187}

Migrate |SetOnlineWallpaper| (used by wallpaper picker) to
WallpaperController.

The goal of the CL:

1) Make sure not to introduce regression in |WallpaperManager| under
Config::CLASSIC. (Have to use some 'hacks' within |WallpaperManager| to
avoid forking the code.)

2) MASH does not crash when setting wallpaper, but it won't be able
to save wallpaper. The wallpaper newly set during an active session
will be lost when the session ends.

TBR=brettw@chromium.org

Bug: 779221
Change-Id: I7b6f1d1d95a8a4b0ad20d31bc4dcc957207f246e
Reviewed-on: https://chromium-review.googlesource.com/770711Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521186}

According to TODO comments, it can be removed as Issue 594645
was already closed as fixed.

Bug: 594645, 779730
Change-Id: I2e7c2722023624d580a4f300c4aa520f2be895ab
Reviewed-on: https://chromium-review.googlesource.com/794016Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521185}

An invocation of StreamFactoryImpl::JobController::ResumeMainJob()
may be posted with a delay. During the delay, the pending jobs
(including the main job) can be canceled. This CL adds a check
that the main job is still alive before resuming it.

This change may also fix 790776.

BUG=789560,790776

Change-Id: I16ac35e44c1b894794b03f1c4561664a56f1eb11
Reviewed-on: https://chromium-review.googlesource.com/805034Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521184}

To reduce modifications to SecurityContext's SecurityOrigin and
make it easier to make SecurityContext's SecurityOrigin const.

Instead of
- Setting a SecurityOrigin to Document by SetReplicatedOrigin() and
- Later then modifying the SecurityOrigin by
  SetReplicatedPotentiallyTrustworthyUniqueOrigin(),
This CL
- Adds |is_potentially_trustworthy_unique_origin| argument
  to WebRemoteFrame::SetReplicatedOrigin() and instead removes
  WebRemoteFrame::SetReplicatedPotentiallyTrustworthyUniqueOrigin().
- Modifies SecurityOrigin before SecurityContext::SetReplicatedOrigin()
  in WebRemoteFrameImpl::SetReplicatedOrigin().

This CL takes IsolatedCopy() of SecurityOrigin in
WebRemoteFrameImpl::SetReplicatedOrigin(), but this shouldn't cause
behavior changes, because the supplied SecurityOrigin is constructed
from url::Origin and is not aliased with any other SecurityOrigin.

This CL also adds WebSecurityOrigin() constructor call explicitly
in unit tests, because once we make WebSecurityOrigin() constructor
take |scoped_refptr<const SecurityOrigin>|, then the compiler can't
infer the implicit conversion there.

Bug: 779730
Change-Id: I93c98b5b897dafe3a1f25ded4e7efc258a101df6
Reviewed-on: https://chromium-review.googlesource.com/762407
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521183}

to NotificationDisplayService.

Also combine the two generic click handling NotificationDelegates.

Bug: 783018, 755413
Change-Id: I180350bfa0507851f658d619f2918c04a81c5d7a
Reviewed-on: https://chromium-review.googlesource.com/765047Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521182}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c5a1c4c3c97..17995a9f1282

$ git log 6c5a1c4c3..17995a9f1 --date=short --no-merges --format='%ad %ae %s'
2017-12-01 myjang [depot_tools] Remove deprecated config check in canned checks

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Ifbf224682a7b093dfdb00defd5aeed1a0aeae1bc
Reviewed-on: https://chromium-review.googlesource.com/804826Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521181}

1) A follow-up to CL 798852, which causes a DCHECK failure.

2) Changed 'Toggle' to 'Add'. In production there's no way to toggle
   the channel info back to empty.

3) Iteratively adds information. Disable the button after all the info
   has been updated to simulate the real scenario.

Bug: 789755
Change-Id: Id62a52fc822a7f41ad4cd35955b3ce7e9d1f058d
Reviewed-on: https://chromium-review.googlesource.com/803749
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521180}

This CL introduces the notion of input focus and adds plumbing
between the GVR Keyboard and our UI. It adds functionality for
showing the keyboard on input text focus, and updating the said
input text model when the user types on the keyboard.

Bug: 780135,780318
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I91c02e2de8b96703307c6f37436ef107d5b5dd07
Reviewed-on: https://chromium-review.googlesource.com/786302
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521179}

Verified on my 1050 that this is working; pulled the NVIDIA driver
version from DisplayDriver/nv_dispi.inf in the 375.76 package, which
contains the fix for this.

BUG=635319
TEST=verified no corruption with https://imgur.com/DqJWQlm on 388.13.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I759f628d2cef250e867fc17aaee51aff1a6e4bb9
Reviewed-on: https://chromium-review.googlesource.com/804634Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521178}

It had a custom implementation to support use of RawResourceClientStateChecker.
Separate these.

Bug: 790778, 640291
Change-Id: Id8a29a5ad916429969b47a0258675437de284b55
Reviewed-on: https://chromium-review.googlesource.com/802094
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521177}

PageSignalReceiver delivers signals to all PageSignalObserver with WebContents,
which may not be managed by the client. This patch ignores those WebContents
that are not managed by TabManager.

BUG=789084

Change-Id: Ia697a5c6ef734c5cf3e3042caa4c81d1d4932f77
Reviewed-on: https://chromium-review.googlesource.com/804821
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521176}

This CL:
* Prevents updating the 'Enable SIM card locking' toggle while a SIM
  dialog is visible (e.g. when a network update arrives).
* Debounces toggle state update.

Bug: 784805
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6780330af0675ca09ac61dca67e72e0a40e582bb
Reviewed-on: https://chromium-review.googlesource.com/803629
Commit-Queue: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521175}

This fixes a regression introduced by
crrev.com/d4e5fdd3.

'image-activate' needs to fire when selected item is of
type OLD.

Test: captured image is activated when selected
Bug: 786887
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ef20f00ef8581721463be33b667456a955e0b6d
Reviewed-on: https://chromium-review.googlesource.com/804834Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521174}

which is a more logical and intuitive place than Rebaseline.

Besides, we add support for removing redundant all-PASS testharness.js
baselines that are not at the root. This may happen when a platfrom
result becomes all-PASS, when its fallback platforms are already
all-PASS, in which case we only download a new all-PASS baseline to the
platform. The previous optimization only looked at the root.

Bug: 768525
Change-Id: Icf4fa98850f5a72541a20d54217a64daef8cb389
Reviewed-on: https://chromium-review.googlesource.com/803795
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521173}

This allows a consumer to call SetAccessibleName multiple times and
have the new name be reflected in ChromeVox.

Bug: 719015
Change-Id: If355c3988907f67f336255a9b146e742e44bf9e2
Reviewed-on: https://chromium-review.googlesource.com/709921Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521172}

Field has a label of "ms", but was actually being output in seconds.

BUG=none
TEST=manual

Change-Id: I24025ba0dc956697d8315c81aa940ea86937a013
Reviewed-on: https://chromium-review.googlesource.com/804616Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521171}

signal strength value is added to the network ID struct. This makes it
possible to store multiple network qualities for the same network
(e.g., a cellular network) along with the signal strength at which
the quality was computed.

When reading the cached network quality, the entry with the signal
closest to the strength of the current network is used.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug: 786997
Change-Id: Ib0f1ad2dacc8590cba7fc0d5180ef0547fb5c6e6
Reviewed-on: https://chromium-review.googlesource.com/785554
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521170}

The API implementations and the code that uses that API generally evolve
together so it makes sense to have the same owners for each. Also arnarb
has lost commit privileges and juanlang is away, so this code is
otherwise stuck.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iadc44d9cf12c975f5857a1601fe88b3e09e16c9b
Reviewed-on: https://chromium-review.googlesource.com/804405Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521169}

As of yesterday, LUCI UI is the new default for Chromium
(https://groups.google.com/a/google.com/forum/#!topic/chops-team/dYJaBL-b46U),
and this means that in the future, we can expect build pages to generally have
URLs with ci.chromium.org, e.g.
"https://ci.chromium.org/buildbot/tryserver.blink/mac10.10_blink_rel/4830".

As far as I understand, LUCI builds with build numbers will behave
basically the same as Buildbot builds with build numbers;
layout test results would be archived to the same place, etc.

Bug: 771438
Change-Id: I42d498caa3a455115e05a50d5f7f69046010530e
Reviewed-on: https://chromium-review.googlesource.com/803615Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521168}

This adds a new state to ChromeChromeController indicating that
the reporter is currently running. This allow us to reflect the
global state in chrome://settings/cleanup and makes it easier to
update the card currently being rendered.

This also simplifies the reporter installer by not requiring the
on_sequence_done callback to be passed, once we decided that the
cleanup page will reflect global state for reporter/cleaner runs,
so we don't need to keep track of the results of individual
sequences.

Bug: 776538
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2ba1c6fb5b72e981d6d25de5e340bc711fbe3b30
Reviewed-on: https://chromium-review.googlesource.com/794533
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521167}

Bug: 791159
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idbc8b244d2f39c61eeaccf177cf306e4edc1ba4c
Reviewed-on: https://chromium-review.googlesource.com/804339Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521166}

Used by MediaCodec to display HDR content
Bug:internal b/68950223
Test:none

Change-Id: I6db3a1e5ce8e74ee6614d557edc7351b75306f2d
Reviewed-on: https://chromium-review.googlesource.com/756443
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521165}

This will make it possible to autogenerate these files with 100% fidelity.

Stop skipping the associated testers on chromium.android.json in the
manage.py script. This was the reason the gtests got out of order in the
first place.

BUG=662541
R=dpranke@chromium.org
NOTRY=true

Change-Id: I2efc4ed6e7f7564737709d5eda607f5d4543a2a8
Reviewed-on: https://chromium-review.googlesource.com/804748
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521164}

Images from files are typically not PNG so we can't rely
on image bytes to be available. Check format and bytes
when selecting image type 'old' to fix this.

Test: DCHECKs passes when selecting image from file in settings
Bug: 
Change-Id: I00ac5ff27520e6a7de249e3fb4a9a4c6c9663e7b
Reviewed-on: https://chromium-review.googlesource.com/804855Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521163}

The drag and drop autoscroll tests were timing out under
root-layer-scrolls but autoscroll itself worked. The issue was that the
LayoutView now owns the scrollbars when RLS is turned on so its
bounding box is larger. This meant that the autoscroll activation region
was further out so the test never activated autoscroll.

This test fixes the issue by excluding the scrollbars when calculating
the autoscroll regions. This means that the activation area starts from
the scrollbar-content edge, rather than the window edge.

Bug: 781431
Change-Id: Ifc0e03d8e5016055586f6242feddc7af50f90069
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/802519
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521162}

https://pdfium.googlesource.com/pdfium.git/+log/752e9bf892ab..b8d86800487d

$ git log 752e9bf89..b8d868004 --date=short --no-merges --format='%ad %ae %s'
2017-12-01 thestig Get rid of else after break/continue/return.
2017-12-01 npm Check for success of decodes to avoid infinite loops

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia547589983fd183d6e9a130426663c638a4f72c6
Reviewed-on: https://chromium-review.googlesource.com/804815
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521161}

This CL hides the BarBanner with an animation if it is triggered
while already showing.

Bug: 786459
Change-Id: I252dbad91ebbcca0ce1e7449e556a3e74cc1109a
Reviewed-on: https://chromium-review.googlesource.com/803906Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521160}

Merge DataReductionProxyConfig::ShouldEnableServerPreviews() into
DataReductionProxyConfig::ShouldAcceptServerPreview().

Bug: 790733
Change-Id: Iea803f50c5f0346e4ade31e80fcb98f18d3c99d7
Reviewed-on: https://chromium-review.googlesource.com/803670Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521159}

The in-progress cache is used to store metadata related to in-progress
downloads. The entry for the download is created upon the initiation of
the download and removed after the download is completed. This CL
continues the implementation of the in-progress cache by implementing
the read/write functionality in the following manner:

- making the in-progress cache an interface.
- initializing the cache during the creation of the download item,
halting the completion of the creation until the cache is initialized
(similar to the history database, which persists longer-term info).
- reading from the file during initialization and storing information
in an |entries| object.
- updating the |entries| object when adding/replacing/deleting and then
writing to the file using ImportantFileWriter.
- including unittests for this process.

Bug: 778425
Change-Id: I8f69dd51dd619dbc688c0f2b6a3b079a3b1164ec
Reviewed-on: https://chromium-review.googlesource.com/736907
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521158}