- 03 Dec, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
And remove perezju. Bug: 1029008 Change-Id: I4fc67136b7816b687ff1c902d5b7b75e176e766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944471Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721030}
-
Roman Aleksandrov authored
Make user menu adjust to the height of virtual keyboard and tray. Bug: 1012499 Change-Id: Idd58cd4943998e60d3008d9e8210cf8bfb8853fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943173Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#721029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dac0d8216b2..db2e7641bed8 git log 9dac0d8216b2..db2e7641bed8 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 brianosman@google.com Particles: SkImageBinding to allow sampling an image from script Created with: gclient setdep -r src/third_party/skia@db2e7641bed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I09b0b89f33d56af9441525ae647d95cdb0ba1fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721028}
-
David Roger authored
This is a reland of f21f4c91 The CL is the same as the one that was reverted. The failing Sync test was modified in the meantime by CL https://chromium-review.googlesource.com/c/chromium/src/+/1948890 and should now pass. Original change's description: > [signin] Don't clear unconsented primary account on cancelling Sync dialog > > The unconsented primary account doesn't necessarily change when the Sync > confirmation dialog is cancelled. > In particular this is the case when PrimaryAccountMutator::ClearPrimaryAccount > is called with RemoveAccountOptions::kKeepAll. > > This CL stops resetting the unconsented primary account as part of the signout > process. > The unconsented primary account is recomputed anyway when GoogleSignedOut is > called. > > > Fixed: 1029701 > Change-Id: Id46bb468952efe63170a13872519fcaded076cb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944862 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Monica Basta <msalama@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720502} TBR=msalama Fixed: 1029701 Change-Id: I26e872f140db99d723037c16dc55219df5a0c706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947647Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721027}
-
Yi Gu authored
Bug: None Change-Id: I0746696dbc76058c86c21b27611a3a479584f021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948740Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721026}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLObjectElement> and DynamicTo<HTMLObjectElement> as new downcast helper 2. Use IsA<HTMLObjectElement>(element) in place of IsHTMLObjectElement(element) Bug: 891908 Change-Id: I1fedbe9efc9e44cd101f9467bc15b6b785f9a316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948398Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#721025}
-
Matt Menke authored
Link Doctor fetches suggestions for certain errors when trying to navigate to an HTTP site. This CL temporarily disables it due to a bug in the (currently unowned) server side service. Further down the line, we'll either need to find an owner (both for the server side code and the Chrome side code) or remove the code for this. This CL also fixes a bug in errorpage_browsertest.cc. Way back when, the mock suggestion service switched from using a suggestion URL served by the error page to a fixed URL. ExpectDisplayingNavigationCorrections() was updated to reflect this URL, but ExpectDisplayingLocalErrorPage() was still checking for a URL served by the EmbeddedTestServer. This CL updates ExpectDisplayingLocalErrorPage() to check for the correct fixed URL. Bug: 1011893, 1030281 Change-Id: I2195ff8e97ea32f408edd45e7a16770ce56ccfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946705 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721024}
-
Dave Tapuska authored
Clean up some old TODOs. BUG=695622 Change-Id: I2b4526efafd77782270e4d7086a5f9fd09b9d5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940494Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721023}
-
Antonio Gomes authored
... in favor calling the ctor directly. BUG=787254, 939691 R=guidou@chromium.org Change-Id: I523d0b23d94152ce815e5ac8ab1099da307b0728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944368 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#721022}
-
Juan Antonio Navarro Perez authored
Builder hasn't worked for a long time, and is no longer needed. Bug: 1029016 Change-Id: I5b29851a48052e0ddf4e89dfd5ccb15a3fe59fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945813 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#721021}
-
Peng Huang authored
There are three problems: * DisplayResourceProvider shouldn't return resource to client when resource is still used by overlay. * SkiaRenderer should Unlock overlay resources with sync token which will be released when the SwapBuffers() is done on GPU thread. * On Windows, SkiaRenderer should release overlay resources when next SwapBuffers is done instead of current SwapBuffers. Bug: 1029556 Change-Id: I91c22106bacf51b28eded4de7a11426b095e6ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944319Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721020}
-
John Chen authored
Add some workaround code while setting browser window to fullscreen mode, to work around an issue in DevTools fullscreen command. In particular, call document.documentElement.requestFullscreen() to ensure that document.webkitIsFullScreen returns the correct values. All WPT tests related to fullscreen now pass. Also made an adjustment to WPT set_window_rect/set.py test_fully_exit_fullscreen, which was using a width below the minimum supported by Chrome. Bug: 982071 Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947816Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721019}
-
Mounir Lamouri authored
This CL makes sure video track disabled by video background track optimization is re-enabled when entering Picture-in-Picture. Bug: 949265 Change-Id: Id0cca141f262537672f49f8cdc8bc6db5c10e3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556837Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#721018}
-
David Benjamin authored
chlily@ pointed out that some of the SameSite tests needed to use localhost and 127.0.0.1, and then even spin up separate servers because the names aren't one certificate. This is a little goofy. Add an example_domains.pem file where we can add names as needed to support testing cross-origin and cross-domain behavior. Start with a.example and b.example. Bug: 984685 Change-Id: Ibf545293a49f9b54ba1ebf356d72c978c330ff56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910345 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#721017}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f205775e90f3..efedd6739684 git log f205775e90f3..efedd6739684 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rharrison@google.com Create spvc specific return codes and use them (#918) Created with: gclient setdep -r src/third_party/shaderc/src@efedd6739684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I519169e453b757a2b5fdad6d4cd8b92c7e61816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948796Reviewed-by:
-
Jun Mukai authored
Bug: none Test: none Change-Id: I24891e76992cfbec3eaa8caa82ee881d2a50e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940564Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#721015}
-
Alexander Hendrich authored
This CL modifies the list of profiles included in a browser report to *not* include irregular profiles (e.g. sign-in profile or lock screen app profile). Bug: 1010213 Change-Id: I30d383ecbb06efcd387a986a8a343e436c03212d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946367Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#721014}
-
danakj authored
TBR=sky@chromium.org Bug: 714018 Change-Id: I684311c0b3f4b213f59508c3f5cee528598fb89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948519Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721013}
-
Matt Simmons authored
Bug: 1004441 Change-Id: I9a5f182b9997fc0b6b61cf2b721d53fbc9c06ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946939Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#721012}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c526f508df1..8c0012bc5c16 git log 2c526f508df1..8c0012bc5c16 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "Allow TraceProcessor to parse ChromeCompositorSchedulerState." 2019-12-03 fmayer@google.com Make ReachableNode iterative rather than recursive. Created with: gclient setdep -r src/third_party/perfetto@8c0012bc5c16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:145582463 Tbr: perfetto-bugs@google.com Change-Id: Ib13c002333d56530e5b954a38a259ccc32c448e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948912Reviewed-by:
-
Marc Treib authored
...to POPUP_ITEM_ID_PASSWORD_ACCOUNT_STORAGE_OPTIN. The new name better reflects what this actually is. No functional changes. Bug: 1024332 Change-Id: Ifdf2be3ab402f8b6a40f4fa09983e6a3f64bff50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948930 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721010}
-
Roman Sorokin authored
Also added a test for the timezone screen Fixed: 1030035 Change-Id: I0f5eca09661192f9c12888fb66bed8a06581b563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947742Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721009}
-
Egor Pasko authored
TBR=hans@chromium.org Bug: None Change-Id: I0007fb38499a66a50cddf89b65ef1dc8fc58e077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948934Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#721008}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGStyleElement> as new downcast helper 2. Use IsA<SVGStyleElement>(element) in place of IsSVGStyleElement(element) Bug: 891908 Change-Id: Iedb35f2161124699df4db245fbf6df9474b98ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948670Reviewed-by:Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#721007}
-
Livvie Lin authored
This is a reland of 702cbe72 The original change was reverted due to failures of the changed tests on trunk (see crbug.com/1029292), so this updated CL uses conditional expectations based on whether the feature is enabled. Original change's description: > Add HTTPDangerWarning experiment to field trial testing config > > Bug: 1027626 > Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719730} Bug: 1027626 Change-Id: I16415497b537b1350af79c88f76a03ef48ae488c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946671Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721006}
-
Elly Fong-Jones authored
This test is actually super flaky on Mac as well, but the flakiness is hidden from the dashboard by issue 899286. Bug: 1028239, 909570 Change-Id: I5e71590eb242df8ed8990332b0135590183726a5 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948044Reviewed-by:
-
Fredrik Söderquist authored
Apparently we sometimes miss to dispatch 'endEvent's, leading to this test timing out. We can switch it to listen for 'beginEvent' instead though with no harm done, so do that. Bug: 1030228 Change-Id: Ie7495d478b0d799fc54b16b45efba9527da222c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948886Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721004}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3bf22fd49e87..7b9a9186c365 git log 3bf22fd49e87..7b9a9186c365 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 aerotwist@chromium.org Migrates inspector_main/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@7b9a9186c365 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id22e4e82237683e2c1e6a269851ddb1bb44b94f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948909Reviewed-by:
-
Vladimir Levin authored
This patch adds early outs in some of the compositor tree walks. This reduces the time on the referenced bug significantly (down to ~60fps on my linux machine), and it doesn't increase as the complexity of the subtree increases due to initial layouts. R=chrishtr@chromium.org Bug: 999486 Change-Id: I43e176d7020cc1979f99d822c80ca60d87410225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937511 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721002}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8ec8ea1910d..fd5a91ebf34d git log b8ec8ea1910d..fd5a91ebf34d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 pihsun@chromium.org cros: Fix `cros --help` 2019-12-03 vapier@chromium.org cidb/claction: drop InsertCLActions 2019-12-03 vapier@chromium.org run_tests: drop python3 blocklist 2019-12-03 vapier@chromium.org deploy_unittest: flush output when running tests 2019-12-03 mmortensen@google.com BuildAPI: Add unit tests and mocks for Test service. 2019-12-03 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-03 vapier@chromium.org cl_messages: drop unused module 2019-12-03 vapier@chromium.org sysroot_lib: use UTF-8 encoding with commands 2019-12-03 akeshet@chromium.org chromite: update protos 2019-12-03 jrosenth@chromium.org cros_gdb: fix format string for missing sysroot error 2019-12-03 cjmcdonald@chromium.org Disable greedy Chrome matching on automated builders 2019-12-03 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-03 vapier@chromium.org auto_update/xbuddy: use cros_test_lib.TestCase 2019-12-02 vapier@chromium.org prpc: drop unused module 2019-12-02 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-02 vapier@chromium.org factory: drop duplicate CachedFunctionCall 2019-12-02 vapier@chromium.org repository: use UTF-8 encoding with commands 2019-12-02 mmortensen@google.com Enable wrapping 'tee' functionality around build_api commands. 2019-12-02 vapier@chromium.org cbuildbot: relevant_changes: drop unused module 2019-12-02 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@fd5a91ebf34d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I64103eab4ce50dafc9c7e13342b10881d2860ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948908Reviewed-by:
-
Marc Treib authored
Before this CL, the test HandlesResetFromDashboardWhenSyncActive checked that after a "Reset Sync" operation, the Sync machinery would *not* start up again in transport-only mode. This is not actually true in practice (on "Reset Sync", the account credentials remain, so Sync will still run in transport mode), and the test only passed due to incomplete (or unrealistic) setup, in particular, setting a primary account with refresh token but no cookies. This CL removes the invalid expectations, and instead adds explicit expectations about the primary-ness of the account, which is really the thing it meant to test anyway. Bug: 1029701 Change-Id: I7916d382ba68c3deaee75262ab23f64914e38d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948890Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13c558ef1494..abdd0094e0d1 Created with: gclient setdep -r src-internal@abdd0094e0d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7b6ce2a79082063b1624b63bcf1ad2be443ce45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948905Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720999}
-
Nicolás Peña Moreno authored
This CL notes that on Android run_benchmark requires the device to be rooted. This should be helpful to people attempting this for the first time. Motivated by https://bugs.chromium.org/p/chromium/issues/detail?id=1026774#c11. Change-Id: Ic3fa62ab60c882a4e8ef3f6328242f73c3a6d61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946455Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#720998}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f16a97ac. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8f1d0c4d0ae73c394a799f9dd8256d8e4d467450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948660Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720997}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4270e9f32430..551bd3a90e35 git log 4270e9f32430..551bd3a90e35 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 wl@gnu.org More nullptr offset UBSan warnings (#57331, #57347). Created with: gclient setdep -r src/third_party/freetype/src@551bd3a90e35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Id294a3c0cad68ced58dd8314b38abb81382ca902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948591Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720996}
-
Benoît Lizé authored
Add a tool to benchmark SHA256 computations on Android and desktop. The aim is to evaluate whether discarding resources to disk, and keeping their SHA256 hash as identity is feasible from a performance standpoint on various platforms. The tool generates 40MiB of data, and hashes it with varying chunk sizes. The user can specify a specific core to run on, in order to evaluate little as well as big cores on ARM platforms. Results are summarized below: - Xeon 2.6GHx, "Haswell": ~350MB/s - Pixel 1 (Snapdragon 821, "Kryo" cores): - little core: 340-370MB/s - big core: 800-900MB/s - Pixel 3 XL (Snapdragon 845, A75 and A55 based): - little core (~A55): 620-730MB/s - big core (~A75): 1.2-1.3GB/s This overall shows that performance is very good (better than zlib decompression, and even LZ4 on some hardware) across the board, especially on low-end Android chips (A55). Full results added to the linked bug. Bug: 1029320 Change-Id: I1f30883e9c97778aa1447c0c9d04933778615f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942689Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720995}
-
danakj authored
This reverts commit fe87b3e0. Reason for revert: Failing. Example: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20(dbg)/18869 Traceback (most recent call last): File "../../chrome/android/monochrome/scripts/monochrome_apk_checker.py", line 284, in <module> sys.exit(main()) File "../../chrome/android/monochrome/scripts/monochrome_apk_checker.py", line 278, in main check_apk(chrome, chrome_pathmap) File "../../chrome/android/monochrome/scripts/monochrome_apk_checker.py", line 274, in check_apk VerifySameFile(monochrome_dict, chrome, CHROME_CHANGES) File "../../chrome/android/monochrome/scripts/monochrome_apk_checker.py", line 157, in VerifySameFile '\n'.join(diff)) Exception: The following files are not same as Monochrome: classes3.dex classes4.dex Original change's description: > Add monochrome_apk_checker to kitkat waterfall. > > The fact that it isn't running appears to have been an oversight. > > Bug: 1029936 > Change-Id: I4c70311bca05f2088fd0e99112512a015524bd95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946875 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720719} TBR=erikchen@chromium.org,jbudorick@chromium.org Change-Id: Ib6fae3a9c2ef0c883a4fe086b2b6fb475341cfb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948486Reviewed-by:
-
Jasper Chapman-Black authored
Change-Id: I01961afcd73fb607777dae37cba9597c58e6cf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946532 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Several DevTools CLs (see below) change the expected output for this test. This patch temporarily allows the relevant Blink Web Test to fail, so that we can land the devtools-frontend patch. We can re-enable and update the test once that happens. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1947533 [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1944335 Bug: chromium:1029031 Change-Id: I72939298ae1f306e5b1d27c3a91c2b13f0d620a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948883 Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#720992}
-
Nazerke authored
This CL removed extra headers and deps from BUILD file in make the further eg2 conversion easier. Bug: none Change-Id: I44e34504627afa5f8ce5a8b288e68bde81ddd81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932553Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#720991}
-
