GitLab

TBR=npm@chromium.org

BUG: 834446
Change-Id: Ia4315e380833ba43908dddd17a1f67125445b2ab
Reviewed-on: https://chromium-review.googlesource.com/1017816Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551857}

BUG=722573

Change-Id: I117497dd31d6270e2284ee54c59a142d620128ab
Reviewed-on: https://chromium-review.googlesource.com/1016241
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551856}

v8::TryCatch is needed to suppress all exceptions thrown during the
code cache generation.

Bug: 832202
Change-Id: I024adcdda2457f8db667d742e6175b77d2abf8e8
Reviewed-on: https://chromium-review.googlesource.com/1014744
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551855}

This reverts commit 8c4cc650.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Adding results_dashboard unit test to src side
> 
> Bug: 832081
> Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb
> Reviewed-on: https://chromium-review.googlesource.com/1010723
> Commit-Queue: Emily Hanley <eyaich@chromium.org>
> Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550619}

Reverted due to failing tests on cros infrastructure, crbug.com/833630


TBR=eyaich@chromium.org,ashleymarie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 832081
Change-Id: I9acab1c37fb050bb18052d94e346c665c0acd083
Reviewed-on: https://chromium-review.googlesource.com/1015182Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551854}

Custom DIAL launch patch part 1 of many.

DialAppDiscoveryService now takes a callback in FetchDialAppInfo()
instead of constructor. This allows classes other than
DialMediaSinkServiceImpl to make calls to it, and is required as part
of custom DIAL launch workflow to get the latest app status.

Bug: 816628
Change-Id: Ib2bae532614921330123db3e02fcfcac2c78d8b4
Reviewed-on: https://chromium-review.googlesource.com/1012744
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551853}

General logic for changes from client is not to notify client back of
changes. For example, if WindowTree::SetBounds() succeeds it should not call
WindowTreeClient::OnWindowBoundsChanged.

Refactors some test code for sharing and adds test coverage.

BUG=none
TEST=covered by tests

Change-Id: I59525ef9aa6729e881d27431abb769e0f78afdc5
Reviewed-on: https://chromium-review.googlesource.com/913719
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551852}

This file has a reference to a non-existing OWNERS file, causing
presubmits error on CLs touching this directory.

NOPRESUBMIT=true

Change-Id: If1a18e878db6de1e1f8eebdaccf5425796399fe3
Reviewed-on: https://chromium-review.googlesource.com/1017321Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551851}

Adds 2-3 minutes to every cros-flavored "gclient runhooks", which
is unfortunate.

Should be unnecessary when/if crbug.com/834134 is fixed.

Bug: 832374
Change-Id: I2696fc736350ecbe2b641112d2140db66118a00e
Reviewed-on: https://chromium-review.googlesource.com/1016137Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551850}

We weren't aggressively removing entries from our map that were empty.

Bug: 826422
Change-Id: Ifc6e6c24457ea7b19c775ef64c783e0bf38b42a6
Reviewed-on: https://chromium-review.googlesource.com/1008271
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551849}

Fixes a mismatch in the names of two histograms and what we're
recording.  Introduced in CL
https://chromium-review.googlesource.com/c/chromium/src/+/754325.

BUG=776451

Change-Id: I3f2b50213f5b9360a6e5e2d57b8313db9cbe0f3f
Reviewed-on: https://chromium-review.googlesource.com/1017230Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551848}

This reverts commit ce0f9d97.

Reason for revert: Linux CFI bot fails due to http://crbug.com/834474

Original change's description:
> [CFI] Enable cfi-icall on CFI memory bot
> 
> BUG=701919
> 
> Change-Id: I1e145f996f091a8e653190d94392119902e757b3
> Reviewed-on: https://chromium-review.googlesource.com/1010836
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551774}

TBR=dpranke@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: Ic609950ec75e82d753f454598365724432c1a1ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701919
Reviewed-on: https://chromium-review.googlesource.com/1018042Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551847}

- Skip virtual/layout_ng_experimental/ and virtual/incremental-shadow-dom/ for now;
- Rebaseline some tests;
- Add failure expectations.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icf89f5b77f301eb1f163946c530ed675cbc5611d
Reviewed-on: https://chromium-review.googlesource.com/1015281Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551846}

Using event generator to dispatch long press event was causing asan to
fail. Switched to dispatch gesture event instead of touch event.

Test: ash_unittests WindowSelectorTest.DraggingWithTwoFingers
Bug: 827435
Change-Id: I2edb1d87f35a9d57e2b58dc7904688a2406a8266
Reviewed-on: https://chromium-review.googlesource.com/1014393
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551845}

ActivityAndroidPermissionDelegate is refactored out of WindowAndroid
in order to also work for other types of activities

Bug: 758690
Change-Id: I77bd7bd0a77b9492d885171d0ad29ddb5d6b3d04
Reviewed-on: https://chromium-review.googlesource.com/1000552
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551844}

SimpleURLLoader requires access to Clone() to enable retries, so this
will allow that use case with SharedURLLoaderFactories.  This CL removes
the NOTREACHED() implementation of Clone() from SharedURLLoaderFactory
itself, and implements function versions in many, though not all,
subclasses.

Bug: 833977
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9d9aabc74282d36001d0bd2464c94ed70f9d63c8
Reviewed-on: https://chromium-review.googlesource.com/1015544Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551843}

This change plumbs through focus (both blink/frame and device) to XRSessions, so we
only call raf callbacks when focused.

BUG=813230

Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8
Reviewed-on: https://chromium-review.googlesource.com/1011288Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551842}

This updates third_party/libaom

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iefb7b76b23b4b21d5706f0f054cc21eeca313ccb
Reviewed-on: https://chromium-review.googlesource.com/1017760Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551841}

Change-Id: I388e2a9605096886291fafdae428b78bfe21dea9
Reviewed-on: https://chromium-review.googlesource.com/992880Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551840}

This sets friend to be a wildcard to allow all third_party/boringssl to
depend on internals.

Bug: 834415
Change-Id: I38c3a923abe57fca2bb86c9c1b30c443aeb7fa0d
Reviewed-on: https://chromium-review.googlesource.com/1017780Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551839}

Bug: 827754

A recent change to libpng [1] (included in Chromium with the recent
libpng update [2]) turns chunks that are bigger than
PNG_USER_CHUNK_MALLOC_MAX into failures. Although this matches the
intent of PNG_USER_CHUNK_MALLOC_MAX, it also causes images which used to
be viewable in Chromium to fail. Changing to a benign error allows us to
display these images once again. Though it means we do allow libpng to
allocate more than PNG_USER_CHUNK_MALLOC_MAX, it matches the behavior
prior to [2] (when we were using 1.6.22), and it does not regress
crbug.com/117369

Add a regression test. The image is supplied in the bug, and has approval
to be checked in [3].

[1] https://github.com/glennrp/libpng/commit/347538efbdc21b8df684ebd92d37400b3ce85d55
[2] https://chromium.googlesource.com/chromium/src/+/f82653a473f8de5fc86d0f2ecc75f6237e61946b
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=827754#c15

Change-Id: Iaae884b42a94bdec6e1cfad97d46ef820a75a5f8
Reviewed-on: https://chromium-review.googlesource.com/1014027
Commit-Queue: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551838}

Navigation Item associated with navigation context can be a pending
item, previously discarded by another navigation. WKWebView allows
multiple provisional navigations, while Navigation Manager has only one
pending navigation.

This change should not have any functional side effects as there is no
need to update Navigation Item which does not exist anymore.

Bug: 833336
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I64435c020899ebb8dd156ee47bbfb9df628036c1
Reviewed-on: https://chromium-review.googlesource.com/1017762Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551837}

Bug: 776877
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia7510f660eb894b4bc9e2757f1db200f42dc4f8f
Reviewed-on: https://chromium-review.googlesource.com/1011673Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551836}

Change-Id: Id56f5d704cd776320016210a8e40250d4ac15419
Reviewed-on: https://chromium-review.googlesource.com/1017862
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551835}

This CL adds a CSS rule to show a white pause icon on the non-overlay
play button when a video is playing.

Bug: 834396
Change-Id: I94694d2a3cecdb62d4f4a53b819e2f744ce61659
Reviewed-on: https://chromium-review.googlesource.com/1017345
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551834}

Change-Id: I9f35828ea104b0c0901a65845796a96bc28cbbe3
Reviewed-on: https://chromium-review.googlesource.com/1017766
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551833}

This new class computes information about a table in an AXTree,
including its dimensions, headers, and a mapping from row/column
index to a cell's node ID. It's computed from an AXTree on-demand
and cached until the tree changes.

Subsequent changes will switch browser-side code to use this
interface instead of the equivalent information provided by Blink,
and then remove some of the table-handling code from Blink.

See bug 832289 for more details on the planned refactoring.

Bug: 832289, 651614, 789748, 753125,
Change-Id: I29b31833426b69cb73266829e8f577785aa6fce6
Reviewed-on: https://chromium-review.googlesource.com/1011229
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551832}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30a2b933e3a0..3e6ddaf232b2

$ git log 30a2b933e..3e6ddaf23 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:722573


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1a65aef301abc143862ff57282e50409dfc80b8e
Reviewed-on: https://chromium-review.googlesource.com/1017586
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551831}

Don't send packets containing only Brain messages.

Adds a BundleWrites() method to QuartcSession.  When called, this method
installs a ScopedPacketFlusher on the connection.  The flusher attaches to the
connection and delays writing packets that are not full until it is deleted.
QuartcSession stores the packet flusher on the heap and keeps it alive until a
subsequent call to FlushWrites() or OnTransportReceived(), either of which
dispatch pending writes immediately.

Quartc bundles writes of Brain messages.  These tend to be very small and not
very latency sensitive.  Sending a whole packet with only a Brain message wastes
bandwidth and throws off congestion control.  It's better to wait and send the
Brain message with a subsequent frame (if possible).

Currently, any other Quartc frame will trigger a flush, sending pending Brain
messages along with it.
Merge internal change: 192995820

https://chromium-review.googlesource.com/c/1016663/
Bug: 77323330
https://codereview.chromium.org/1016663

--------------------------------------------------

Support multiple QuartcSessionVisitors on a single QuartcSession.

In order to implement go/quartc-packet-notifications, one visitor will always be
in use (collecting stats from QUIC and reporting them to the Quartc Brain).  In
order to support tracegraf and other debug utilities, QuartcSession needs to
delegate connection debug events to multiple visitors.

QuartcSessionVisitor no longer exposes a QuicConnectionDebugVisitor.  Instead,
it implements a number of methods that match QuicConnectionDebugVisitor's
callbacks.  It could simply extend QuartcConnectionDebugVisitor, but exposing a
separate interface is how the rest of //gfe/quic/quartc works.

For now, this is limited to functionality needed by tracegraf and
go/quartc-packet-notifications.

There's still a leaky abstraction in the form of OnQuicConnection(), which is
necessary due to a circular dependency between QuicConnection and
QuicTracegrafVisitor.

The QuartcSessionTracegrafVisitor now implements this interface.

Merge internal change: 192844927

https://chromium-review.googlesource.com/c/1016662/
Bug: none
https://codereview.chromium.org/1016662

--------------------------------------------------

In QUIC, explicitly feed application limited signal to pacing sender
instead of trying to figure out itself. Protected by
FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender.
Merge internal change: 192819301

https://chromium-review.googlesource.com/c/1015559/
Bug: 77723739
https://codereview.chromium.org/1015559

--------------------------------------------------

In QUIC, set sending packets's long header type in session and
dispatcher. Not used yet. Not protected.
Merge internal change: 192614208

https://chromium-review.googlesource.com/c/1015556/
Bug: 35377641
https://codereview.chromium.org/1015556

--------------------------------------------------

Remove references to jri@
Merge internal change: 192493283

https://chromium-review.googlesource.com/c/1015702/
Bugs: 77906482, 77907041
https://codereview.chromium.org/1015702

--------------------------------------------------

Do not use QUIC's MSPC tag and instead require MIDS. protected by
FLAGS_quic_reloadable_flag_quic_no_mspcxc

The QUIC handshake tag MSPC (max streams per connection) was replaced
by MIDS (max incoming dynamic streams) in QUIC v35 and should have
been removed when we removed v34, but we forgot to do this.
Merge internal change: 192474785

https://chromium-review.googlesource.com/c/1015552/
Bug: None
https://codereview.chromium.org/1015552

--------------------------------------------------

Remove the unused CTIM, SWIN, and SRBF QUIC handshake parameters.
Merge internal change: 192275571

https://chromium-review.googlesource.com/c/1015508/
Bug: none
https://codereview.chromium.org/1015508

--------------------------------------------------

Add flag count for
FLAGS_quic_reloadable_flag_quic_register_static_streams.
Merge internal change: 192233397

https://chromium-review.googlesource.com/c/1015548/
Bug: none
https://codereview.chromium.org/1015548

--------------------------------------------------

Pad probing retransmissions in QUIC.  Not flag-protected, since the
probing is not enabled in GFE.
Merge internal change: 192197258

https://chromium-review.googlesource.com/c/1015504/
Bug: none
https://codereview.chromium.org/1015504

--------------------------------------------------

Use the send alarm instead of the resume_writes alarm in
QuicConnection.  Protected by
FLAGS_quic_reloadable_flag_quic_unified_send_alarm.
Merge internal change: 192169762

https://chromium-review.googlesource.com/c/1015545/
Bug: none
https://codereview.chromium.org/1015545

--------------------------------------------------

Fix linking error for templated method
gfe_quic::CryptoUtils::SetKeyAndIV

Merge internal change: 192161750

https://chromium-review.googlesource.com/c/1015543/
Bug: 77753328
https://codereview.chromium.org/1015543

--------------------------------------------------

Let framer be able to build IETF stateless reset packet and version
negotiation packet. Not used yet.

Merge internal change: 192123603

https://chromium-review.googlesource.com/c/1015262/
Bug: 35377641
https://codereview.chromium.org/1015262

--------------------------------------------------

Change quic_client_bin to return code 20 when failed to connect to
server due to QUIC_INVALID_VERSION and FLAGS_version_mismatch_ok is
false.

Merge internal change: 192120462

https://chromium-review.googlesource.com/c/1012953/

R=rch@chromium.org

Bug: 77515653
Change-Id: I885b8911668be34372c1b4233f64e8b15e8221e1
https: //codereview.chromium.org/1012953/
Reviewed-on: https://chromium-review.googlesource.com/1016668Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551830}

Bug: 796315
Change-Id: I976eca626746f01f70ec374ab47c66f82efd25a0
Reviewed-on: https://chromium-review.googlesource.com/1015962Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551829}

This reverts commit 1aa4ba15.

Reason for revert: Broke compile https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5269

Original change's description:
> cros: Add Settings shortcuts search to launcher
> 
> This cl adds the framework to search Settings shortcuts in launcher.
> Changes:
> 1. Add feature flag to enable Settings shortcut search in launcher.
> 2. New class SettingsShortProvider.
> 3. New class SettingsShortResult.
> 4. New struct SettingsShortcutMetadata.
> 
> Bug: 834049
> Test: SettingsShortcutProviderTest.Basic and SettingsShortcutResultTest.Basic
> Change-Id: Ib25f2d18487b77c138b7d550ad06b6f2ac73f6c2
> Reviewed-on: https://chromium-review.googlesource.com/1016128
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551783}

TBR=xiyuan@chromium.org,wutao@chromium.org

Change-Id: I1051c175b6dcd3652e2fd3eb43979837f3e25bea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834049
Reviewed-on: https://chromium-review.googlesource.com/1017667Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551828}

Move BatchModeScoper into Scoper.

Bug: 781703
Change-Id: If10a87bbbfd04aadc54a24390ce747f0318b1519
Reviewed-on: https://chromium-review.googlesource.com/1011172
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551827}

Using wpt-import in Chromium 3cf4a083.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15774

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I103a135f5e2c9c5c7c20875e2b5cb7f1e960f219
Reviewed-on: https://chromium-review.googlesource.com/1017561
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551826}

When I adjusted the separator height and thickness for material menus, I forgot
to also adjust these constants. Set them to 9 - 1pt of line and 8pt of padding,
since the full separators have 8pt on either side. The "spacing" separator is
also 9 despite having no line, for visual consistency with the ones that do
have lines.

Bug: 831201
Change-Id: I14ed22823d7af9f6194281ef914ca64395feca31
Reviewed-on: https://chromium-review.googlesource.com/1017063Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551825}

TBR=sky@chromium.org
NOTRY=true

Bug: none
Change-Id: I1854df6f8447a86cc7773438cc40f6e92de45881
Reviewed-on: https://chromium-review.googlesource.com/1017565Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551824}

BUG=762641
TBR=jdufault@google.com

Change-Id: I907c35be791949270846a2dfbeb388812299b8f7
Reviewed-on: https://chromium-review.googlesource.com/1017564Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551823}

This argument enables excluding certain files and folders from code
coverage report using regular expression.

Bug: 813123
Change-Id: I13343645ba1e3e67dfc17932bc97113600a69095
Reviewed-on: https://chromium-review.googlesource.com/1017382Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551822}

Recently layout tests have been fairly flaky; this is causing extra load
on the CQ. Every time layout tests fails, they are retried without patch
to determine if the failure is a flake or a failure at tip of tree. This
means that layout tests are running more than other test suites, and
since layout tests take a long time to run, we end up consuming more
capacity from our swarming pool than we should.

Isolated script tests don't have the ability to retry only the tests
that failed, which is what other test suites do. This CL changes that so
that layout tests, when re-run without the patch, retry on the tests that
fail, which should significantly reduce swarming load and cycle time for
running layout tests without patch.

Bug: 533481
Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
Reviewed-on: https://chromium-review.googlesource.com/1015843
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551821}

Originally, if you:
1) enable unified-consent
2) goes to sync subpage and signs in with avatar row on top
3) click "go to settings" in the sync confirmation dialog
4) clicks "cancel sync" in the toast notification

You'll get taken back to the basic page with a sync error.

This is because the code was erroneously not identifying the
subpage as the current login-UI. This CL fixes that by
replicating https://chromium-review.googlesource.com/c/chromium/src/+/1015234/1/chrome/browser/ui/webui/settings/people_handler.cc#666

Bug: 800972
Change-Id: Ie0f5e447523f73f605bec47f48936b63c3c6ee5a
Reviewed-on: https://chromium-review.googlesource.com/1015234
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551820}

https://chromium-review.googlesource.com/c/chromium/src/+/1014352

TBR=kbr@chromium.org
Bug: 833463

Change-Id: I1780be2e8bcf3b32600d8a96594fef67c2c579f3
Reviewed-on: https://chromium-review.googlesource.com/1013153Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551819}

Bug: 678687
Change-Id: If1bc9f87184627130879775865b5e8696faf82c2
Reviewed-on: https://chromium-review.googlesource.com/1008278Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551818}