GitLab

renamed existing PowerButtonController to ShutdownDialog

BUG=None
TEST=covered by unit tests

Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860
Cr-Commit-Position: refs/heads/master@{#299821}

R=mukai@chromium.org

Review URL: https://codereview.chromium.org/654343002

Cr-Commit-Position: refs/heads/master@{#299873}

bug/build fix release

+ cherry-pick from pre-rc3 to deal with a mips build issue

Review URL: https://codereview.chromium.org/653803003

Cr-Commit-Position: refs/heads/master@{#299872}

Pair of ClientSession and ServerSession holds WebRTC connection which tunnels DevTools UNIX socket.

Once cloud based signaling channel doesn't exist at the moment connections work on a single android device. For manual testing the testing APK has launch activity which lets to start service which tunnels Chrome Shell socket to another local socket (only works when Chrome Shell signed with the same certificate).

BUG=383418
TEST=Automatic: LocalSessionBridgeTest, SessionControlMessagesTest. See description for manual testing.
R=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/537253003

Cr-Commit-Position: refs/heads/master@{#299871}

BUG=363099,371084

Review URL: https://codereview.chromium.org/659023002

Cr-Commit-Position: refs/heads/master@{#299870}

This change depends on Blink r183742.

BUG=89845, 403007

Review URL: https://codereview.chromium.org/659793002

Cr-Commit-Position: refs/heads/master@{#299869}

This should match vabr being already in components/password_manager/OWNERS.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/659463002

Cr-Commit-Position: refs/heads/master@{#299868}

Changes in this CL are many, but they are basically about type annotations.
The actual code doesn't change substantially.
Changes which affect actual code will be separate CLs.

BUG=406995
TEST=run browser_tests

Review URL: https://codereview.chromium.org/651403002

Cr-Commit-Position: refs/heads/master@{#299867}

html tags: cite, tbody, tfoot, th(as rowheader), param, input type text
ARIA state/property: aria-haspopup(true,false), aria-relevant(additions, removals, text, all, additions-text), aria-pressed
ARIA Role: columnheader

BUG=170575

Review URL: https://codereview.chromium.org/651223004

Cr-Commit-Position: refs/heads/master@{#299866}

BUG=416798

Review URL: https://codereview.chromium.org/637293002

Cr-Commit-Position: refs/heads/master@{#299865}

This patch moves the DRT-specific bits of ShellURLRequestContextGetter
out into a layout-test-only subclass.

BUG=420994

Review URL: https://codereview.chromium.org/651883002

Cr-Commit-Position: refs/heads/master@{#299864}

error callback has fired. Test timesout after the 2nd gUM request if
a callback is not fired.

BUG=420048
TEST=Try jobs + I ran the content_browsertest on 40.0.2189.0 (which contains the bug)
and Tot (where the CL has been reverted).

Review URL: https://codereview.chromium.org/653533004

Cr-Commit-Position: refs/heads/master@{#299863}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/de258cd..30bc88c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/662573002

Cr-Commit-Position: refs/heads/master@{#299862}

The rendering for the first few frames is much slower (As much as
100ms on Peach Pit). To get stable/correct numbers in performance
tests, we try to warm it up by rendering several frames in the
beginning.

BUG=411123
TEST=Run the vda_unittest on Peach pit.

Review URL: https://codereview.chromium.org/583503002

Cr-Commit-Position: refs/heads/master@{#299861}

BUG=363099,371084

Review URL: https://codereview.chromium.org/656223002

Cr-Commit-Position: refs/heads/master@{#299860}

BUG=397019

Review URL: https://codereview.chromium.org/631913004

Cr-Commit-Position: refs/heads/master@{#299859}

BUG=424056
NOTRY=true
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/652023003

Cr-Commit-Position: refs/heads/master@{#299858}

R=rsleevi@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/662553002

Cr-Commit-Position: refs/heads/master@{#299857}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/641363003

Cr-Commit-Position: refs/heads/master@{#299856}

Needs for component builds.

BUG=None
R=nkostylev@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/646773003

Cr-Commit-Position: refs/heads/master@{#299855}

We need to start GCMChannelStatusSyncer when GCM is disabled in order
to poll the server to find out when it is reenabled.

Also if server returns empty response, we should not treat it as error
and trigger the backoff logic.

BUG=423415
TEST=new tests added

Committed: https://crrev.com/9e9dd3b7798b3500d70941af04b1325ef9a0b544
Cr-Commit-Position: refs/heads/master@{#299518}

R=fgorski@chromium.org

Review URL: https://codereview.chromium.org/653843003

Cr-Commit-Position: refs/heads/master@{#299854}

Patch authored by: Thomas Boyt
http://www.thomasboyt.com/2014/10/06/chrome-message-workaround.html

BUG=

Review URL: https://codereview.chromium.org/632793002

Cr-Commit-Position: refs/heads/master@{#299853}

When AllowServiceWorker is false, don't let a worker control a new page.
Existing controllees remain controlled until their tab closes.

BUG=419282

Review URL: https://codereview.chromium.org/637243003

Cr-Commit-Position: refs/heads/master@{#299852}

Originally, Simon made SourceControl a class becaused we expected to
add a SvnSourceControl subclass which implemented the same methods in
different ways. However, after the git transition we're fairly sure
that we don't want to do this.

So, all of the functions in the SourceControl class can be made top-level
functions that don't need a "self" argument. This way, there's no need
to pass around a bogus SourceControl object; the functions can be called
directly.

I also added tests for some methods that seemed relatively testable.

PTAL and give suggestions :-)

BUG=

Review URL: https://codereview.chromium.org/650223005

Cr-Commit-Position: refs/heads/master@{#299851}

R=avi@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/654403002

Cr-Commit-Position: refs/heads/master@{#299850}

PasswordManager::RegisterLocalPrefs(PrefRegistrySimple*) is declared in
components/password_manager/core/browser/password_manager.h,
but only defined in chrome/browser/password_manager/password_manager_util_win.cc.
That's confusing, all of PasswordManager should be defined in
components/password_manager/core/browser/password_manager.cc.

This patch move the definition of RegisterLocalPrefs(PrefRegistrySimple*)
from password_manager_util_win.cc to password_manager.cc.

BUG=361529

Review URL: https://codereview.chromium.org/650423004

Cr-Commit-Position: refs/heads/master@{#299849}

Extraction of the filename from a URL handles the parameters differently now by returning the string after the last slash till its following semicolon as FileName.

BUG=323156

Review URL: https://codereview.chromium.org/560283003

Cr-Commit-Position: refs/heads/master@{#299848}

The property of FileChooserFileInfo#file_system_url is newly added for handling non-native files in Chrome OS.

BUG=126902
TEST=None

Review URL: https://codereview.chromium.org/655153002

Cr-Commit-Position: refs/heads/master@{#299847}

Revert of Intorduce PowerButtonObserver API (patchset #3 id:80001 of https://codereview.chromium.org/654343002/)

Reason for revert:
This is breaking the main waterfall : http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)

It appears that athena_unittests got added to the waterfall and not trybots. Please fix that before relanding this.

Original issue's description:
> Intorduce PowerButtonObserver API
>
> renamed existing PowerButtonController to ShutdownDialog
>
> BUG=None
> TEST=covered by unit tests
>
> Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860
> Cr-Commit-Position: refs/heads/master@{#299821}

TBR=mukai@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/659923002

Cr-Commit-Position: refs/heads/master@{#299846}

A better fix will be needed for cross-process iframes support, but for now
this is safe and solves the bug.

BUG=423846

Review URL: https://codereview.chromium.org/643893003

Cr-Commit-Position: refs/heads/master@{#299845}

See
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31795
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31798
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31799
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31800
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31801

BUG=85276
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/660713002

Cr-Commit-Position: refs/heads/master@{#299844}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/498bc5f..de258cd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/659913002

Cr-Commit-Position: refs/heads/master@{#299843}

Now Service Worker registrations and data get deleted as per
SpecialStoragePolicy.

BUG=419280

Review URL: https://codereview.chromium.org/633873002

Cr-Commit-Position: refs/heads/master@{#299842}

As a result, stop using the private class BluetoothDeviceChromeOS from outside
of the //device/bluetooth component.

BUG=423114
TEST=compiles
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/652403002

Cr-Commit-Position: refs/heads/master@{#299841}

In "Import bookmarks and settings" overlay, 'Import' button is disabled when
no checkboxes are checked. But for 'Safari' only 2 checkboxes are shown;
when other checkboxes are checked in background(not shown), it causes the button
to always be enabled regardless of visible checkboxes checked or unchecked.
This CL checks if a checkbox is both shown and checked, to enable the button.

BUG=275265
R=dbeam@chromium.org

TEST=
1.Launch chrome ,go to settings and click on 'Import bookmarks and settings' button under 'Users' section.
2.Select 'Safari' and Uncheck 'Browsing history' and 'Favorites/Bookmarks' option .
3.Observe the 'Import' button. The 'Import' button should be disabled.

Review URL: https://codereview.chromium.org/636933002

Cr-Commit-Position: refs/heads/master@{#299840}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/af11f94..c8ee2ce

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/657283002

Cr-Commit-Position: refs/heads/master@{#299839}

Prior to my major fullscreen refactor, Presentation Mode and Canonical
Fullscreen had significant implementation differences. As a result,
fullscreen_controller treated the two modes very differently. If a user tried
to enter tab fullscreen after entering browser fullscreen (Presentation Mode),
enterImmersiveFullscreen: would not be invoked. If a user tried to do the same
after Canonical Fullscreen, enterImmersiveFullscreen: would be invoked.

After my major fullscreen refactor, Presentation Mode and Canonical Fullscreen
are almost identical. However, I failed to update the logic in
fullscreen_controller, which still treated the two modes differently.

This CL updates the logic in fullscreen_controller to treat both modes like
Presentation Mode. If a user tries to enter tab fullscreen after entering
browser fullscreen, enterImmersiveFullscreen: is not invoked.

BUG=422191

Review URL: https://codereview.chromium.org/652983005

Cr-Commit-Position: refs/heads/master@{#299838}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/655413002

Cr-Commit-Position: refs/heads/master@{#299837}

BUG=265619

Review URL: https://codereview.chromium.org/658713003

Cr-Commit-Position: refs/heads/master@{#299836}

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/656033009

Cr-Commit-Position: refs/heads/master@{#299835}

R=brettw@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/654303003

Cr-Commit-Position: refs/heads/master@{#299834}