GitLab

- Rename Init as Start.
- Rename CreateSubsystems as Init.

As a result, Init is truely the first thing that must be called before using the
instance.

Bug: 920062
Change-Id: I5606250f10c3d249a994f19b71682a8d95e44be0
Reviewed-on: https://chromium-review.googlesource.com/c/1442072Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626911}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/966762d3..7d49c734

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I758b06b81d1524575e7c50c965374e828b77108b
Reviewed-on: https://chromium-review.googlesource.com/c/1441957Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626910}

This fixes crashes (due to duplicated DrawingDisplayItem ids) of overlay
layout tests in CompositeAfterPaint mode.

Sample errors: https://test-results.appspot.com/data/layout_results/linux_layout_tests_composite_after_paint/761/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

Test: compositing/visibility/overlays*.html in CompositeAfterPaint mode.

Bug: 524134
Change-Id: I206e191bd01768388f1192846d7370abe5f652ed
Reviewed-on: https://chromium-review.googlesource.com/c/1440524Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626909}

No behavioural change; just refactor the code to use async/await.

Bug: 908288
Change-Id: I533c05538e25fa5e4176a7373706dd479c6009b1
Reviewed-on: https://chromium-review.googlesource.com/c/1379594
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626908}

This CL changes the app management page to load its app icons from
chrome://app-icon instead of chrome://extension-icon. It also fixes
a bug which prevents the default icon from loading in some cases where
the icon can't be found.

The chrome://app-icon url currently doesn't work for some Chrome
system apps (e.g. Web Store, Audio Player), so this will require
further investigation.

Bug: 906508
Change-Id: Ib350bf2490193fd17c807d2677f05355eefeb6bf
Reviewed-on: https://chromium-review.googlesource.com/c/1428620
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626907}

It can improve the fps of overview window dragging about 4~5fps.

Bug: 925131, 925122
Change-Id: Ia76d1baf2e8a35f5dd53e1ec7bb325ab4f6c45eb
Reviewed-on: https://chromium-review.googlesource.com/c/1439930
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626906}

Split up creation and start-up of all WebAppProvider subsystems.
A separate end-end construction and init phase allow us to write better
integration tests (override selected subsystems with mocks before Init).

In the future, we want to defer Init until WebAppProvider::OnRegistryReady
moment to prevent init races.

Bug: 920062
Change-Id: Id77676dbeca2449a5148d7c00b1b08a886e1e8b8
Reviewed-on: https://chromium-review.googlesource.com/c/1429323
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626905}

This interface is not for ARC in general, but for GPU-related stuff only.
Rename it to ArcGpu to avoid future confusion when adding another
ARC-related interface.

BUG=925769
TEST=build

Change-Id: I49ea9874f6c5455751941fddb846ac32003e6e68
Reviewed-on: https://chromium-review.googlesource.com/c/1438976Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626904}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5570bda71313..edb4ccca4f09


Created with:
  gclient setdep -r src-internal@edb4ccca4f09

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6a5fb3492f1c81271a37693ccf6a7be29ae03fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1441535Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626903}

This CL switches task runners at several places from per-thread to
per-frame. The purpose of this change is to make it possible to freeze
tasks for bfcache.

bfcache is a new feature to freeze a tab for quick back-forwarding. When
a tab goes frozen, we can stop per-frame task runners while we cannot
per-thread task runners since per-thread task runners can be shared
between multiple tags/pages. As a frozen tab must not execute any
JavaScript, all JavaScript execution must be on per-frame task runners,
which can be suspended.

Bug: 913912
Change-Id: I5dcf4d2fa650469fda473cae0b5a1e2d603176ca
Reviewed-on: https://chromium-review.googlesource.com/c/1438855
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626902}

This reverts commit 7c0e6537.

Reason for revert: Build broken again???
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/61090

Original change's description:
> Reland "build: Default use_lld to true on ChromeOS for x64"
> 
> This is a reland of 3c031af0
> 
> I changed libassistant to use lld when lld is used to build chrome in:
> https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/800068
> 
> Original change's description:
> > build: Default use_lld to true on ChromeOS for x64
> >
> > This is a partial reland of 12b1bbff
> >
> > I confirmed current lld can link chrome with the same config of previously failed build.
> > https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59619
> >
> > Original change's description:
> > > build: Default use_lld to true on ChromeOS.
> > >
> > > As of https://chromium-review.googlesource.com/c/1372768 ChromeOS
> > > chrome is always linked with lld. Because ChromeOS's build system
> > > always overrides the value of use_lld this change should have no
> > > effect on official ChromeOS builds, but it should make ChromeOS on
> > > Linux more consistent with "real" ChromeOS.
> > >
> > > Bug: 701659
> > > Change-Id: I447e1b2dfb6cc970f2c2dd64d396b5ba58bc2ef2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1377139
> > > Reviewed-by: Nico Weber <thakis@chromium.org>
> > > Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#616485}
> >
> > Bug: 701659, 923168, 917504
> > Change-Id: Iedb48cfe5b3b9c189dcf1b4c04bea998ee009d2c
> > Reviewed-on: https://chromium-review.googlesource.com/c/1419558
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: George Burgess <gbiv@chromium.org>
> > Commit-Queue: George Burgess <gbiv@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#624005}
> 
> Bug: 701659, 923168, 917504
> Change-Id: Ibdb678d59313d7defdb3238e307bbf525dd94dfa
> Reviewed-on: https://chromium-review.googlesource.com/c/1437040
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626850}

TBR=thakis@chromium.org,pcc@chromium.org,gbiv@chromium.org,tikuta@chromium.org

Change-Id: I7964f3e807df07d9000e9af3b2e3c41f3a625050
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701659, 923168, 917504
Reviewed-on: https://chromium-review.googlesource.com/c/1442075Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626901}

Note that this CL should not cause any behavior change.

We no longer run run_gtest_perf_test.py as a standalone
subprocess after
https://chromium-review.googlesource.com/c/chromium/src/+/1428090
and
https://chromium-review.googlesource.com/c/chromium/src/+/1423840
are submitted.

Move the remaining code directly into run_performance_tests.py.
I tried not to edit much after that since I mostly wanted to
remove dead code to get things ready for the improvements and
cleanups that I am planning.

Bug: 757933,920002,923628
Change-Id: I95bb2176234f81172785c841a1e4e5c90251249b
Reviewed-on: https://chromium-review.googlesource.com/c/1423918Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626900}

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id324ad0abc178937ce373e03180d2135fe3d2c97
Reviewed-on: https://chromium-review.googlesource.com/c/1235113
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626899}

This script was used during the migration. Now that everything is
migrated, it isn't needed anymore. Everything already uses the
--migrated-test flag now.

This is blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=924351 .
Fixing that first.

This is also blocked on
https://chromium-review.googlesource.com/c/chromium/src/+/1436559

BUG=757933,920002

Change-Id: I2be974d4606f732f5099f89854ba50dff5429e18
Reviewed-on: https://chromium-review.googlesource.com/c/1423840Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626898}

This CL builds typemapping between blink::HTTPHeaderMap and
network.mojom.HttpRequestHeaders.

BUG=860403

Change-Id: I3ae25caa135bb74f904e2d9b6f758371f8ac7de8
Reviewed-on: https://chromium-review.googlesource.com/c/1411313Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#626897}

This CL extends the copyTextureCHROMIUM implementation to support
RGB10_A2 (see bug for the use case).

It also extends gl_copy_texture_CHROMIUM_unittest.cc appropriately,
and cleans it a tiny bit (const, removal of dead code, style).

For some reason, glCopy(Sub)TextureCHROMIUM() fails on Adreno 4xx,
this CL adds a workaround for it, see crbug.com/925986.

Bug: 922198, 925986
Change-Id: I8e4e95d766e89282cec1fc11e86c2c2fadc807fc
Reviewed-on: https://chromium-review.googlesource.com/c/1418330
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626896}

The regionCode attribute was removed in spec side[1]. FYI, the attribute
was behind runtime flag and have never shipped. So, we don't need to
send intents to blink-dev.

[1] https://github.com/w3c/payment-request/pull/823

Bug: 925722
Change-Id: I85b370770141b1caf69389e399358b82ad071b89
Reviewed-on: https://chromium-review.googlesource.com/c/1438981Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#626895}

Using wpt-import in Chromium 2e33fba9.
With Chromium commits locally applied on WPT:
40748e1e "Upstream fast/workers to external/wpt/workers: first batch."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: If4b1706cd2506a2ad0844d1893212322793a10f2
Reviewed-on: https://chromium-review.googlesource.com/c/1441314Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626894}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56f3eeaa1714..5570bda71313


Created with:
  gclient setdep -r src-internal@5570bda71313

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iaf8b5cd6adfba2db60fef5394991f5893b1f3c8b
Reviewed-on: https://chromium-review.googlesource.com/c/1441441Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626893}

https://chromium.googlesource.com/angle/angle.git/+log/0f073667daf0..8922ac230f33


git log 0f073667daf0..8922ac230f33 --date=short --no-merges --format='%ad %ae %s'
2019-01-28 enrico.galli@intel.com ES31: Enable glBindBufferRange on SSBOs in the D3D renderer


Created with:
  gclient setdep -r src/third_party/angle@8922ac230f33

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I7f25ce61dde8459a13d122098fed581d3910707f
Reviewed-on: https://chromium-review.googlesource.com/c/1441534Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626892}

This test is flaky in Chrome. One of the fetches fails but we only get
output "failed to fetch" from Chrome. Make the test easier to read using
async/await and add more debugging info.

Bug: 924448
Change-Id: Ib9a0537772b1160e627517ff3ed1cef820778705
Reviewed-on: https://chromium-review.googlesource.com/c/1441654
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626891}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6e89f8f5..966762d3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iabbcd013e723c89ff3f21d3cd10ddcdf3ea48484
Reviewed-on: https://chromium-review.googlesource.com/c/1441641Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626890}

In BaseFetchContext, "origin" header is set from
 - FetchContext's security origin, or
 - the referrer string.

On the other hand,
https://fetch.spec.whatwg.org/#http-network-or-cache-fetch says:

  If the CORS flag is set, httpRequest’s method is neither `GET` nor
  `HEAD`, or httpRequest’s mode is "websocket", then append
  `Origin`/the result of serializing a request origin with
  httpRequest, to httpRequest’s header list.

This CL makes it a bit more spec conformant by setting the header based
on ResourceRequest::RequestorOrigin.

Bug: 914739
Change-Id: Ia911ca1f2efaf2be080d891b1258f87230d57f2d
Reviewed-on: https://chromium-review.googlesource.com/c/1388344
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626889}

This CL adds .grd and .xtb files for Chrome Camera App in order to
follow i18n rule on chromium.

Test: None
Change-Id: Iabe414e551ec168b4f1c9911c8b45b7d6eac8bf5
Reviewed-on: https://chromium-review.googlesource.com/c/1436471
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626888}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 925652
Change-Id: Id6e26777299128d504dce525ba87883254a93631
Reviewed-on: https://chromium-review.googlesource.com/c/1438360Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626887}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I0d88d0749b739abf3db573dfc36ec3035765403e
Reviewed-on: https://chromium-review.googlesource.com/c/1441797Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626886}

Summary of issue: Tab traversal within Assistant was very irregular,
the Assistant cards (backed by NavigableContents) would steal focus
when attempting to traverse the native view hierarchy. See video in
bug comments for example of issue.

Solution: Handle WebContentsDelegate::TakeFocus event to trigger a
clearing of native view focus in NavigableContentsView.

Bug: b:120682808
Change-Id: Ib571b3a1a6e9ccbc48d44fe29c67c6aa62aa85b0
Reviewed-on: https://chromium-review.googlesource.com/c/1407172
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626885}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=mohsen@chromium.org

Bug: 925652
Change-Id: I643dfe709c621b34674fe3d48326561a6e4ca1e8
Reviewed-on: https://chromium-review.googlesource.com/c/1438363
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626884}

This CL adds tests for the pin to shelf toggle in the app management
metadata view. It also creates a test util file, and refactors some
tests to use these util functions.

Bug: 906508
Change-Id: Ica7f7ceb5b097effbbab544a7f7cc066c7a9074d
Reviewed-on: https://chromium-review.googlesource.com/c/1420077Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626883}

conformance/ogles/GL/exp2/exp2_001_to_008.html is flaking in the WebGL
2.0 suite as well, not just the WebGL 1.0 suite.

Tbr: senorblanco@chromium.org
Bug: 923080
Change-Id: I9aef3e7035d82f66e84ed76d1a93697329f3225b
Reviewed-on: https://chromium-review.googlesource.com/c/1441471Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626882}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=rkc@chromium.org

Bug: 925652
Change-Id: I4a7655e9d2c965eefd0bfa6a861ab5526311dd74
Reviewed-on: https://chromium-review.googlesource.com/c/1438356
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626881}

Information about both the contentInset and contentOffset are needed to
properly restore scrolling positions for pages whose insets have been
updated due to fullscreen events.  crrev.com/c/1432377 added this
information to the scroll offsets, but requires careful consideration
of the comments to understand the semantic meaning of the stored scroll
offset.  This CL updates the PageScrollState interface to explicitly
use UIScrollView terminology.

Bug: 1432377
Change-Id: Icaabea95bb94d12206f0b955a789448051497b4e
Reviewed-on: https://chromium-review.googlesource.com/c/1436140Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626880}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cde480ef34f..56f3eeaa1714


Created with:
  gclient setdep -r src-internal@56f3eeaa1714

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6a9340f4a02ba3f94b835582f07a13d0b7dfbec3
Reviewed-on: https://chromium-review.googlesource.com/c/1441353Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626879}

Map VIEW_SELECTED to chrome's kValueChanged event, and all onEventIfInRange
to ensure new slider value is read out.

Test: manual
Bug: b/123485689
Change-Id: Iea60804a83177afbdbe4340dfba78fd1e041d4db
Reviewed-on: https://chromium-review.googlesource.com/c/1436463Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626878}

Fuchsia has a platform requirement that libraries be placed in in the
/lib directory in order to be located by the loader. We used to have a
shlib_subdir variable to satisfy such a requirement.  Bring this variable
back and set it to "/lib" on Fuchsia.

This allows us to reduce special handling of libraries during the
packaging phase. Ideally all package artifacts would be placed correctly
by the build system so that the packager doesn't have to rearrange.

Don't use abspath() in the script, either. Using absolute paths in the
build can be harmful (leaks data, causes cache misses) and is rarely
necessary.

BUG=925040
TBR=mef@chromium.org

Change-Id: Idb2d8d4a0fa493904000244332ed242790698b8b

Reviewed-on: https://chromium-review.googlesource.com/c/1434221Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626877}

At the moment mojom::MediaController uses the media
session observer. This splits it so it has its own
observer. This allows use to have a nullable info
parameter passed to MediaSessionInfo which can tell
observers that we are not bound to any media session.

BUG=892771

Change-Id: Ifcb1835e3901c82221c7daad1b0036caadd10288
Reviewed-on: https://chromium-review.googlesource.com/c/1422837Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626876}

This reverts commit 6a235ad7.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 626816 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmEyMzVhZDcxZjVmMzRjNGI0M2E1YzZiZTRhNzhjOTZjYjc0ODkyMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/56035

Sample Failed Step: services_unittests

Sample Flaky Test: HidReportDescriptorTest.ValidateDetails_BelkinNostromoMouseAndExtra

Original change's description:
> Parse HID report descriptor for report info
> 
> The previous HID report descriptor parser was designed to only
> extract the maximum size of each type of report and did not preserve
> information about the individual fields within a report. This CL
> adds a new parser that builds a hierarchical representation of the
> reports supported by the HID device.
> 
> BUG=890096
> 
> Change-Id: I4ac3bf883a843bec00576bfad78958d42f53abc7
> Reviewed-on: https://chromium-review.googlesource.com/c/1257897
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626816}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=890096

Change-Id: I20e9ea374b71a25c2dfd6ff9535cc936ce1c4d31
Reviewed-on: https://chromium-review.googlesource.com/c/1441952
Cr-Commit-Position: refs/heads/master@{#626875}

This is a follow up to https://chromium-review.googlesource.com/c/1401238 that
fixes unpausing of virtual time.

Change-Id: Iec1d96000e7468b0dd45d3e7db43d80e902515b0
Reviewed-on: https://chromium-review.googlesource.com/c/1441646
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626874}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f5b861c32e0..3f812d07b2aa


git log 9f5b861c32e0..3f812d07b2aa --date=short --no-merges --format='%ad %ae %s'
2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@3f812d07b2aa

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: If88e529b929bf8686c4f1ec50ec6027d6cbb4d89
Reviewed-on: https://chromium-review.googlesource.com/c/1441533Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626873}

Currently, the PaintWorkletImageCache keeps a hashmap from
PaintWorkletInput to a PaintRecord. The problem is that the PaintRecord
could be used by multiple tiles for rasterization, while the main
thread might be trying to purge the cache.

This CL makes the PaintRecord ref counted. Whenever a tile is using it
for rasterization, the counter will increment. When the rasterization
is done, the counter will decrement.

Bug: 907897
Change-Id: Idaf1a1f191c084b7531c3a17e5163288e8ba1d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1439761Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626872}