GitLab

When a native Android EditText widget is focused, the DPAD_CENTER keyboard event
(e.g. from the center button on the Nexus Player remote) causes the on-screen
keyboard to show on keyup. Currently in WebView, we're showing the keyboard on
keydown, and then the on-screen keyboard is receiving the keyup event. In
Android Oreo, the keyboard was rewritten and when the new keyboard receives this
keyup event, it types the character selected by default on the keyboard (usually
'1').

The fix is to not show the keyboard until keyup, to match the behavior of
Android EditText. Despite no longer doing anything in response to the keydown
event, we still want to make the event prevent default instead of passing it to
the web app, since passing it to the web app would cause compatibility problems.
E.g. the Facebook app for Android TV would blur the input element in response to
the keydown immediately after the keyboard is opened (which causes the keyboard
to close again).

Bug: 776591
Change-Id: Icf893f8d2ef27825d78d2bc264575a62b0e77648
Reviewed-on: https://chromium-review.googlesource.com/729281Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510277}

Bug: chromium:768986
Change-Id: I45d6bbfde855f17d3ef8d7bae8f7817ead0b5fa9
Reviewed-on: https://chromium-review.googlesource.com/716874
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510276}

GitCL.trigger_try_jobs is called with different types in test_importer.py and
rebaseline_cl.py. It's not very complicated to just make it accept any
sequence. This CL adds a bug fix and unit test.

Bug: 776585
Change-Id: Ie9d57e1d388ef08fb24d78b9a61392a70b76723b
Reviewed-on: https://chromium-review.googlesource.com/729541Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510275}

Since we now have the Chrome memory dumps in the service, we can now
centralise the code which performs the trace dumps.

Bug: 728199
Change-Id: I7385a99782b9027a85eacd11a755a6d10bb3c8f1
Reviewed-on: https://chromium-review.googlesource.com/685854
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510274}

This change adds the Xbox One Elite gamepad to the list of devices
recognized by the Xbox data fetcher on Mac. The Elite supports button
remapping, and exposes both the mapped and unmapped state. Chrome will
use the mapped button state, which has the same layout as the normal
Xbox One button state.

BUG=773048

Change-Id: I595031b93bf97facd8c66e6ccb227aefd3b99d89
Reviewed-on: https://chromium-review.googlesource.com/726853Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510273}

This patch is a preparation for supporting IMG and other atomic inlines
in offset mapping, for which we need to use general annotation type in
offset mapping builder instead of LayoutText.

Bug: 776272
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0c9a24dc4ff97f1c839cb36f25dbef38e30cd4a8
Reviewed-on: https://chromium-review.googlesource.com/728925Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510272}

The test has taken more than ten seconds to run in recent
debug builds.

We shard the test to avoid flakes, for example when running
under virtual/threaded.

BUG=757868

Change-Id: I0ca84820bafb5be00c3f39a0aa4dc95d45134be2
Reviewed-on: https://chromium-review.googlesource.com/722480Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510271}

This bug is readily apparent when misspelling markers are added to static text objects inside text fields but the text field is not notified of the change. As a result, NVDA doesn't make any sound indication when a misspelling is detected.

Bug: 730977
Change-Id: I6872e62f676691f0709ab3d933543707e382a8c9
Reviewed-on: https://chromium-review.googlesource.com/728353
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510270}

TBR=rohitrao@chromium.org

Bug: 776593
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic2b4c38cf3ba8c94b20f2c3b34dfb67b2f6e6609
Reviewed-on: https://chromium-review.googlesource.com/729542Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510269}

These crashes were caused by the following situation:
(1) Asynchronous shutdown flow begins.
(2) BleAdvertiser or BleScanner finish their operations and notify
    observers.
(3) Observer shuts down the Tether component.
(4) BleAdvertiser or BleScanner try to update their states, but they
    have already been deleted. A segfault occurs.

Now, these classes execute this code in a new task which is destroyed
if the Tether component is deleted.

Bug: 776241, 672263
Change-Id: I0eab11afc08853fc7e112ea57ff90e28534ab924
Reviewed-on: https://chromium-review.googlesource.com/729304
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510268}

This reverts commit a16415e1.

Reason for revert: Seems to have caused a leak: 
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/11042

Original change's description:
> [LayoutNG] LocalVisualRect for inline
> 
> This patch implements LocalVisualRectIgnoringVisibility() for
> LayoutInline and LayoutText, that are used by PaintInvalidator.
> 
> This patch is still at the early iteration in a few ways:
> 1. Other similar functions (e.g., LocalSelectionRect()) are not
>    implemented.
> 2. The inline fragment iterator is supposed to be useful for
>    several other purposes. Making it more generic and applicable
>    for other purposes is planned after we collect how we use it.
> 3. Adds ~20 new failures, part because CurrentFragment() is not
>    available in some cases, part because overflow logic isn't
>    complete yet. I'll look into these failures in following patches.
> 
> Bug: 636993, 714962
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Change-Id: I55c607a40fcf705c46162577fd9a1255f3048da7
> Reviewed-on: https://chromium-review.googlesource.com/718637
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510020}

TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org

Change-Id: Idf7967b552c11dd92e022fc9e1e1668288f447fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 636993, 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/729660Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510267}

This CL adds two new metrics.

OutOfProcessHeapProfiling.ProfiledProcess.Type is emitted once per 24-hours per
process being profiled. Type is currently Browser, Renderer, Gpu, or Other.

OutOfProcessHeapProfiling.ProfilingMode is emitted once per 24-hours for Chrome
instances that have profiling enabled. ProfilingMode is None [should not occur],
Minimal, and All.

The ProfilingService interface is modified slightly to include ProcessType along
with AddProfilingClient. This is necessary to emit
OutOfProcessHeapProfiling.ProfiledProcess.Type, but will also be used to emit
the correct process type when generating a heap dump.

Bug: 
Change-Id: I47c74c2aaa06b018aa83e9bca71d24e1e34b50d2
Reviewed-on: https://chromium-review.googlesource.com/724529Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510266}

Chrome suffers a significant performance degradation when both tracing and
out-of-process heap-profiling are enabled. This is because the profiling service
emits multiple trace events each time it reads from a profiling pipe, which
happens around every 30 allocations or so. For more details, see the thread
https://groups.google.com/a/google.com/forum/#!topic/chrome-benchmarking/rjNyxf_53lU.

Bug: 769583
Change-Id: Iba006679154037268bb91b5baf09857a73aae8d2
Reviewed-on: https://chromium-review.googlesource.com/723747
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510265}

This reverts commit 37d5fc56.

Reason for revert: It looks like this is causing a test failure for UiRendererTest::UiRendererSortingTest
(https://cs.chromium.org/chromium/src/chrome/browser/vr/ui_renderer_unittest.cc?q=UiRendererSortingTest&sq=package:chromium&l=39)

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__1_%2F72602%2F%2B%2Frecipes%2Fsteps%2Fvr_common_unittests%2F0%2Flogs%2FSortingTests__x2f_UiRendererTest.UiRendererSortingTest__x2f_0%2F0

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/72602

Original change's description:
> Add speech recognition API wrapper in VR
> 
> This CL adds an invisible button which should trigger voice search.
> Note that the UI will change significantly. The main purpose of this
> CL is to add speech recognition API wrapper.
> 
> Bug: 773767
> Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b
> Reviewed-on: https://chromium-review.googlesource.com/701174
> Commit-Queue: Biao She <bshe@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510182}

TBR=vollick@chromium.org,bshe@chromium.org

Change-Id: I3131a869691bca49a0d97f3b3be658d27874bb98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773767
Reviewed-on: https://chromium-review.googlesource.com/729799Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510264}

This CL adds a new field trial param that allows to use a separate
server for requests coming from Dev/Canary and Stable users.

Bug: 692471
Change-Id: I9774ef54f3f4d1778492b84840e24804cb08705f
Reviewed-on: https://chromium-review.googlesource.com/728405
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510263}

BUG=598073

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I0b38a0f82bbbb46dba1402ebcedb8b3a192745fa
Reviewed-on: https://chromium-review.googlesource.com/729042Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510262}

R=lushnikov@chromium.org

Bug: chromium:763752
Change-Id: I002ac8a40cc6a21949a51d926c1c22ddd8b23fc0
Reviewed-on: https://chromium-review.googlesource.com/728731
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510261}

Previously we were calling IsSuperfish() (which computes the Sha256 of
all certs in the chain) twice. This moves the call and the UMA logging
up into SSLErrorHandler::HandleSSLError() to combine both flows (the
result is needed for UMA logging and for the options_mask passed to the
delegate).

Bug: 770843
Change-Id: Idda41d5ad388ed49c63c7997ef897d27636dcd5f
Reviewed-on: https://chromium-review.googlesource.com/728923Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510260}

Adds a setting to allow per-word highlighting instead
of node-based highlighting. This works well in nearly all
cases but there are two tts bugs identified and filed to the
tts team, one regarding lots of quotes, and the other with
phrases that start with a single letter word.

Removes empty nodes from paragraphs so that these will
not be highlighted at all.

Bug: 676451
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2d08e0cd8ed786e894f65ecf5c664a784cf12f01
Reviewed-on: https://chromium-review.googlesource.com/724361
Commit-Queue: Katie Dektar <katydek@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510259}

This UMA will report whether CDM instance creation succeeded or not. As
usually, we report it for Clear Key, Widevine and other (unknown) key
systems.

BUG=700147
TEST=Manually checked about://histograms

Change-Id: I0925d07c7a61da68ba43d2d170931617a4452f07
Reviewed-on: https://chromium-review.googlesource.com/727180Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510258}

This reverts commit 65d50038.

Reason for revert: Causing LayoutTest failures e.g. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/25167

Original change's description:
> Better interpolation of oscillator at low frequencies
> 
> For low frequencies, use a 3-point or 5-point Lagrange interpolation
> scheme to improve the accuracy of the oscillator instead of using
> simple linear interpolation.
> 
> For a typical context, the linear interpolator is used if the
> frequency >= 3.2 Hz; the 3-point, for 3.2 > frequency > 1.7 Hz; and
> the 5-point for all other cases.  Thus, typical use-cases are not
> impaired by this change.
> 
> Some benchmark results from running an oscillator for 1000 seconds in an
> offline context.  This is the time measured from startRendering()
> until the promise is delivered.  The SNR is the measured SNR between
> the test signal and a reference 440 Hz signal.  The linear time was
> the same before and after this CL.
> 
> linear:
> time: 1844.6 ms, stddev: 154.4
> SNR: 27.7 dB
> 
> 3-point:
> time: 2426.5 ms, stddev: 265.0
> SNR: 37.2 dB
> 
> 5-point:
> time: 2752.6 ms, stddev: 215.1
> SNR: 59.3 dB
> 
> 7-point (for reference, not used now):
> time: 3239.4 ms, stddev: 263.8
> SNR: 82.5 dB
> 
> Bug: 773507
> Test: Oscillator/osc-440hz.html
> Change-Id: Ib49fab4fb27738f4f02bd41f8adcc2e3b2dd2137
> Reviewed-on: https://chromium-review.googlesource.com/713576
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510133}

TBR=rtoy@chromium.org,hongchan@chromium.org

Change-Id: If59bb7f8169b077c35e5d735c6f6f19cc780d512
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773507
Reviewed-on: https://chromium-review.googlesource.com/729719Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510257}

Add new event to In-Product Help for Contextual Search that records each time the
user clicks on the Web Search option from the popup menu.

Bug: 771750
Change-Id: Ib29134ba4135828c76dc24348535536b7f14d18a
Reviewed-on: https://chromium-review.googlesource.com/713743
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510256}

https://chromium.googlesource.com/breakpad/breakpad.git/+log/1c6d1613966e..072f86ca83bb

$ git log 1c6d16139..072f86ca8 --date=short --no-merges --format='%ad %ae %s'
2017-10-18 tobiasjs Provide helper wrappers for basename(3) and dirname(3)
2017-10-17 pcc Move main executable handling out of procmaps parser loop.
2017-10-17 ted Rename src/common/memory.h to memory_allocator.h.
2017-10-16 tobiasjs Add -s flag to microdump_stackwalk for dumping stack contents.
2017-10-13 tobiasjs Convert {mini|micro}dump_stackwalk argument parsing to getopt.
2017-10-11 adamharrison ios: Adds a no-Mach exception handler
2017-10-06 jperaza Android: Use sys/types.h instead of stdint.h for sys/user.h
2017-10-05 mark Fix minidump_dump_test after 6d0287851fab
2017-09-27 mark Dump Crashpad extension structures in minidump_dump
2017-09-27 mark Only run GYP for Windows targets on Windows
2017-08-28 orgads Fix MSVC build on 64-bit
2017-08-28 orgads Refresh refresh_binaries.bat

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug: 469376
Change-Id: I18c48cca483500d350709119c41b04a79efeae17
Reviewed-on: https://chromium-review.googlesource.com/723850
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510255}

It started failing in r482709 since more robust checks were added for
checking for test result output files.

To fix, remove switches::kTestLauncherOutput from the subprocess
command line so it doesn't try to create test result output.

Bug: 776265
Change-Id: Ib0406b77fb7aa90cddf712331342526fa555491b
Reviewed-on: https://chromium-review.googlesource.com/727680
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510254}

Random small stuff I came across while working on push validation.

Bug: 554220
Change-Id: I58d43860b2f347b5df2833868ad8f906513e8f40
Reviewed-on: https://chromium-review.googlesource.com/728361Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510253}

BUG=none
TEST=no change

Change-Id: I5ff9a3c0ec522abd45e54439365b1cb9a45429b9
Reviewed-on: https://chromium-review.googlesource.com/728721Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510252}

This CL replaces the deprecated openURL: call with
openURL:options:completionHandler:.

Bug: 774483
Change-Id: Idf9414bbacc9e633c98f1190a6aee89e2d0ebacd
Reviewed-on: https://chromium-review.googlesource.com/728733
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510251}

This CL adds dirtiness detection to UiScene::OnBeginFrame() as
preparation for future optimizations. It also adds very minor
optimizations to OnBeginFrame by returning early when nothing is dirty.

The concept of dirtying the scene graph is a workaround while we
migrate all of the existing code that modifies UI elements directly to
use bindings.

This shouldn't have any user-visible changes, so is safe to land
sans-flag.

Bug: 776521
Change-Id: I470e8494bd05dd8278c124313bae7df94795861b
Reviewed-on: https://chromium-review.googlesource.com/728943
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510250}

There was no spaces between the title and the rest of the message.
This doesn't solve the issue at crbug.com/773717, but at least it
is less broken now.

Bug: None
Change-Id: Ifda5b20c8a2f1f9cbb0eb32878c56bd1dbc2ebe0
Reviewed-on: https://chromium-review.googlesource.com/726342
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510249}

TBR=haraken@chromium.org
BUG=757374, 776334
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Change-Id: I36c3f44119b547c8c85efa7a03c66357c3f1a118
Reviewed-on: https://chromium-review.googlesource.com/729302
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510248}

This reverts commit 71c0f5b5.

Reason for revert: This CL logs to stderr on every test, causing the archive_webkit_layout_tests step to explode. See crbug.com/776334.

Original change's description:
> Reland: Add UKM Document.OutliveTimeAfterShutdown
>
> This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/647050.
> This CL tries to reland the change after rebasing.
>
> This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
> recorded when a Document object survives 5, 10, 20 or 50 garbage
> collections after detached. If a document outlives such long time, the
> document might be leaked. The UKM would be very useful to know where such
> leaky documents exist and to fix them.
>
> Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing
>
> Bug: 757374
> Change-Id: I1f64d2a9260d898c386bb948dd25a1c5586f8eb7
> Reviewed-on: https://chromium-review.googlesource.com/722301
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510029}

TBR=palmer@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,holte@chromium.org

Change-Id: I59155476ced5620a87e027225f9f017c296813e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757374
Reviewed-on: https://chromium-review.googlesource.com/729462
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510247}

Currently this UMA is reported in ContentDecryptorDelegate which is only
used in the pepper CDM path. This CL makes sure we report the same UMA
in the mojo CDM path as well.

TBR=bbudge@chromium.org
BUG=412987,721876
TEST=Manually tested and checked about://histograms

Change-Id: I4687e5115ee6d03e6a2701250bae50acf2dec2a8
Reviewed-on: https://chromium-review.googlesource.com/727700
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510246}

After these changes there are two new browser_test failures:

 * https://chromium-review.googlesource.com/725385
 * https://chromium-review.googlesource.com/665657

The later failure appears to be an existing test failure uncovered by a
change which prevented the Network Service from being enabled during the
test run.

TBR=jam@chromium.org

Bug: 769401
Change-Id: If1d8af9fcfccc9491a5005bd545c1679e820045e
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/729521Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510245}

Also a stepping stone in getting deps from .rc files correct automatically.

The driver script rc.py works like rc.exe; it supports printing resource
names on /showIncludes:

$ cat test.rc
4 ICON "icon.ico"
$ build/toolchain/win/rc/rc.py /showIncludes test.rc
Note: including file: ./foo.h
Note: including file: /Users/thakis/src/chrome/src/icon.ico
$ file test.res
test.res: MSVC .res

The driver script behind the scenes calls a deps'd-in "rc" binary.
This CL includes a script to build new versions of that binary.
It's ~150kB on Mac and Linux, and ~600kb on Windows.

The compiler isn't hooked up to anything yet. I plan to change
tool_wrapper.py to call both it and rc.exe in ExecRcWrapper() when
on Windows (and compare the two outputs and make sure they're identical),
and to call only rc.py when on non-Windows.

Eventually I also want to make ExecRcWrapper() use rc.py's /showIncludes
to get dependencies for .rc files right.

The README.md has some more details. We're in the process of slowly
upstreaming this to LLVM, but it looks like that'll take a while longer,
so in the meantime let's do this until the LLVM version is ready.

Bug: 774193,132660
Change-Id: I9a9ee1e271bf403ddb7f8d18ecd97730762c6cbc
Reviewed-on: https://chromium-review.googlesource.com/727110
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510244}

Previously some compositing layout tests used references which contained
styles and elements which were not enough different from the test. This
increased chances that the same bug affects both the test and the
reference and the test still passes.

This CL removes unnecessary styles and elements from references to make
them more different from the tests.

Change-Id: I7c452c27f44fb34460217697ce1dd9bf98456d48
Reviewed-on: https://chromium-review.googlesource.com/726542
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510243}

NOTRY=true

Bug: 776575
Change-Id: I986136822ee7d835f94af1dffd48399be03ce43a
Reviewed-on: https://chromium-review.googlesource.com/729439
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510242}

These are behavior-driven tests, each test testing a specific behavior:
- addTrack() with a track and no stream should fire ontrack with a
  remote track with the same ID and no streams.
- addTrack() with a track and a stream should fire ontrack with a
  remote track and stream with matching IDs.
- addTrack() with two tracks and a shared stream should fire ontrack
  twice with remote tracks and a shared remote stream, with matching
  IDs.
- addTrack() with a track and two streams should fire ontrack with a
  track and two streams with matching IDs.
- ontrack should fire before setRemoteDescription()'s promise resolves.
- ontrack's receiver should match getReceivers().
- removeTrack() should not result in a receiver being removed.

Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on
transceiver support. When testing a behavior like "fires an event with
a track" the test does not test unrelated things like the event being a
complete implementation of RTCTrackEvent with transceivers and all.

In a follow-up, I will add tests for other behavior associated with the
removal of a track, including onmute events firing and the track being
removed from the remote streams.

Bug: 774303
Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f
Reviewed-on: https://chromium-review.googlesource.com/719615
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510241}

Whenever the Page Info bubble needs to update the number of cookies being used
on a site, it will update the text in the Page Info bubble to reflect this,
which will then trigger a layout update and reanchor the bubble. However, if
this occurs while the browser window is moving into full screen mode, the Page
Info parent window will be null and this operation will crash.

Fix by checking whether the parent window exists before trying to reanchor.
Moving into full screen will also close the Page Info bubble, so the reanchor is
unnecessary anyway - it will be correctly positioned the next time it is opened.

Bug: 773283
Change-Id: I6f7418fcc96a95b8e3f0a3276ac009cef6eda92e
Reviewed-on: https://chromium-review.googlesource.com/720579
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510240}

At this point, the id_mapping functionality is only used for GetSynciv
(and IsSync, but it's a noop there), whereas this can be simplified by
using a Do function that does the same thing (and is much smaller code
than the corresponding autogen logic).

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I65128d736ea07f034ac3f5c93eb3d0445095ee27
Reviewed-on: https://chromium-review.googlesource.com/728703Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510239}

In addition to registering the name with the global ThreadIdManager, the
platform thread object's name is set with zx_object_set_property(), so
that it will be reflected in logging from e.g. the platform's crash
handler.

Bug: 725726
Change-Id: Id47efa77857b35c2317b5eed05aa2e630a044113
Reviewed-on: https://chromium-review.googlesource.com/727699Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510238}