GitLab

A common pattern on the web is to animate both -webkit-filter and filter.
-webkit-filter can currently be composited while filter cannot.
Composited animations are not started if there are non-compositable properties
being animated simultaneously.
This patch ignores filter in CSS keyframes so that animations using
-webkit-filter and filter will run on the compositor.

Once -webkit-filter becomes an alias for filter we can stop ignoring filter
in CSS Animations.

BUG=520610

Review URL: https://codereview.chromium.org/1319083003

git-svn-id: svn://svn.chromium.org/blink/trunk@201522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I missed LocalToWindowPointTest in https://codereview.chromium.org/1308663004/,
and there are two more tests with different subclasses too.

BUG=523910
TBR=chrishtr

Review URL: https://codereview.chromium.org/1314353004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=519650

Review URL: https://codereview.chromium.org/1307743008

git-svn-id: svn://svn.chromium.org/blink/trunk@201520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |character{After,Before}()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568

Review URL: https://codereview.chromium.org/1320233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructor

This patch introduces |visiblePositionOf()| with |PositionWithAffinity| as
replacement of |VisiblePosition| constructor with |PositionWithAffinity| to
prepare making |VisiblePosition| constructors private.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326563002

git-svn-id: svn://svn.chromium.org/blink/trunk@201518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before r201294, SegmentedString::push() had an exotic behavior where two
consecutive push() results are swapped.  SegmentedString stored those two
chars into m_pushedChar{1,2} to avoid messing up SegmentedSubString.

After r201294, SegmentedString::push() is guaranteed to be used for
ungetc()-like usecase, where it reverts the SegmentedString::advance()
which was issued just before the call.

This CL removes m_pushedChar{1,2} optimization, and replace it with
SegmentedSubstring::push() which simply decrement m_data.string{8,16}Ptr.
In pessimistic case, this may end up prepending wtf::String inside
SegmentedSubstring, but this should be very rare.

BUG=None
TESTS=SegmentedStringTest

Review URL: https://codereview.chromium.org/1319913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch disables kSubpixelPositioning_Flag for "Dotum" in small
sizes.

The embedded bitmap of "Dotum" font looks poorly positioned when linear
metrics is used. This patch improves the positioning of the font by
disabling linear metrics.

Skia disables linear metrics and use DWRITE_MEASURING_MODE_GDI_CLASSIC
when kEmbeddedBitmapText_Flag & the font has 'eblc' OpenType table for
the specified size & !kSubpixelPositioning_Flag. The first two
conditions are already true, this patch turns the last condition to
true.

BUG=394585

Review URL: https://codereview.chromium.org/1304363011

git-svn-id: svn://svn.chromium.org/blink/trunk@201515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of document.querySelector[All]() should check selector context (patchset #6 id:100001 of https://codereview.chromium.org/1245933002/ )

Reason for revert:
This seems to have caused a significant perf
regression.  Reverting.

BUG=526742

Original issue's description:
> document.querySelector[All]() should check selector context
> 
> Blink failed to check whether the left-most matched selector ends up
> in Document TreeScope.
> The check was only enabled for querySelector*() is called on
> a regular element, not on document.
> 
> This issue can be exposed by passing "::shadow" or "/deep/"
> which pierces shadow boundary and the selector can
> incorrectly match inside shadow.
> 
> BUG=511486
> TEST=fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201461

TBR=esprehn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511486

Review URL: https://codereview.chromium.org/1329523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLTokenizer checkpointing features are never used.

BUG=None
TBR=yoav

Review URL: https://codereview.chromium.org/1309673006

git-svn-id: svn://svn.chromium.org/blink/trunk@201513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Slow didn't help location_assign.html.
- Assign specific bug numbers to some tests.
- iframe_sandbox_allow_script.html and
  resource-selection-invoke-remove-from-document.html don't crash on bots.

BUG=108417,525872,525896,525889
TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1327573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium-side patch that removes suppressing asynch processing of
redundant MSE seeks (https://codereview.chromium.org/1305273007/)
appears to have changed behavior enough on at least desktop Chromium
that the mediasource-duration layout test now shows "PASS" for each test
within it. This change updates those expectations to PASS (by removing
the expectations file) and marks the test flaky in preparation
for landing the Chromium-side change.

TBR=philipj@opera.com
BUG=526337, 399523, 303419, 284782, 266631
TEST=http/tests/media/media-source/mediasource-duration.html

Review URL: https://codereview.chromium.org/1321253005

git-svn-id: svn://svn.chromium.org/blink/trunk@201511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201488

BUG=521730
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/1315423004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201495

BUG=516580
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1304163011 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520195
TBR=pfeldman

Review URL: https://codereview.chromium.org/1306053010

git-svn-id: svn://svn.chromium.org/blink/trunk@201508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1311353007

git-svn-id: svn://svn.chromium.org/blink/trunk@201507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526568

Review URL: https://codereview.chromium.org/1317973003

git-svn-id: svn://svn.chromium.org/blink/trunk@201506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201494

BUG=506669
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1322933003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1320793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526748

Review URL: https://codereview.chromium.org/1317493003

git-svn-id: svn://svn.chromium.org/blink/trunk@201503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526221
NOTRY=true

Review URL: https://codereview.chromium.org/1325483003

git-svn-id: svn://svn.chromium.org/blink/trunk@201502 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525061

Review URL: https://codereview.chromium.org/1325593002

git-svn-id: svn://svn.chromium.org/blink/trunk@201501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |{next,previous}PositionOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1307023005

git-svn-id: svn://svn.chromium.org/blink/trunk@201500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mandoline uses WebFrameWidgetImpl for an iframe, and it could
be in a separate process from the main frame. And touch events
are dispatched to iframe directly, so this CL add gesture support 
for WebFrameWidgetImpl.


BUG=522592

Review URL: https://codereview.chromium.org/1313763004

git-svn-id: svn://svn.chromium.org/blink/trunk@201499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=518999,526594

Review URL: https://codereview.chromium.org/1322753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Back in the mists of time, BlobBuilder called UTF8Encoding().encode()
when appending strings, which looks correct. But then mean old
https://crbug.com/117128 came along pointing out that encode() was
actually NFC normalizing strings even when not wanted, so
https://crrev.com/19845004 cleverly renamed the function to
normalizeAndEncode() so future callers would not fall into this trap.
A few existing places such as XHR were eventually changed to just call
encode() (https://crrev.com/22875053) but no-one noticed BlobBuilder
was getting it wrong prior to this bug report.

Change the BlobData::appendText() method to just call encode(), and
add a test case for the Blob constructor.

The new behavior matches FF and IE.

BUG=427183
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1305393006

git-svn-id: svn://svn.chromium.org/blink/trunk@201497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For consistency with the timeline and profiles panel, network should have
the same shortcut for toggling recording.

BUG=

Review URL: https://codereview.chromium.org/1310073007

git-svn-id: svn://svn.chromium.org/blink/trunk@201496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix handling of emojiFonts in getFontBasedOnUnicodeBlock, the emojiFonts
field was incorrectly not marked as static and thus would only be set on
the very first invocation of the method.

TEST=fast/text/emoji-font-fallback-win.html
BUG=516580
R=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1312903004

git-svn-id: svn://svn.chromium.org/blink/trunk@201495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously we paint outlines and focus rings in very different paths.
- Focus rings are painted in the way that we collect all rects first
  then combine the rects into a enclosing path, then paint the path.
- Outlines are painted by each box, line box, continuations, causing
  difficulties when handling the joints. We have issues of broken
  joints, unconnected segments, missing segments, etc.

With this CL:
- We paint outlines and focus rings in the same way: collect rects first
  paint the path. This resolves the original issues of broken joints and
  unconnected segments, etc.;
- Don't need to propagate outline style to continuations because the
  outline owner paints the whole outline. This enables us to paint a
  whole connected outline enclosing the continuations.

BUG=506669

Review URL: https://codereview.chromium.org/1224933002

git-svn-id: svn://svn.chromium.org/blink/trunk@201494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the comment for WebInputEvent.timeStampSeconds to reflect 
what Chrome actually delivers.

BUG=none

Review URL: https://codereview.chromium.org/1320193002

git-svn-id: svn://svn.chromium.org/blink/trunk@201493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently it's only exposed to the HTTP family, but now that Chrome
extensions support service workers they need to support the fetch API.
This patch adds registerURLSchemeAsSupportingFetchAPI to the Blink API,
queried by the fetch API code as shouldTreatURLSchemeAsSupportingFetchAPI.

BUG=466876
R=yhirano@chromium.org, dcheng@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/1313733006

git-svn-id: svn://svn.chromium.org/blink/trunk@201492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526315

Review URL: https://codereview.chromium.org/1313863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Line Layout API] Add hasOverflowModel, logicalVisualOverflowRectForPropagation, and logicalLayoutOverflowRectForPropagation to API

This CL updates all callers (all in InlineFlowBox).

BUG=499321

Review URL: https://codereview.chromium.org/1323803002

git-svn-id: svn://svn.chromium.org/blink/trunk@201490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're currently recording an optional clip in the image drawing.  Since we have a specialized
recorder/display item for clips (and to simplify the implementation of the image recorder),
we can apply the clip independent of the image recording.

R=chrishtr@chromium.org,vmpstr@chromium.org

Review URL: https://codereview.chromium.org/1322613004

git-svn-id: svn://svn.chromium.org/blink/trunk@201489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org
NOTRY=true
BUG=521730,410145,521764,526752,440452

Review URL: https://codereview.chromium.org/1319083006

git-svn-id: svn://svn.chromium.org/blink/trunk@201488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebViewHelper::initializeAndLoad() doesn't take ownership of the optional
frame client parameter.  All other subclasses of TestWebFrameClient are
constructed on the stack too.

Fixes leaks like
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5b2ea0 in operator new(unsigned long) /b/build/slave/ClangToTLinuxASan/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:62
    #    #1 0x1799216 in blink::WebPluginContainerTest_Copy_Test::TestBody() third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp:242:99
    #

BUG=523910,245126,494827

Review URL: https://codereview.chromium.org/1308663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When trying to find the size of a flexible grid item the algorithm must
perform several steps, which are described in the following section of
the spec:

https://drafts.csswg.org/css-grid/#algo-find-fr-size

When the flex factor sum is less than 1, we should use 1 instead so we
can apply each factor to the total available size to fill.

BUG=520477

Review URL: https://codereview.chromium.org/1321573005

git-svn-id: svn://svn.chromium.org/blink/trunk@201486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=473220

Review URL: https://codereview.chromium.org/1301993003

git-svn-id: svn://svn.chromium.org/blink/trunk@201484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ensures that we always get correct slow scroll regions 
even when full layout is skipped in favor of faster OverflowRecalc.

TEST=scrollingcoordinator/non-fast-scrollable-transform-changed.html
BUG=417345

Review URL: https://codereview.chromium.org/1256043007

git-svn-id: svn://svn.chromium.org/blink/trunk@201483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://heycam.github.io/webidl/#es-invoking-callback-functions
By default, "the callback this value" should be "undefined".

In strict mode,
- before: this value was window (global object).
- after: this value is undefined

In non-strict mode,
undefined (or null) this value is converted to the global object.
This conversion is done in V8.  So user script observes no change.

See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.3

Note: This CL changes the callback this value from the window object of the receiver to the global object of the running script.
Example) Suppose running the following script in a child window.
    function f() { console.log(this); }
    top.requestAnimationFrame(f);
before: this === top
after: this === window (child window)

BUG=332663

Review URL: https://codereview.chromium.org/1301423004

git-svn-id: svn://svn.chromium.org/blink/trunk@201482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Upon executing a javascript: URL in an empty document, we take care to
notify that the load has started. Should the result of executing the
script code be no result and navigation, balance the progress notifications
by signalling completion also.

R=haraken
BUG=495495

Review URL: https://codereview.chromium.org/1158973004

git-svn-id: svn://svn.chromium.org/blink/trunk@201481 bbb929c8-8fbe-4397-9dbb-9b2b20218538