GitLab

This change implements a newer version of the global media controls UI
based on updated UI mocks.

Bug: 1124401
Change-Id: I0827b33ec97697ead88e7db4dd8b5248668bb236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399619
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805993}

https://android.googlesource.com/platform/external/perfetto.git/+log/3b19b9d3347f..a4cfaa2dfc7f

2020-09-10 treehugger-gerrit@google.com Merge "tp: add support for gzipped traces in DecompressTrace"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ibdfea728bfd9a301334ab16e1cf7e6473a60ce41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404801
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805992}

In incognito mode, the stored verdict count is always 0 because real
time URL check is disabled. Therefore,
CleanUpExpiredRealTimeUrlCheckVerdicts can return early to avoid the
jank.

Bug: 1095078
Change-Id: Ic6c8a5ee441d18cd26e4591186699a7597c158fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404743
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805991}

Bug: 1041589
No-try: true
Change-Id: Ib5d355bce4ba17e2da9cf26483e7de6e84495ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404152
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805990}

https://skia.googlesource.com/skia.git/+log/18f6a54fc3ce..0f64e0dfd845

2020-09-10 jlavrova@google.com An attempt to make font resolution more predictable.
2020-09-10 brianosman@google.com Clean up SkSL operator utility functions
2020-09-10 johnstiles@google.com Add InlineCandidateAnalyzer to locate candidate functions for inlining.
2020-09-10 brianosman@google.com Refactoring determine_binary_type to fix some bugs
2020-09-10 bungeman@google.com Mark FreeType bitmap font bounds as unknown.
2020-09-10 johnstiles@google.com Prevent inlining of recursive calls.
2020-09-10 herb@google.com combine origin and drawing matrix for drawGlyphRunList
2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0a1061da0c7f to 87f25134a8c1 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: reed@google.com
Change-Id: I2de4f99acebad3bb8339c93cf13478026ee61693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404683Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805989}

Currently all file results have score 0.5, so let's add some scoring
logic. This CL uses the fuzzy string match algorithm also used for apps
to score file results.

Bug: 1053637
Change-Id: Ia41dcca17c20909aec849ce3e0ee28f890bf6f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396196
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805988}

Previously, when in Incognito the browser UI language was used for
Accept-Language and navigator.language.

This changes it so that only the first language in the Accept-Language
list is used.

Bug: 1077547
Change-Id: I9d7e6748411e12dfc2969028cce8991840c6c481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392440
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805987}

These functions are used in hundreds of locations in the code base and
there's no ongoing effort to deprecate them. New developers are
sometimes confused when they write code that must use these functions.
Delete the comments discouraging their usage.

Bug: none
Change-Id: I4d40956edc6168340a361b762eb741723d47c8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404949
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805986}

This reverts commit a3e6095c.

Reason for revert: Fix test flakiness

Original change's description:
> Revert "[lacros] Support mojo connection in testing environment"
> 
> This reverts commit 44a2bf3d.
> 
> Reason for revert: New test times out.
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462
> 
> Original change's description:
> > [lacros] Support mojo connection in testing environment
> > 
> > This CL supports setting up mojo connection between lacros and ash in
> > testing and debugging environment, and it is done via a unix domain
> > socket.
> > 
> > Unix domain socket is only used in testing, not production because it
> > allows a random process to connect to ash-chrome as long as it knows
> > the socket path.
> > 
> > Currently, only one lacros-chrome is allowed to connect to ash-chrome,
> > so in the testing environment, test launcher will run tests serially,
> > and will change to run in parallel once ash-chrome supports multiple
> > clients.
> > 
> > Bug: 1120582
> > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543
> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805537}
> 
> TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org
> 
> Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1120582
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805696}

TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org,mstensho@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1120582
Change-Id: I3cf4c46e939ee71e57b30d435da58bd23d15c02a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404684Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805985}

https://chromium-review.googlesource.com/c/chromium/src/+/2398193
updated the reporting of the MobileIntent.PageLoadDueToExternalApp
histogram to exclude Chrome self-launches. This change updates the
histogram description to match.

Bug: b/167573777
Change-Id: I56aa24f002b37acbd7bc65e2367fad817d0e0e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401801Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805984}

This histogram is still useful, as it tracks full page network usage
ads and other UMA metrics are split by main frame / sub frame.

Bug: 1109947
Change-Id: I0636b490556254cb5dbb1802327f5ab6f8eb7632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401698Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805983}

Previously a placeholder was used. We now have a more suitable icon.

Bug: 1127111
Change-Id: I772313b316845fcd03d77ec37af1beeb72a2fcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404065Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#805982}

https://android.googlesource.com/platform/external/perfetto.git/+log/feb1579dfb25..3b19b9d3347f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie9c11233985eab040a03597d4016e85164685758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805981}

Change-Id: I756d575d9ce93df26f52c31201274dab67f2c0ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404391
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805980}

- Styling wrapper for diagnostic cards
- No styling is applied yet

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I21df9d3311aa54f8a21ef1f501a517c3e1a22e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403901Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805979}

This is still gated by the NTP modules flag and the
server side KS gating but we can turn it on so
people can test it easier.

BUG=1121360

Change-Id: I20736d9e8ebe594d03d510749eb9a2b5effaddab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401729
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805978}

ReadBackFramebuffer assumes that the destination buffer size and format
match the source. However, this isn't true when exporting the buffer for
software compositiing since it only supports RGBA_8888, but the buffer
could be RGBA_F16.

Also fixes undefined behavior due to using the same buffer as source and
destination for SkPixmap::readPixels which does a memcpy under the hood.

Bug: 1122638
Change-Id: I887f70ea65fdf7ad215f5db22b39d0727fc3d09a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393160
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805977}

ImageData::StorageFormatDataSize returns 1, 2 and 4 for the data size
for color format in uint8, uint16 and float 32 format, respectively.
This not really true, since we need 4 channel to describe a color, the
data size should really be 4, 8 and 16 bytes instead. In image_data.cc,
we always call ImageData::StorageFormatDataSize and then multiply the
result by 4 to get the real data size.

In this cl, I update ImageData::StorageFormatDataSize to return 4, 8 and
16 and remove the multiplication to improve the readability of the code.

Bug: 1122866

Change-Id: Ib78e31cff3c919728a3a84771acf2545d29a89a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391984Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805976}

https://webrtc.googlesource.com/src.git/+log/fc83cdc8198b..8b9424e9da85

2020-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b55cb19f..a3dcf9ef (805701:805834)
2020-09-10 hidehiko@chromium.org Expand is_linux to is_linux || is_chromeos.
2020-09-10 nisse@webrtc.org Make NetEqController::TargetLevelMs method const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1110266
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I7fd5d1de23efde64a3460a9ada88f679969c818e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805975}

Since the JS Self-Profiling API will require COOP+COEP to ship, it's no longer
necessary to isolate by context. This is a step towards deprecating this
functionality in V8 entirely, as context scraping depends on reads of
potentially uninitialized memory.

Bug: 956688
Change-Id: I6fb8c2565f1979991f6ef8f86ceefe82ce5a5e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387150
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805974}

This commit adds Sensor Hal Dispatcher, sensor mojo interfaces, and
basic usages of them to connect clients to iioservice.

BUG=chromium:1006141, b:162154663
TEST=builds, unit tests and test on octopus: Chromium connects to
iioservice as a DBus client, and invites iioservice into the mojo
network. Chromium then waits for iioservice_client (test executable) to
register and establish a connection between iioservice and
iioservice_client. All re-connections between Chromium and iioservice
work well.

Change-Id: I9f9ed4267093191ad306c25216300f850dc42006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332056
Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805973}

These APIs will eventually be wired up to Holding Space UI.

Bug: 1126274
Change-Id: I8c213459488dea838dd34e64f4c80dd57d466172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404470
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805972}

Previously, the header expand/collapse chevron button was on the far
right side of the header row.

This looked like a bug sometimes, when the header started out collapsed.

This CL moves the button to be directly adjacent to the header text.

See the bug for details.

Bug: 1127090
Change-Id: I23eba83d9ff58d31e6983af195fb219e668e9cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404663Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805971}

Adds deep links to the Crostini Page, including the Crostini Details,
Import Export, and Android ADB subpages.

Bug: 1084154
Change-Id: I0dd75e13999b5ce7f8c17b39442d20dc0bfea59b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381072Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#805970}

Type kBorealis had a FALLTHROUGH to the default case, which contains
a NOTREACHED().

Remove FALLTHROUGH, since those are only needed for non-empty blocks.

Remove default case, so the compiler will emit an error when an
app type is not included. This reveals that AppType::kRemote was not
being handled.

No behavior changed expected. I just noticed this while working on
an unrelated issue.

Bug: none
Change-Id: If55a1473c5739f5070b1377aae7e06da704a1806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393949Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805969}

This change adds 2 new install icons, and creates a configurable feature
that will change the current icon to one of the new ones.

Before:
https://drive.google.com/file/d/1kjTrjTw1aPIBnEbZ018CEv3v9G25Q9Ve/view
Download style:
https://drive.google.com/file/d/1H6-GojGKMigLtSMBnqoJ3-H3SJYX5ZL9/view
Device style:
https://drive.google.com/file/d/1Cn1r6FCt4AxRPgMp0RGLM8P7w0fbTZJc/view
Reference images:
https://drive.google.com/corp/drive/folders/1m4CGxZJNP6PkQ6u7QHGPYuO5vy59fAlm

Doc:
https://docs.google.com/document/d/1D6vQpZR8X5l4rMCs9ErUvgxWNIPRK3iv4hGvy5qXSDo/edit#

Bug: 1117260
Change-Id: Id4d0ca6e67ce13093fe4ed6344424810e6665f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401329Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805968}

This CL adds SignedExchangeSubresourcePrefetch to the config.

Bug: 935267
Change-Id: Ia138e0667e4a13fcf210d931db55fdbf0bc41477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398040Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805967}

Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/2392712/2

Change-Id: I7642e72fbe75f8b31f19bc34f10cbbb60201e81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404571
Auto-Submit: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805966}

This change prepares for development of capturer features behind a new flag. Moving static functionality into a separate file allows the capturer implementation to be duped, and the creator to create either implementation based on a flag.

Future CLs will add the flag and perform the duplication.

Bug: chromium:1126690
Change-Id: I8592a2ba81765e999c497eda9a6f09cc644e1423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401520Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#805965}

Bug: 1126205
Change-Id: I0409fa9fa12f272077bbef6f107ff81fe0866132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401975
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805964}

Will clean up test files for the disabled case in a follow up.

Bug: 994052
Change-Id: I45f5e12fcc901fbf656aaad1423949deea6322f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402184Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ben Goldberger <benwgold@google.com>
Cr-Commit-Position: refs/heads/master@{#805963}

The "SafeBrowsing.Settings.UserAction*" metrics was added on Android
settings page in https://crrev.com/c/2357677. We'd like to log the
same metrics on desktop settings page as well.

Bug: 1124491
Change-Id: Ib87672da86d696fd28c46955ac78159719cfba82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389260Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805962}

Generate the thumbnail onto the SkBitmap of a Thumbnail object using
PDFium's FPDF_RenderPageBitmap().

Add a test PDF and expectation PNGs of its thumbnails at different
resolutions. Compare the rendered thumbnails to the expectation PNGs.

Bug: 652400
Change-Id: Id4c5e7f7a93822c6c38efdd63657e3e8002cd9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382687Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805961}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I83438888e9bc42b8965e4e3aebd045da75dc9dff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405000Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805960}

This CL adds feature author guide section for document policy
to README.md.

Change-Id: Ib75b203192545fbbb8de48ceef25f1156398c4a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380609Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#805959}

This reverts commit cf0f02ca.

Reason for revert: may be the cause of crbug.com/1127106
(linux-blink-rel failure in webdriver_tests_suite)

Original change's description:
> [chromium] Enable ChromeDriver log for WPT tests
>
> Enable chromedriver log for CI wpt tests
>
> Change-Id: I02d4acb627ca90233b7c0dab401c7c28e6759604
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402319
> Reviewed-by: John Chen <johnchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Shengfa Lin <shengfa@google.com>
> Cr-Commit-Position: refs/heads/master@{#805817}

TBR=sky@chromium.org,johnchen@chromium.org,kyleju@chromium.org,shengfa@google.com
Bug: 1127106

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I0ca84f034e92e8858cd4fcf23bb49b0e52161f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404158Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805958}

This change ensures that the RecyclerView clears the view pool
when the user ends interaction with the Omnibox.

Bug: 1075602
Change-Id: Iacd36ade19e67144421674cc85c05b750bd0b7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404390
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805957}

This replaces it with direct callback registration on the underlying
links, conveyed by setting the callback on the RangeStyleInfo
corresponding to the link.  This allows eliminating parameters like the
range, since a different callback or different bound arguments can be
set for each range.

With a change to how ContentSettingBubbleContents works (which was the
other place using the Link* argument of Link::ClickedCallback), this
allows reducing Link::ClickedCallback to one argument as well.  It makes
sense to make these changes simultaneously since they mostly affect the
same listeners and thus this avoids changing lots of signatures twice.

Bug: 1108460
Change-Id: Ie7c9cc7cafeb92b91aad2949e176b99d26d493e3
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388944
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805956}

Bug: 1126713
Change-Id: Ie53a32768b8246f6ec7443281c65a08608f4e04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404521
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805955}

This change prepares all public methods of PpdProvider to accept
arguments that may contain mixed-case effective-make-and-model strings
and explicitly converts any such members to lowercased ASCII.

Bug: chromium:888189
Test: none
Change-Id: I7ed8399858924828c138f0c27f86408a9ddcae32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363656
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805954}