GitLab

When the font name passed to check() does not match any font face in the
FontFaceSet, current implementation always returns true.  As per the
latest spec draft [1], it should return true if it matches platform font
name, otherwise false.

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-check

BUG=378989
TEST=fast/css/fontfaceset-check-platform-fonts.html

Review URL: https://codereview.chromium.org/324293003

git-svn-id: svn://svn.chromium.org/blink/trunk@176278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/331283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SubtargetGeometry is used only in Vector.

BUG=357163

Review URL: https://codereview.chromium.org/332183006

git-svn-id: svn://svn.chromium.org/blink/trunk@176272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and makes their element members Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/334223009

git-svn-id: svn://svn.chromium.org/blink/trunk@176271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGLengthContext is made STACK_ALLOCATED, as it is currently never used
on a heap.

BUG=357163

Review URL: https://codereview.chromium.org/339793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333413006

git-svn-id: svn://svn.chromium.org/blink/trunk@176267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Types of m_maximumAge and m_imeout are "unsigned long"
but they are "int". Therefore their types should change to
"unsigned" for align with others.

BUG=368184

Review URL: https://codereview.chromium.org/336213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376377
TEST=no new test; just refactoring

Review URL: https://codereview.chromium.org/330543004

git-svn-id: svn://svn.chromium.org/blink/trunk@176265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change cleans up the code a little to make it easier to see that
the "direction of playback" is being used and corrects the definition of
"forward" to include playbackRate == 0. New test cases were added to
expose the change in behavior.

BUG=385343
TESTS=LayoutTests/media/media-ended.html LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html

Review URL: https://codereview.chromium.org/331063006

git-svn-id: svn://svn.chromium.org/blink/trunk@176264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Mark XMLTreeViewer STACK_ALLOCATED().
- Make m_document Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/339703004

git-svn-id: svn://svn.chromium.org/blink/trunk@176263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ThisValue should support "any" type other than "object".

BUG=382728

Review URL: https://codereview.chromium.org/330163004

git-svn-id: svn://svn.chromium.org/blink/trunk@176262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The content should take total window width while overlay-scrollbar is enabled. 

BUG=382900

Review URL: https://codereview.chromium.org/333633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This simply calls its superclass since about four months ago.
https://codereview.chromium.org/129873009/

Review URL: https://codereview.chromium.org/339753002

git-svn-id: svn://svn.chromium.org/blink/trunk@176260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we just report that "no squashing target was found". There
are many reasons why squashing might fail and this message is not very
informative. This cl expands the list of squashing-related compositing
reasons to make diagnosing layer explosions easier.

R=chrishtr@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/331203003

git-svn-id: svn://svn.chromium.org/blink/trunk@176259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trivial patch, found while investigating another issue. This patch
removes resetMargin and resetBorderRadius.

Review URL: https://codereview.chromium.org/337043002

git-svn-id: svn://svn.chromium.org/blink/trunk@176258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For repaint tests, compute minimum repaint by comparing pixel dump
before and after repaintTest() and output repaint in layout test result.

In overlay, visualize the minimum repaint in expected results.

In this way, when making repaint change and checking actual results,
we can easily discover under-repaint bugs if we see any solid black
area not covered by repaint rects.

This CL depends on chromium-side CL https://codereview.chromium.org/301243022.

Review URL: https://codereview.chromium.org/315443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the testing, timing, workers and xml subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/339573006

git-svn-id: svn://svn.chromium.org/blink/trunk@176256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bonus: sort entries on serviceworker expectations section.

NOTRY=true
BUG=385384, 364390

Review URL: https://codereview.chromium.org/339013002

git-svn-id: svn://svn.chromium.org/blink/trunk@176255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/338233002

git-svn-id: svn://svn.chromium.org/blink/trunk@176254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop traverseNextElement() method from HTMLCollection class to avoid code
duplication with traverseForwardToOffset(). This method was only used
by supportedPropertyNames() and updateIdNameCache(). Now these methods
uses the standard traversal API (HTMLCollection::length() / item(index)),
and thus the standard code path for HTMLCollection traversal.

I did not see any regression with this change on Dromaeo:
http://dromaeo.com/?id=223149,223150

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/336133002

git-svn-id: svn://svn.chromium.org/blink/trunk@176253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can't enable Oilpan for ImageBitmapFactories, another class in
modules/imagebitmap/, because it's a Supplement of DOMWindow or
WorkerGlobalScope.

BUG=340522

Review URL: https://codereview.chromium.org/323293004

git-svn-id: svn://svn.chromium.org/blink/trunk@176252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We check for form inputs in blockSuppressesAutosizing, but the block
must be a potential cluster root to reach this check.

BUG=376012

Review URL: https://codereview.chromium.org/334333002

git-svn-id: svn://svn.chromium.org/blink/trunk@176251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=abarth@chromium.org
CC=jkarlin@chromium.org, japhet@chromium.org

Review URL: https://codereview.chromium.org/338093006

git-svn-id: svn://svn.chromium.org/blink/trunk@176250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WEB_AUDIO and SVG_FONTS conditions in tagName files were 
handled by generate scripts and this CL adds the support. 
This fix was also needed to build without SVG_FONTS enabled.

Review URL: https://codereview.chromium.org/330093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=305497

Review URL: https://codereview.chromium.org/328263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove inefficiency from HTMLCollection::namedItems(). The code was
unnecessarily checking that the pointers were non-null for every iteration of
the for loops. This CL updates the code so that the null check is done only
once.

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/337963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik@chromium.org
BUG=354447

Review URL: https://codereview.chromium.org/331313002

git-svn-id: svn://svn.chromium.org/blink/trunk@176246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame might be null, so we need to check that before trying to
dereference it to see if it's a local frame.

BUG=385162

Review URL: https://codereview.chromium.org/334323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Force the use of fully aliased text for certain common east asian fonts
at smaller font sizes to ensure that text is legible. This is only
required for fonts without an embedded bitmap at a the specific size and
the minimum size for enabling anti aliasing is set on a per font basis.

BUG=383090,383040
R=dglazkov@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/339693002

git-svn-id: svn://svn.chromium.org/blink/trunk@176244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Universal accelerated overflow scroll doesn't paint
highlight gaps between scroll children because the
scrolling contents layer isn't always set up to
draw content.

BUG=381185,381187

Review URL: https://codereview.chromium.org/303253004

git-svn-id: svn://svn.chromium.org/blink/trunk@176243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371746

Review URL: https://codereview.chromium.org/339703002

git-svn-id: svn://svn.chromium.org/blink/trunk@176241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=none
BUG=383749
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/334263005

git-svn-id: svn://svn.chromium.org/blink/trunk@176240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have NodeList::item() overrides return an Element* when appropriate instead
of a generic Node*. This makes it clear to callers that these are actually
returning Elements and avoids unnecessary isElementNode() checks or casts
that look unsafe.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/331863003

git-svn-id: svn://svn.chromium.org/blink/trunk@176239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[webcrypto] Require importKey() for JWK to provide data as a Javascript object rather than a JSON arraybuffer.

BUG=373917,245025

Review URL: https://codereview.chromium.org/336173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the page, plugins, rendering, and svg subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/334223005

git-svn-id: svn://svn.chromium.org/blink/trunk@176237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Original patch from http://trac.webkit.org/changeset/169849

We were getting the length of the string before calling lower() on
it but we were looping over the new string which might have a
different length than the original.

BUG=383704

Review URL: https://codereview.chromium.org/333643008

git-svn-id: svn://svn.chromium.org/blink/trunk@176235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the inspector and loader subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/337873003

git-svn-id: svn://svn.chromium.org/blink/trunk@176234 bbb929c8-8fbe-4397-9dbb-9b2b20218538