GitLab

This makes the buildbot archive hermetic for package building, rather than
pulling files from the package builder's source tree (e.g. BRANDING) and system
(e.g. lib32 stuff).

Note, this currently only applies to official builds since that's all we package.

This depends on:
http://codereview.chromium.org/115842
http://codereview.chromium.org/113966

Review URL: http://codereview.chromium.org/115843


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17151 0039d316-1c4b-4281-b951-d872f2087c98

page. This allows faster prototyping (F5) of the NNTP.

TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should
show the file. Make a visible change in the file and reload the tab page and
the change should be visible immidiately.

BUG=None

Review URL: http://codereview.chromium.org/113927

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98

One visible change: new tab page has Google icon, not Chromium.

Gyp doesn't have a set environment variable facility; hence the
addition of a command line option to grit.

Review URL: http://codereview.chromium.org/113974

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115879

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17146 0039d316-1c4b-4281-b951-d872f2087c98

Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately.

BUG=10558
Review URL: http://codereview.chromium.org/115885

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98

Treat alt-(arrows/pgup/pgdn) like alt was not pressed.  There's no reason to ignore these keypresses.

BUG=6992
TEST=Type a letter so the omnibox dropdown shows.  Press alt-down.  If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear).  If you used the standalone arrow keys, the selection should move down one row.
Review URL: http://codereview.chromium.org/115891

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98

and updates the build files so that it will build.
Review URL: http://codereview.chromium.org/115847

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17142 0039d316-1c4b-4281-b951-d872f2087c98

Add support for scanning missing source files for executable lines.
Add support for HTML output.
Now reports percent coverage.

BUG=none
TEST=by hand on experimental buildbot
Review URL: http://codereview.chromium.org/113980

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98

in windows that triggered status bubble (such as gmail) to always come
to front.

BUG=none
TEST=see bug

Review URL: http://codereview.chromium.org/113962

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17140 0039d316-1c4b-4281-b951-d872f2087c98

This will generate prettier looking sln files.

Review URL: http://codereview.chromium.org/113979

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17138 0039d316-1c4b-4281-b951-d872f2087c98

It mostly confuses the press.

Review URL: http://codereview.chromium.org/113978

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12174

Review URL: http://codereview.chromium.org/115893


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12844
TEST=Install Chromium and make sure gears.dll is present.

Review URL: http://codereview.chromium.org/113976


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5372
TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7.  You should navigate to your home page (by default, the new tab page).
Review URL: http://codereview.chromium.org/113971

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115886

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17133 0039d316-1c4b-4281-b951-d872f2087c98

Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space.

Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton).

BUG=12829
TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior.

Review URL: http://codereview.chromium.org/113970

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17132 0039d316-1c4b-4281-b951-d872f2087c98

This should have been in my earlier CL, but I had a gcl fail.

TBR=darin
BUG=None
TEST=No behavior change

Review URL: http://codereview.chromium.org/112067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Linux first run dialog should be properly styled?
Review URL: http://codereview.chromium.org/115890

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98

Repairing tree bustage.

r=jrg
Review URL: http://codereview.chromium.org/113975

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17129 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.

This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.

This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496

bug=12850

r=raman
Review URL: http://codereview.chromium.org/113473

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115878

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17121 0039d316-1c4b-4281-b951-d872f2087c98

Trying to track down a bug that a user is seeing.
The getter we were using to extract the value before was for
a debugger-compatible string.  Perhaps it was the quote-removal
code that was getting us before; if not, these CHECKs will track
it down.

BUG=12530

Review URL: http://codereview.chromium.org/115877

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17118 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115869

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98

Custom start urls and default search options widgets aren't hooked up.
Home page settings work, but are overridden by the linux start page settings.
Default browser checking/setting functions are not implemented, so the option
isn't useful yet.

Refactors some common code out of browser/views/options/options_page_view.*
into browser/options_page_base.{cc,h}

BUG=11507

Patch by Matt Mueller (mattm@google.com).

Review URL: http://codereview.chromium.org/113967


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113965

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17113 0039d316-1c4b-4281-b951-d872f2087c98

Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface.

The APIs aren't perfectly tidy yet but this is a good first pass.

BUG=none
TEST=make sure you can still edit text fields, run the view unit tests.

Review URL: http://codereview.chromium.org/113940

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115876

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115852

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17110 0039d316-1c4b-4281-b951-d872f2087c98

_views.foo.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/115875

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17109 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/115873

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17108 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115874

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98

or when the file is detected to be changed externally.

Review URL: http://codereview.chromium.org/114055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17105 0039d316-1c4b-4281-b951-d872f2087c98

This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.

BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98

other gtk popups (e.g., gtkmenu).  Always allow Esc to close the
popup so a hung renderer doesn't require mouse usage.

Review URL: http://codereview.chromium.org/113959


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17103 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/112063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17102 0039d316-1c4b-4281-b951-d872f2087c98

ported.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/113963

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115872

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/12550
TEST=as described in bug report

Review URL: http://codereview.chromium.org/113960

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17097 0039d316-1c4b-4281-b951-d872f2087c98

This is useful for getting general build version information, such as needed
for Linux packaging.

Review URL: http://codereview.chromium.org/115842


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17096 0039d316-1c4b-4281-b951-d872f2087c98