- 28 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bc80aa34110..a745d8886808 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106626 Tbr: tinazwang@google.com,mek@google.com Change-Id: I93e37c2e37ee8b1d1e44df35e58f06ca8da18e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381949Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802793}
-
Xiaodan Zhu authored
Bug: 1116234 Change-Id: Ie21f6e0ea2fdb4098bcd1fa2f2632207ccd185ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378536 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802792}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fc1eb95f39a3..1e87a9ab4a13 2020-08-28 mtklein@google.com second guess swizzler avx-512 opts 2020-08-28 reed@google.com Only expose isConvex on path publicly. 2020-08-28 johnstiles@google.com Remove fProgram member from ProgramVisitor. 2020-08-28 mtklein@google.com create a sample to demonstrate a timing attack 2020-08-28 johnstiles@google.com Add helper function for making temp variables in inlineCall. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1088224 Tbr: mtklein@google.com Change-Id: I8ab94e27350db84183dd65880d88837598f7487f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802791}
-
Regan Hsu authored
This ensures that all links in os_settings_strings.grdp include the following: <ph name="LEARN_MORE_LINK_BEGIN">..</ph> <ph name="LEARN_MORE_LINK_END">..</ph> or a variant so that translators will know explicitly how to format the link. Previously, in Czech, the string was formatted like <a href=".."></a href="..."> instead of <a href="..."></a>. This was not caught in crbug/1095590 because when the string was changed, it tested correctly in English instead of the translated Czech version, which happened after the strings were uploaded. Screenshots: https://screenshot.googleplex.com/9o9LUcssZfhHdKq https://screenshot.googleplex.com/3WyzTChH8UjTmsG Bug: 1120339 Change-Id: I0f9ac9bb72b1a206a1bc5e6f18d81d8b982e4c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382062Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802790}
-
Emily Stark authored
Change-Id: Ic873b7df02124db730d689c3f82b8a06feb0f8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382770Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#802789}
-
Matt Menke authored
When diving up the input into 4 chunks, it was skipping over the final character of each chunk. This happened even if a chunk included all remaining characters, resulting in a StringPiece that started beyond the end of the string. This resulted in a 0-length StringPiece, and things worked fine for years, until a CHECK was added catching this this brokenness. This CL switches the fuzzer over to using FuzzedDataProvider, which doesn't have this issue. Fixed: 1123036 Change-Id: If17e26d065a157f8d401a7e4afc06c769c8670f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382063Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#802788}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..af2dca5c5320 2020-08-28 fmayer@google.com Merge changes Ifdb4b002,I8c0d63c9,Ic64bb6d9 2020-08-28 taylori@google.com Merge "perfetto-ui: Add exception logging" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic238798d09af06f17fb300ff56a2c1f5824b136f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381946Reviewed-by:
-
Aaron Leventhal authored
This code in AXNodeObject::InsertChild() to clear the inserted child's children, was added in WebKit, to support a use case that no longer exists. Specifically, an aria-hidden=false descendant of aria-hidden=true is no longer exposed. The spec may change again to allow that, but it would better to find an implementation that does not require reworking entire subtrees whenever a node changes. Performance improvement for dynamic changes in large subtrees. Also required for CL:2192752 to land. AX-Relnotes: n/a Bug: 1107988 Change-Id: I43f1fc880e7740cb937f273db76c6429e43e8d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204154Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802786}
-
Wez authored
Bug: 1120914 Change-Id: I712e0f02f28eaeb9e51bf260aa1fa5bfcdbd5f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377876Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802785}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.11-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I47b06187fddc0b423ec23642c988c405e7c7a5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382694Reviewed-by:
-
Bailey Berro authored
Bug: 1123074 Change-Id: I3cc11088dd8ae2e17e1a6f6f6c3a083a3ffe8e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382218 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#802783}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.11-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f6cb5b425bd07e39ee2e6346414bf4f15447d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382691Reviewed-by:
-
Jesse McKenna authored
This change makes IdleWakeups aggregate only measurements taken while the target process was running. Zero values taken while the process was not running (output rows showing "0 processes") are excluded from the final average and median. This prevents 0 values during idle time from skewing down the final results. Change-Id: I10a301cf7e20da5b51db6e986f18c9b37d73d05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380198Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#802781}
-
Adrienne Walker authored
https://chromium-review.googlesource.com/c/chromium/src/+/2365358 added the use of filesystem_proxy, but for in memory databases it is null. Previously this was handled because blob_path was set to empty, and so removing empty files would fail silently in the base file_util functions. Now, with a null filesystem proxy, it would crash. Instead of implicitly failing, explicitly check for the filesystem_proxy where needed. Bug: 1122011 Change-Id: I5e79e89c380e0e2ad9a4f80f14bcd614564b8940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382392Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802780}
-
Alex Newcomer authored
Implements ClipboardImageModelFactoryImpl. Previous CL landed ClipboardImageModelFactory, and all ash-side usages of the factory. This CL implements rendering of HTML via ClipboardImageModelRequest. Bug: 1117230 Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802779}
-
Devlin Cronin authored
A bunch of variables were stored as members on the test, even though they weren't used. Clean them up where possible. Bug: None Change-Id: Ieb6fb26099926092f4dccfe798fa67b6a5b91e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381250Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802778}
-
Jeroen Dhollander authored
This simplifies the code in multiple ways: 1) BloomControllerImpl no longer relies on any of the other Assistant classes, like |AssistantInteractionObserver| and |AssistantActionObserver|. 2) BloomControllerImpl no longer needs to expose methods like HasInteraction() and GetLastInteractionResolution() just for the purpose of unittests. Bug: b/165356952 Tests: chromeos_components_unittests --gtest_filter="Bloom*.*" Change-Id: I150c2be11ccad611bf468ad33c5835e9c7146d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365753 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802777}
-
Ben Joyce authored
local runs would be ran with: rdb stream -new -realm chromium:public ./out/Debug/bin/run_net_unittests --result-sink-upload Need to add --result-sink-upload to recipes. The rdb stream will be active on the bots, as a gn.arg Bug: 1104245,1104238 Change-Id: I8cbc9246110c28579e11c26ed92aad133a187a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365216 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802776}
-
Evan Stade authored
Bug: 1057100 Change-Id: I76e10024a499eb65f4f0f217c25f571eccd1c542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373394Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#802775}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7c4e9418e36..b1e3f57ef7c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I857dc50c8409e8fd341dd6e57284f24eaf9d9cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382203Reviewed-by:
-
Maksim Sisov authored
This is a reland of 75363679 Original change's description: > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > This is a reland of f985905e. > > This change broke our headless build: > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > assert(ozone_platform_x11) > ^----- > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > "//ui/events/platform/x11",. > > Fix: > Don't include x11 build for headless case. > > Original change's description: > > X11 and Ozone: enable use_x11 and use_ozone > > > > This is the final change that enables use_x11 > > and use_ozone for Linux builds and (as it was > > before) excludes X11 for chromeos, chromecast, > > lacros. > > > > in order to run ozone/X11/wayland, one must pass > > —enable-features=UseOzonePlatform > > —ozone-platform=x11 or wayland. otherwise, > > non-ozone/X11 is used. > > > > it’s also possible to completely disable X11 > > so that clients, who need that kind of build can > > continue to have that. > > > > Bug: 1085700 > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801523} > > Bug: 1085700 > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801692} Bug: 1085700 Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802773}
-
Jacques Newman authored
Placeholder gets exposed as an attribute on the input accessibility node, so there's no need to add its text children. This duplication was causing Narrator to read the placeholder text twice. This effectively reverts CL 1649466: UIA Placeholder Text Navigation AX-Relnotes: n/a Change-Id: If1a3218b64e0fdc2d4dd167faa1f5d9fe4d91c98 Bug: 1121729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375904Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802772}
-
Richard Knoll authored
This handles outgoing transfer updates from the PayloadTracker and gracefully closes outgoing connections after 1 minute. Bug: 1085067 Change-Id: Ia16fc5fdb8cfd1846b130385414064dc3bd2a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379900Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802771}
-
Joe DeBlasio authored
This CL hacks in a histogram to record safety tip status alongside whether the preceding navigation was initiated by the same origin, a different origin, or unknown. To keep the signal as clean as possible, this histogram only records at the reputation check following navigation commit. This means that: * It only records once per page load, and * It only records when the tab is loaded in the foreground. This CL is submitted entirely without new tests. That's a slightly risky move, but those tests would be somewhat complicated, the logic is pretty straightforward, and I'm trying to sneak this into M86. I've manually verified that it does what I expect, as well as accounted for the possibility that the committed URL won't match the reputation check's URL in the metrics. It should hopefully then be fairly obvious if it's recording the wrong thing once real data starts rolling in. This CL also adds the initiating origin to the reputation service object, rather than plumbing it through alongside other reputation information. I don't know if this is a great idea or not, but I'm hoping that we can use that stored info to carve out more false positives in the future. If we do that, we'll likely need to store the data like this, since initiator origin isn't readily available in the visibility callback (since we don't have a navigation handle). Bug: 1109246 Change-Id: I013ebd75ef47c70c81bfe41f45f31feef4603774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380678 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#802770}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/336f984f8cbc..02f6b66357eb 2020-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-08-28 brucedawson@chromium.org Print packaging file size/count stats always If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib870b694c9a52c201c8bcca10d5ea79d5edcb49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382493Reviewed-by:
-
Chong Gu authored
Bug: 1123095 Change-Id: I1e875997179c73c0504690e3efe1809b11e9d864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382295 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802768}
-
Elaine Chien authored
Bug: 1122724 Change-Id: I5cc4574546a5ca4fed41dd8f0c50f17d70a7034b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380583Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#802767}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.11-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I57b69bd0fed2fd6cfac870ee2f2eac62a34ae69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382498Reviewed-by:
-
Xing Liu authored
We should use Calendar.HOUR_OF_DAY to parse the time. The Android time picker widget gives us HOUR_OF_DAY instead of Calendar.HOUR. Bug: 1122999 Change-Id: I7b4de8b9316ed84281e2b8b3aec2fbc0b92c08cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382294Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802765}
-
James Cook authored
CreateScreenshotDelegate does not need a mojo-compatible delegate. That comment is left over from the mustash project. Bug: none Change-Id: Ie0eb0a89687abc9366903f982f8755d051b60c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382397 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598613564-5098a3febf11f8ec7b96c750766d9c7bc759629e.profdata to chrome-mac-master-1598637591-8ae79944c569ee90562dcd97e5dcdbd0077c5a06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If1cb7e963397f0c351528cfe3f8f51e9ea0f43cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382495Reviewed-by:
-
Jeffrey Young authored
Add new metric "Ash.AmbientMode.EngagementTime" to record usage time of each ambient session. BUG=b:163529518 Change-Id: I0c7652fee7fcd6491ba5f43b59dbef2d6f5e36da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367398 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802762}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41f8db90. With Chromium commits locally applied on WPT: 40203c99 "Fix typo in feature policy README" 41f8db90 "[LayoutNG] Correct border painting for fieldset fragmentation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42d4c2ba34f0d3a224f0879c7ede49712261422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382150Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802761}
-
Koji Ishii authored
Legacy and NGPaintFragment ignores empty rects (i.e., width and height are zero) even when their offsets are outside of the frame rects. This patch changes |NGInkOverflow| to match the behavior. Note, the behavior of `backdrop-filter` using the visual rect for inline boxes look questionable and weird, probably needs a separate fix, but it helped to find the change of the ink overflow in r784976 <crrev.com/c/2269389>. Filed crbug.com/1123089 for the `backdrop-filter` issue. The 3 rebaselines for paint/invalidation were incorrectly rebaselined by r789685 crrev.com/c/2300667 due to this issue. Bug: 1122021 Change-Id: Ida5fc770963efedd219eecf602c2f33dfec51b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802760}
-
Dana Fried authored
This CL: - sets throbber height equal to location bar height - ensures that the throbber paints over the border and not under it - fits border in 24x24px space with padding around (same as other toolbar icon heights) - uses 12pt font by default In order to accommodate double-digit numbers using system fonts, we shrink the font slightly when there are 10 or more tabs. See: https://docs.google.com/presentation/d/1vhfCoRyOyyCrj_0ZVHthV1aW8aPReFiqGUEXiqAj9mo/edit#slide=id.g90c8105bab_0_15 Change-Id: Ica739933f8b36ab56f644666979f02b3124a92d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374665Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#802759}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MnmDAUwQadNlsA_kV1-e9jcBLwfneTyY3-p7R76j8GAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I6669e68b0614657031f7b47781a2f302b2e6b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380649Reviewed-by:
-
Himanshu Jaju authored
- Adds a SingleThreadTaskRunner for WebRTC medium to allow jingle calls - Replaces SequencedTaskRunner with SingleThreadTaskRunner for platform SingleThreadExecutor impl Bug: 1122532 Change-Id: I611ef85ec96fbcad3eeb160fd74b9e688edfc5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379727Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#802757}
-
Xianzhu Wang authored
This is based on the feedback in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0. This feature is not supposed to be enabled for web tests. Bug: 1121839 Change-Id: I2713381e147dabf7b24090738afd1cd02e7c53b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380313Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I910a6047ad1c87164f2cb5cb3abf6bc1808d26f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382059Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802755}
-
Yao Xiao authored
This reduces the overall memory. And hopefully it could fix the regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2324204, which could allocate a regex for every input element. Bug: 1116302 Change-Id: I00f1fa7ad07664d5ab799e760483034c1a1594fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357464 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#802754}
-
