- 04 Apr, 2018 40 commits
-
-
Daniel Bratell authored
There are several classes/types named Display so to get the X11 one, you have to specify it with ::Display (gfx::Display is a common alternative when you're inside the gfx namespace). TBR=hubbe@google.com Bug: 822068 Change-Id: I402b7ad2d37a82d3091577733f3f06e673c29c7e Reviewed-on: https://chromium-review.googlesource.com/994212 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#547916}
-
Peter Kasting authored
This allows tests that want to provide mock implementations of these objects to just override what's necessary to change functional behavior, not provide boilerplate simply to instantiate the objects at all. BUG=none TEST=none Change-Id: I0b3ccc6da2ae2b3a87789c06d427cae227a2d662 Reviewed-on: https://chromium-review.googlesource.com/987326 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#547915}
-
Blake O'Hare authored
This unit test is redundant with VirtualKeyboardRootWindowControllerTest_FollowInputFocus which uses a test DisplayManager utility to properly mock the displays. The problem with the ui/keyboard unit test is that it simply mocks windows and treats them as root windows. I'll be following this CL up with more changes that use displays instead of just root windows and if this isn't removed, it will start failing. Change-Id: I20b5c8dfb947211161b7cd761390bc8a76229370 Reviewed-on: https://chromium-review.googlesource.com/991893Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547914}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=kbr@chromium.org Bug: 790063,790077,790066 Change-Id: Id7bdaa570abd2bae90051d6389f24a1f66426ed4 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994534 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#547913}
-
Lucas Furukawa Gadani authored
Bug: 824562 Change-Id: Ib7af477a49036204517d6115e45cba2ce721ef2b Reviewed-on: https://chromium-review.googlesource.com/984037Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547912}
-
Kent Tamura authored
Add snake_case per-file lines as well as CamelCase per-file lines in OWNERS files in //third_party/WebKit This is a preparation to rename all C++ files in //third_party/WebKit. A follow-up CL will remove CamelCase per-file lines. Bug: 768828 Change-Id: I398d3a8447f1f4fd025438310915b9f312b8c494 Reviewed-on: https://chromium-review.googlesource.com/991792 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#547911}
-
Kent Tamura authored
Bug: 578345 Change-Id: I4da3ad3167bb8317c4273c832aac3e4308610c06 Reviewed-on: https://chromium-review.googlesource.com/991313Reviewed-by:
-
Chris Nardi authored
MediaList.appendMedium was able to throw an exception, but MediaQuerySet::Add() always returned true, making it impossible for that exception to be thrown. This matched the spec, as |appendMedium| cannot throw an exception. Remove the dead code surrounding the possible exception, and make MediaQuerySet::Add() return false if the medium is not added. Also remove the TODO as deleteMedium can throw an exception per the spec. Change-Id: I32c1b7b3ac90812ce036273e9c1c56f6d65c0af2 Reviewed-on: https://chromium-review.googlesource.com/993398 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#547909}
-
sczs authored
- Moves out the HistoryService and Driver creation from HistoryCollectionVC to HistoryPanelVC. Because of this HistoryCollectionVC will have less model responsibilities. On the new implementation this responsibilities will be owned by a Coordinator instead of a parent VC like HistoryPanel. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I749be91308ed35eb8d08a2a9f6c4bf984eb8bb79 Reviewed-on: https://chromium-review.googlesource.com/991253 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547908}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=kbr@chromium.org Bug: 790063,790077,790066 Change-Id: Iebe7718ee74428f7d1f89d590ca59c8b1dacd524 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994114Reviewed-by:
-
Pete Williamson authored
Bug: 758690 Change-Id: I829790f7f53d97b4717b653b3eeae9065387e7ad Reviewed-on: https://chromium-review.googlesource.com/994336Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#547906}
-
Xiaocheng Hu authored
This reverts commit 797a3802. Reason for revert: The overall approach is a hack that keeps generating regressions Original change's description: > Eliminate NOSCRIPT element from TranslateHelper text dump > > TranslateHelper uses a sample of the page text to determine the page > language. This patch eliminates content of NOSCRIPT elements from the > text dump, so that non-text contents in NOSCRIPT elements are not passed > to TranslateHelper. > > Bug: 813009 > Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 > Reviewed-on: https://chromium-review.googlesource.com/924111 > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537557} TBR=groby@chromium.org,eae@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813009 Change-Id: Ibb2557436cdb5b07586bc69177f1456dc435568c Reviewed-on: https://chromium-review.googlesource.com/994059Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547905}
-
Peter Kasting authored
This avoids instantiating a real InfoBarService in tests that don't need it, which will in turn avoid constructing platform-specific InfoBar instances, which will in turn prevent crashes in an upcoming change where I make the views-specific implementation rely on objects these tests don't create. This also addresses my followup comments on https://chromium-review.googlesource.com/c/chromium/src/+/953711 . BUG=none TEST=none Change-Id: Iab027693b982db7b91a3be8681647a112ba86e9e Reviewed-on: https://chromium-review.googlesource.com/989213Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547904}
-
Fady Samuel authored
This CL makes progress on a number of fronts. This CL makes progress towards enabling viz::LocalSurfaceId allocation on the child renderer process by allocating a new LocalSurfaceId when auto-resize is enabled. This is accomplished by moving auto-resize from RenderViewHost to RenderWidgetHostView. This allows the behavior to be async and for child frames to call out to the parent renderer to request a new parent-allocated LocalSurfaceId when that state changes. This CL pulls out ResizeParams in BrowserPlugin and RenderFrameProxy and moves them one step closer to unification with content::ResizeParams by adding some more properties that are in common with content::ResizeParams for auto-resize. Change-Id: I63749d8a652630f4b2bf3500660081e6c093c935 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/991602 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547903}
-
bsheedy authored
Adds support for saving shared preference files to the encrypted data directory in the instrumentation test runner and VR Telemetry tests and sets the VR shared preference files to use this new functionality. Prerequisite Catapult change is at https://chromium-review.googlesource.com/c/catapult/+/986951. Bug: 826501 Change-Id: Ie51003fac40536c77b5814076ae67c4a153ed31d Reviewed-on: https://chromium-review.googlesource.com/986926Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547902}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/668c1d8d1f1a..adcf030f6910 $ git log 668c1d8d1..adcf030f6 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 agable Continue the story 2018-04-03 ehmaldonado roll_dep: Make roll_dep.py use gclient_eval instead of regexes. Created with: roll-dep src/third_party/depot_tools BUG=chromium:828154,chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia25847fe34f0686dd3c1edc3176bc8a7135f3d1f Reviewed-on: https://chromium-review.googlesource.com/994055Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547901}
-
Fabio Tirelo authored
With the introduction of the 3p removal trigger, the concern is that subtitles make the card too heavy, so we are simply removing them. Bug: 816666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I48fc29fac751c6fe54a3e7c87567d14bcf7f4f6c Reviewed-on: https://chromium-review.googlesource.com/938625 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547900}
-
sczs authored
Since [mediator initObservers] users the Browser state we need to set it before calling this method. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I757b5c28f48c782b5984212ad39a7f27e643d21f Reviewed-on: https://chromium-review.googlesource.com/994137Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5138441.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5138441.html" to "indent_before_blockquote.html". Note: "5138441.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Id82a24a4b2c742fe729b1696ad428085965ee300 Reviewed-on: https://chromium-review.googlesource.com/991697Reviewed-by:
-
Dan Harrington authored
Thumbnails are downloaded when a prefetched page finishes downloading. This CL also adds thumbnail methods to OfflinePageModel. Bug: 794828 Change-Id: I91263c58028d2b18dba22d33ee9964e909a0823e Reviewed-on: https://chromium-review.googlesource.com/985205 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#547897}
-
Paul Meyer authored
Since interventions actually block or change browser behavior, their messages should be reported as errors rather than just warnings. Bug: 564071 Change-Id: Id8f1110466f127903bd362c4c7ada454aa3df0d6 Reviewed-on: https://chromium-review.googlesource.com/985028Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547896}
-
Kyle Horimoto authored
When a device registers to use the CryptAuth back-end, it sends a GcmDeviceInfo proto message. Before this CL, this was done from within ChromeCryptAuthService, which resides in //chrome. In order to share this code with the in-progress DeviceSync service, this CL refactors this code and moves it to a new location where it can be shared between both clients. Implementation is split between a pure-virtual GcmDeviceInfoProvider class living in //components/cryptauth and an implementation which has //chrome dependencies in //chrome/browser/chromeos/cryptauth. This separation is necessary so that the DeviceSync services, which resides in //chromeos, can utilize this class behind an interface. Bug: 824568, 752273 Change-Id: I0b5a4401809185cf3beef7e95cc1a68c369eaa79 Reviewed-on: https://chromium-review.googlesource.com/991234Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#547895}
-
Yoshifumi Inoue authored
This patch changes "focus-body.html" to utilize |selection_test()| for ease of maintenance. Note: "focus-body.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: I6c3be17a3b92aab4fff714fc7798a2b323d97d52 Reviewed-on: https://chromium-review.googlesource.com/992076Reviewed-by:
-
John Budorick authored
Bug: 776495 Change-Id: Ie982fe018f7f075c7e3c335cfb0b0b0eae62dbc5 Reviewed-on: https://chromium-review.googlesource.com/994413Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547893}
-
Yoshifumi Inoue authored
This patch changes "editable-inline-element.html" to utilize |selection_test()| for ease of maintenance. Note: "editable-inline-element.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: Iba8e093c7dccd28be883b43dbcfd19fd72b46add Reviewed-on: https://chromium-review.googlesource.com/992012Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "merge-whitespace-pre.html" to utilize |selection_test()| for ease of maintenance. Note: "merge-whitespace-pre.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Idb0840579c0c915d221aa242969518e18f62cbd5 Reviewed-on: https://chromium-review.googlesource.com/991494Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "align-in-span.html" to utilize |selection_test()| for ease of maintenance. Note: "align-in-span.html" is failed on layout_ng bot due by newline difference. Bug: 679977, 636993 Change-Id: If2459543969e992b198a2f5275b590f8bce1917f Reviewed-on: https://chromium-review.googlesource.com/991624Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "4959067.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "4959067.html" to "replace_contents_of_link.html" Note: "4959067.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: I700f0952a81d8aeed1e69cf0cdc9aa257fa5ee3f Reviewed-on: https://chromium-review.googlesource.com/991972Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "4875189-1.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "4875189-1.html" to "replace_in_list_item.html" Note: "4875189-1.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: I46817e1e78106644fe689a20a521bf45762af568 Reviewed-on: https://chromium-review.googlesource.com/991698Reviewed-by:
-
Wenzhao Zang authored
Bug: 827062 Test: --enable-features=Mash Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8191b88f1561d4f0927f8af17e168b88a54c38a2 Reviewed-on: https://chromium-review.googlesource.com/963010Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547887}
-
Jiaquan He authored
Regression of 24a92352. A stupid mistake while migrating some metrics from Chrome to Ash. Bug: 733662 Bug: 828620 Change-Id: I025791f9721d8b7f0db15a3df18cbbd7c6fa5bff Reviewed-on: https://chromium-review.googlesource.com/994189Reviewed-by:
-
Erik Luo authored
This adds styles to prevent fields in the CSS shadow editor from shrinking. Bezier and Color swatch popovers are already scroll well under small window dimensions. Screenshot: https://imgur.com/a/hpIMe Bug: 827093 Change-Id: I0ff7d4ca336cf728b79dac02feca4a0d60cff12f Reviewed-on: https://chromium-review.googlesource.com/986661Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#547885}
-
Dave Tapuska authored
The input router is recreated after a new input channel is constructed. Ensure that the Frame Tree Node Id is set in all codepaths. BUG=827267 Change-Id: Ie8c6a2665afccad23fdea9cfa0dc186c3b919455 Reviewed-on: https://chromium-review.googlesource.com/992357Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#547884}
-
Esmael El-Moslimany authored
Bug: 736217 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie8e661305b9135ef3ccba5fd52b6053467c695c2 Reviewed-on: https://chromium-review.googlesource.com/991202Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Nick Carter authored
[GURL] (2 of 2) Strip username/password/port when canonicalizing, if the scheme doesn't support them The goal of this CL is to inhibit port numbers and usernames in internal schemes like "chrome-extension" and "chrome". Currently, navigations to chrome-extension:// URLs with ports actually get suprisingly far; it seems like no good can possibly come from that. A new SchemeType is added: SCHEME_WITH_HOST_AND_PORT (no user information). This is only used when canonicalizing the inner URL of filesystem: -- e.g., filesystem:http://user@host:20/temp/foo now canonicalizes to filesystem:http://host:20/temp/foo; whereas filesystem:chrome://user@host:20/temp/foo canonicalizes to filesystem:chrome://host/temp/foo Bug: 606001,809062 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I77c5ba3d2fe964deb8aadae95a06519ce038c472 Reviewed-on: https://chromium-review.googlesource.com/974380Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547882}
-
Philip Rogers authored
Printing can change layout and we should update visual rects when this occurs. After [1], visual rects are used for clipping which exposed a bug where painting occurred with stale visual rects (the skia rtree is not used when printing which would have exposed this in SPV1). This patch fully enables the paint invalidation step to reduce special-cases in the document lifecycle, even though only the visual rect update is strictly needed. [1] https://chromium.googlesource.com/chromium/src/+/b7e8c6eb13e6eb297747b9e394854408b3f29195 Bug: 824031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0b9b358b078fa15b4aa1c26b494c213d62e571c4 Reviewed-on: https://chromium-review.googlesource.com/993700Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547881}
-
https://chromium.googlesource.com/angle/angle.git/+log/30b604d8d174..6bc264aee686 $ git log 30b604d8d..6bc264aee --date=short --no-merges --format='%ad %ae %s' 2018-03-31 jmadill Fix potential bad access in LinkProgram. 2018-03-20 oetuaho Collect static use information during parsing 2018-03-21 oetuaho Avoid mangled name comparisons of 3-parameter functions 2018-04-01 fjhenigman Fix conditions for updating element array buffer. Created with: roll-dep src/third_party/angle BUG=chromium:827158,chromium:823856 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Idf3b7b345465da375c6dd6ed0f5a934cedc070e8 Reviewed-on: https://chromium-review.googlesource.com/993002Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547880}
-
Dominick Ng authored
This CL moves the code responsible for displaying the intent picker UI on Chrome OS from ArcNavigationThrottle to the app-platform-generic AppsNavigationThrottle class. There should be no functional changes. The supporting AppInfo type is migrated to apps_navigation_types.h to allow other app platforms to make use of it. Future CLs will migrate the ArcNavigationThrottle::AsyncOnIntentPickerClosed method to AppsNavigationThrottle, so that apps of different types can have UMA recorded. BUG=824598 TBR=sky@chromium.org Change-Id: I875cd4d59f7ac562eaeba973fa67daf3a213f136 Reviewed-on: https://chromium-review.googlesource.com/981834 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#547879}
-
Eugene But authored
Previously status label was resized by calling sizeToFit. sizeToFit does not play well with autolayout and overrides the existing constraints. This CL creates statusLabelTrailingConstraint which anchors the label to close button or to action button (when download is not in progress and action button is visible). The test was updated to force the view load, so setting up constrains do not fail in the test. Bug: 827641 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d84d6ba041d85bfd7cee9290c76c56a8f68c8b8 Reviewed-on: https://chromium-review.googlesource.com/988750 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Ella Ge authored
On Windows, we send context menu when long press gesture is released. Previously context menu event is sent on long press gesture. On Windows, context menu was held in last_context_menu_params_ and wait for next GestureTap event. In this Cl, let contextmenu events send on GestureLongTap on windows. So there is no need to store the last_context_menu_params_ for windows, remove related code. Because we still want to handle text selection on longpress but only move context menu event to long tap, remove setting caret on long tap because that will break text selection quick menu on windows. Bug: 748480 Change-Id: If5372e30d08473dfeded0fe133f32f7d6ca43328 Reviewed-on: https://chromium-review.googlesource.com/960964Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#547877}
-
