- 21 Aug, 2020 40 commits
-
-
Tom Anderson authored
BUG=1066670 Change-Id: I324c66b3848c4ef6dd40326ae08270c8f14c9eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354916 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800759}
-
Yicheng Li authored
Cryptohome already supports starting/ending fingerprint auth session (i.e. preparing biometrics daemon for upcoming fingerprint scan / back to normal mode). This change enables ExtendedAuthenticator to start fingerprint auth session so that ExtendedAuthenticator can be used to do fingerprint auth. The reason why fingerprint auth needs starting/ending auth session is because it is expensive to switch mode of the fingerprint MCU. The client should only end fingerprint auth session when no more fingerprint retries are expected. The reason why we are doing this by calling cryptohome, instead of calling biometrics daemon, is that we want cryptohome to control all authentication mechanisms, and there's a generalized "auth session" project in cryptohome. Bug: b:156258540, b:144861739 Change-Id: I767b2aff9791c838674d8ace8ab8d4494f69e603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364894 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800758}
-
Josh Nohle authored
Fix heap-use-after-free error in Nearby Share unit tests caused by not reseting the testing factories after a unit test finishes. Also, reorder member variables in certificate manager unit tests in rough order of creation time. Change-Id: I9c17f467f388716b8f83fb59dceb47d80282da41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369498 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#800757}
-
Ana SollanoKim authored
The fieldset layout algorithm was able to handle breaks inside borders and padding, but since this is no longer supported, some code had to be removed. This change addresses the TODO that was proposed in https://chromium-review.googlesource.com/c/chromium/src/+/2263353 In a previous change where we had made the legends monolithic https://chromium-review.googlesource.com/c/chromium/src/+/2353354 additional TODOs were added as a result of the following open issue crbug.com/1097012. In this change, a missing TODO was added and comments have been updated. Bug: 1097012 Change-Id: I2087957b98681904606a4d6d780094c24a8e7ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367698 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#800756}
-
Sinan Sahin authored
Bug: 1120707 Change-Id: Ifd791aef0358e6a41d4ec58e2cf9d9fa214fa850 Tbr: peconn Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368320Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#800755}
-
William Lin authored
Skipping the account chooser will require the GetAuthToken function to retrieve the gaia id of the account currently in use. Storing the CoreAccountInfo will allow the function to always be able to retrieve the gaia id for comparison in the scenario that CoreAccountId is an email. This CL replaces the CoreAccountId with CoreAccountInfo in the ExtensionTokenKey. Additionally, relevant locations of the existing code have been modified to use the CoreAccountId stored in CoreAccountInfo to account for this replacement. Bug: 1100535 Change-Id: Ie72f437aecdbfe6b98a1c5cf0caae3501f42baa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366033Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: William Lin <williamlin@google.com> Cr-Commit-Position: refs/heads/master@{#800754}
-
Xiaodan Zhu authored
Bug: 1116178 Change-Id: I86a0ee351e2202267b6c66e5c0689c223b1eba87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368042Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800753}
-
Sophie Chang authored
This was potentially falling back to hint still being fetched if URL hint hadn't arrived yet Bug: 1112500 Change-Id: I0307f41f1b49a6901eef48b522dfefe0546f6139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369264Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800752}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib90ddfee2c684b099ba3279051ce414f6559a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800751}
-
Leonid Baraz authored
Fake-* is removed, as well as virtual interface: we are using openssl and AEAD directly. Also, decryption is moved out from Chrome, since for now we only use it in test. Once we add it to the server, it will be placed elsewhere and probably wrapped in Java class. Bug: b:153649905 Change-Id: Ib6383efa8f6b1e993e351e03f2f747043c6cb521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363868 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#800750}
-
Chris Lu authored
Adds LogUserInteractionWithFullscreenPromo and HasUserInteractedWithFullscreenPromoBefore to be able to set and get the NSUserDefault config to keep track of user interaction history with the fullscreen default browser promo. Adds calls to LogUserInteractionWithFullscreenPromo. Bug: 1107489 Change-Id: I5d73e6e93d8dd20682e65dfe9eb68ef10ca63632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363660 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#800749}
-
Kyle Horimoto authored
This class exposes Instant Tethering functionality to the Phone Hub UI. For now, TetherControllerImpl does not actually do anything, but landing it in its current state unblocks UI code from depending on it. Bug: 1106937 Change-Id: I70ee9dd2d241e9784fac04ba227477435f407473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369656 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800748}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I299f547d8b1430ff3237e3e8c306cf715a6acb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369574Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800747}
-
Mike Wasserman authored
Fullscreen is exited when a related frame opens a popup window. See security-based motivations for that behavior in these issues: crbug.com/1042210 crbug.com/1020026 crbug.com/1037730 crbug.com/752003 Window Placement experimentally permits multi-screen window features: See https://github.com/webscreens/window-placement Sites want to open a popup on Screen X while fullscreen on Screen Y. Allow user-permitted sites to open a popup and retain fullscreen. Followup work must prevent interference with fullscreen security UI. (e.g. exit related-frame fullscreen if a popup targets that display) See crbug.com/1120746 for details and work-item tracking. Do not default-allow window-placement in content_browsertests. (that misrepresents the default capabilities of sites in tests) Disable getScreens content_browsertests for now (crbug.com/1119974): - They need per-test-fixture permission controls - WPT test coverage is adequate in the mean time Bug: 1040297, 1119974 Change-Id: Ib2a40e87f7b92fa36d7745ffec41090837bcfea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366088Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#800746}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bce19cd0eefc..fbb49b4f7f86 2020-08-21 ilnik@webrtc.org Enable Vp8VariableFramerateScreenshare by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:949112 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1851db87ce87c1557d45db5510026f9522f6fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800745}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkIpConfigTest* Change-Id: Ie94e86efab513c315fff2edf1da9b29b27de19e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368468 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800744}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6733ced7..1ca34252 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If83ddde54e5b06ba7884e0d72d1ce706b0eeb75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369005Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800743}
-
Mustafa Emre Acer authored
This CL expands the PhishGuard ping proto and adds a new field to LoginReputationClientRequest containing information about the Delayed Warnings experiment and Simplified URL Display experiments. Note that the presubmit gives a reminder to update chrome/common/extensions/api/safe_browsing_private.idl. Since this isn't an API change, this CL doesn't modify this file. Bug: 1114922 Change-Id: I118c74c2b7ef2b0bd1ea18c091575540cc464dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347975 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#800742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0cf0214eefa..6821f818e6f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,nektar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115220,chromium:1116650,chromium:1117663 Tbr: xhwang@google.com,nektar@google.com Change-Id: I51bc0b4d22b336ccc222ea8b8b410ce190618cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800741}
-
Tiancong Wang authored
This patches removes old hugepage mechanism that works without orderfiles. So now, enabling orderfile == enabling THP. Bug: 1100803 Test: Build chrome os locally Change-Id: Ib4ff215b10ccc4c3c51347357a0cba7f51ec6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369335 Commit-Queue: Tiancong Wang <tcwang@google.com> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#800740}
-
Jeff Yoon authored
ios-simulator-noncq to compile with xc12b5 as well. Running iOS 14.0 simulators for our test suites on xc12b5. Change-Id: I7ca5f763174c296278401ae3563894a4f5210379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367792 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800739}
-
Jun Kokatsu authored
This change enables Trusted Types mitigation on WebUI by default. It enforces use of safe API by default, and any use of unsafe API (e.g. innerHTML, document.write, etc) has to overwrite Trusted Types directives in the CSP header. Therefore this change makes security review or audit of JavaScript code on WebUI a lot easier. Because JavaScript could introduce XSS only by using `trustedTypes.createPolicy` to generate untrusted html or script as Trusted Types, or removing Trusted Types mitigation. And all of those has to be carefully reviewed going forward. Bug: 41905 Change-Id: Iba7b8f617bc00c27b22386e2f632402209c47549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353547Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#800738}
-
Hung Vu authored
This CL adds the flag for handling smart suggestion for large downloads Bug: 1118207 Change-Id: I695757bef4119d97fc594d08945406a14a36723c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368154 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800737}
-
Richard Knoll authored
Obfuscation is needed as the text is shown as a preview on the remote device before accepting the transfer. Bug: 1085067 Change-Id: I100d369685c5aec2b7bcb97058df68f6c94c4c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368594 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#800736}
-
Victor Costan authored
When Chrome receives a 304 for a resource stored in AppCache, we do not update the cache's headers with the 304 headers. We had a fix for this issue under development, gated by a feature flag. While the fix was very close to the finish line, AppCache's deprecation and removal means we can't justify finishing the fix. This CL removes the feature flag and the code gated by it. This is intended to make it easier to maintain our AppCache implementation until we're ready to delete it from the tree. This CL should not cause any behavior changes for Chrome instances without manually modified feature flags. Bug: 989611 Change-Id: I9f0c98fbbc59dab527db8159eb6f691398480c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360556Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800735}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/nPjEGC7iC_JZPS-2t6OXpyqtoD_uxii0UigGyO6p6ToC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/158654343,b/165394926,b/165748389,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: If707950d26252fa151c73089f6efdbc1dc5893c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800734}
-
Ali Juma authored
This adds integration tests for real-time Safe Browsing checks. In order to test real-time lookups without making network requests to Safe Browsing servers, this adds a "--mark_as_real_time_phishing" command-line flag for treating a given URL as unsafe. This works by adding an unsafe verdict for this URL to VerdictCacheManager. This also adds a "--mark_as_allowed" command-line flag for treating a URL as safe according to the allowlist used by real-time lookups. Bug: 1111414 Change-Id: Id72c6a4f4ffe2186a71e680b34df9a1c4d0a7a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357553 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#800733}
-
Thomas Guilbert authored
This CL allows the WebCodecs feature flag to be controlled by origin trial infrastructure. It also bumps up WebCodecs to be part of the experimental Web Platform features. Bug: 1120704 Change-Id: I1ce31847ba467bdfd00e5ff2c6f4289c6d69fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368232 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#800732}
-
Stephanie Kim authored
Changes Mac Builder Next os to be 11.0, sets up Mac11.0 Tests thin tester, and sets up mac 11.0 trybots Bug: 1066875 Change-Id: Ic8355cae637464a6f056bbf5cbe46bdd98f24a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330737 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800731}
-
Etienne Pierre-doray authored
It's possible for a thread to re-enqueue a JobTaskSource right before the job is canceled/joined and will sill end up in the queue (the main thread may try to remove it before it's added again). The fix is simply to avoid calling user callback if the job has the cancel bit set. In addition, a job that's joined needs to be marked as canceled. Bug: 1120686 Change-Id: I1ca9458a22eda71c400cfb6f0ef42efc85e38e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369435Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#800730}
-
Andres Calderon Jaramillo authored
This CL adds some CHECKs to assert that duping dma-buf FDs is successful. See referenced bug for more details. Bug: 1097956 Test: None Change-Id: I766a8729cf34635892c69b297f4b09b2d8a9c471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366293Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800729}
-
Sinan Sahin authored
This is still flaky Bug: 1109965 Change-Id: I60297eeebd90cd73a088c51e3552479b78cb3ca8 Tbr: twellington@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369514Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#800728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f80c4be2. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ice04f0e0e3cb6779d5aa4708bc5740c6d52976a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369003Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800727}
-
Zentaro Kavanagh authored
These are used to track usage of Display features Bug: 1088714 Change-Id: I5bf1cd0c11fedb24035ed3ce49230677705129bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363697Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#800726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/12559f038590..a2193f8a8b70 2020-08-21 cduvall@chromium.org Add support for running WebLayer perf tests against bundles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: zhanliang@google.com Change-Id: I8f6e53e3ca4bd4f96971c63f59bf17b0d4bb7cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800725}
-
Jonah Ryan-Davis authored
These tests are crashing the ASAN bot. Skip for now until we can triage further. Bug: chromium:1119939 Change-Id: Ieff9bde84643ac6677bea77a73112ddaa373a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368499Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#800724}
-
evliu authored
This CL splits the SODA component into a single SODA binary component and multiple language pack components. Todo: Update the settings UI reflect the download progress of the SODA binary and the language pack(s). Todo: Verify that the SODA binary component and the language pack component is installed before launching the Live caption feature. Change-Id: Ia82ac3b46da2d37ce1e0fae9d6cd7fb541d67d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340873Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#800723}
-
Richard Knoll authored
This will filter any further TransferMetadata updates afterr receiving a final status one. Bug: 1085067 Change-Id: I75fa89ad57f61cf81ed7738c6b646218f3823e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368598Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800722}
-
Trent Begin authored
This change adds user visible strings for the network diagnostic routine problems. Bug: chromium:1098405 Change-Id: Ib482f2d27f2200639930023c0c797ef9ff1edafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363948 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#800721}
-
Ted Meyer authored
Causal statuses are required to be non-ok-statuses, but the conditions as written could allow a causal status to be generated from a successful HRESULT. This breaks the conditions up, and moves one of the checks from !SUCCEEDED() to FAILED() for consistency Bug: 1120094 Change-Id: I47c2524c2ee5ae4984f1616fb26f02386bfbe6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369434 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#800720}
-