GitLab

This performance test that is meant to draw to a GPU accelerated
canvas accidentally changed its behavior due to a recently added
heuristic that cancels GPU acceleration under certain
circumstances. This CL fixes the test to prevent it from triggering
the heuristic.

BUG=653565

Review-Url: https://codereview.chromium.org/2399013003
Cr-Commit-Position: refs/heads/master@{#423767}

As part of preparing ash::DisplayManager for relocation to ui,
eliminate its dependency on ash localization strings.

BUG=581462

Review-Url: https://codereview.chromium.org/2383313002
Cr-Commit-Position: refs/heads/master@{#423766}

Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/ )

Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7628

unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php

TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org,hiroshige@chromium.org
BUG=616234

Review-Url: https://codereview.chromium.org/2399243002
Cr-Commit-Position: refs/heads/master@{#423765}

Following r419951 getExecutionContext() may return null, so
return value must be checked.

BUG=653272
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2398313002
Cr-Commit-Position: refs/heads/master@{#423764}

This matches the obsolete/modern part of the security panel. A cipher
suite is a particular thing in TLS and is not just the bulk cipher.
Cipher is a more appropriately generic term for a decomposition we made
up.

BUG=none

Review-Url: https://codereview.chromium.org/2393393004
Cr-Commit-Position: refs/heads/master@{#423763}

After the CL, there is a separate EventSender instance for each
WebWidgetTestProxyBase.  Additionally EventSender transforms the
coordinates of the event before calling Blink, to make sure the
coordinates will work with the target widget.

Supporting EventSender via WebWidgetTestProxyBase requires
exposing WebWidgetTestProxyBase::web_view_test_proxy_base()
accessor and this in turn allows for clean-ups in some other
places - for example this allows to remove storing borrowed
pointers to TestRunner and WebViewTestProxyBase inside
WebWidgetTestClient.

BUG=616608
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2036873002
Cr-Commit-Position: refs/heads/master@{#423762}

Currently data use is measured as foreground and background. In some
cases where the app was transitioning from one state to different state,
data use at that time should be logged as unknown.

This CL changes the UMA to log on every network TX/RX of the URLRequest.
Earlier it was logged only when URLRequest completes.

BUG=648808

Review-Url: https://codereview.chromium.org/2399783003
Cr-Commit-Position: refs/heads/master@{#423761}

BUG=555865

Review-Url: https://codereview.chromium.org/2391453002
Cr-Commit-Position: refs/heads/master@{#423760}

Finish AppTasks on the UI thread rather than the insturmentation
thread during test setup and tear down. Also eclose the finishAndRemoveTask()
calls in a try-catch block so that otherwise passing tests don't fail
on Android framework exceptions.

BUG=653731

Review-Url: https://codereview.chromium.org/2396253002
Cr-Commit-Position: refs/heads/master@{#423759}

The following type hierarchy exists in core/animation: KeyframeEffect is a
subclass of KeyframeEffectReadOnly is a subclass of AnimationEffectReadOnly.
Type casts have already been defined to convert AnimationEffectReadOnly objects
to KeyframeEffect objects; this patch adds the equivalent for converting to
KeyframeEffectReadOnly.

Review-Url: https://codereview.chromium.org/2395993002
Cr-Commit-Position: refs/heads/master@{#423758}

. MojoShellConnection -> ServiceManagerConnection
. MojoChildConnection -> ChildConnection
. EmbeddedApplicationRunner -> EmbeddedServiceRunner
. *MojoApplication* -> *Service*

R=rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2398783002
Cr-Commit-Position: refs/heads/master@{#423757}

BUG=564904

Review-Url: https://codereview.chromium.org/2397993003
Cr-Commit-Position: refs/heads/master@{#423756}

BUG=

Review-Url: https://codereview.chromium.org/2384323002
Cr-Commit-Position: refs/heads/master@{#423755}

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490

Review-Url: https://codereview.chromium.org/2361603002
Cr-Commit-Position: refs/heads/master@{#423754}

It frequently fails all three test runs on tablets.

BUG=581268
TBR=yfriedman@chromium.org

Review-Url: https://codereview.chromium.org/2400083002
Cr-Commit-Position: refs/heads/master@{#423753}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f7d080135d03..22570732fbb1

$ git log f7d080135..22570732f --date=short --no-merges --format='%ad %ae %s'
2016-10-06 benjhayden Finish value-set-table tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2396003003
Cr-Commit-Position: refs/heads/master@{#423752}

Currently GpuChannel destruction runs as a single large task in the GPU
process. This can cause watchdog timeouts on very busy systems, as we
can end up doing a huge number of GL commands in a single task.

This change adds logic to ping the watchdog thread at regular intervals
(assuming that destruction is moving forward, and hasn't actually hung).
This should prevent the timeout hangs we're seeing.

In addition to reporting progress in ContextGroup, we also report during
shader, program, and texture deletion, as these are the three cases
where we've actually seen timeouts.

BUG=612219
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2378583003
Cr-Commit-Position: refs/heads/master@{#423751}

Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.

BUG=chromium:648580

Review-Url: https://codereview.chromium.org/2395293003
Cr-Commit-Position: refs/heads/master@{#423750}

This check actually triggered on the wrong condition (hence I also renamed a few things to reduce the confusion).
There was a valid point for the check, though: we should only fill the histogram when we don't get too many snippets.
Once we completely moved to the Zine cloud backend, this histogram should go away anyways.

Review-Url: https://codereview.chromium.org/2387293009
Cr-Commit-Position: refs/heads/master@{#423749}

The queue lives in the target, so the weak pointer is redundant.

BUG=639087

Review-Url: https://codereview.chromium.org/2397783004
Cr-Commit-Position: refs/heads/master@{#423748}

The purpose of this CL is to improve the readability of this test, to
try to better indicate what webkit-patch copy-existing-baselines-internal
does.

Review-Url: https://codereview.chromium.org/2392173002
Cr-Commit-Position: refs/heads/master@{#423747}

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2374183006
Cr-Commit-Position: refs/heads/master@{#423746}

This patch restricts the service worker when JavaScript is disabled by checking
the settings in ChromeContentBrowserClient::AllowServiceWorker().

BUG=632823

Review-Url: https://codereview.chromium.org/2377603002
Cr-Commit-Position: refs/heads/master@{#423745}

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.

Review-Url: https://codereview.chromium.org/2395133003
Cr-Commit-Position: refs/heads/master@{#423744}

Revert of Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices (patchset #1 id:1 of https://codereview.chromium.org/2397573008/ )

Reason for revert:
Root cause is in Android framework, we're just going to catch the exception

Original issue's description:
> Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices
>
> BUG=653685
> TBR=carlosk@chromium.org, dfalcantara@chromium.org
>
> Committed: https://crrev.com/3988c1fd1bc405d01850a8e5e28619d0630b5184
> Cr-Commit-Position: refs/heads/master@{#423709}

TBR=carlosk@chromium.org,dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653685

Review-Url: https://codereview.chromium.org/2396243002
Cr-Commit-Position: refs/heads/master@{#423743}

When an IndexedDB versionchange transaction is aborted, Blink's
IndexedDB metadata is not entirely reverted, causing our behavior to
deviate from the IndexedDB specification in minor, subtle ways. This
change aligns our behavior with the spec and with Firefox's
implementation.

The change also (slightly) reduces IndexedDB memory usage in two ways.
(1) Object store and index metadata is now shared between an IDBDatabase
and its associated IDBObjectStore and IDBIndex instances, instead of
being copied. (2) versionchange transactions only back up the metadata
for object stores that are accessed by JavaScript, instead of creating a
backup for the entire database metadata.

BUG=645018,457447

Review-Url: https://codereview.chromium.org/2314933005
Cr-Commit-Position: refs/heads/master@{#423742}

This is not longer needed after we switch to using offline interceptor

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2395763003
Cr-Commit-Position: refs/heads/master@{#423741}

This was deemed unnecessary in UX review. When navigator.share is used
from incognito, you still see the intent picker which is considered
sufficient warning for users.

The bulk of the code to support this (https://crrev.com/420564) remains
and will be removed in a future CL.

BUG=645007

Review-Url: https://codereview.chromium.org/2389393004
Cr-Commit-Position: refs/heads/master@{#423740}

This adds an MB config for 'Linux ChromeOS Buildspec Tests' builder, and makes the 'linux_packages_all' target be defined for CrOS builds as well as desktop Linux, though I have no idea if this'll actually build in that config.

TBR=dnj@chromium.org, brettw@chromium.org
BUG=643238

Review-Url: https://codereview.chromium.org/2399883003
Cr-Commit-Position: refs/heads/master@{#423739}

After a sequence of frames that don't saturate bandwidth libvpx always
chooses lowest allowed quntizer (highest quality). As result these frames
are quite big after being encoded, which results in poor response latency
for those frames. With this change the scheduler detects those frames and
sets min_quantizer to 60 to ensure that they are first encoded with low
quality and quality is topped off later.

This change reduces latency for "big" frames in
ProtocolPerfTest.TotalLatencyWebrtc from 500ms to 200ms in 8Mbps case,
even without proper BW estimation.

Also changed frame duration from 66 to 33 ms, to match actual frame
duration (this doesn't seem to have significant effect on quality).

BUG=645656

Review-Url: https://codereview.chromium.org/2381213002
Cr-Commit-Position: refs/heads/master@{#423738}

Chrome now uses the browser process for background download resumption.
We don't need a separate process for this, remove the code.

TBR=palmer@chromium.org

Review-Url: https://codereview.chromium.org/2365093002
Cr-Commit-Position: refs/heads/master@{#423737}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b5cecfe7c5a9684ea21d08599cbcc85a419dd190 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/a3f10315eb5597be73cdfc1a4a1145fe3cc3b541 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/825386b5d616ed1e5fca94ec76eb6de9335b86d2 Add astunparse and update_vendoring. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2400843002
Cr-Commit-Position: refs/heads/master@{#423736}

This CHECK is hit by MSE users who make a small Remove() of their last
appended frames and then a subsequent Append() as if the previous remove
had not occurred.

The bug will also manifest if users set duration to just under the
current duration - currently equivalent to a small Remove().
Aside: duration truncation will soon be deprecated.

If the initial Remove() is small enough (less than the fudge room),
RemoveInternal() will fail to see this as causing a discontinuity and will
not reset range_for_next_append_. If the next append is beyond the
newly-shortened-range-end + fudge room, then CanAppendToEnd will CHECK.

BUG=627905
TEST=new unit tests, crash gone from (nsfw) http://ck101.com/thread-3559838-1-1.html?ref=banner

Review-Url: https://codereview.chromium.org/2385423002
Cr-Commit-Position: refs/heads/master@{#423735}

SERP will dispatch intents directly to instant apps. If the user clicked
on http/https link on SERP, it should not offer or launch instant apps.

BUG=644772

Review-Url: https://codereview.chromium.org/2397153003
Cr-Commit-Position: refs/heads/master@{#423734}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- tabs

BUG=634140

Review-Url: https://codereview.chromium.org/2398793002
Cr-Commit-Position: refs/heads/master@{#423733}

A couple triggers crashes, which I've filed separately. The keyboard
ones won't work in mash. I plan to move those out of this file
separately.

BUG=624172,652871
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2391153002
Cr-Commit-Position: refs/heads/master@{#423732}

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2238883006
Cr-Commit-Position: refs/heads/master@{#423731}

Every implemented function of the Adapter Mojo service requires a
reference to the system's Bluetooth adapter. Since any function could be called
at any time in the service, the adapter must be available from the creation of
the Adapter service. To satisfy this requirement, a factory pattern has been
implemented to create instances of the Adapter service with the required
reference to a Bluetooth adapter.
BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2379573006
Cr-Commit-Position: refs/heads/master@{#423730}

It is bad user experience to show sign in promotions to users who
eventually cannot sign in anyway, because of missing gmscore. This CL
suppresses sign in promotions by checking the availability of gmscore.

BUG=653615

Review-Url: https://codereview.chromium.org/2399183002
Cr-Commit-Position: refs/heads/master@{#423729}

Currently, w3c-test-autoroller is blocked on importing
because new baseline files are not added and committed
before uploading.  Example of a build where this happens:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7732.

Purpose: This CL would unblock this issue on w3c-test-autoroller.

This would be unnecessary (and could be reverted) if either of
http://crrev.com/2397573002 or http://crrev.com/2396433004 is committed.

BUG=621599

Review-Url: https://codereview.chromium.org/2394913002
Cr-Commit-Position: refs/heads/master@{#423728}