- 25 Feb, 2019 40 commits
-
-
Bence Béky authored
Change-Id: I1806570ef5d7d6f62dd2e7d3bbe9d33d7dce2646 Reviewed-on: https://chromium-review.googlesource.com/c/1484825Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635228}
-
Jao-ke Chin-Lee authored
TBR=hinoka Bug: 907562 Change-Id: Ibe6c3d12fa8fadd5f05fd6b8a5b3a95fee5f7a0e Reviewed-on: https://chromium-review.googlesource.com/c/1485065Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#635227}
-
Xiaocheng Hu authored
Bug: 935678 Tbr: dmazzoni@chromium.org NoTry: True Change-Id: Ib2d2182069250b68196c43e707ccbd30c9b1fd3e Reviewed-on: https://chromium-review.googlesource.com/c/1487700Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635226}
-
John Abd-El-Malek authored
NOTRY=true TBR=mek@chromium.org Bug: 933880 Change-Id: Iaabc83ae1386bc536a56961fbb930eb2cb88f881 Reviewed-on: https://chromium-review.googlesource.com/c/1487702Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635225}
-
Bruce Dawson authored
This reverts commit 7a0168cc now that we don't need to work around the VC++ bug. Bug: 934323 Change-Id: I594c2c6b86096ffc8643e0f9ceb5b357e1c214be Reviewed-on: https://chromium-review.googlesource.com/c/1484353 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#635224}
-
Ted Choc authored
This will remove the dependency on the server experiment to disable it while we test on earlier channels. BUG=927509 Change-Id: I933bfd29d8df6284a51ed182bf124c883f789f4d Reviewed-on: https://chromium-review.googlesource.com/c/1487358Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635223}
-
Eugene But authored
This CL fixes 'Copy to Chrome' in multitasking mode when kExternalFilesLoadedInWebState flag is enabled. URL is set to completeURL (which is file:// URL) and virtualURL is set to externalURL (which is chrome:// URL). This is necessary because WebState knows how to render file URLs but can not render chrome:// URL. The code was copied from UserAcrtivityHandler, so this CL can be cherry-picked to M73. Code duplication cleanup will be done in a follow up CL. Bug: 934789 Change-Id: I490cea33171b25ff73ef713c8610a64da9d8145f Reviewed-on: https://chromium-review.googlesource.com/c/1484631 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635222}
-
Joe DeBlasio authored
This is a reland of c9078153 which was reverted because it triggered a bug fixed in http://crrev.com/c/1483732 . Original change's description: > Hide URL from lookalike URL warning interstitial. > > This CL adds support for hiding of URLs in the omnibox by security > interstitials so as to enable it for the lookalike URL interstitial. > > Bug: 927924 > Change-Id: I2a7c7311480d6626d2ef27572e326c0a473dc20b > Reviewed-on: https://chromium-review.googlesource.com/c/1478358 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634067} Bug: 927924 Change-Id: I14e5db4d7eec03b060df25569fa38ce1cd1e8522 Reviewed-on: https://chromium-review.googlesource.com/c/1482940Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#635221}
-
Yi Su authored
ios_web_shell_egtests.NavigationTestCase can be removed now since it's covered by ios/web/navigation/history_state_operations_inttest.mm. Bug: 930859 Change-Id: Ib14239b206799d1429070800ad7ee259faaaee69 Reviewed-on: https://chromium-review.googlesource.com/c/1486338 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635220}
-
Martijn Croonen authored
This updates from revision 5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08) to revision 0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21) Bug: 928091 Change-Id: I2c0582cbd3724211fca8990ded30232351290588 Reviewed-on: https://chromium-review.googlesource.com/c/1484301Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635219}
-
Xiaocheng Hu authored
[Sheriff] Mark virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html as flaky leak Bug: 894651 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I501a7dd5576570cb26075aa16b2cde53064a387d Reviewed-on: https://chromium-review.googlesource.com/c/1487694Reviewed-by:
-
Lukasz Anforowicz authored
This is a 2nd reland of https://crrev.com/c/1441277 (1st reland was in https://crrev.com/c/1481535). This reland lands just the product code changes, without a test that flakily failed on linux-chromeos-rel. We will attempt to also reland the test in separate follow-up CL - this work will be tracked in http://crbug.com/934612. Original CL description follows below: Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457, 934612 Tbr: John Abd-El-Malek <jam@chromium.org> Tbr: Daniel Cheng <dcheng@chromium.org> Change-Id: I638d3065c2afc001e67d7631e09658015c9c9d3c Reviewed-on: https://chromium-review.googlesource.com/c/1482944 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635217}
-
Peter Kasting authored
Bug: 431427, 820435, 828063, 863296 Change-Id: I40b7b8129ebc72b3798f5d360e4ed2fa933847c7 Reviewed-on: https://chromium-review.googlesource.com/c/1483677Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635216}
-
Mei Liang authored
This CL integrates TabModelFilter into the following UI: * TabCountProvider * LayoutManager and changes these UIs to wait for events from TabModelFilter instead of TabModel. TabModelFilters are provided by TabModelFilterProvider class. They observe TabModel changes and notify their observers about the changes. Bug: 930960 Change-Id: Iad95594f9b3f9002103fcac564f2197468cbee58 Reviewed-on: https://chromium-review.googlesource.com/c/1464118 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635215}
-
Nico Weber authored
Bug: 926235 Change-Id: I32c7a9f15f1f544caaceef28b0d34ebd643aa35d Reviewed-on: https://chromium-review.googlesource.com/c/1486880Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635214}
-
Jarryd authored
QuotaManager currently uses a custom deleter that ensures the deletion happens on the IO thread. This CL removes the custom logic, and instead has QuotaManager inherit from RefCountedDeleteOnSequence. This CL was previously submitted with https://crrev.com/c/1479302 as d82ad3d0. It is currently broken up to minimize the impact of a potential revert. Change-Id: If39890da03f577771b31faf71a1ae479ca11cc9d Reviewed-on: https://chromium-review.googlesource.com/c/1481591 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#635213}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afb82004c0be..ebeca2a9eb81 git log afb82004c0be..ebeca2a9eb81 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 eseckler@google.com Merge "protos: Add v0 of new TrackEvent protos" Created with: gclient setdep -r src/third_party/perfetto@ebeca2a9eb81 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia82906c6b1c9ca7c3e27e536ddc9278e8c40818f Reviewed-on: https://chromium-review.googlesource.com/c/1487192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635212}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I6a402d08ecafa76447aef58b498fc4e33867fd2f Reviewed-on: https://chromium-review.googlesource.com/c/1486871 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#635211}
-
Devlin Cronin authored
Make the PermissionSet constructor accept URLPatternSet parameters by value, enabling std::move()ing the parameters rather than necessitating a copy. Update call sites that are easily modified. Bug: 908536 Change-Id: I80ce85497b3272285a5b2a2299f8dc153530df51 Reviewed-on: https://chromium-review.googlesource.com/c/1383537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635210}
-
Yue Li authored
Bug: 930994 Test: Manual Test Change-Id: I18da4e8c5767002c709f72293c76c8e67259d1d9 Reviewed-on: https://chromium-review.googlesource.com/c/1484231Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#635209}
-
Xiaocheng Hu authored
Bug: 935665 Tbr: fsamuel@chromium.org Change-Id: I96afe7230617c4399c8aa992cd56aae4be4c0209 NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487179Reviewed-by:
-
Nico Weber authored
TBR=pastarmovj Bug: 926235 Change-Id: If49ed5cf5da0138db5b2249f6c51286f6306b446 Reviewed-on: https://chromium-review.googlesource.com/c/1486876 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#635207}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I10193ba9b6531707ac2891b99565e2c1e2e089b9 Reviewed-on: https://chromium-review.googlesource.com/c/1487291 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#635206}
-
Varun Khaneja authored
See also: http://cl/235019478 Bug: 909778 Change-Id: I1082d8c4f81c27ab62840ed78196db9cb71c8b3e Reviewed-on: https://chromium-review.googlesource.com/c/1481602Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635205}
-
Sahel Sharify authored
This cl changes scrollend/overscroll events to bubbling when the target node is document. With this change overscroll/scrollend events' bubbling behavior will be identical to the bubbling behavior of scroll event and registering an overscroll/scrollend event listener on window will work. To try the cl locally use --enable-blink-features=OverscrollCustomization runtime flag. Bug: 907601 Change-Id: I9a170a5ba3406f82d08e06c8c20e51bc5b001f6c Reviewed-on: https://chromium-review.googlesource.com/c/1483350Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635204}
-
Jimmy Gong authored
- Implements Net::NetworkChangeNotifier::NetworkChangeObserver to SmbService. - Optimizes the workflow of host name resolution by calling on host discovery whenever a network change is discovered, rather than only running host discovery on an error returned by StartReadDirectory. Bug: 922273 Test: manual end to end Change-Id: I9e91a1527fe06570b3d82c7abc92c448c07ed74a Reviewed-on: https://chromium-review.googlesource.com/c/1484501 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#635203}
-
David Bienvenu authored
When native-win-occlusion is turned on, this will cause the page visiblity API to get triggered when the screen is locked/unlocked. Bug: 532128, 813093 Change-Id: Ic747188d31ebf9a692a6913d9b84a70f86c9d2aa Reviewed-on: https://chromium-review.googlesource.com/c/1481581Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635202}
-
Frank Poole authored
This change adds a minimal testable implementation of the UIA IWindowProvider interface and associated unit and browser tests. IWindowProvider::get_IsModal is implemented while the remaining APIs are added as unsupported (we do not intend to implement them). IWindowProvider is made available through IRawElementProviderSimple::GetPatternProvider when an accessibility node is explicity set as modal or not modal. This mapping for aria-modal is required by Core-AAM: https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table Bug: 847971 Change-Id: I2b0a6ec359302dbf8aae7cfcd21cbe23b527f962 Reviewed-on: https://chromium-review.googlesource.com/c/1480694Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Frank Poole <frpoole@microsoft.com> Cr-Commit-Position: refs/heads/master@{#635201}
-
Elly Fong-Jones authored
This change: 1) Removes the protect-sync-credential and ProtectSyncCredentialOnReauth flags; 2) Removes their backing features; 3) Removes SyncCredentialsFilter::GetAutofillForSyncCredentialsState(), which collapsed into always returning ALLOW_SYNC_CREDENTIALS after (1) and (2); 4) Removes AutofillForSyncCredentialsState, since (3) made it unused except in SyncCredentialsFilter::FilterResults(); 5) Removes SyncCredentialsFilter::FilterResults(), since it collapsed down to the identity function; 6) Removes CredentialsFilter::FilterResults() altogether, since (5) removed the only non-test override of that function, and removes it from StubCredentialsFilter; 7) Removes test coverage for CredentialsFilter::FilterResults; 8) Marks PasswordManager.SyncCredentialFiltered as obsolete, since it can no longer be generated; 9) Cleans up a bunch of now-unneccesary includes. Bug: None Change-Id: I8ef8a0798110d954afc44e6c7bdddc4b1e6f381b Reviewed-on: https://chromium-review.googlesource.com/c/1483394 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635200}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e3b205b1202f..f6b0439fb639 git log e3b205b1202f..f6b0439fb639 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e2d8b1286ce3..5efe61188243 (1 commits) 2019-02-25 bungeman@google.com Remove fuzz samples. 2019-02-25 ethannicholas@google.com fixed SkSL float literals in Arabic locale 2019-02-25 bungeman@google.com Remove defunct SkJSCanvas 2019-02-25 jvanverth@google.com Check for zero offsets for PolyUtils 2019-02-25 borenet@google.com [infra] Make the presubmit bot use recipes from CIPD 2019-02-25 fmalita@chromium.org [skottie] Layer blend mode support 2019-02-25 reed@google.com fill the layer if there is a backdrop filter Created with: gclient setdep -r src/third_party/skia@f6b0439fb639 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3fd8175d1ca143e9a838be57a679fe0b27cb9bbe Reviewed-on: https://chromium-review.googlesource.com/c/1487072Reviewed-by:
-
Mike Wittman authored
All implementations of this function are now empty. Bug: 931418 Change-Id: I87d875a5523fa12a9db9b52b1e3baef41118e62b Reviewed-on: https://chromium-review.googlesource.com/c/1478073 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635198}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/2901ec32a9..93d155bc44 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/2901ec32a9..93d155bc44 Bug: None Change-Id: I0089165c94f2676eb7069fd8c53908fc25ff351f Reviewed-on: https://chromium-review.googlesource.com/c/1485952Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#635197}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries 4. with comment about numbering from 0 without gaps 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface There is additionally removed one unnecessary Map. BUG=919666 Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/1142764Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb111e85e7e..4a8da2c58a9d Created with: gclient setdep -r src-internal@4a8da2c58a9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia6d19a65a49a99429f9e1222c9cda370414cfb36 Reviewed-on: https://chromium-review.googlesource.com/c/1487132Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635195}
-
Elly Fong-Jones authored
Bug: None Change-Id: I023840d139f7494636224358c8c0d3519b6179f2 Reviewed-on: https://chromium-review.googlesource.com/c/1486491 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#635194}
-
James Cook authored
Use "Chromebox" vs. "Chromebook" depending on device type. Bug: 872739 Change-Id: I1ef4b6db7b176c8cd27979e39cde5aaf77f76cea Reviewed-on: https://chromium-review.googlesource.com/c/1484507Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#635193}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7a49ee027d224abc8bb8e5228201bfb69df41c12 Reviewed-on: https://chromium-review.googlesource.com/c/1486836Reviewed-by:
-
Lukasz Anforowicz authored
Before this CL, a comment in //extensions/browser/url_loader_factory_manager.cc used to incorrectly link to an internal doc with a draft of https://www.chromium.org/Home/chromium-security/extension-content-script-fetches (this comment landed back when we were still considering just making the doc public, rather than moving the content under https://www.chromium.org/Home/chromium-security). Bug: 846346 Change-Id: I55a09bc55523bb0f59d21133402da8a53dd94625 Reviewed-on: https://chromium-review.googlesource.com/c/1487351Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635191}
-
Christian Biesinger authored
{Min,Max}PreferredLogicalWidth only constrains the size by the min/max-width if it is a fixed value. However, ChildIntrinsicLogicalWidth needs to constrain even for percentages and others. R=mstensho@chromium.org Bug: 935022 Change-Id: I3f5eff5e6f8e99484185635e44e3afa426c741fb Reviewed-on: https://chromium-review.googlesource.com/c/1484854 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635190}
-
Xiaocheng Hu authored
Bug: 935638 Change-Id: I5bd95e9e38a713a42863d2b2607fc1c6bb824bef Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487195Reviewed-by:
-
