- 25 May, 2018 40 commits
-
-
Ryan Tseng authored
To easily visualize the green luci builders. Bug: 840631 Change-Id: Ic06e92870f7a169a8a720140fa3ab0615e92672c Reviewed-on: https://chromium-review.googlesource.com/1073962Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562035}
-
Jennifer Apacible authored
This change adds support for tabbing through the controls in the window. Previously, the user can only utilise mouse clicks to interact with the controls. ControlButton will likely be updated to accommodate the addition of a non-constant number of custom actions in the future. UI affordances for the currently focused control will be added in a separate patch. BUG: 836389 Change-Id: Ic25524cfab9ceeba1d17ef00975347f6e3d562e6 Reviewed-on: https://chromium-review.googlesource.com/1072516 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#562034}
-
Carlos Knippschild authored
This fixes the presentation of this histogram in the UMA dashboards where it currently shows as representing a numeric value. Bug: 794828 Change-Id: I549d7460440435861cb4364f303845cfcac5d2e0 Reviewed-on: https://chromium-review.googlesource.com/1072712Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#562033}
-
Luna Lu authored
UseCounter now checks if a page is an ordinary page when it logs usage. This means all UseCounter realted unit tests need to use a dummy page holder that is added to ordinary pages. Previously a dummy page holder is added to ordinary pages upon construction, which is not ideal. This CL only explicitly add a dummy page holder to ordinary pages when needed. Change-Id: I7b48d894a546849797e656e66cad13cc58b20635 Reviewed-on: https://chromium-review.googlesource.com/1070670 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#562032}
-
Kristian H. Kristensen authored
We need to allocate the native pixmap for the unittest using the SCANOUT_VDA_WRITE usage flag like we do in Chrome so we get the right tiling. Bug: 845076 Test: video_decode_accelerator_unittest passes Change-Id: I877bf94e6f7f90c14973be76c1f53d841aed4305 Reviewed-on: https://chromium-review.googlesource.com/1072638Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562031}
-
Xiaocheng Hu authored
If an NGPhysicalTextFragment is created from first-letter, its GetNode() method returns nullptr, which leads to false negative when hit-testing on this fragment. This patch adds a new method to obtain the text node for first- letter fragments, and applies it in hit test code, so that we can correctly obtain the text node when hit-testing the first letter. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I70e5cd4948f248a6e51e3a1732273779ef36509c Reviewed-on: https://chromium-review.googlesource.com/1072691 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562030}
-
Nicolas Pena authored
Bug: 836310 Change-Id: Ib2d8796129e34c22c922e21b492e474130ea4420 Reviewed-on: https://chromium-review.googlesource.com/1057434 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#562029}
-
Ryan Tseng authored
This adds max_concurrent_invocations on a per-builder basis for chromium.lkgr builders. Bug: 840631 Change-Id: Id45281695c35b7d0f1549183ac5e72fd8e5ae957 Reviewed-on: https://chromium-review.googlesource.com/1073925Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562028}
-
Esmael El-Moslimany authored
Bug: 794289 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1ed00732e07bd0f9b3bdf2cf97cd257d8054f8e Reviewed-on: https://chromium-review.googlesource.com/1069793Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562027}
-
Aga Wronska authored
This is a new User Policy that is used to determine if Sync Consent should be displayed for the user during login. TBR=atwilson@chroumium.org Bug: 841156 Change-Id: Ibf5e0bdbe7a1037b6c2760032901e3cbe1924146 Reviewed-on: https://chromium-review.googlesource.com/1073623 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#562026}
-
Michael Spang authored
This adds the missing override of viz::OutputSurface::UpdateGpuFence to content::VulkanBrowserCompositorOutputSurface. Bug: none Test: compile Change-Id: I8dc0c40d98c16f4bb85c404b51f654f90bce47ca Reviewed-on: https://chromium-review.googlesource.com/1073063Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562025}
-
Eugene But authored
This optional method is not implemented by native content classes. Bug: 725239 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I70bb3e0e308762bd90c354769eccd1cc2616ed73 Reviewed-on: https://chromium-review.googlesource.com/1073676Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#562024}
-
Sergey Abbakumov authored
With these gn args: is_clang = false target_cpu = "x64" the file fails to compile due to uint64 -> uint32_t conversion. Change-Id: I76126e6d170f01eedcccfd3a17f6aa4184753fe9 Reviewed-on: https://chromium-review.googlesource.com/1071287Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#562023}
-
Charlie Harrison authored
This CL: 1. Stops null-checking the WebContents when considering to block popups. All callers pass in a valid contents already. 2. Tests the case when a caller calls ShowBlockedPopup with an invalid id. This seemed like a more reasonable API to be defensive with, but it wasn't tested. Bug: None Change-Id: I3913ed540b06f57e7fd31cae1f7da7de4da37dab Reviewed-on: https://chromium-review.googlesource.com/1073847Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#562022}
-
Steve Kobes authored
Bug: 823365 Change-Id: I847384bf51dfe78dcb772afde72d7d19c876b44b Reviewed-on: https://chromium-review.googlesource.com/1073659Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#562021}
-
Sadrul Habib Chowdhury authored
Remove FrameTokenAllocator since it is no longer needed or used. BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I760a1dcaf220dd13d8b4ac448de911ec46acf593 Reviewed-on: https://chromium-review.googlesource.com/1073081Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#562020}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0 Reviewed-on: https://chromium-review.googlesource.com/1073644 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562019}
-
wutao authored
This cl adds the support to toggle the shortcut view by the same shortcut: Ctrl + Alt + /: 1. If the KSH window is active, close it. 2. Otherwise, open it (if it's not open already) or activate it (if it's open but not active). Bug: 819815 Test: New unit test KeyboardShortcutViewTest.ToggleWindow Change-Id: Icbc9fba5644208750d1632b7473c66f53b923a80 Reviewed-on: https://chromium-review.googlesource.com/1073101Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#562018}
-
erikchen authored
This CL is a refactor with no intended behavior change. This CL: * Removes the mojom interface ClientProcesss::EnableHeapProfiling. * Removes the implementation, primarily hosted in MemoryDumpManager. Change-Id: Id55835da60d86520f692385930208a31206f7dce Bug: 822843 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1069000Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562017}
-
James Cook authored
We removed ash::Config::MUS as part of the switch to //services/ui/ws2. ShellPortMus isn't used independently anymore. Bug: 841941 Test: ash_unittests --enable-features=Mash Change-Id: I506a0526aebd8b90f07d654ceaad8f90891106cb Reviewed-on: https://chromium-review.googlesource.com/1072454 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#562016}
-
Olivier Robin authored
When elements don't have scope, setting the model value throws an undefined element exceptions, causing autofill to fail. Test existence of scope before updating model. Bug: 846730 Change-Id: Ia1119604252829d2012bfc728de297607aa92883 Reviewed-on: https://chromium-review.googlesource.com/1072473Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#562015}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/710fa99b0bd2..d4d645abecec $ git log 710fa99b0..d4d645abe --date=short --no-merges --format='%ad %ae %s' 2018-05-25 rharrison Reserve space for code words when creating encoder context Created with: roll-dep src/third_party/pdfium BUG=chromium:846027 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26d090f4a72bd512979b45a7799106a90ad1cc68 Reviewed-on: https://chromium-review.googlesource.com/1073680 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562014}
-
Matt Reynolds authored
The W3C Gamepad spec says that gamepad timestamps should be returned as DOMHighResTimeStamps relative to the navigationStart attribute of the PerformanceTiming interface. This CL modifies the internal Gamepad buffer to store the timestamp as a 64-bit signed integer count of milliseconds since the base::TimeTicks origin. When returning the value to the page, the value is converted to a DOMHighResTimeStamp relative to navigationStart. Additionally, all gamepad data fetchers are modified to set the last-update timestamp using the base::TimeTicks clock. This is a reland of commit: 2464a382 The first attempt broke OculusGamepadDataFetcher and was reverted: https://chromium.googlesource.com/chromium/src/+/fb0674220c41322d99ba8a08347356af20061bbd BUG=398642 Change-Id: I1a77881be388d91131443d93e22395e3f5a78363 Reviewed-on: https://chromium-review.googlesource.com/1070996Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#562013}
-
Weidong Guo authored
Background: New specs require that an item can be dragged to next page without having to fill up the current page. However, all items in launcher currently are laid out linearly and no gap is allowed between items. And the item's visual index (e.g. (i, j) means ith page and jth slot.) can be calculated by it’s model index (index of the item view in |view_model_|) via formula: visual_index.page = model_index / max_items_per_page visual_index.slot = model_index % max_items_per_page However, this formula does not work for new specs, so we need a new view structure to map from model index to visual index. Changes: 1. Add a view structure to represent the item view's structure we show to users. 2. Add functions to operate on the view structure: load, save, sanitize, move, remove, add, etc. 3. Create a new page if the user drag an item to the end of last page. 4. Put everything behind a home launcher flag because it is part of home launcher feature. Design doc: go/applist-gap BUG=837871 Change-Id: I9718bfca0ebf31da5a5d63aa73c4a6f1fb20459a Reviewed-on: https://chromium-review.googlesource.com/1058715 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562012}
-
David Trainor authored
Restructure new download home code to pull out the list specific information from the DownloadManagerCoordinator. This will make it easier to separate the rest of the code (things like undo snackbars, etc.) from the list specifics, and allows us to just expose the list coordinator to keep the interfaces clean. Bug: 842345 Change-Id: Id2bf042f3e2af865ee741dfce18cd6427aea5b66 Reviewed-on: https://chromium-review.googlesource.com/1072152Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#562011}
-
Kevin Bailey authored
The tab switch button wasn't quite vertically centered in the GM2 style result view, and the icon was being clipped. This CL makes provisional size changes to make them fit. Bug: 780835 Change-Id: Ia72cb406088f50c2e22c0929e9e0acdb8d0db31e Reviewed-on: https://chromium-review.googlesource.com/1069569Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562010}
-
Jennifer Apacible authored
Currently, resizing sometimes doesn't always adhere to the aspect ratio when the window also moves (origin point updates) alongside it. OnNativeWidgetMove() is called in these cases. With this change, if the sizes of the previous and new bounds are the same, the window was only moved rather than resized. This change will make OnNativeWidgetSizeChanged() handle the updates for |current_bounds_|. BUG: 829677 Change-Id: Id7df25c0a888efa4b2a7cad39cf83105aa03a759 Reviewed-on: https://chromium-review.googlesource.com/1071125Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#562009}
-
Ted Meyer authored
Omitting kNoClockless allowed the renderer to pull frames quickly rather than trying to ratelimit them at the video fps. This was causing the video to finish playback in the short timespan between being resumed and suspended, causing the 'WaitUntilOnEnded' call to incorrectly return early, as the 'ended_' attribute on the PipelineIntegrationTest had been set to true. This ended_ boolean is only reset on a seek or a resume, none of which had come after the suspend. This was flaking because sometimes the video _wouldn't_ finish before the Suspend call, leaving the pipeline test in an unended state. Bug: 836785 Change-Id: I89d4382354e4cfcd6593b69f6cc02d6821492e41 Reviewed-on: https://chromium-review.googlesource.com/1072955 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#562008}
-
rbpotter authored
Since the InputChanged_ observer was tracking both validity and the input string, it generated intermediate states in which validity was true and the setting value was set to an invalid value, as the input value had not been updated. Fix this issue. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb35e8e825c3d4177d4c99a59dc6dcd5275969a6 Reviewed-on: https://chromium-review.googlesource.com/1072697Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#562007}
-
Kevin McNee authored
DevToolsEmulator::HandleInputEvent handles the case of a gesture pinch being handled on the main thread. Since touchscreen gesture pinch events are all handled on the compositor thread, this workaround is no longer needed. Bug: 787924, 734201 Change-Id: I3499c1129b0ee529a8d218a652c69e258fa93fc0 Reviewed-on: https://chromium-review.googlesource.com/1073401Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562006}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8933c795ce0eb05ab54ef5bf92342cd21c2299c8 Reviewed-on: https://chromium-review.googlesource.com/1073678Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562005}
-
Jennifer Apacible authored
Per UX feedback, add some space between the close button and the edge of the window. BUG: 836389 Change-Id: Id527c868b6beef25e7278e737faa2e0aff4ea469 Reviewed-on: https://chromium-review.googlesource.com/1071233 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#562004}
-
Wenzhao Zang authored
This CL is exactly the revert of the diff between patch 6 and 7 of CL 1013211: https://chromium-review.googlesource.com/c/chromium/src/+/1013211/6..7 It was assumed that GURL and std::string are equivalent for this use case. However GURL converts spaces in urls to "%20", therefore wallpaper_manager.js fails to use the url to find the currently set wallpaper. It's observed that this issue is only reproducible for wallpapers whose urls have space. Think it makes sense to use std::string since the url is not used for downloading purpose. (Using url as wallpaper id is not the best solution IMO, but changing it is a separate task.) Bug: 846264 Change-Id: Ie83b6d9e95dccbe44dd8fca8c0843a85fcfd9758 Reviewed-on: https://chromium-review.googlesource.com/1072700Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562003}
-
Brian Salomon authored
Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I759a98701d50bad4347ae5f44e49a11a3b9cdd45 Reviewed-on: https://chromium-review.googlesource.com/1054526 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#562002}
-
Pavel Feldman authored
Change-Id: Iac5d986f51b86b5c43b20d9cbf1f742684aa610b Reviewed-on: https://chromium-review.googlesource.com/1072790 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#562001}
-
Marc Treib authored
CanEngineStart specified the required conditions for creating the SyncEngine object: CanSyncStart() plus a refresh token being available. The refresh token condition was there because creating the engine will trigger a request for an access token. Previously, that request would fail in unhelpful ways if the refresh token wasn't loaded yet. Now however, PrimaryAccountAccessTokenFetcher handles that situation just fine, it'll simply wait for the refresh token. So this CL removes the refresh token condition from ProfileSyncService. Bug: 825190, 842697 Change-Id: Ica57945f93efcdf8597c1bdfdbda19a0b879e6d9 Reviewed-on: https://chromium-review.googlesource.com/997796 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562000}
-
Mustaq Ahmed authored
Bug: 846405 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I83be26f39db7175b2726052a98311e120bd3a2ee TBR: jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1073398 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561999}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13f43437558c..faaf41e886aa $ git log 13f434375..faaf41e88 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 agable Remove PatchChrome command Created with: roll-dep src/third_party/chromite BUG=chromium:770408 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I12953870db5d4be3b20d54bbbd523559e053ea40 Reviewed-on: https://chromium-review.googlesource.com/1073661Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561998}
-
liberato@chromium.org authored
Includes "null check for encryption info", reviewed here: https://chromium-review.googlesource.com/1072163 This CL does not roll to origin/master, since that is currently in a broken state (merge from upstream fails on the bots). Instead, 1da9c3346d8 has origin/merge-m68 as a parent. Created with: roll-dep src/third_party/ffmpeg BUG=832852, 846009 Change-Id: I09714fed74c90c6173a9fc8c33db7458fc26b38f Reviewed-on: https://chromium-review.googlesource.com/1072520 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561997}
-
Greg Thompson authored
BUG=846623 TBR=tapted@chromium.org Change-Id: Iafb9b3b179e35f4847d87c887a58b143524d0ce0 Reviewed-on: https://chromium-review.googlesource.com/1073372Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561996}
-