- 21 Feb, 2020 40 commits
-
-
Paul Moy authored
Now that cros_healthd collects memory information, use it to fetch and report the information in DeviceStatusCollector. DeviceStatusCollectorTest.TestCrosHealthdInfo and chromeos_unittests --gtest_filter= CrosHealthdServiceConnectionTest.* Bug: chromium:1054198 Test: browser_tests --gtest_filter= Change-Id: I23617c2184fc49859b25faf35ae7574af96240c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067252Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743590}
-
Ben Kelly authored
Experimentation on stable shows an ~8% progression on CacheStorage match time during FetchEvent handling at P95. Bug: 913107 Change-Id: Ia81a59b1ad13db3c613b7198adffd576e7cf7264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036025 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#743589}
-
Owen Min authored
Bug: 10487447 Change-Id: Ic1521f63db6ffa6d8e0b1f1ce5fe617c6c7170ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036799Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743588}
-
Nektarios Paisios authored
On platforms other than Chrome OS, Views objects are exposed to assistive software directly via an associated ViewAXPlatformNodeDelegate. To reduce code complexity and allow better text navigation in Views, we are planning to expose Views as an AXTree, in the same way as we currently expose web contents to accessibility. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I988437501a2ca8dfba06f4eb927b65a363f3bb42 Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068041 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743587}
-
Mason Freed authored
This is an in-progress API, part of the declarative Shadow DOM proposal [1], with the I2P at [2]. The new getInnerHTML() function gets the innerHTML property, but with additional options. At the moment, there is a single bool argument, which if true, serializes any contained `#shadowroot` nodes into declarative shadow root markup: <template shadowroot="mode">. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md [2] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nJDc-1s3R9U Bug: 1042130 Change-Id: I25ee40479e74d8d5aceb10b0b790d401f638e593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063891Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743586}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id065c6a115ede775da9f57459d484b45ffb54acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743585}
-
Josh Nohle authored
The current SystemInfoAPI logic does not account for multiple event listeners in the same browser context. The result was that when a listener was removed from the last relevant browser context, storage and display-changed events were not being dispatched. This is particularly deadly when lazy listeners still exist, listening for events while the background browser extensions lie dormant. The consequence is that, after roughly 15s, the browser extension handling display-changed and storage events goes dormant, all listeners except the lazy listeners are removed, the event dispatchers stop dispatching, and the Settings > Displays UI does not respond to changes such as monitor (un)plug or (un)mirroring. Here, we utilize the EventRouter::HasEventListeners() to ensure that events are dispatched if and only if at least one browser context has the relevant listeners attached. Tested "system.display.onDisplayChanged" events manually with debug logging (see patchset #3). Note: "system.storage.onAttached" and "system.storage.onDetached" event handling from SystemInfoAPI is only used in extensions browser tests. Fixed: 966053 Change-Id: Iaeb0406539971d87505bd44ae60e44553a9fc104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037955 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#743584}
-
Robert Phillips authored
This reference into Skia's include/private directory is preventing SkDeferredDisplayList.h being moved to include/core. SkDDLTmpRedirect.h acts as a redirection to allow the following Skia-side CL to land: https://skia-review.googlesource.com/c/skia/+/272343 (Move SkDeferredDisplayList.h into include\core) Change-Id: I4960712be5a4af372b285bc125ee65c2bdee2469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067386Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#743583}
-
Mason Freed authored
This reverts commit 4486011f. Reason for revert: See crbug.com/1054837 Original change's description: > Add tests to Fuchsia ARM64 CI builder. > > Use the same test exceptions for Fuchsia ARM64 as fuchsia-fyi-arm64-rel. > > Bug: 1042512 > Change-Id: I7b9333e49151975b4bfecb98dd6d36d954b514ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067673 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#743555} TBR=martiniss@chromium.org,jbudorick@chromium.org,steveroe@google.com Change-Id: Id61a07e464d238b7007e18625f19a549cd249b05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067091Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/694b74b82673..1dea1ea41202 git log 694b74b82673..1dea1ea41202 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 ilnik@webrtc.org [VP9 encoder] Set temporal id also on disabled spatial layers Created with: gclient setdep -r src/third_party/webrtc@1dea1ea41202 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051476 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I394403e169eb862ce5b59749470b7f8f6d83c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068426Reviewed-by:
-
Aaron Leventhal authored
Intent to Ship thread on blink-dev with 3 approving reviewers: https://groups.google.com/a/chromium.org/g/blink-dev/c/2uume_z0n8M Bug: 1006767 Change-Id: I08eb0468d69d9c989d08b53c83c71dde2d0dab87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067471 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743580}
-
Jose Lopes authored
The decrypt callback is called to indicate that the decrypt operation has completed: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=253e14fadbd228088575647ae333ca4ba974b021&l=60 The decrypt operation is defined in: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=253e14fadbd228088575647ae333ca4ba974b021&l=76 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I4fe39c6e5159438d80895df6c85432db38a4d789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050367 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743579}
-
Hui Wang authored
TransientEntry will chang to a general entry when we restore it from the state which was saved before. while TransientEntry usually used for InterstitialPage(eg. blocking pages) then an TransientEntry will be created again when we restore and load with the entry. Use the LastCommittedEntryIndex as selected entry index same with chrome. BUG: None Change-Id: I56146535799a6cbaa367b9f9de9485fa870b4640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068218 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743578}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f33bae87..79f0359a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I526e63f15af466367f0e6295de9fbbf3b74a6c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e4fe70d. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" c07550c4 "Fix ResolvedUnitType() in CSS min/max with both integers and floats" 86c2cff8 "Don't make anchor clicks cancel form submission when href=#" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" f1545e0e "webrtc: add wpt for validating ice-ufrag and ice-pwd syntax" afc2a4ab "WPT: Fix bogus use of assert_object_equals()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I38c7652896f71d21925a5effb62ae0b693ff2254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067199Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743576}
-
Jose Lopes authored
This is meant to be called every time the buffering state changes: * https://cs.chromium.org/chromium/src/chromecast/media/cma/pipeline/media_pipeline_client.h?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=31 This is a documented example: * https://cs.chromium.org/chromium/src/chromecast/media/cma/pipeline/media_pipeline_impl.cc?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=406 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 TBR=jam@chromium.org Bug: 714018 Change-Id: I915667489e660da38387747f91e1c2a42a84c6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047228 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Fredrik Söderquist authored
All attribute accesses here use the underlying object model, so there's no need to synchronize the attributes. Bug: 109212 Change-Id: I14448b23fe61eedbf0e8de3479c8b48331830371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066750 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743574}
-
Patrick Monette authored
Bug: 1054596 Change-Id: Ifa36d10be3188a8e0636e48d8cac170f1a1999d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067383Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#743573}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a139c005963b..137ae16f4e3f git log a139c005963b..137ae16f4e3f --date=short --first-parent --format='%ad %ae %s' 2020-02-21 lamontjones@chromium.org sdk.py: Honor build_source with no board list. 2020-02-21 vapier@chromium.org Revert "cbuildbot_launch: switch to python3 only" 2020-02-21 vapier@chromium.org export_to_cloud_trace: get it working under Python 3 2020-02-21 vapier@chromium.org scripts: convert random standalone programs to python3 only 2020-02-21 vapier@chromium.org cros_generate_breakpad_symbols: migrate to python3 only 2020-02-21 lamontjones@chromium.org api: refresh python files 2020-02-21 lamontjones@chromium.org toolchain: support Kernel CWP AFDO verify builders. 2020-02-21 lamontjones@chromium.org toolchain: Implement Chrome VerifyReleaseAfdoFile endpoints 2020-02-21 lamontjones@chromium.org toolchain_util: Pass all locations to _FindLatest* 2020-02-21 bsheedy@chromium.org Add option to snapshot VM 2020-02-20 gbiv@google.com simplechrome: simplify thinlto/cfi special cases 2020-02-20 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@137ae16f4e3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If6e09e8d6ff49300eea5008b942fd6526d2d2076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068421Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/706851dc99d9..f8f9cd84fa04 git log 706851dc99d9..f8f9cd84fa04 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 kjlubick@google.com [canvaskit] Expose bindings to particles uniforms. 2020-02-21 robertphillips@google.com Revert "Remove copies for wrap modes in GrTextureProducer." 2020-02-21 kjlubick@google.com [canvaskit] Expose parseColorString 2020-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2801bf43716e..94ec1e5f8df5 (24 commits) 2020-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 74d3f371f201..f50cc82b3bed (6 commits) 2020-02-21 csmartdalton@google.com Split uniform and texture uptades to different methods in GrGLProgram 2020-02-20 bsalomon@google.com Revert "Remove GrDeviceSpaceTextureDecalFragmentProcessor." 2020-02-20 bsalomon@google.com Remove GrDeviceSpaceTextureDecalFragmentProcessor. 2020-02-20 bsalomon@google.com Remove copies for wrap modes in GrTextureProducer. Created with: gclient setdep -r src/third_party/skia@f8f9cd84fa04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I4a9605c6893e22c135a5e6973c8a04dcd7890b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068422Reviewed-by:
-
Daniel Libby authored
This CL adds plumbing of an ExecutionContext into the creation of MediaQueryExp objects. This will allow RuntimeEnabledFeatures that are slated for origin trial experimentation to pass the ExecutionContext to the REF::*Enabled check so that origin trials can appropriately enable new media features based on experimentation status per origin. Callsites that perform media query parsing now pass an ExecutionContext, except for tests, media_feature_overrides, and html_preload_scanner. The overrides don't need an ExecutionContext since they are used to produce emulated values - parsing/setting the new features/values would still need to be enabled for this to have any effect. Not having the ExecutionContext for the preload scanner means that if experimental media features are gating resources, they may not be preloaded. However, given that these features are experimental, will eventually get loaded, and the fact that the amount of extra plumbing required is non-trivial, I've decided not to add the plumbing here. This CL also adds a test-only media feature that is enabled by the basic sample API origin trial feature in order to test various aspects of the plumbing. Bug: 1051382 Change-Id: Ifaafa2816f65a04f9cdd87bab8b1f216b54a348c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062699Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743570}
-
kylechar authored
In preparation for enabling finch experiment on beta channel. This CL also flips skia_renderer_screenshot_sync_tests to be gl_renderer_screenshot_sync_tests on Windows/Linux. GPU telemetry tests will flip to use SkiaRenderer by default now so this maintains limited test coverage for GLRenderer in CQ. Bug: 809722 Change-Id: I5ea506566db874f5a83aa6c6bd82980f5196536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988154 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Chris Harrelson authored
is an effect on the root element. The only reason to do so is to preserve blending. A more complete fix might be to always allocate an isolation effect node for the HTML element, but that will cause a very large number of rebaselines and introduces some risk of its own. (This CL needs to be merged into M81.) While not perfect, it returns us to the situation before landing [1]. Bug: 1050462 [1] https://chromium-review.googlesource.com/c/chromium/src/+/1979258 Change-Id: Id7b51837c0d36c426c1042bb9c6c0e5f81e64a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067288Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743568}
-
Vasiliy Telezhnikov authored
During destruction of WebView it's possible that not every observer has unsubscribed from BeginFrameSource in RootFrameSink (the latest it will happen in dtor RootFrameSink). This leads to situation when RootFrameSinkProxy is still observing BrowserViewRenderer's BeginFrameSource in dtor which leads to DCHECKs. This CL adds explicit RemoveObserver in RootFrameSinkProxy dtor to handle sutiation correctly. Bug: 1054777 Change-Id: I00811c79ae430872964075c83a308cad17a8694a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067087Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95fa3e68d355..f67f959012ef Created with: gclient setdep -r src-internal@f67f959012ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99b617de5f75940ee34db1083685d04d47661d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068423Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743566}
-
Aga Wronska authored
User app activity data should only be uploaded to the server when app activity collection toggle is enabled. If collection is disabled Per-App Time Limits feature will still work 'locally', but without uploading activity data. As a consequence parent nor child will not be see activity data in Family Link app. Bug: 1042477 Change-Id: I93382b654e490e2f8431dbd345f242ed2cc44f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067662Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#743565}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Ide6316330f98c2b8a325a03403dd5b3184574bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066923 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#743564}
-
Aga Wronska authored
Ownership is changed to CrOS Family Experiences team. Updated histograms: * ManagedUsers.SafeSitesDelay * Profile.NumberOfManagedProfiles * Profile.PercentageOfManagedProfiles Bug: 1053109, 1053004 Change-Id: Ie435635d6d66248fee63101b919957bc51ad6915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067559Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#743563}
-
Sorin Jianu authored
Bug: 1054696 Change-Id: Icf2d04d066a8af07577f0e9c52963ae09a0c3221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067860Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743562}
-
David Van Cleve authored
Trust Tokens key commitment records are served during the issuance and redemption steps of the Trust Tokens (Privacy Pass) protocol. These are JSON messages returned by a server endpoint located at a .well-known path relative to the Trust Tokens issuer origin. This change adds a flow for fetching these from the server; a concurrent CL (https://crrev.com/c/2029292) adds logic for parsing the messages. New code: - KeyCommitmentController, which manages a commitment request, creating an appropriately parameterized (viz., uncredentialed) ResourceRequest and passing it to a SimpleURLLoader - Unit tests verifying requests are constructed correctly and testing end-to-end request flow by mocking out the response parser Bug: 1042962 Change-Id: Iccf590a1b9a7b82f0ee85d7f6eb057f6194cced0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057009 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#743561}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b6120a066eb..84d733f34b73 git log 4b6120a066eb..84d733f34b73 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 tvanderlippe@chromium.org Revert "Updates performance timeline for long tasks" 2020-02-21 tvanderlippe@chromium.org Revert "Build Karma test with Ninja" 2020-02-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-21 aerotwist@chromium.org Updates performance timeline for long tasks 2020-02-21 tvanderlippe@chromium.org Build Karma test with Ninja Created with: gclient setdep -r src/third_party/devtools-frontend/src@84d733f34b73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1054447 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8b6f14ccba93d5015a2d284e5e2ab0fd69b98d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068375Reviewed-by:
-
Anton Bikineev authored
This is a workaround for the blink unit tests that run non-nested pending tasks manually with heap pointers on stack. We can't use GCForbiddenScope there anymore because incremental marking was moved to tasks which are executed from the task runner in tests. Bug: 1022735 Change-Id: Id870d2da846d1b5cbedc6c053d2c06d1d9f2435c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906353 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743559}
-
Nazerke authored
This CL modernizes the OmniboxCoordinator - to use |browser| in the initializer, - to remove the public property for dispatcher and browserstate, - to use self.browser to get browserstate and dispatcher values. This includes migration to ChromeCoordinator as a superclass. Bug: 1029346, 1048422 Change-Id: I894a367dec2c2c1c289b9709f1015401f661b328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066728Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#743558}
-
Liquan (Max) Gu authored
Before change: The URL view on Expandable Payment Handler UI toolbar gets updated when navigation starts. No URL update on navigation end. After change: No URL update on navigation starts; instead, it happens on navigation end. Change: Move URL update from navigation start to navigation end Bug: 1051634 Change-Id: Iab484aa710919b5cf2e23916ab85204aa9b5f0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065496Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743557}
-
Miguel Casas authored
This reverts commit ed3b55f6. Reason for revert: b/149959687 broke tast.video.DecodeAccelPerf.vp9_1080p_30fps on kevin|hana|scarlet 64 bit Original change's description: > media/gpu/test: Group ivf frames whose timestamps are same > > The served stream in webrtc can be dumped by the chrome > option [1]. When the stream structures spatial-layers, one > spatial layer is separately saved in one ivf in the dumped > ivf file. > > On the other hand, to play the ivf file properly, it is needed > to group the spatial layers, which have the same timestamp in > ivf frame header. IvfFileReader [2] in webrtc does so in fact. > > This applies the group logic to our own ivf parser used in > VDA test. This enables us to test SVC stream in VDA test. > > [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp; > [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h > > Bug: 1044816 > Test: video.DecodeAccel.vp9_ksvc > Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740575} TBR=hiroh@chromium.org,dstaessens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044816, b:149959687 Change-Id: I4863f2d6a9079957a16a33eca339bd29ff81b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068122 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#743556}
-
Stephen Roe authored
Use the same test exceptions for Fuchsia ARM64 as fuchsia-fyi-arm64-rel. Bug: 1042512 Change-Id: I7b9333e49151975b4bfecb98dd6d36d954b514ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067673Reviewed-by:
-
Nick Diego Yamane authored
After migrating away from ui::*Event constructors to XEvent translation helper functions in Aura/X11, MouseEvent::changed_button_flags is wrongly initialized for non-XI2 XEvents. This causes issues such as crbug.com/1053931 and crbug.com/1047484. This CL fixes it as well as adds unit tests to prevent future similar regressions. Bug: 1054581, 1053931, 1047484 Test: events_unittests --gtest_filter=XEventTranslationTest.ChangedMouseButtonFlags interactive_ui_tests --gtest_filter=ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction R=sadrul@chromium.org Change-Id: Iddc55cbaf36e5f40bb09655149e5b288b8402652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063749Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#743554}
-
Maksim Moskvitin authored
|request_completed_callback_| might destroy PerUserTopicSubscriptionRequest object, so any use of this object after running the callback must be avoided. It wasn't the case for OnURLFetchCompleteInternal() which called RecordRequestStatus() with arguments based on class members after the running callback. This CL reorders the calls to avoid heap-use-after-free and adds documentation for |request_completed_callback_| behavior. Bug: 1054590, 1054759 Change-Id: Iea0d10a7bbabc3b4cabdfea233e0ec0c79bd197c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066924 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743553}
-
Mikhail Khokhlov authored
The metric finds periods in a trace when scroll update events started but didn't finish. The idea is arguable, but it corresponds well with my subjective feeling of scroll jankiness when I look at the phone screen. My plan is to run this on an FYI bot on the waterfall for a while, to see how stable the results are, and what can affect them. Change-Id: If8833af1c07f56b1a21abce443e2915b39e736bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062334 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743552}
-
Rohit Agarwal authored
Currently, we can enable or disable set of features during our tests using @Features annotations. This populates the |sTestFeatures|. During our check of whether a feature is enabled or not in ChromeFeatureList#isEnabled we check first if the feature is present in the |sTestfeatures|. In case it's not we return an IllegalArgument Exception. This however omits a check to see if that feature may be present in native instead. This CL adds a new variable |sTestCanUseDefaults| which will be set as true for instrumentation tests that require access to default value in native flags and is by default false, ideally for unit tests that must explicitly enable or disable each Features, for which the their unit test relies on. Bug: 1053463 Change-Id: Iab681c610bb41141f74764e58efaecbabb85dc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061155 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#743551}
-
