- 20 Feb, 2018 40 commits
-
-
Fady Samuel authored
I find myself printing out SurfaceInfo over and over again. This is a quick CL to upstream this. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia1a4afbbb02f20e5cb6466fd5e381da192d713c1 Reviewed-on: https://chromium-review.googlesource.com/925681Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537783}
-
Miguel Casas authored
This CL makes Display:: RotationSource, TouchSupport and AccelerometerSupport enum classes. Just stumbled upon them while reading this class and thought why not? sed -i -e 's/Display::ACCELEROMETER_SUPPORT_/Display::AccelerometerSupport::/g' `grep -rn "Display::ACCELEROMETER_SUPPORT_" ui ash chrome components extensions | cut -f 1 -d: | uniq` sed -i -e 's/Display::TOUCH_SUPPORT_/Display::TouchSupport::/g' `grep -rn "Display::TOUCH_SUPPORT_" ui ash chrome components extensions | cut -f 1 -d: | uniq` sed -i -e 's/Display::ROTATION_SOURCE_/Display::RotationSource::/g' `grep -rn "Display::ROTATION_SOURCE_" ui ash chrome components | cut -f 1 -d: | uniq ` Bug: None Change-Id: Ic470df3b9de4f1b1ea9fbdc218078d6bd4be770e Reviewed-on: https://chromium-review.googlesource.com/915211Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#537782}
-
Peter K. Lee authored
FeedbackKit V2 needs GTMNSData+zlib. Bug: 657076 Change-Id: I4b5ab25b4d9c8b2594c34a067935107e11318bbc Reviewed-on: https://chromium-review.googlesource.com/926041Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#537781}
-
https://skia.googlesource.com/skia.git/+log/62ce2ca06978..7f583c933032 $ git log 62ce2ca06..7f583c933 --date=short --no-merges --format='%ad %ae %s' 2018-02-20 reed null check Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I2dffb6e54382b71dcbd4fedd65e357ac91160f87 Reviewed-on: https://chromium-review.googlesource.com/926301 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537780}
-
Henrique Nakashima authored
Bug: 811331 Change-Id: Id7d44e0d0ef14252735516d4a9d62bf055da2076 Reviewed-on: https://chromium-review.googlesource.com/914849 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#537779}
-
Maxim Kolosovskiy authored
TBR=khushalsagar@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813545, 813150 Change-Id: I46869c1d8bb4250fc94416c9083e0d2185d9b8a1 Reviewed-on: https://chromium-review.googlesource.com/926402 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537778}
-
Matt Falkenhagen authored
Bug: 813775 Change-Id: Ifb738ea32c6f06b20aabca21b540a1c39577300f TBR: bashi Reviewed-on: https://chromium-review.googlesource.com/926442Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537777}
-
Dianna Hu authored
This CL lands server change 185170750 by bnc. BUG=488484 Change-Id: I9d6b44ef24fe690fe707087bf2bcc366631a7933 Reviewed-on: https://chromium-review.googlesource.com/925806 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537776}
-
Gauthier Ambard authored
This CL adds an Earl Grey test to ensure that the toolbar buttons and the toolbar visibility is correctly updated when the size class changes. Bug: 804726 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee3937485ddf379695fabe420ce3311ddea4aba3 Reviewed-on: https://chromium-review.googlesource.com/919061Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#537775}
-
https://webrtc.googlesource.com/src.git/+log/e12738720874..52e58524b67a $ git log e12738720..52e58524b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6fce9f3d85a2662d9afc379783bd7de90c767245 Reviewed-on: https://chromium-review.googlesource.com/925846Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537774}
-
Maxim Kolosovskiy authored
TBR=avayvod@chromium.org, beccahughes@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789921 Change-Id: Id8433239e4c12bd115330bbaee3e43e3afe5e204 Reviewed-on: https://chromium-review.googlesource.com/926403 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
See https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29 TBR=beccahughes@chromium.org,avayvod@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789921 Change-Id: Ib4add80912d6ec2f95fe27224d06656702b7380f Reviewed-on: https://chromium-review.googlesource.com/926363 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Peter K. Lee authored
Bug: 657076 Change-Id: Iebbc85ea1061ef2a00479d80eecd038d78a6c548 Reviewed-on: https://chromium-review.googlesource.com/926042Reviewed-by:
-
Pavol Marko authored
This reverts commit bef7198b. Reason for revert: Broke browser_tests on some platforms due to ODR violation due to accidentally including chromeos_switches.cc in the browsertest. Original change's description: > Chrome OS: Only restart chrome if site isolation command line flags change > > On user session start, only request the chrome process to be restarted > if site isolation policies effectively change between the sign-in screen > and the user session. > The DeviceLoginScreenSitePerProcess and DeviceLoginScreenIsolateOrigins > policies map to --site-per-process and --isolate-origins command-line > flags passed to the sign-in screen chrome process by session manager > (see CL:924421). > The user session should respect SitePerProcess/IsolateOrigins user > policies instead. > > Replace special handling of the site isolation flags with placing them > between --policy-flags-begin and --policy-flags-end sentinels. > This makes sure that chrome is restarted exactly when the user session > flags don't match the login screen flags. > Background: chrome decides if it should be restarted by comparing the > parts of the current command line with parts of the target command line. > Specifically, the parts between flags and policy sentinels are compared. > > Also, evaluate the user policies mapped through user Profile prefs > instead of local_state. > Reason: When login_manager starts chrome with site isolation flags, the > prefs are set by ChromeCommandLinePrefStore. > > Bug: 800117 > Test: browser_tests --gtest_filter=*SiteIsolationFlagHandlingTest* > Change-Id: Ic11f8d687ab55ccd08928df7655896c19936cd34 > Reviewed-on: https://chromium-review.googlesource.com/924147 > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537733} TBR=xiyuan@chromium.org,emaxx@chromium.org,pmarko@chromium.org Change-Id: I2877bbefb4fe9207c464e2456c2e0bead18e742d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800117 Reviewed-on: https://chromium-review.googlesource.com/926322Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537770}
-
Takashi Toyoshima authored
This patch reimplements WebCORSPreflightResultCacheItem equivalent in network service, and share the implementation between the network service and Blink. The next patch will replace whole WebCORSPreflightResultCache, and this is the preparation to make the next patch small. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifa06967830465236dbe198908062e1952095e55b Reviewed-on: https://chromium-review.googlesource.com/915543 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537769}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9747b32b..e87c0fb4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I24d62aa597e6401efc6041f4e675ba5c298c1cd1 Reviewed-on: https://chromium-review.googlesource.com/925563Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537768}
-
Guido Urdaneta authored
This CL introduces a mojo interface for audio logging and makes the following classes from the audio service use it: - AudioInputDelegateImpl - AudioOutputDelegateImpl - AudioOutputDispatcherImpl Due to layering restrictions, AudioOutputDispatcherImpl cannot access mojo interfaces directly. To work around this limitation, this CL also introduces the MojoAudioLogAdapter class, which wraps mojo audio logs in the existing media::AudioLog interface. Bug: 812568 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I13a90ed12ddcd33944dffa8dda83df276905af68 Reviewed-on: https://chromium-review.googlesource.com/921282 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Bartosz Fabianowski authored
This CL adds a method for uploading app push-install logs to the CloudPolicyClient. It contains a trivial amount of boilerplate code and a non-trivial amount of boilerplate tests. Bug: b/73277923 Test: components_unittests and browser_tests Change-Id: Ib2ca2f562e7cf974e7536e612d0b6a72bdcebcf7 Reviewed-on: https://chromium-review.googlesource.com/919485 Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537766}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 53dc445f. With Chromium commits locally applied on WPT: 91310914 "Port another set of sticky tests to JS rather than reftests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12611 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=lukebjerring No-Export: true Change-Id: If8dd3cacd567cc825b96c2e39654a0f1deeb426c Reviewed-on: https://chromium-review.googlesource.com/925810 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#537765}
-
Gauthier Ambard authored
The content of the WebView overflows its bounds to be displayed below the toolbars (allowing to have a blur effect on the toolbars). But during the rotation the content is displayed outside the bounds of the main view, creating a weird effect. This CL fixes it by clipping the content of the BVC to BVC's bounds. Bug: 809103 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ica7a34fab6070a780b3e1eb03cae1ae2ad43e04b Reviewed-on: https://chromium-review.googlesource.com/924150Reviewed-by:
-
tzik authored
This CL applies //tools/clang/base_bind_rewriter to //chrome, that removes unneeded base::Passed as a parameter of base::BindOnce. This doesn't contain any behavior change. For example, on base::BindOnce call around |Foo|, |ptr|, and |ptr2| below: void Foo(std::unique_ptr<int>); std::unique_ptr<int> ptr; std::unique_ptr<int>* ptr2 = &ptr; If the parameter of base::Passed() is an rvalue-reference, it just removes the base::Passed call. // Before base::BindOnce([](&Foo, base::Passed(std::move(ptr))); // After base::BindOnce([](&Foo, std::move(ptr)); If the parameter is a pointer and its address is taken there, the rewriter replaces base::Passed and `&` with std::move(). // Before base::BindOnce(&Foo, base::Passed(&ptr)); // After base::BindOnce(&Foo, std::move(ptr)); If the parameter is other form of pointer, the rewriter replaces it with std::move(). // Before base::BindOnce(&Foo, base::Passed(ptr2)); // After base::BindOnce(&Foo, std::move(*ptr)); Change-Id: I2f8c1cd7b46143da8e79d0b4e917ba4d585485f2 Reviewed-on: https://chromium-review.googlesource.com/926081Reviewed-by:
-
Jennifer Apacible authored
Change-Id: Id4e254b78049373025d52dd1d04ecfc0f53c8e8e Reviewed-on: https://chromium-review.googlesource.com/911881Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#537762}
-
Mythri Alle authored
The parser cache in V8 is no longer used. Hence removing the option to produce a parser cache. Bug: chromium:779254 Change-Id: I70b0e211e63f312c701f4df3d57b3d75094cd762 Reviewed-on: https://chromium-review.googlesource.com/906988 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#537761}
-
Gauthier Ambard authored
This CL is cleaning the toolbar, moving files to a more precise location. It is moving the files related to the old toolbar to the legacy folder and the buttons related files to their own folder. Bug: 809785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie1c078e71853239fcc47021e9b79bd7a45e01c11 Reviewed-on: https://chromium-review.googlesource.com/926202Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/500874effdad..e12738720874 $ git log 500874eff..e12738720 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c2de8c89b816024dca20ca05d4e9acecb0c3e21 Reviewed-on: https://chromium-review.googlesource.com/926281Reviewed-by:
-
Takayoshi Kochi authored
This reverts commit d9a63882. Reason for revert: Possibly this caused mac bot webkit_tests failures https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29?numbuilds=200 Original change's description: > Remove ElementShadow indirection for getting ShadowRoot > > After multiple shadow roots are removed, getting a shadow root > can be done by Node::GetShadowRoot() or Element::GetShadowRoot(). > > Old code used to use get ElementShadow first, then use > ElementShadow::GetShadowRoot(), but it is no longer necessary. > > This is a step to merge ElementShadow class into ShadowRoot class. > > TBR=dmazzoni@chromium.org, mlamouri@chromium.org > > Bug: 624724 > Change-Id: I44af0d2de85e45badb36e5ba59facc03f7d81602 > Reviewed-on: https://chromium-review.googlesource.com/923245 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537258} TBR=kochi@chromium.org,dmazzoni@chromium.org,hayato@chromium.org,haraken@chromium.org,mlamouri@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 624724 Change-Id: I24902d3e98b81a1616f1f73fa3954c48952f6b9e Reviewed-on: https://chromium-review.googlesource.com/926261 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537758}
-
Raphael Kubo da Costa authored
test-results.appspot.com is returning an HTTP 500 error code when `webkit-patch rebaseline-cl` tries to fetch the -actual.txt files to rebaseline the test, and this is blocking WPT imports. TBR=robertma,lukebjerring Bug: 813762 Change-Id: Idd1ae8263d3a16f796cca3080913478f39b293d1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/925705Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#537757}
-
Hajime Hoshi authored
Now Timer is no longer used. Remove this. This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Change-Id: Ic0a0eccdfb9f98c0be8024d4f39a9c2b2ade5c9f Reviewed-on: https://chromium-review.googlesource.com/926083Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537756}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74f87f4e..9747b32b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I93fc36b605d99ef298c4722794be3ddd5ef081de Reviewed-on: https://chromium-review.googlesource.com/925646Reviewed-by:
-
Kinuko Yasuda authored
- array_buffer - clipboard - color_chooser - feature_policy Also renames feature_policy_struct_traits.{h,cc} to feature_policy_mojom_traits.{h,cc} per the standard mojom naming guideline. Did some relevant edits in README.md etc too. TBR=iclelland@chromium.org,haraken@chromium.org,jam@chromium.org Bug: 809983 Change-Id: I31a6f7a497423fa0c099d12ba93755bf737e7a76 Reviewed-on: https://chromium-review.googlesource.com/925983 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: -
Morten Stenshorne authored
Got fixed by https://chromium-review.googlesource.com/c/chromium/src/+/925601 , possibly combined with some other CL, since the trybot didn't detect it. TBR=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4d7b16e0cbaa67f1b940bdceb1fc7e265a6057e8 Reviewed-on: https://chromium-review.googlesource.com/926122 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#537753}
-
Hajime Hoshi authored
This is the counterpart for Mac of https://chromium-review.googlesource.com/c/chromium/src/+/923875 This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Change-Id: I9d3696671e71c44dff39da0c50c0a4b8e112e737 Reviewed-on: https://chromium-review.googlesource.com/925880Reviewed-by:
-
Yoshifumi Inoue authored
This patch add |const| to invariant member variables in |ReplaceSelectionCommand| for improving readability. Change-Id: I0ba290cbba3637145f09d948fc6a7ca926892453 Reviewed-on: https://chromium-review.googlesource.com/925879Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537751}
-
https://chromium.googlesource.com/catapult.git/+log/8273e472c811..7ae2122b3b38 $ git log 8273e472c..7ae2122b3 --date=short --no-merges --format='%ad %ae %s' 2018-02-20 dtu Revert "[dashboard] Cache ServiceAccountHttp() in memcache." 2018-02-16 dtu [pinpoint] Store all arguments passed to /new. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iede74d8eacf35b8ff5aa9475f78b5776fa184000 Reviewed-on: https://chromium-review.googlesource.com/925699Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537750}
-
David Tseng authored
ARC++ has no focus by when TalkBack is on design. Speaking this hint interferes with TalkBack. Original change https://chromium-review.googlesource.com/c/chromium/src/+/902405 Bug: 809083,806470, 806469 TBR=yawano@chromium.org,dmazzoni@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84d3b635e6cca62c0bc152723d143cfabdcc0982 Reviewed-on: https://chromium-review.googlesource.com/925698 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#537749}
-
Takuto Ikuta authored
This patch makes following command do nothing in second run. $ ninja -C out/android_n5x_swarming_rel/ chrome_sync_shell_apk Bug: 646165 Change-Id: If95d3691bffdfbdba2fbbc0b71f01af2c08214fc Reviewed-on: https://chromium-review.googlesource.com/923466Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#537748}
-
Tatsuhisa Yamaguchi authored
This is a tentative care to silence all flaky tests. We have found all the tests using the test mount point info are flaky affecting the trybot runs every time. So we'll disable all the affected test before fixing the root cause. Bug: 804413 Change-Id: I6e97504db495e5cd9c06d7e2d43de6a9611a083d Reviewed-on: https://chromium-review.googlesource.com/925878 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537747}
-
Kunihiko Sakamoto authored
It's getting hard to maintain LinkLoaderPreloadTest as number of fields in PreloadTestParams increases. This patch splits the test cases into several subclesses that take only relevant parameters. Change-Id: I3c63ec45b162c98f64eb93a1293695d5b6e28d14 Reviewed-on: https://chromium-review.googlesource.com/925984Reviewed-by:
-
Morten Stenshorne authored
TBR=atotic@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5d9fa090cb54cbdd4a5f39cc152627d5f9f4dbb7 Reviewed-on: https://chromium-review.googlesource.com/926001Reviewed-by:
-
Koji Ishii authored
Similar to CL:923925, this patch captures the 3 default SkFontMgr to see if they are the same in crash dumps. Bug: 409784 Change-Id: I9ca760dfbb28f7d23caca05d3311bca05be7d1c1 Reviewed-on: https://chromium-review.googlesource.com/923744Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#537744}
-
