GitLab

Moved MediaRouterEnabled() from chrome_switches to media_router_feature.
For desktop, the new function will use a FeatureSwitch integrated with
an experiment "EnableMediaRouter" to determine whether media
router should be enabled.

Properly wrap MediaRouterEnabled() calls with #if define()s.

The FeatureSwitch use the regular switch ("enable-media-router") first,
then use experiment if switch is not present. The default behavior
is to disable media router. (See feature_switch.h for details on
precedence).

BUG=541315

Review URL: https://codereview.chromium.org/1415333002

Cr-Commit-Position: refs/heads/master@{#357003}

1024 is the original value (see https://codereview.chromium.org/924433002, and https://codereview.chromium.org/197031)

BUG=513693
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1431493002

Cr-Commit-Position: refs/heads/master@{#357002}

To be used by BluetoothDispatcherHost in: http://crrev.com/1317933003

BUG=549327

Review URL: https://codereview.chromium.org/1418743006

Cr-Commit-Position: refs/heads/master@{#357001}

I need to constrain sizes more, but this is a good start.
Also, it looks like resizing doesn't actually work. I suspect that is
a bug in NativeWidgetMus (or WindowTreeHostMojo). Will figure that out
separately.

This adds the new test suite, but no bots are running it yet. I'll
update the build files separately.

BUG=548420
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1416453005

Cr-Commit-Position: refs/heads/master@{#357000}

- add missing file to compile
- fix final build directory (and make --output work)

BUG=none
R=dpranke@chromium.org,tfarina@chromium.org

Review URL: https://codereview.chromium.org/1411303008

Cr-Commit-Position: refs/heads/master@{#356999}

RenderPasses are very rare. Hash map is way overkill. We already have
a vector, just use that and delete the hash map.

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1413053004

Cr-Commit-Position: refs/heads/master@{#356998}

A webkit unit test will crash in chromium code if a scrollbar using
native theme is painted, because the required resources are not loaded
in webkit unit tests.

Synchronized painting would cause some unit tests previously didn't
crash to crash.

Use mocked scrollbar for these unit tests.

BUG=536999

Review URL: https://codereview.chromium.org/1413513009

Cr-Commit-Position: refs/heads/master@{#356997}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9a78ccb6..ad696d95

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1411183005

Cr-Commit-Position: refs/heads/master@{#356996}

This fixes the find bar view. I don't know what other, if any, UI
surfaces are affected.

Before this patch both the current and the MD findbar always use the
system theme, but this looks broken because the find bar is part of
the top browser Chrome. With this patch, the findbar will only use
the system theme if the whole browser is in GTK theme mode.

BUG=512443

Review URL: https://codereview.chromium.org/1427803004

Cr-Commit-Position: refs/heads/master@{#356995}

As of http://crrev.com/1374753004, ChromeOS is able to use the monotonic
clock and still have its trace event timestamps match timestamps from
ftrace.

BUG=541692

Review URL: https://codereview.chromium.org/1424323002

Cr-Commit-Position: refs/heads/master@{#356994}

This patch adds the dependencies that //components/crash that were
missing that was making `gn check` upset and, in at least one case,
causing us to actually miscompile things because the public_configs
were not being propagated from content properly.

R=rsesek@chromium.org, jam@chromium.org, pkotwicz@chromium.org
BUG=547635

Review URL: https://codereview.chromium.org/1423043002

Cr-Commit-Position: refs/heads/master@{#356993}

1. Only dequeue pending tasks when no other tasks are running.
2. Use the running tasks list to accept or reject a foreground task.

BUG=549305

Review URL: https://codereview.chromium.org/1419473005

Cr-Commit-Position: refs/heads/master@{#356992}

Review URL: https://codereview.chromium.org/1416673007

Cr-Commit-Position: refs/heads/master@{#356991}

When gathering savable resources from the whole page, each resource
could have come from a different frame and therefore could have had a
different referrer associated with it - back then it made sense to send
a vector of referrers (potentially a different one for each savable
resource).  Now (after crrev.com/1308113008) we gather savable resources
per frame and therefore can simplify the IPCs and send only a single
referrer for the whole frame.

Note that for the main frame, the browser already knows the referrer ...

  render_frame_host_impl->frame_tree_node()
                        ->navigator()
                        ->GetController()
                        ->GetLastCommittedEntry()
                        ->GetReferrer()

... but this CL keeps communicating the referrer over IPC, because 1) it
covers all the frames and 2) the renderer seems like a simpler, single,
race-free, more authoratitative source of the referrer information.

This CL is to some extent a reply to a CR feedback at
crrev.com/1413103003/#msg6 that pointed out general undesirability of
sending over IPC a struct-of-vectors (as opposed to a
vector-of-structs).

This CL improves upon crrev.com/10387090 which introduced sending of
referrer information during save-page-as operation, but initially kept
sending only default, rather than actual referrers.

BUG=526786

Review URL: https://codereview.chromium.org/1425013004

Cr-Commit-Position: refs/heads/master@{#356990}

This allows ::ScheduleEnforceMemoryPolicy() to be called on
a worker thread without a message loop.

BUG=549274
TEST=content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerScheduleEnforceMemoryPolicyTest.SetMemoryLimitOnSimpleThread

Review URL: https://codereview.chromium.org/1430743002

Cr-Commit-Position: refs/heads/master@{#356989}

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org, gab@chromium.org
BUG=548965

Review URL: https://codereview.chromium.org/1419223006

Cr-Commit-Position: refs/heads/master@{#356988}

BUG=none

Review URL: https://codereview.chromium.org/1412463006

Cr-Commit-Position: refs/heads/master@{#356987}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c75be34..8a3760f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Commits in this roll:
8a3760f benjaminwagner@google.com For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Review URL: https://codereview.chromium.org/1408993006

Cr-Commit-Position: refs/heads/master@{#356986}

Fix the glitch and add a test.

BUG=548273

Review URL: https://codereview.chromium.org/1422383003

Cr-Commit-Position: refs/heads/master@{#356985}

BUG=548912

Review URL: https://codereview.chromium.org/1421733004

Cr-Commit-Position: refs/heads/master@{#356984}

This fixes NinePatchPainter to do layout in physical pixels after the
change to use slimming-paint in the ui compositor. Instead of using
the matrix on the canvas (which won't be meaningful for scale), it uses
the gfx::Canvas::SaveAndUnscale() method to move into a physical space
and do layout there.

R=oshima, sky
BUG=539496

Review URL: https://codereview.chromium.org/1424983005

Cr-Commit-Position: refs/heads/master@{#356983}

This reverts https://codereview.chromium.org/1225393002.

Android Support design library is large and currently is only used in one place
where we already have an existing similar class. This will reduce our method
limit by 1409

BUG=272790

Review URL: https://codereview.chromium.org/1419553003

Cr-Commit-Position: refs/heads/master@{#356982}

Currently, the response preview of Network Panel uses CodeMirror for
contents less then ~100Kb and fallbacks to a simple DIV with
word-wrapped text otherwise. The DIV with word-wrapped text might be
very slow to render.

The fallback was implemented in crrev.com/14432002 to avoid text
truncation bug in codeMirror: crbug.com/168052. Nowadays, the bug does
not seem to be reproducible in CodeMirror any more, so it is safe to
use CodeMirror all the time.

BUG=519131
R=pfeldman

Review URL: https://codereview.chromium.org/1419813005

Cr-Commit-Position: refs/heads/master@{#356981}

Revert of [Telemetry] Enable screenshot taking on Mac (patchset #2 id:20001 of https://codereview.chromium.org/1415133005/ )

Reason for revert:
Broke telemetry_unittests on Mac: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/8449

Original issue's description:
> [Telemetry] Enable screenshot taking on Mac
>
> BUG=369490
>
> Committed: https://crrev.com/e887c296c741e723e6787ad4b684b65d3a59729d
> Cr-Commit-Position: refs/heads/master@{#356951}

TBR=eakuefner@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369490

Review URL: https://codereview.chromium.org/1427033004

Cr-Commit-Position: refs/heads/master@{#356980}

This is needed before we enable sync painting. Repaint when interest
rect changed sufficiently.

Also combine GraphicsLayer::paintIfNeeded() and GraphicsLayer::paint().
The former was needed because the caller needed to check the result to
determine if it's safe to commit the new paints. Now this is not needed.
Actually we always paint, and output CachedDisplayItemList when the
whole display item list is cached.

BUG=536999

Review URL: https://codereview.chromium.org/1428643004

Cr-Commit-Position: refs/heads/master@{#356979}

- MediaRouterDialogDelegate has a WeakPtr to MediaRouterAction, but it
it never set in the ctor. The SetAction() method appears to be never
called. As a result, the WeakPtr is always null. This patch sets action_
in the ctor. Changed expectations in test.

- MediaRouterActionUnitTest setup is incorrect. It should call
MediaRouterTest to have the kEnableMediaRouter switch activated.

- MediaRouterActionUnitTest should only be inlcuded if we are building
Media Router.

BUG=548456

Review URL: https://codereview.chromium.org/1417893005

Cr-Commit-Position: refs/heads/master@{#356978}

Adds support for loading and drawing a crushed sprite resource.
Animates the search provider icon using a crushed sprite sheet every time
on long press if the user has never opened the panel before and
once a day on tap.

BUG=529915

Review URL: https://codereview.chromium.org/1337703002

Cr-Commit-Position: refs/heads/master@{#356977}

BUG=532437

Review URL: https://codereview.chromium.org/1421973006

Cr-Commit-Position: refs/heads/master@{#356976}

BUG=510485

Review URL: https://codereview.chromium.org/1415803005

Cr-Commit-Position: refs/heads/master@{#356975}

Ran 50 times without fail.

BUG=315308

Review URL: https://codereview.chromium.org/1410163002

Cr-Commit-Position: refs/heads/master@{#356974}

It was deleted in the following CL:

https://codereview.chromium.org/1411063004/diff/300001/net/quic/crypto/quic_crypto_client_config.cc

R=asvitkine@chromium.org, rch@chromium.org
BUG=549278

Review URL: https://codereview.chromium.org/1408343007

Cr-Commit-Position: refs/heads/master@{#356973}

The AttachmentBroker can be accessed from any thread, so any modifications to
internal state should be guarded by a lock.

BUG=535711

Review URL: https://codereview.chromium.org/1405253010

Cr-Commit-Position: refs/heads/master@{#356972}

The current name makes it sound like it has something to do with:
- managed profiles
- the bubble you see when entering full screen
- definitely not the bubble you see when you click a location bar icon

The new name, LocationBarBubbleDelegateView, describes how it's used.

BUG=none

Review URL: https://codereview.chromium.org/1427873002

Cr-Commit-Position: refs/heads/master@{#356971}

Ran it 60+ times, didn't fail once.

BUG=315308

Review URL: https://codereview.chromium.org/1408003006

Cr-Commit-Position: refs/heads/master@{#356970}

xp-release/sizes/setup.exe/setup.exe: http://build.chromium.org/f/chromium/perf/xp-release/sizes/report.html?history=150&graph=setup.exe&rev=356955

TBR=aiolos@chromium.org
BUG=549329

Review URL: https://codereview.chromium.org/1427053002

Cr-Commit-Position: refs/heads/master@{#356969}

BrokerableAttachments are typically stored and passed around in a scoped_refptr.
There were several locations where they were being unnecessarily converted to a
raw pointer. This was probably responsible for a non-deterministic crash on GPU
bots (https://code.google.com/p/chromium/issues/detail?id=535711#c28), although
I haven't been able to reproduce the problem locally.

BUG=535711

Review URL: https://codereview.chromium.org/1414503009

Cr-Commit-Position: refs/heads/master@{#356968}

This makes a few visual adjustments to the icons that are added to the
home screen via "Add to home screen":
 - Icons aren't cropped. Previously icons were cropped by 1px, which
   caused circular icons to look broken.
 - We now add padding around the icon in accordance with the Material
   spec for icons [1]. We add padding such that the entire icon width
   with padding is 192 units, while the icon width without padding is
   176 units.
 - To minimize scaling artifacts, icons aren't resized to
   getLauncherLargeIconSize(). getLauncherLargeIconSize() is just a
   guess at the launcher icon size, and is often wrong -- the launcher
   can shows icons at any size it pleases. Instead of resizing the icon
   to the supposed launcher size and then having the launcher resize the
   icon again, we leave the icon at its original size and let the
   launcher do a single rescaling. Unless the icon is much too big; then
   we do scale it down.

[1] The Material spec for icons:
https://www.google.com/design/spec/style/icons.html#icons-product-icons

BUG=530329

Review URL: https://codereview.chromium.org/1421973005

Cr-Commit-Position: refs/heads/master@{#356967}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/389c6660..9a78ccb6

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1420283007

Cr-Commit-Position: refs/heads/master@{#356966}

This feature is only used to, in a very roundabout way, specify that we
want to use the GLImage texture target (if available) for the resource.
Make this more clear, by replacing CreateResourceWithTextureTarget with
CreateResourceWithImageTextureTarget, which does not take a target
argument.

Similarly add ResourcePool::CreateForImageTextureTarget as a way to
create resource pools that will have this behavior.

BUG=533677
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1422103003

Cr-Commit-Position: refs/heads/master@{#356965}

BUG=549314
TEST=none
TBR=samli

Review URL: https://codereview.chromium.org/1430773002 .

Cr-Commit-Position: refs/heads/master@{#356964}