- 30 Nov, 2018 40 commits
-
-
Giovanni Ortuño Urquidi authored
This reverts commit ff026011. Reason for revert: AddToHomescreen tests failing on Android CFI https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3851 JNI ERROR (app bug): expected jboolean (0/1) but got value of 255 as argument 2 to void org.chromium.chrome.browser.webapps.AddToHomescreenManager.onIconAvailable(android.graphics.Bitmap, boolean) Original change's description: >
👹 Add adaptable homescreen shortcuts for maskable icons. > > The Add to Homescreen feature will now consider "maskable" icons from > the web app manifest [1]. If a maskable icon is present and we are on > an Android O+ device, turn that "maskable" icon into an Android Adaptive > icon [2]. > > The icon is scaled to ensure that the safe zone is preserved [3]. > > [1]: https://w3c.github.io/manifest/#purpose-member > [2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive > [3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653 > > Bug: 904354 > Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443 > Reviewed-on: https://chromium-review.googlesource.com/c/1341998 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612218} TBR=yfriedman@chromium.org,peter@chromium.org,mgiuca@chromium.org,peconn@chromium.org,dominickn@chromium.org Change-Id: I2cccbcbd5fc01f68e1004516b470465db1e663ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904354 Reviewed-on: https://chromium-review.googlesource.com/c/1356166Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612513}
-
Giovanni Ortuño Urquidi authored
This reverts commit 1d979043. Reason for revert: SandboxMacTests failing on Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36825 [ RUN ] SandboxMacTest.FontLoadingTest [1000:779:1129/160013.776478:988116558481:WARNING:test_suite.cc(257)] Test launcher output path /b/s/w/itucGTyo/.org.chromium.Chromium.qx9Sed/test_results.xml exists. Not adding test launcher result printer. Nov 29 16:00:13 vm132-m1.golo.chromium.org content_unittests[1000] <Error>: SeatbeltExecServer: Failed to initialize sandbox: -1 line 163: subpaths must not end with a slash [1000:779:1129/160013.839716:988179793263:FATAL:sandbox_mac_unittest.mm(177)] Check failed: result.server->InitializeSandbox(). 0 content_unittests 0x000000010519dc1f base::debug::StackTrace::StackTrace(unsigned long) + 31 1 content_unittests 0x00000001050d871f logging::LogMessage::~LogMessage() + 223 2 content_unittests 0x000000010170d8b2 content::(anonymous namespace)::CheckCreateSeatbeltServer() + 562 3 content_unittests 0x000000010170e389 content::FontLoadingProcess() + 473 4 content_unittests 0x0000000104587138 base::TestSuite::Run() + 104 5 content_unittests 0x000000010459f43a base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 282 6 content_unittests 0x000000010459f2ea base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 154 7 content_unittests 0x00000001044df9df main + 191 8 libdyld.dylib 0x00007fff8f5845c9 start + 1 ../../content/browser/sandbox_mac_unittest.mm:90: Failure Expected equality of these values: 0 rv Which is: 1 Stack trace: 0 content_unittests 0x0000000102cbd93b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 content_unittests 0x0000000102cbd2f9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 content_unittests 0x000000010199ea19 content::(anonymous namespace)::SandboxMacTest::ExecuteWithParams(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, void (*)(sandbox::SeatbeltExecClient*)) + 1625 3 content_unittests 0x000000010199ca4c content::(anonymous namespace)::SandboxMacTest::ExecuteInRendererSandbox(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 172 4 content_unittests 0x000000010199db5e content::SandboxMacTest_FontLoadingTest_Test::TestBody() + 1278 [ FAILED ] SandboxMacTest.FontLoadingTest (286 ms) Original change's description: > macOS Sandbox: Port fontloading test to V2 sandbox. > > This removes all of the obsolete unit testing code from the V1 sandbox. > > Bug: 902597 > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 > Reviewed-on: https://chromium-review.googlesource.com/c/1327527 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612416} TBR=kerrnel@chromium.org,rsesek@chromium.org Change-Id: I4731044d228c3b21778334b1ef2693baa1818239 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902597 Reviewed-on: https://chromium-review.googlesource.com/c/1356165Reviewed-by:
-
bsheedy authored
Fixes an issue in the sizes script when converting from ChartJSON to HistogramSet. The data produced by the results collector does not contain the benchmark_name or format_version keys, which causes the conversion script to fail. Bug: 906685 Change-Id: I15258026651499ac2a7640958c7bd2d93a794a35 Reviewed-on: https://chromium-review.googlesource.com/c/1352395 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#612511}
-
Moe Ahmadi authored
- Creates a ARQuickLookCoordinator as the ARQuickLookTabHelperDelegate that presents a QLPreviewController in order to display USDZ format files. Bug: 908696 Change-Id: I7cee24392cd7133aa23127dd991b51694fabadfa Reviewed-on: https://chromium-review.googlesource.com/c/1353048 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612510}
-
Leo Zhang authored
This flag is used by enabling an experimental IME Mojo service to replace the existing IME framework, the project might last for a few quarters until we are confident to get rid of old system. Before that, we want to keep the fallback possibility for users Change-Id: I010a8d3b21c7ff9e7a8a706bf604a1e501518717 Reviewed-on: https://chromium-review.googlesource.com/c/1345789Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612509}
-
Esmael El-Moslimany authored
The position transitions cause a couple issues. 1. When the slider value is set after being retrieved asynchronously even if the retrieval is quick, the movement will transition from 0 to the retrieved value. This is a minor issue noted in https://crbug.com/896625. 2. Multiple arrow keyboard events, including repetition from holding down and arrow key, results in a delay in updating the position causing erratic movement of the knob. Bug: 910054 Change-Id: Ibc98638f1c9bda6531a8dea2648654e41a91e37f Reviewed-on: https://chromium-review.googlesource.com/c/1355760 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612508}
-
rajendrant authored
This CL creates a bool in WebSettings to enable lazyloading of frames and images. The bool is populated by WebContentsDelegate which offline pages listens to and disables lazy loading. Bug: 701884 Change-Id: I1ad1776adf3f9c7e6a8a3a68507aa9dc419e3955 Reviewed-on: https://chromium-review.googlesource.com/c/1352817 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#612507}
-
rbpotter authored
When the user changes focus between custom margins inputs, this causes the preview area to scroll, which should not occur since the iframe containing the plugin is in a fixed location. Work around this issue in the same way as in the old UI: manually set the offsets of the preview area element to 0. This workaround has the downside that the newly focused input is not visible to the user, and therefore key events cause another scroll, which is not addressed by the workaround. To address this issue, after setting the offsets, inform the plugin that it should scroll to make the input visible. Bug: 901777 Change-Id: If310b84229fd53ffaee449699b8ac8a13806101c Reviewed-on: https://chromium-review.googlesource.com/c/1351950Reviewed-by:
-
Alexei Filippov authored
BUG=901165 Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698 Reviewed-on: https://chromium-review.googlesource.com/c/1352850Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#612505}
-
Donn Denman authored
Changes the title of the menu item from "Sneak peek" to "*New* Sneak peek" to help draw attention to the new choice. BUG=894619 Change-Id: I1446b191e8891f17452762b5dda4d6203c332510 Reviewed-on: https://chromium-review.googlesource.com/c/1355252Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#612504}
-
Ken Rockot authored
Replaces usage of the deprecated ServiceContext with ServiceBinding. Also adds support for a C++ ServiceMain which is passed a proper ServiceRequest instead of a raw Mojo handle. This makes writing ServiceMain slightly less awkward. Also cleans up service.gni using forward_variables_from, which was unsupported when it was originally written. Finally, removes the unused RegisterInProcessServices method from BrowserProcessPlatformPart/Base. Bug: 891780 Change-Id: I99734414586b6b3a355fa22afa85930249f8e62b Reviewed-on: https://chromium-review.googlesource.com/c/1355336 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612503}
-
Vlad Tsyrklevich authored
The custom version of bits::CountTrailingZeroBits64 is deprecated by upstream support from https://crrev.com/c/1321253 Change-Id: Id091afc2c5bd2d8ba8969ec12248b4c89d4d9ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1355248 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612502}
-
Findit authored
This reverts commit faf5cdcc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 612469 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmFmNWNkY2M4ZDJkODkwMDAzMzY5MmZhODYzNDAzYTE2ZTkwOTBjOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16665 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls Original change's description: > Reland "[Accessibility] Volume slider reads out level in percentages." > > This is a reland of cf071719 > > Original change's description: > > [Accessibility] Volume slider reads out level in percentages. > > > > This CL makes it such that the volume level is read out as a percentage > > in aria. This CL also amplifies how the accessibility information is > > given to aria, by setting attributes instead of explicitly creating > > accessibility nodes. > > > > Bug: 905024 > > Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > > Reviewed-on: https://chromium-review.googlesource.com/c/1337298 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612160} > > TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org > > Bug: 905024 > Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1356007 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612469} Change-Id: Icc1f84da3c66189f0d3b30108e0ab4330d4061f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905024, 910442 Reviewed-on: https://chromium-review.googlesource.com/c/1356137 Cr-Commit-Position: refs/heads/master@{#612501}
-
Weidong Guo authored
After powerwash and sign in, the internal app item and page break item's positions may be out of sync because model updater is not set. Then the user has to wait til next sign in to get the most up to date position. During the first sign in, the user may reorder or install new apps which triggers single item page after next sign in. Changes: Set model updater for internal app and page break item. Bug: 873853 Change-Id: I492234ceaf107deffdba056856a4f0a3c5df59e0 Reviewed-on: https://chromium-review.googlesource.com/c/1355178Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612500}
-
Eric Roman authored
Bug: 721403 Change-Id: I879f2d2eb8a903bd59b459cb3267c890308da60d Reviewed-on: https://chromium-review.googlesource.com/c/1356220Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612499}
-
Miguel Casas authored
This CL cleans up and activates |decode_using_client_picture_buffers_| after recent power consumption measurements done by the Intel folks reveal that there should be no regression, and also because skipping the Vpp has a huge impact in memory consumption since Va doesn't need to allocate ~13/14 Buffer Objects inside (see crbug.com/909926). Bug: 909926, 822346 Change-Id: Ie8d6b41521f5d8ee62568f9674ae071a67c290bf Reviewed-on: https://chromium-review.googlesource.com/c/1356019Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#612498}
-
Sam McNally authored
Bug: 909056 Change-Id: I04b2180f58d86db40e8775015f44158916c7a157 Reviewed-on: https://chromium-review.googlesource.com/c/1351981 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612497}
-
Daniel Rubery authored
Add a field to DownloadFileType that determines the type of content inspection we should do (treating it as a ZIP,DMG,RAR, or none) This allows us to more easily configure which files should be treated as archives. Bug: 628796 Change-Id: I8b02f3be316df23db9593cdda230afef5d825da2 Reviewed-on: https://chromium-review.googlesource.com/c/1352849 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#612496}
-
Alex Moshchuk authored
Currently, SiteInstance::IsSameWebSite() is static and will need to be modified to support dynamic isolated origins. Those origins will apply only to future BrowsingInstances, meaning the answer to IsSameWebSite will depend on which frame/SiteInstance is asking this question. This CL replaces this method with a non-static SiteInstance::IsSameSiteWithURL method. This will ensure that the internal implementation will be able to provide sufficient context (i.e., BrowsingInstance info) in the future, without having to expose that context outside of content/. Note that the content-internal version of this call, SiteInstanceImpl::IsSameWebSite, stays as-is for now. The only two non-test uses of this were in NaCl code. They were checking whether the current SiteInstance's site URL is same-site with the URL of the NaCl file to be loaded, with both URLs expected to be extension URLs. There should be no behavior change in these, as the underlying implementation doesn't change. A few tests are also refactored to either avoid using IsSameWebSite entirely, or, for tests inside content/, to use the internal version of IsSameWebSite. Bug: 905513 Change-Id: Ia2957bb1ec7a16de8c3d18ef167149f1f5a08066 Reviewed-on: https://chromium-review.googlesource.com/c/1352856Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612495}
-
Sergey Ulanov authored
This will allow to reuse the class in //webrunner when starting context process. Bug: 861853 Change-Id: I499850a7ba8df4b73e5f71b6a61568a5cfca1e6b Reviewed-on: https://chromium-review.googlesource.com/c/1355764Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612494}
-
Katie D authored
In Chrome OS and Android, the TTS platform implementation needs to stay in chrome. Bug: 517317 Change-Id: I09858ce1edc412dd5d0d53abc3fab645fece6a8a Reviewed-on: https://chromium-review.googlesource.com/c/1352055Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#612493}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74c126845dcd..0de9e8166ee4 git log 74c126845dcd..0de9e8166ee4 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 derat@chromium.org cros_uprevchrome: Fix cross-site CQ-DEPEND links. 2018-11-30 dburger@chromium.org Remove waterfall parameter from InsertBuild method Created with: gclient setdep -r src/third_party/chromite@0de9e8166ee4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ife933160984e095875cdf9a1b41e1ad34a95310c Reviewed-on: https://chromium-review.googlesource.com/c/1355906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612492}
-
Joey Arhar authored
This is a replacement for the fix made in https://chromium-review.googlesource.com/c/chromium/src/+/1350170 which uses the same-origin mode instead of bypassing service workers in order to make sure changes made by the service worker get into devtools properly. Bug: 823392 Change-Id: I7773a0281d52ebeddc1aa3b9facb7353f7fd1dcc Reviewed-on: https://chromium-review.googlesource.com/c/1353991 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612491}
-
Becca Hughes authored
This is a reland of 0475617f Binary-Size: Adding duplicate classes that will be removed in https://crrev.com/c/1241554 TBR=mlamouri@chromium.org,tedchoc@chromium.org Original change's description: > [Media Session] [2/4] Move Metadata to service > > This CL moves any existing uses in Android of MediaMetadata > to the new version in the media_session service. > > BUG=875004 > > Binary-Size: Adding duplicate classes that will be removed > in https://crrev.com/c/1241554 > > Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 > Reviewed-on: https://chromium-review.googlesource.com/c/1241466 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605498} Bug: 875004 Change-Id: I4689ac36b9dcf6b0582d4789016e238811b498e2 Reviewed-on: https://chromium-review.googlesource.com/c/1318809Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612490}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ee85992c5c61..63d69d7792c1 git log ee85992c5c61..63d69d7792c1 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 charliea@chromium.org Fix bug where disabling stories on N5 also disabled them on N5X Created with: gclient setdep -r src/third_party/catapult@63d69d7792c1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894906 TBR=sullivan@chromium.org Change-Id: I82daa446bb0740864fe1e0e433c9c72e680ddb28 Reviewed-on: https://chromium-review.googlesource.com/c/1355560Reviewed-by:
-
Clark DuVall authored
These mostly fall into two categories: 1. tests trying to crash network service 2. tests using NetworkServiceTest (which isn't available with in-process NS) Bug: 908993 Change-Id: I91d518b260f79ef263a58fb2a3a24e28e7c96210 Reviewed-on: https://chromium-review.googlesource.com/c/1355615Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I98dc447ef5c8a58fc2e8256586d2dbb32cd88f70 Reviewed-on: https://chromium-review.googlesource.com/c/1355905Reviewed-by:
-
Scott Little authored
This CL records VisibleBeforeLoaded histograms when lazily loaded images become visible before they've finished loading. This metric is useful to look at alongside the existing VisibleLoadTime metrics, since the VisibleLoadTime metrics aren't recorded until the image finishes loading, which can lead to misleading data if the user navigates away or closes the tab before the image finishes loading, particularly on slow networks. TBR=mpearson@chromium.org Bug: 910347 Change-Id: I349eb69d173420ada94e3febeaeb4e369c998e07 Reviewed-on: https://chromium-review.googlesource.com/c/1356009 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612486}
-
Peter Kotwicz authored
This CL makes FirstRunFlowSequencer#launch() shorter by extracting the logic to check whether the generic FRE is active into a separate function checkIsGenericFreActive(). This CL also changes maybeSwitchToTabbedMode() to only return whether the FRE should use tabbed mode and to not modify the FRE launch intent. This CL is in preparation to adding WebAPK-related complexity to FirstRunFlowSequencer#launch() BUG=None Change-Id: If3605de61905edde800129f2d5e36c572432566f Reviewed-on: https://chromium-review.googlesource.com/c/1355327 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612485}
-
Giovanni Ortuño Urquidi authored
This reverts commit d20781e1. Reason for revert: Causes compile failure in Google Chrome ChromeOS https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59164 In file included from ../../chromeos/services/assistant/assistant_manager_service_impl.cc:5: ../../chromeos/services/assistant/assistant_manager_service_impl.h:142:31: error: no type named 'AndroidAppInfo' in namespace 'chromeos::assistant::action'; did you mean 'mojom::AndroidAppInfo'? void OnOpenAndroidApp(const action::AndroidAppInfo& app_info, ^~~~~~~~~~~~~~~~~~~~~~ mojom::AndroidAppInfo gen/chromeos/services/assistant/public/mojom/assistant.mojom.h:1276:8: note: 'mojom::AndroidAppInfo' declared here class AndroidAppInfo { ^ Original change's description: > Handle Open/Verify android apps for Assistant > > Bug: b/117793081 > Test: Manual Test > Change-Id: If747d3317cb163715ff907839203e0c0eee57a1c > Reviewed-on: https://chromium-review.googlesource.com/c/1352341 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612448} TBR=sammc@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,llin@chromium.org Change-Id: If0edc6853dfdce343f6f52edd6bc059f8c7ec1aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/117793081 Reviewed-on: https://chromium-review.googlesource.com/c/1356164Reviewed-by:
-
agrieve authored
This reverts commit 8dc97871. Reason for revert: Broke compile for android-rel https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928477879975314896/+/steps/compile/0/stdout Original change's description: > Android: Using R8 instead of ProGuard for public targets > > Bug: 908988 > Change-Id: Iaaee8124c56945a8769e6d4ff2a0859ef39c1aea > Reviewed-on: https://chromium-review.googlesource.com/c/1355424 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612439} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I6cdf8fd95b254abe733426f9e38aa1446661f9e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988 Reviewed-on: https://chromium-review.googlesource.com/c/1356229Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612483}
-
Varun Khaneja authored
R=drubery Bug: 867518,890484, 887186 Change-Id: I1e5a8c342deef6737f6c69d99ede839028d9aae9 Reviewed-on: https://chromium-review.googlesource.com/c/1356124 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612482}
-
Paul Irish authored
Bug: 772558 Change-Id: Ie1ef89f7a189687e600e5e22d376c53dac242079 Reviewed-on: https://chromium-review.googlesource.com/c/1355176Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: I70453c9a11b2d2cab1fa0355647b333508ba700c Reviewed-on: https://chromium-review.googlesource.com/c/1351982 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
chcunningham authored
Adds flags for configuring the size of the rolling window and the number of days to keep stats before expiring. Bug: 910404 Test: new unit tests Change-Id: I8a88a81154c710a1cc9b029e2b8ef8af61d945e0 Reviewed-on: https://chromium-review.googlesource.com/c/1355996Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#612479}
-
Alan Cutter authored
This reverts commit 6d4576ad. Reason for revert: On second thought this is too risky to land on branch day. Also I want to land the new binary separately from the shortcuts pointing to it so we can make sure it deploys properly before irreversibly depending on it (it's difficult to update shortcuts). Original change's description: > Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows > > This change adds a new executable to Windows called chrome_proxy.exe which > opens chrome.exe with all arguments forwarded. > > The purpose of the executable is for bookmark app shortcuts to target so > they don't pick up the chrome.VisualElementsManifest.xml file when pinned > to the Windows 10 start menu. This fixes a bug where pinned bookmark app > shortcuts all use the Chrome logo instead of their own. > > Bug: 732357 > Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1335075 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612477} TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org Change-Id: If327a489864c0bd6066ec13b3f9421f3be57636b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732357 Reviewed-on: https://chromium-review.googlesource.com/c/1356163Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612478}
-
Alan Cutter authored
This change adds a new executable to Windows called chrome_proxy.exe which opens chrome.exe with all arguments forwarded. The purpose of the executable is for bookmark app shortcuts to target so they don't pick up the chrome.VisualElementsManifest.xml file when pinned to the Windows 10 start menu. This fixes a bug where pinned bookmark app shortcuts all use the Chrome logo instead of their own. Bug: 732357 Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6 Reviewed-on: https://chromium-review.googlesource.com/c/1335075Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612477}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/471358f39a6a..b51eb09fb5bb git log 471358f39a6a..b51eb09fb5bb --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: Allow bindings to compute stage 2018-11-29 syoussefi@chromium.org Vulkan: Uber-shader generated code optimization 2018-11-29 jmadill@chromium.org Pass Context to setLabel. 2018-11-29 jmadill@chromium.org Clear draw attachments as a dirty object. 2018-11-29 cnorthrop@google.com Add temporary icon for ANGLE apk 2018-11-29 jmadill@chromium.org Use packed enum for DrawElementsType. Created with: gclient setdep -r src/third_party/angle@b51eb09fb5bb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I939db58664276d98db325bcfbe51cc161b43a941 Reviewed-on: https://chromium-review.googlesource.com/c/1356000Reviewed-by:
-
sczs authored
After the recent Infobar refactoring I think I have enough knowledge to become an Infobar owner. This will also help on the implementation of the new design. Doc: go/bling-infobar-refactoring CLs: https://crbug.com/892376 Bug: 892376 Change-Id: Idaf4bc27e8ab2f490ad5d93268331616a35a0b71 Reviewed-on: https://chromium-review.googlesource.com/c/1354560Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#612475}
-
Andreas Butler authored
Implementing an explicit commit function for the IndexedDB Transaction API. The addition of this API allows developers to preempt IndexedDB's autocommit functionality by sending their own explicit commit signal. Explainer: https://andreas-butler.github.io/idb-transaction-commit/EXPLAINER Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=898257 Change-Id: I5e8bdc697052139d014757408d9a7f2b6367655b Reviewed-on: https://chromium-review.googlesource.com/c/1300055 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#612474}
-
