GitLab

Bug: 738611
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2a3058d0df03faba6b4975672ecfc3557c05d73a
Reviewed-on: https://chromium-review.googlesource.com/1117863
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571301}

Plumb views::WidgetDelegate::ShouldShowWindowTitle to the ws host frame.
Move prop to aura/client for MusClient and DesktopWindowTreeHostMus.
Make the KSV's delegate return false for ShouldShowWindowTitle.

Based on Scott's CL (PS1 matches crrev.com/c/1112587 PS4)

BUG=854324
TEST=covered by tests; No title in Chrome OS KSV (Ctrl-Alt-/)

Change-Id: I190c8245edbb310a1f03f6ec6ad318b325be04bc
Reviewed-on: https://chromium-review.googlesource.com/1113938
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571300}

Change-Id: I1178f3f84f12b9d9d105f846ce732764aad5952f
Reviewed-on: https://chromium-review.googlesource.com/1117750
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571299}

TBR=carlosk@chromium.org
NOTRY=true

Bug: 857520
Change-Id: I2326fc9bbce2224b1c8123e6a91125905b4d5235
Reviewed-on: https://chromium-review.googlesource.com/1119350Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571298}

This reverts commit 4eb39392.

Reason for revert: Testing complete.  All crashes I looked at showed
non-zero values at address zero.  Pages are not all zeros so
the problem isn't a whole page being cleared.

Original change's description:
> Check theory that entire mmap page is getting zeroed.
>
> This is a temporary change that will be reverted once crashes can be
> analyzed to confirm the working theory.
>
> Bug: 836875
> Change-Id: Iaeffbd6c78b604af66b33991392990d71648d4a9
> Reviewed-on: https://chromium-review.googlesource.com/1050071
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557159}

TBR=asvitkine@chromium.org,bcwhite@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836875
Change-Id: If65d667029c8f3a1f82dec35c878a32dc96b8343
Reviewed-on: https://chromium-review.googlesource.com/1118826
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571297}

Added "Unexpectedly flaky" filter.
Color unexpected results in red/green for greater visibility.
Added "?" shortcut that blinks image failure differences.
Added "p" shortcut that prints current expectation to console.

Bug: 726520
Change-Id: I14be5b3ec2b86a113dff0e0087ac57332519c108
Reviewed-on: https://chromium-review.googlesource.com/1118004
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571296}

When a remote-bound WebRTC event log is successfully started,
its ID is sent to the calling JS code.

This ID is incorporated into the log's filename, allowing it to
later be retrieved, e.g. if a bug report is submitted.

Bug: 775415, 829748
Change-Id: Ie3d68b7b9cf6ee94eb468135ad5e25caf3204603
Reviewed-on: https://chromium-review.googlesource.com/1116958
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571295}

This reverts commit cb125363.

Reason for revert: crbug.com/857447

Original change's description:
> Fix some math in Android tab_layer.cc causing tab cropping
> 
> Currently, even if Stack#getMaxTabHeight() returns the maximum possible value
> (beyond which it's clamped to that value), we crop the tabs in the Android tab
> switcher somewhat when we scale them down. The overlapping tab switcher uses 90%
> scale, where this is not very apparent. It is apparent, however, in the
> nonoverlapping tab switcher, where we use 60% scale if there's more than one tab
> (we use 80% if there's only one).
> 
> The root cause here is there's some odd/incorrect math that's causing certain
> sizes to not scale properly with the tab scale, so we actually end up cropping
> the tab too high and drawing the bottom border too high when content_scale < 1.
> After fixing that, it turns out that there's a small gap that appears between
> the tab thumbnail and the bottom border. I resolved this by raising the bottom
> border up by an amount equal to its own height. So there's still some cropping
> on the bottom of the tab with this CL, but it's an extremely small amount.
> 
> Bug: 849401
> Change-Id: I06c20e4a881e2d7a5b38bfc9e95ef8522c7c3921
> Reviewed-on: https://chromium-review.googlesource.com/1115777
> Commit-Queue: Ryan Landay <rlanday@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570993}

TBR=dtrainor@chromium.org,rlanday@chromium.org

Change-Id: Ia4537e0d69a4e40d35751854cfc33cb428c9ac4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849401
Reviewed-on: https://chromium-review.googlesource.com/1119307Reviewed-by: Ryan Landay <rlanday@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571294}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/37c0f8c6bbd2..66c52be1969a


git log 37c0f8c6bbd2..66c52be1969a --date=short --no-merges --format='%ad %ae %s'
2018-06-28 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@66c52be1969a

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I65f8ad06ee02ba38f63de8df7d16eddf4a26afa0
Reviewed-on: https://chromium-review.googlesource.com/1118810Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571293}

It can be inlined into ScrollbarTheme directly.

Change-Id: I9b4eeaa8d1650811ce0759f5f89e1a665d7709d4
Reviewed-on: https://chromium-review.googlesource.com/1114459Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571292}

Placed the util in ash::assistant::util.
Follow up CLs will handle the deep links.

Bug: b:110433859
Change-Id: Ie554bd1a8c3d3acfab6d73697b2bbee9522b4c35
Reviewed-on: https://chromium-review.googlesource.com/1115506Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#571291}

This reverts commit 7baa2dc1.

Reason for revert: test failures (crbug.com/858826) that i'd like to understand better.

Original change's description:
> Convert various gpu video decoders to use AbstractTexture.
> 
> Previously, VDAVideoDecoder, MCVD and D3D11VideoDecoder used
> the validating GLES decoder's TextureRef (possibly indirectly, via
> GLES2DecoderHelper and CommandBufferHelper) to retain textures.
> 
> This CL moves them all over to use AbstractTexture, in preparation
> for supporting the passthrough GLES decoder.
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I13985223443b8e0897c1508f052d0f35d77746fe
> Reviewed-on: https://chromium-review.googlesource.com/1091649
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571223}

TBR=sandersd@chromium.org,liberato@chromium.org,piman@chromium.org

Change-Id: I0fcde15d436de04320da1bc6fdcf9fb9b0eafd42
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1119306Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571290}

Bug: 857038
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4833cfabc4b7981ab99c787a9c82e0a6b1150d1a
Reviewed-on: https://chromium-review.googlesource.com/1119158Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571289}

With LUCI migration instead of several variable builders, Findit has a
single variable builder with a few beefy machines.

It is important that goma runs fast on these mostly 32 core machines.

R=thakis,tikuta,stgao

Bug: 857284
Change-Id: Ie74b323f3829f510fcae76994076800fcd2f919d
Reviewed-on: https://chromium-review.googlesource.com/1117882Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571288}

Using double to represent timestamps and time ranges is error prone
and the units used are unclear.

Bug: 763980
Change-Id: I80ff8c1f0eb8d575e00b0edbce1dd8bbaec0ca7e
Reviewed-on: https://chromium-review.googlesource.com/1112566
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571287}

On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.

Instead, we should keep the slice info when resume with an error.

Bug: 837128
Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
Reviewed-on: https://chromium-review.googlesource.com/1112754Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571286}

This reverts commit c618b6e7.

Reason for revert: Revert 2 of 2 - FindIt flagged this CL with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); had to revert https://chromium-review.googlesource.com/1105568 first to be able to revert this one.

Original change's description:
> Add skeleton of Demo Mode setup UI.
> 
> Mocks:
> https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z
> 
> Bug: 827376
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
> Reviewed-on: https://chromium-review.googlesource.com/1100237
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571137}

TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org

Change-Id: I49ab0b951ced812d56f5fc14e953da854f085b50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827376, 858817
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119305Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571285}

Migrate the LayerTreeHostForPaintArtifactTest to platform/testing/
as LayerTreeHostEmbedder, and use it in platform/graphics/ tests
that want to construct a cc::LayerTreeHost but currently do so through
WebLayerTreeViewImplForTesting.

Also construct and use a cc::AnimationHost directly in the
platform/animation/ tests instead of a WebLayerTreeViewImplForTesting.

As the last user of it, we also remove the WebLayerTreeViewImplForTesting
class, bringing us closer to being able to remove the WebLayerTreeView
interface.

R=chrishtr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia92b0d6227575d1c8733a336c80e4a3aebb75001
Reviewed-on: https://chromium-review.googlesource.com/1117610Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571284}

This reverts commit 1f7e073e.

Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one.

Original change's description:
> Implement content of progress and error dialogs according to mocks.
> 
> Bug: 827376
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828
> Reviewed-on: https://chromium-review.googlesource.com/1105568
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571202}

TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org

Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827376, 858817
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119267Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571283}

Unlike PostTask from IO thread to compositor thread in Chrome IPC, mojo
polls for messages on the compositor thread which means it can dequeue a
large number of begin frame messages after the compositor thread has
been busy for some time. All but the last begin frame cancels the
previous begin frame, and is essentially a nop, but it still ticks
animations. When a page has a large number of animations each begin
frame can take a long time and push out other tasks such as tile manager
callbacks stalling the pipeline.

Throttling the begin frames in viz doesn't fully solve the problem
because we have to allow at least two begin frames in flight for
pipelining, and so the client can still process two begin frames back to
back.

Post a task to issue the begin frame to the source and its observers.
The task is reset on every begin frame mojo message so only the last
message is propagated to the source.

TEST=AsyncLayerTreeFrameSinkTest.MultipleBeginFrames
R=danakj
BUG=782002

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie98930a3078dde5ff99b42148596cf564c079220
Reviewed-on: https://chromium-review.googlesource.com/1111474
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571282}

This reverts commit 7c777876.

Reason for revert: Due to http://crbug/853780, this code is no longer used.Feature flag changes are not reverted since they will be needed later.

Original change's description:
> Return fallback colors for MV tiles with missing or small icons
>
> Fallback style (background and text colors) will be returned for tiles with missing or small icons (i.e. where only a 1x icon is available when 2x is needed). This will be used to display a fallback monogram in the frontend.
>
> Bug: 837798
> Change-Id: I9e80d763085ea5b095787f83e5d1e38b801c83eb
> Reviewed-on: https://chromium-review.googlesource.com/1096670
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567402}

TBR=thakis@chromium.org,treib@chromium.org,kristipark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837798
Change-Id: I1101c99e3dfde87f77d0111ac52c2dd2f90b37d4
Reviewed-on: https://chromium-review.googlesource.com/1117500
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571281}

Fix bug where MobileStartup.ToolbarFirstDrawTime.<activity name> and
MobileStartup.ToolbarFirstFocusTime.<activity name> were being double
reported.

Also rename aforementioned histograms to
MobileStartup.ToolbarFirstDrawTime2.<activity name> and
MobileStartup.ToolbarFirstFocusTime2.<activity name> respectively after
the bug fix.

Bug: 857508
Change-Id: I32f401a0a63df37f6fad2f781cb5e6598abb4a34
Reviewed-on: https://chromium-review.googlesource.com/1118749Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571280}

TBR=fserb@chromium.org

Bug: 857576
Change-Id: Ie09bb209328a8fe54d23e8d069b9fd744bbc9cfa
Reviewed-on: https://chromium-review.googlesource.com/1119159Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571279}

https://chromium.googlesource.com/angle/angle.git/+log/dc66ef9dc48b..fa5d84be4145


git log dc66ef9dc48b..fa5d84be4145 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 lucferron@chromium.org Vulkan: Fix offset handling for vertex buffers
2018-06-28 geofflang@chromium.org Vulkan: Refactor config generation out of platform specific code.
2018-06-28 jmadill@chromium.org Vulkan: Split tree ops into separate files.
2018-06-28 geofflang@chromium.org Update dEQP EGL expectations for Vulkan on Windows.
2018-06-28 courtneygo@google.com Emulate eglSwapBuffersWithDamageKHR when needed
2018-06-28 jmadill@chromium.org Vulkan: Roll glslang (June 2018).
2018-06-28 lucferron@chromium.org Vulkan: Framebuffer blit support for depth/stencil cases
2018-06-28 jmadill@chromium.org Vulkan: Work around unused sampler validation.


Created with:
  gclient setdep -r src/third_party/angle@fa5d84be4145

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Id1d292ce00eb39c3c3e7984ed26eff194cb92b59
Reviewed-on: https://chromium-review.googlesource.com/1118812Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571278}

This reverts commit cf42dd28.

Reason for revert: Due to http://crbug/853780, this code is no longer used.

Original change's description:
> Add fallback icon support to MV tiles
> 
> Tiles with missing/small favicons will display fallback icons instead, which consists of a colored circle and the first letter of the tile title. The fallback color will either be gray for missing favicons or the dominant color of the small favicon.
> 
> This change depends on https://crrev.com/c/1096670.
> 
> Screenshot: https://screenshot.googleplex.com/dbu8dxk97sX.png
> 
> Bug: 837798
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Ie6ddf538396bcf8fbfd11cb9e9f0bad075301edd
> Reviewed-on: https://chromium-review.googlesource.com/1096680
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567493}

TBR=treib@chromium.org,estark@chromium.org,kristipark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837798
Change-Id: I3631acae23acde679ad436832aea623f3b4e74ba
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1117802
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571277}

Zucchini makes the assumption that a valid DEX file has code items.
However, this contraint was not applied to whether the DEX file
contained valid and parsable code. As a result when attempting to find
references for within these code items, which weren't successfully
parsed, Zucchini would crash.

The solution is to impose a requirement that at least one code item was
parsed to create a disassembler.

Found during fuzzing of DEX files in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1117123

Change-Id: I76fcbb9267099a7fe3d6eb61c345ffbfaf772fff
Reviewed-on: https://chromium-review.googlesource.com/1118851
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571276}

This is a rename-only change to make the review easier, namely
  kPersistentReleaseMessage -> kPersitentUsageRecord
as kPersistentReleaseMessage was never used.

Note that 'persistent-release-message' was removed from the EME
spec and the blink code, but never removed from CdmSessionType.

See Bug for details on the motivation of the change.

Bug: 856925
Test: None
Change-Id: I245cb8cce14e9d6a02bf75c69eafe061a429010d
Reviewed-on: https://chromium-review.googlesource.com/1117137Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571275}

Adds ProcessFilterConfig part to TraceConfig. The functionality
allows clients to whitelist processes that need to record traces.

It is going to be used by DevTools to limit the trace collection
to inspected processes. It will greatly reduce overhead of performance
recording, especially when it is being run in a browser having lots
of tabs open.

BUG=849887

Change-Id: I6395170509cd9b2ff688ee675a768393d0e95c8a
Reviewed-on: https://chromium-review.googlesource.com/1087947Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571274}

This reverts commit 0127f2eb.

Reason for revert: Failing test bot https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3661

Original change's description:
> [Mac] Get Suggestions from Whole Text and Current Selection
> 
> Currently, the SuggestedTextTouchBarController generates text
> suggestions based only text being selected and doesn't take any
> surrounding text into account. The goal is to generate text
> suggestions from all the text present in the textfield and the
> current cursor position, which results in behavior more similar to
> Safari's text suggestions.
> 
> First, WebContents::DidChangeTextSelection() and
> WebContentsObserver::DidChangeTextSelection() were modified to pass in
> the whole text in the textfield and the current selection range
> instead of the selected text.
> 
> The method requestSuggestionsForText: was modified to
> requestSuggestionsForText:inRange: so that it may receive the full
> text in the textfield along with the range of the current selection.
> 
> The WebContentsTextObserver was edited to also observe when a
> webpage finishes loading. This way, the controller can check whether
> the cursor is in a textfield before the text selection changes. This
> is necessary for websites in which a textfield is autofocused.
> This currently does not account for text that may be in the
> autofocused textfield, which will be addressed in a later CL.
> 
> Bug: 717553
> Change-Id: I3d56d7e590ba11c9a6c1c2e55f5bf1bb1b398985
> Reviewed-on: https://chromium-review.googlesource.com/1101962
> Commit-Queue: Tessa Nijssen <tnijssen@google.com>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571208}

TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com

Change-Id: Iab7f11ad32948d911bd23f27bbb5cf48721cff45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717553
Reviewed-on: https://chromium-review.googlesource.com/1119265Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571273}

We could have different encryption scheme support when using hardware
secure codecs. For example, when not using hardware secure codecs, we
support both "cenc" and "cbcs", but when using hardware secure codecs,
we may only support "cenc".

This CL updates KeySystemProperties::IsEncryptionSchemeSupported() and
KeySystemConfigSelector so that we can differentiate encryption schemes
supported in normal mode and in hardware secure mode.

WidevineKeySystemProperties is also updated to take
"hw_secure_encryption_schemes" returned by KeySystemSupport.

TBR=slan@chromium.org

Bug: 853261
Test: Added new test cases
Change-Id: I3ca9eba3e01adb5395a700969d2f985765d2544d
Reviewed-on: https://chromium-review.googlesource.com/1116426Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571272}

Bad merge job from refactored //chrome equivalent put
wrong condition here.  Causing crash on chromecast
chromevox.

Bug: 110944578
Test: Manual verification

Change-Id: Ibfd228dce524ce9498d97d1cedfe36ca3c698321
Reviewed-on: https://chromium-review.googlesource.com/1119071Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571271}

This lets us show the popup in VR.

+ UMA log when user tries to open certificate and whats more links on
popup while in VR.

+ Hide modal dialogs in VR when exit prompt is shown. Otherwise, the
exit prompt will be on top of the modal dialog.

+ Add support for dialogs to the VR testapp.

Bug: 828573
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
Change-Id: I02e4381a914aff867abae33739aa6427ec1d9796
Reviewed-on: https://chromium-review.googlesource.com/984954
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571270}

Move key_idle_power_cases.py into rendering folder and refactor classes
to inherit from RenderingStory. Since this page set uses
android_screen_restoration_shared_state, modify rendering_shared_state
to behave in the same manner

Bug: 849392
Change-Id: I458523224946ddaec24f57c8d310e863088aa5a6
Reviewed-on: https://chromium-review.googlesource.com/1117576
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571269}

Using wpt-import in Chromium 7baa2dc1.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20302

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: Ic647a2d7bcfa9e4e663d09a167d1757901933352
Reviewed-on: https://chromium-review.googlesource.com/1119090
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571268}

Also added background that displays on hover, and tweaked the sidebar so its
transparency effect does not show the scrim.

https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-06-28/

Bug: 847599
Change-Id: I7c9b404cf4b6a468c297a4b147b41d47e4998f7a
Reviewed-on: https://chromium-review.googlesource.com/1119108
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571267}

Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/share

Continuation of work in bug 646094.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug: 846456
Change-Id: Ib4c6260e49b28bc78ec06059d3a15a2937d2f313
Reviewed-on: https://chromium-review.googlesource.com/1096008Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#571266}

Refine strings for safe browsing extended reporting toggle in settings.
Also add screenshot hashes to assist translation.

Bug: 856270
Change-Id: I5ce9940861c9ff4ea7167fc1d9f9140c1e42cb1c
Reviewed-on: https://chromium-review.googlesource.com/1117447Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571265}

We convert from rotation matrix to quaternion, but the calculation
wasn't stable.  It was mostly correct, but would occasionally give
NaN or other invalid values when w was near zero.

Rather than trying to correct the math, this change converts to using
common helpers.

BUG=852959

Change-Id: Ieecac34c0d7dd8d4abf550f1a93df017644237ef
Reviewed-on: https://chromium-review.googlesource.com/1117869Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571264}

Sometimes publishing an offline page results in the CANCELLED error.
Add some UMA to help discover how the cancelled results happen.

Bug: 856857
Change-Id: I14f35135ad9c76bb4093cce57c49a5b888a7c2df
Reviewed-on: https://chromium-review.googlesource.com/1116178Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571263}

Bug: 854301
Change-Id: Ifd2289c07dd1a63cbe328bc327dee2c74db8e7eb
Reviewed-on: https://chromium-review.googlesource.com/1112633Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571262}