- 02 Feb, 2018 40 commits
-
-
Andreas Haas authored
We used ScriptForbiddenScope::IsScriptForbidded to detect if we can reject a promise when we abort streaming compilation. With this CL we use IsContextDestroyed instead because it is more meaningful and serves the same purpose. R=haraken@chromium.org Change-Id: Ifc10fcffca8c9abdf7c88a9f58562c43c8d2d4a1 Reviewed-on: https://chromium-review.googlesource.com/897428Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#534027}
-
Hajime Hoshi authored
This is part of efforts to replace non-per-frame task runners with other appropriate task runners in the renderer. Bug: 804694 Change-Id: Ibcb96b6461fda0d777edcb961bc21294fcc5cf23 Reviewed-on: https://chromium-review.googlesource.com/897308Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534026}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e150d63db9f7..1f067b88df42 $ git log e150d63db..1f067b88d --date=short --no-merges --format='%ad %ae %s' 2018-02-02 machenbach Optimize check for existing files in download_from_google_storage Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib01ccf2fcd5646ced79cb3ea36253113f77af4e3 Reviewed-on: https://chromium-review.googlesource.com/899022Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534025}
-
Nicolas Dossou-gbete authored
Setting enable_android_deps_repository to true will let the build use the dependencies defined in //third_party/android_deps, that will be added by https://crrev.com/c/819771. By default this flag is disabled. Bug: 807641 Change-Id: If75f7bbac38d2dc807ae35cdd8de0f229bcf6545 Reviewed-on: https://chromium-review.googlesource.com/895691 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#534024}
-
Keishi Hattori authored
Check if table_ exists because the table may be freed after the callback has been registered when incremental marking is enabled. Bug: 757440 Change-Id: I677ae294f5d66f539ea6e68ddab29053aaf6c503 Reviewed-on: https://chromium-review.googlesource.com/896913Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534023}
-
Keishi Hattori authored
rare_data_ is a raw pointer instead of a Member (because it is in a union). Hence it needs a manual write barrier. Bug: 757440 Change-Id: I8852471d3c1d7db3e1db7fc1d6f74fbe3f33f311 Reviewed-on: https://chromium-review.googlesource.com/896909Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534022}
-
Keishi Hattori authored
Fixes the unused variable 'kCanClearUnusedSlotsWithMemset' error. Bug: None Change-Id: Ib1f85353e7e4523b865648f8bbbb660f94585852 Reviewed-on: https://chromium-review.googlesource.com/898906Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534021}
-
Chris Pickel authored
This reverts commit a55fe78f. Reason for revert: Possible source of flakiness in AutomationApiTest.DesktopHitTestIframe Original change's description: > Expose reverse relationships in the automation API. > > AXTree now keeps track of reverse relationships automatically, > so take advantage of that to expose reverse relationships for > some attributes already exposed in the automation API. > Also add two relation attributes that are supported by Blink > but weren't added to automation yet: details, errorMessage. > > The new attributes are: > > detailsFor (reverse of details) > errorMessageFor (reverse of errorMessage) > controlledBy (reverse of controls) > descriptionFor (reverse of describedBy) > flowFrom (reverse of flowTo) > labelFor (reverse of labelledBy) > > Bug: 757707 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I112c283c87274388fc9e7e725bcc126393133e39 > TBR: michaelpg@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/837643 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533819} TBR=dmazzoni@chromium.org,dtseng@chromium.org,michaelpg@chromium.org Bug: 757707 Bug: 808343 Change-Id: Ie61c369e0f234eca7435ac80d056a6c10ea75a41 Reviewed-on: https://chromium-review.googlesource.com/897864Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#534020}
-
https://webrtc.googlesource.com/src.git/+log/c7b964cd71fb..7dd9d6f54b8d $ git log c7b964cd7..7dd9d6f54 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d4edf15d11ce99bc913b8c9cc9c306ecf2c1933 Reviewed-on: https://chromium-review.googlesource.com/898942 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534019}
-
Christos Froussios authored
1. Empty space is introduced between the buttons in the export dialog. 2. The export menu item is the More Actions menu is changed to a different string. Additionally, the string is moved to settings_strings.grdp, next to the rest of the strings. Mocks: https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g29b76db41a_0_6 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id939ebe158a68ff71e12a783919c7baaea1ed00f Reviewed-on: https://chromium-review.googlesource.com/892881 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#534018}
-
arthursonzogni authored
Content-Security-Policy: The CSP source 'self' is usually the origin of the current document. Immediately after an new window or new frame is created, there are no current document. In this case, the origin used is the one of the opener (in case of a new window) or the parent (in case of a new iframe). For you intention: The frame's CSP are already the one of its opener when there are still no committed document. It makes sense to do the same with 'self'. Several web platform tests are added. Bug: 807206 Change-Id: I2acf66d9b6d63d4efb14370a4d0ff2206c943aeb Reviewed-on: https://chromium-review.googlesource.com/895589 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#534017}
-
Tsuyoshi Horo authored
This CL adds the following data files for fuzzer: 1: Same as SignedExchangeCertFetcherTest.OneCert 2: Same as SignedExchangeCertFetcherTest.OneCertWithExtension 3: Same as SignedExchangeCertFetcherTest.TwoCerts 4: The actual cert of www.example.com and the intermediate cert. Bug: 803774 Change-Id: I55182556a39c1ed852f2412df18707eae7a7c2c2 Reviewed-on: https://chromium-review.googlesource.com/896770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534016}
-
Kush Sinha authored
Bug: 807568 Change-Id: Id9b249fdbacfcd7b64cc7256a33204778f437450 Reviewed-on: https://chromium-review.googlesource.com/897671 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#534015}
-
Alex Clarke authored
This bug was causing tasks to occasionally run sooner than intended. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I93516407032313c1a0026302f49a714c3bbeae40 Reviewed-on: https://chromium-review.googlesource.com/897645Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534014}
-
Kent Tamura authored
Simplify Document::createElementNS() code by using Document::createElement(qname, flags). There were no createElement(qname, kCreatedByCreateElement). Removing |flags != kCreatedByCreateElement| in it is safe. This CL has no behavior changes. Bug: 806641 Change-Id: I79112ccedb35ad3804e84fc62def3b0c395b1a7b Reviewed-on: https://chromium-review.googlesource.com/896910Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534013}
-
Takashi Toyoshima authored
This patch moves CORSURLLoaderFactory and unit tests for CORSURLLoader and CORSURLLoaderFactory to services/network. Only Mechanical changes. Since now that this patch remove the last source files in content/network, this patch also removes content/network directory completely. It affects WATCHLISTS, other BUILD.gn, DEPS, and OWNERS files that refer content/network. The patch also includes mechanical string replacements, s/content\/network/services\/network/g. Bug: 807565 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iba027a1c625d421e5671dd3faac5d32c1d2136ad Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/895217 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#534012}
-
Koji Ishii authored
Following bot results are included. 3489 3494 3497 3500 3502 22 lines were removed and 31 lines were deflaked by consecutive results since 3410. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0ae30c41711a7a3cb76154d61e11229f9c16cfd2 Reviewed-on: https://chromium-review.googlesource.com/898142 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#534011}
-
Chandan Padhi authored
This is a reland of 2b33f996. Original change's description: > Migrate MediaStreamDispatcherHost to be per frame > > Currently, there is only one MediaStreamDispatcherHost per renderer > process, but almost all its methods require a frame ID to be supplied > by the caller. This CL migrates this object to be per frame. > > Bug: 807274 > Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890 > Reviewed-on: https://chromium-review.googlesource.com/894864 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533970} TBR=guidou, avi, tsepez Bug: 807274 Change-Id: Idca20b52a27123cabfbbb55fe570c97a582d4e7a Reviewed-on: https://chromium-review.googlesource.com/897321Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534010}
-
Tien-Ren Chen authored
This CL adds clip-path support to SPv175+ by the following changes: 1. PropertyTreeBuilder now builds a clip node (ClipPathClip) or a effect node (ClipPath), depend on whether path-based or mask-based clip path should be used. 2. A per-fragment clip-path cache that saves the bounding box and (if available) the path of path-based clip path. This cache will maintain the same pointer identity across document lifecycles so that clip node comparison during raster invalidation won't incur expensive by-value comparison for paths. 3. ClipPathClipper now paints path-based clip path in appropriate property state. HTML-based contents apply property state in a bundle by local border box property (unchanged), while SVG-based contents apply property states manually in SVGPaintContext. 4. Implement SPv1 composited mask layer adjustment. The hierarchy of effect tree and clip tree are slightly different because in SPv1 composited clip path are always applied to a mask layer then apply to actual contents indirectly. BUG=769942,792769 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8dcd5fad685067dc22efda9dedfd6ab6366a26a7 Reviewed-on: https://chromium-review.googlesource.com/896607 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534009}
-
Jens Widell authored
In jumbo/unity builds, it conflicts with another constant in bindings/ api_event_listeners.cc (that has a different value.) This particular constant didn't seem to add too much. It was only used in one place; in a function with a comment that talks about the constant's value. It could be argued that the code is easier to follow if the (very simple) function implementation then uses the value directly. (In particular since the "value" is in fact the name of another constant.) Change-Id: I728a34b0a8b43382e742c6b640ace3baadc4d2db Reviewed-on: https://chromium-review.googlesource.com/897489Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534008}
-
Jens Widell authored
They conflict in jumbo/unity builds. Since one read a file as binary data (into a `std::vector<uint8_t>`) and one as text (into a `std::string`), it seems reasonable to change the names to `ReadAndDeleteBinaryFile()` and `ReadAndDeleteTextFile()`. Change-Id: I8d8402c64cfe45132df9640bd5664df28742d6d7 Reviewed-on: https://chromium-review.googlesource.com/897603Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534007}
-
Chris Pickel authored
This reverts commit f0baa069. Reason for revert: "BackgroundTest.ActiveDescendantUpdates" is flaky. Since it appears to have been added in this CL, reverting for dtseng to take another look. Original change's description: > Force updates to related nodes > > Test: chromevox_tests. Prior to the change, > BackgroundTest.ActiveDescendantUpdates fails because 'Selected' is not spoken. > > Compute text content for list items without names > > Chrome doesn't compute descendant name on focus. > > Test: manually on twitter.com using j/k. Verify all text gets read. > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ie75dff41f98b8aa3904e435afa4bd245b9771cce > Reviewed-on: https://chromium-review.googlesource.com/891676 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533960} TBR=dtseng@chromium.org,nektar@chromium.org Bug: 808337 Change-Id: I4f838f27aa81a607bcb83934bec0dc321d336466 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/897789Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#534006}
-
Jens Widell authored
They conflict in jumbo/unity builds. Change-Id: Ie5eae8aa303f5a163eabb74ff931f696127ff032 Reviewed-on: https://chromium-review.googlesource.com/897602Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534005}
-
Shanmuga Pandi M authored
This patch will show deprecate warning for the extra form data which was added, if "value" attribute present with non-empty value for <input type='image'> Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs Bug: 753746 Change-Id: I565132d6ef8c6d4a93ce5447e5d18d7f7f8c1910 Reviewed-on: https://chromium-review.googlesource.com/896740Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#534004}
-
Yoshifumi Inoue authored
This patch makes |ComputeSelectionType()| to take |EphemeralRange| instead of two positions |start| and |end| to make sure we keep invariant of |start| < |end| for improving code health. Change-Id: Ibe2427899f7b60b9a37e23c516172203276ab12c Reviewed-on: https://chromium-review.googlesource.com/898683Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534003}
-
Yuta Kitamura authored
This reverts commit 6d10aad7. Reason for revert: Caused MSAN bot failure. https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/7639 Original change's description: > [css-typed-om] Refactor CSSStyleImageValue to prepare for gradients. > > Currently CSSStyleImageValue implements the CSSImageValue class in > Typed OM. CSSImageValue can be anything that's an <image> i.e. a <url>, > <gradient>, or <cross-fade>. > > However, the current implementation of CSSStyleImageValue only really > works for <url>s. This patch moves <url> specific logic into > CSSURLImageValue. This prepares for the implementation of <gradient> and > <cross-fade>, which will be subclasses of CSSStyleImageValue. > > We also do some cleanup work (e.g. making things const, moving code in > header to cpp). > > Bug: 803680 > Change-Id: I848b3eab5dbbcb9bbe7f0aea0d377497f63bfda3 > Reviewed-on: https://chromium-review.googlesource.com/882786 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: nainar <nainar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533949} TBR=nainar@chromium.org,shend@chromium.org Change-Id: I9aedca3ac9e3ecb07ed283447febede0628d7aeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803680 Reviewed-on: https://chromium-review.googlesource.com/896671Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#534002}
-
Marina Ciocea authored
Replace duplicate implementation of AudioDeviceDescription::IsLoopbackDevice with function call. Bug: 783109 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I896038026359723d8fe1c4366cd3a54ddd51e9c1 Reviewed-on: https://chromium-review.googlesource.com/897534Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#534001}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09eb87e6..33f6b756 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id386ff99db678d09ae255d4b2a066f209b443bf0 Reviewed-on: https://chromium-review.googlesource.com/898783Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534000}
-
Jens Widell authored
In jumbo/unity builds, some of the constants conflicted with (identical) declarations in the anonymous namespace in verified_content.cc. Change-Id: I66e9ecb180e99cfd468c914ddce44613a5013242 Reviewed-on: https://chromium-review.googlesource.com/897604Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#533999}
-
Yoshifumi Inoue authored
This patch changes "push-down-implicit-styles-mac.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. Following patch will rename this test file with remove "-mac" suffix to "push-down-implicit-styles.html" since this test file no more depends on MacOS. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: I5c9a77d5d48651a9f3936496ca14b195a5633828 Reviewed-on: https://chromium-review.googlesource.com/898765Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533998}
-
Yoshifumi Inoue authored
This patch changes |CreateVisibleSelection()| to utilize |ComputeRange()| of |SelectionTemplate| to simplify source code for improving code health. Change-Id: I3d19d963cf04acba7f7bb0cb090dd45139f914a4 Reviewed-on: https://chromium-review.googlesource.com/897290Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533997}
-
Yoshifumi Inoue authored
This patch changes "push-down-font-styles{,-mac}.html" into "push-down-font-styles.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: If2a26ed1d3007048d6799ce8f7fb20e12903d9c4 Reviewed-on: https://chromium-review.googlesource.com/898764Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533996}
-
Yoshifumi Inoue authored
This patch Introduces printers for |EphemeralRange| and |EphemeralRangeInFlatTree| for ease of debugging and a preparation of the patch[1]. [1] http://crrev.com/c/898683 Make ComputeSelectionType() to take EphemeralRange Change-Id: I2988679b2c9febe50d29a9330ac6e5577972ca20 Reviewed-on: https://chromium-review.googlesource.com/896739Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533995}
-
Yoshifumi Inoue authored
This patch changes "push-down-implicit-styles-around-list-{mac,win}.html" into "push-down-implicit-styles-around-list.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: I21267338d42fe7400be683b102fb85168bb6b01b Reviewed-on: https://chromium-review.googlesource.com/896777Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533994}
-
Jens Widell authored
They conflict in jumbo/unity builds. Also rename the overly generic `g_static`/`g_lazy_instance` variables. They did not conflict with anything currently, but generic names in the anonymous namespace are likely to become a problem eventually, sadly. Change-Id: Ie90ca3c7eee3d357c3aca205a5551034b768eb77 Reviewed-on: https://chromium-review.googlesource.com/897488Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#533993}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I16585f0cf479191f33fdac9a7afc924cd077b908 Reviewed-on: https://chromium-review.googlesource.com/897318 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533992}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/994eb2b34934..036bdc0c9a4f $ git log 994eb2b34..036bdc0c9 --date=short --no-merges --format='%ad %ae %s' 2018-01-28 wl [truetype] Minor typo. 2018-01-27 wl [truetype] Better protection against invalid VF data. 2018-01-27 wl * src/truetype/ttinterp.c (Ins_GETVARIATION): Avoid NULL reference. 2018-01-27 wl * src/truetype/ttgxvar.c (tt_set_mm_blend): Minor. 2018-01-27 wl [truetype] Better trace VF instances. 2018-01-27 wl Fix comment. 2018-01-27 wl [truetype] Beautify tracing of VF axis records. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Change-Id: Ia6e13f2b4ccff77c6f968c91dacd3235272231bc PDFium-Bug: https://bugs.chromium.org/p/pdfium/issues/detail?id=995 Reviewed-on: https://chromium-review.googlesource.com/889868 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533991}
-
Sam Zackrisson authored
This CL removes the render_fifo_ buffer from MediaStreamAudioProcessor and DCHECKs that the input audio is 10 ms long. MediaStreamAudioProcessor currently buffers audio provided to OnPlayoutData, to feed frames in 10 ms chunks to the APM. However, the caller of OnPlayoutData already DCHECKs that this is the case. This CL also modifies the unit tests. They use the same configuration for capture input as for render input, even though only capture needs to support input other than 10 ms. Bug: 804277 Change-Id: Ia20cf0e0810c59570305f1ca295016e0ca11057e Reviewed-on: https://chromium-review.googlesource.com/875862 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533990}
-
Scott Violet authored
Original is here: https://chromium-review.googlesource.com/c/chromium/src/+/882558 This differs from the patch that landed in two ways: 1. I completely misunderstood RunsTasksInCurrentSequence(). It may be called on any thread and basically comes down to checking if the current thread matches the thread the TaskRunner runs on. Changed implementation of DeferredSequencedTaskRunner and DeferringTaskRunner appropriately (added test for this). 2. Master prefs need ResourceBundle loaded with the data pack, so, shuffled around loading of that. This is covered by browser_tests that sadly only run on official builder. There are two motivations for this change: 1. In order to run a field trial for state setup in creating toolkit. 2. To have local state ready at the time ash is created. In order to have field trial ready I need to load local state and everything it touches. This ended up including ResourceBundle (not really the ResourceBundle, but the ResourceBundle code is used to determine the locale, and the locale is needed by code related to metrics, specifically ChromeMetricsServiceClient::GetApplicationLocale). As much of this code was previously created at a time when task runners were available I had to create a deferring task runner that queues up tasks and then flushes them when the real task runner is available. I've tried to only move what is necessary and leave as mush initialization as possible in the place before this change. You'll notice this creates g_browser_process early on. I explored not doing this, but it turns out very painful as instead some code then has to cache state that is later available in g_browser_process. The camel that broke the straws back was the application locale. See https://chromium-review.googlesource.com/c/chromium/src/+/853300 for the early approach. BUG=800358 TBR=mark@chromium.org,jamescook@chromium.org,mpearson@chromium.org Change-Id: I3343e8959321900daec0de16f6a86715d3760f29 Reviewed-on: https://chromium-review.googlesource.com/898070 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533989}
-
tzik authored
WebMIDI backend implementations have used double as a time type. As base::TimeTicks is available in Blink now, it's better fit to use as the timestamp. Change-Id: Ide762f3a8dd503b3bd77eae9077f5ecde18e3796 Reviewed-on: https://chromium-review.googlesource.com/892726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533988}
-