- 19 Apr, 2017 40 commits
-
-
sebmarchand authored
This benchmark has been failing (timing out) for months now, so removing it won't affect the performance. The issue seem to be that Speedometer takes a while to tun, and it's much slower in a PGI build, so we timeout after 10 minutes and at this point the benchmark is still running. We could increase the timeout but as mentioned above this has been failing for months and we haven't noticed a performance regression. BUG=650432 Review-Url: https://codereview.chromium.org/2814103003 Cr-Commit-Position: refs/heads/master@{#465682}
-
brettw authored
The sets and maps are typically small or empty and created once. flat_set and flat_map will have better performance for these workloads. See the bug for histograms of sizes. Reland of https://codereview.chromium.org/2821353002 with fix. Reland of https://codereview.chromium.org/2823043002 with fix. BUG=712295 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=jbauman@chromium.org Review-Url: https://codereview.chromium.org/2831663002 Cr-Commit-Position: refs/heads/master@{#465681}
-
kkhorimoto authored
BUG=546208 Review-Url: https://codereview.chromium.org/2819883002 Cr-Commit-Position: refs/heads/master@{#465680}
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#465679}
-
sandersd authored
During recent changes, it became possible for the first video buffer timestamp in a stream to be negative. This change restores the invariant that video buffer timestampes are non-negative, by emitting a demuxer error in this case. BUG=710845 Review-Url: https://codereview.chromium.org/2822063002 Cr-Commit-Position: refs/heads/master@{#465678}
-
pdr authored
This patch refactors FindScrollLayerForDeviceViewportPoint as FindScrollNodeForDeviceViewportPoint which both simplifies code and lets us remove two users of ScrollNode's owning_layer_id. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2824683002 Cr-Commit-Position: refs/heads/master@{#465677}
-
zhaobin authored
For b/37234823 BUG=711841 Review-Url: https://codereview.chromium.org/2822843003 Cr-Commit-Position: refs/heads/master@{#465676}
-
clamy authored
https://codereview.chromium.org/2750503010 introduced a call to GetFrameHostForNavigation while not meaning to create a RenderFrameHostForNavigation. This is a wrong usage of this function. This CL removes it in favor of using navigating_frame_host that was defined earlier in the function. BUG=711848 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2825373002 Cr-Commit-Position: refs/heads/master@{#465675}
-
danakj authored
The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Original-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465674}
-
rogerm authored
BUG=709080 TBR=varkha@chromium.org Review-Url: https://codereview.chromium.org/2827093002 Cr-Commit-Position: refs/heads/master@{#465673}
-
estevenson authored
Added in https://codereview.chromium.org/2501193003, IsSelectiveJniRegistrationEnabled() was missing a capital. BUG= Review-Url: https://codereview.chromium.org/2820213002 Cr-Commit-Position: refs/heads/master@{#465672}
-
gmanikpure authored
Revert of [Chromedriver] Re-enable java tests on Android stable and beta. (patchset #1 id:1 of https://codereview.chromium.org/2820833002/ ) Reason for revert: Tests still fails on bot across all the chrome android channels : stable,beta and HEAD. https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/33579 Original issue's description: > [Chromedriver] Re-enable java tests on Android stable and beta. > > BUG=chromedriver:922 > TBR=stgao@chromium.org > > Review-Url: https://codereview.chromium.org/2820833002 > Cr-Commit-Position: refs/heads/master@{#464955} > Committed: https://chromium.googlesource.com/chromium/src/+/db88f21898176b391c397fff32e4c47282dd31ba TBR=johnchen@chromium.org,stgao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromedriver:922 Review-Url: https://codereview.chromium.org/2825083002 Cr-Commit-Position: refs/heads/master@{#465671}
-
xiyuan authored
SessionController::RunUnlockAnimation expects the callback to be invoked only once. SessionStateAnimatorImpl uses the callback per animation per container. Mulit-display would have multiple containers involved hence multiple animation and callbacks. The multiple callback would cause a mojo CHECK failure. SessionStateAnimator should only run the callback once after all animations finish. The CL use a BarrierClosure to combine the animation callbacks. BUG=712422 TEST=SessionStateAnimatiorImplContainersTest.AnimationCallbackOnMultiDisplay Review-Url: https://codereview.chromium.org/2823343006 Cr-Commit-Position: refs/heads/master@{#465670}
-
eugenebut authored
Notable changes: - didStartProvisionalNavigation: is no op if passed navigation is not the latest navigation (this way didStartProvisionalNavigation: does not mess up with pending item) - didCommitNavigation: does not commit pending entry if if passed navigation is not the latest navigation. Instead it changes last committed item to one that matches with URL, which may not be correct, but it's just a minor temporary inconsistency which does not have any security implications (last committed URL is still correct). BUG=711465 Review-Url: https://codereview.chromium.org/2821173002 Cr-Commit-Position: refs/heads/master@{#465669}
-
rdevlin.cronin authored
Instead of adding traffic management headers for all update pings, only include them for pings sent to the webstore. BUG=647516 Review-Url: https://codereview.chromium.org/2823923002 Cr-Commit-Position: refs/heads/master@{#465668}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/24e36dadf5b1..121ef2b4a8c6 $ git log 24e36dadf..121ef2b4a --date=short --no-merges --format='%ad %ae %s' 2017-04-19 rnephew [Telemetry] Get rid of old debugging information. Created with: roll-dep src/third_party/catapult BUG=667470 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I20439992b215d7734dad275d7a9ebe0cb27b3d11 Reviewed-on: https://chromium-review.googlesource.com/481900 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#465667}
-
rtoy authored
Manually convert tests to use new Audit BUG=704967 TEST= Oscillator/osc-low-freq.html Oscillator/osc-negative-freq.html Oscillator/oscillator-basic.html Oscillator/oscillator-late-start.html Review-Url: https://codereview.chromium.org/2804633004 Cr-Commit-Position: refs/heads/master@{#465666}
-
chrisha authored
Currently on a post-crash startup with the --restore-last-session flag specified an automatic session restore occurs, and an infobar offering an additional session restore is created. Clicking "restore" on the infobar results in the session being restored twice. This CL removes the logic that makes the flag automatically restore the session post-crash. This diminishes the power of the flag somewhat, but allows it to continue working in support of OS-specific "continue where you left of" functionality on Windows and OS X. BUG=707998 Review-Url: https://codereview.chromium.org/2832503002 Cr-Commit-Position: refs/heads/master@{#465665}
-
qiankun.miao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a60..73fd432 BUG=708730, 712584, 712117, 713127, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2820113008 Cr-Commit-Position: refs/heads/master@{#465664}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This makes the existing DeliveryAgent class self-scheduling using the ReportingObserver interface: when reports are added to the cache, or periodically while reports are still queued, it automatically runs the "send reports" algorithm described in the spec. BUG=704259 Review-Url: https://codereview.chromium.org/2785293003 Cr-Commit-Position: refs/heads/master@{#465663}
-
dpapad authored
languages_page.js has a lot of platform specific code, but it was not properly marked, so it was being included in unrelated platforms. This CLs cleans up the code such that is only included in the platforms that it is actually used. - chromeos - chromeos or is_win - not is_macosx This is a step towards deflaking/re-enabling the corresponding tests(for example this makes it clear which platforms need a browser proxy abstraction). BUG=692356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2822863002 Cr-Commit-Position: refs/heads/master@{#465662}
-
glebl authored
BUG=635619 Review-Url: https://codereview.chromium.org/2823343003 Cr-Commit-Position: refs/heads/master@{#465661}
-
chrishtr authored
We already disable display list caching for this content. This CL also effectively disables subsequence caching. Also removed some now-unneeded under-invalidation code in PaintController (unneeded since https://codereview.chromium.org/2768143002) and improved a comment. BUG=709846 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2820233002 Cr-Commit-Position: refs/heads/master@{#465660}
-
sczs authored
Screenshots: https://drive.google.com/file/d/0Byo6-Nuda2jgaDNxMVYtWmEtUXc/view?usp=sharing https://drive.google.com/file/d/0Byo6-Nuda2jgaXJEYmZ3RzdVUlU/view?usp=sharing BUG=682880 Review-Url: https://codereview.chromium.org/2814963002 Cr-Commit-Position: refs/heads/master@{#465659}
-
alexclarke authored
Also adds support for finding the render tree node id, if any, for a given devtools agent host id. BUG=546953 Review-Url: https://codereview.chromium.org/2812253002 Cr-Commit-Position: refs/heads/master@{#465658}
-
ningxin.hu authored
BUG=712181 Review-Url: https://codereview.chromium.org/2822983002 Cr-Commit-Position: refs/heads/master@{#465657}
-
chiniforooshan authored
BUG=712753 Review-Url: https://codereview.chromium.org/2827813002 Cr-Commit-Position: refs/heads/master@{#465656}
-
pkalinnikov authored
BUG=671962 Review-Url: https://codereview.chromium.org/2828763002 Cr-Commit-Position: refs/heads/master@{#465655}
-
capn authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..dc7759c - Fixes ThinLTO linking. - Fixes TSAN data race. BUG=chromium:686980, chromium:710753 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2826133002 Cr-Commit-Position: refs/heads/master@{#465654}
-
danakj authored
This moves the windows-specific implementation into the window OSExchangeData::Provider. Since there's no ash that code does not need to handle both anymore. On windows+mus we use a OSExchangeDataProviderMus in the UI process instead, which will do the right thing (the same thing that drag_utils used to do instead of calling to the OSExchangeData::Provider). Changes the return type of GetDrawImage{Offset} to be more friendly to implementations that do not return a ref to a member variable. R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2792183002 Cr-Commit-Position: refs/heads/master@{#465653}
-
boushley authored
R=jochen@chromium.org, zpeng@chromium.org BUG= Review-Url: https://codereview.chromium.org/2794723003 Cr-Commit-Position: refs/heads/master@{#465652}
-
servolk authored
Move the definitions of the default Flush and StartPlaying* behaviors for audio/video renderers to a common InitializeAndExpect function, instead of repeatedly definining those behaviors in individual tests. Review-Url: https://codereview.chromium.org/2826613002 Cr-Commit-Position: refs/heads/master@{#465651}
-
petewil authored
In the first implementation, we passed extra headers inside the body, a CR comment identified that it would be better to pass them separately, this change separates them out into a different input parameter. BUG=706628 Review-Url: https://codereview.chromium.org/2827503002 Cr-Commit-Position: refs/heads/master@{#465650}
-
raphael.kubo.da.costa authored
The existing bindings still referenced WebIDL array types that were removed from the spec in 2015, and converting JS types to IDL sequences with an algorithm that expected either a JS array (in which case it just iterated over each element) or an object that adhered to an outdated protocol where a "length" property was expected. The current WebIDL sequence conversion steps are simpler and described in https://heycam.github.io/webidl/#es-sequence. In short, JS objects are converted to sequences via @@iterator and the regular iteration protocol of calling next() and checking the returned object. This works with arrays as well as any object that implements a valid Symbol.iterator property. It opens the way for custom iterators, the lack of which was causing some layout tests to fail. In other words, any iterable JS object can now be converted into a sequence<>. The downside is that the Blink-V8 communication required for calling @@iterator, invoking next() and checking objects on every iteration step is costlier than what we had before, so the "fast case" has been preserved for JS arrays (even though it is not 100% clear if this is a valid shortcut to take, it at least does not introduce any regression compared to the previous code). This is part 1: several functions in V8Binding.h that implement the old conversion algorithm (e.g. ToMemberNativeArray(), ToImplArray(), ToV8Sequence() and ToImplSequence()) have not been removed yet, and their callers in the code base have not yet been changed. This will come at a later point in the future. BUG=690428 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2826673004 Cr-Commit-Position: refs/heads/master@{#465649}
-
oka authored
On full width mode, the |requested_bounds| parameter passed to SetChildBounds can have different offsets from the |new_bounds| set to the keyboard container window, because only the height of the window matters in full width mode. Therefore the value passed to NotifyKeyboardBoundsChanging should be |new_bounds| instead of |requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing overlapping aura windows and wrong viewports are calculated for those windows. BUG=709360 TEST=manually tested the bug is fixed. Review-Url: https://codereview.chromium.org/2830513002 Cr-Commit-Position: refs/heads/master@{#465648}
-
stevenjb authored
BUG=701945 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2819253002 Cr-Commit-Position: refs/heads/master@{#465647}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f7d9852..e6777487 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2829663002 Cr-Commit-Position: refs/heads/master@{#465646}
-
lod authored
BUG=622743 Review-Url: https://codereview.chromium.org/2810403003 Cr-Commit-Position: refs/heads/master@{#465645}
-
mek authored
Somehow sometimes browser shutdown crashes on shutting down the DB thread for these tests on mac. BUG=712872 Review-Url: https://codereview.chromium.org/2820343003 Cr-Commit-Position: refs/heads/master@{#465644}
-
thakis authored
Only one target (somewhat questionably) still uses this, so just set the include directory in that target directly. BUG=401588 TBR=brettw Review-Url: https://codereview.chromium.org/2826113002 Cr-Commit-Position: refs/heads/master@{#465643}
-