- 21 Apr, 2020 40 commits
-
-
Yuki Shiino authored
Bug: 839389 Change-Id: I868fc7bc0294a4cbc6d6202293dc5a891a37f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159169Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761014}
-
Dominique Fauteux-Chapleau authored
The equivalent CL on the upload path is crrev.com/c/2134191 This is only a refactor to use Connectors manager instead of reading the deep scanning policies directly to facilitate the transition to new policies. Change-Id: I0b1253aaac9a90e8277d6f468fa33cfc6f5b74c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154739Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761013}
-
Aaron Leventhal authored
An object cannot have both children and a child tree. When an object fails to load, its child fallback content loads. In that case, expose the fallback children instead of the broken <object> content. Bug: None Change-Id: If6ba1dfc27ac19665a2e80c3d54750b3dc99bfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153887 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#761012}
-
Henrique Nakashima authored
- chrome/browser/flags/android - chrome/browser/preferences/android - chrome/browser/util/android These can be depended on by any code in chrome/android and chrome/browser. Remove scattered DEPS entries to these modules that are not needed anymore, since a parent directory already allows them. Change-Id: Idd1b5a6da6f4b0552150d640637eedd2a55180c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150975Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#761011}
-
rbpotter authored
Leave fonts_browser_proxy autogenerated since it is used by OS settings. Bug: 1069258 Change-Id: I7bd27c81477499b4171e27b7da32c9817724b5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155435 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#761010}
-
Ted Choc authored
BUG=1036923 Change-Id: I7777cc7cbdfc8b6703b22cacb49d256931ef57ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158828Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761009}
-
Matthias Körber authored
The requirements for storing new profiles address in Egypt enforce both a ZIP code and a state entry. Both are commonly not present in address forms from Egypt. This prevents Egyptian users from using autofill as intended. This change simply relaxes the requirements to enable Egypt users to use autofill. Change-Id: I3511941ef5195e8f16c53d6dd535b9eef0cc52a7 Bug: 1073078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159434 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#761008}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a653d8a2. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" daae887f "CookieStore: Add validation behavior for __Host- prefixed cookies" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia6042d948f99339dcec814e7860f2f1b861d0c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761007}
-
Li Lin authored
Stop means to stop playback and reset the session with no intention to resume it. To allow resume after stopping, use the suspend API instead. Bug: b/140945356 Test: Manual test Change-Id: Ib4b76aa64d7ed1d805c0c4761375faf2c6c447b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158046 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#761006}
-
Yuki Shiino authored
Bug: 1060971 Change-Id: I3deb3787a431c6d195eb948cd3c966588a9e3ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158197Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761005}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/146137adeebe..811efc06df3d git log 146137adeebe..811efc06df3d --date=short --first-parent --format='%ad %ae %s' 2020-04-21 mbonadei@webrtc.org Trigger bots. Created with: gclient setdep -r src/third_party/webrtc@811efc06df3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I787933ffc0fea40c246c87672248ab0353c211d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761004}
-
Andrew Grieve authored
Turns out it uses a different setting for disabling hidden API access from Q. hidden_api_policy_p_apps vs hidden_api_policy. Bug: None Change-Id: I25d603664da762f24d44f66bafb20fe641a2b935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159408 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761003}
-
Haiyang Pan authored
K is deprecated after m81 so it is not needed any more. android-cronet-kitkat-arm-rel is kept due to https://crbug.com/1032336#c25 Bug: 1032336 Change-Id: I4e93516375f79faf2b21ef5d7a9c5073b8df9908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157974Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#761002}
-
Sergio Collazos authored
This reverts commit 3e1566b9. Reason for revert: Landed by error Original change's description: > Reland "Enables kInfobarUIRebootOnlyiOS13 by default" > > This reverts commit 920d8f93. > > Reason for revert: Initial Patchset to Reland this change. > Original change's description: > > Revert "Enables kInfobarUIRebootOnlyiOS13 by default" > > > > This reverts commit b7db0ccb. > > > > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. > > > > Original change's description: > > > Enables kInfobarUIRebootOnlyiOS13 by default > > > > > > This is now needed in order to enable this locally and not via a finch > > > config which might not land before the re-sping gets to users. > > > > > > Bug: 1071853 > > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#760756} > > > > TBR=eugenebut@chromium.org,sczs@chromium.org > > > > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1071853, 1073091 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760984} > > TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org > > Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1071853, 1073091 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760999} TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org Change-Id: Id605aba1c85df624862ef46ce9776dedffdb8e37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159250Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#761001}
-
Julian Pastarmov authored
Only trust the URLWhitelist policy for external protocol handlers if the computer is part of an AD or AAD domain. BUG=1052093 Change-Id: Ie0d3ecb24ae6117248ff4e00e875a9104255ef41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152585Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#761000}
-
Sergio Collazos authored
This reverts commit 920d8f93. Reason for revert: Initial Patchset to Reland this change. Original change's description: > Revert "Enables kInfobarUIRebootOnlyiOS13 by default" > > This reverts commit b7db0ccb. > > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. > > Original change's description: > > Enables kInfobarUIRebootOnlyiOS13 by default > > > > This is now needed in order to enable this locally and not via a finch > > config which might not land before the re-sping gets to users. > > > > Bug: 1071853 > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760756} > > TBR=eugenebut@chromium.org,sczs@chromium.org > > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1071853, 1073091 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760984} TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#760999}
-
David Tseng authored
R=dmazzoni@chromium.org Change-Id: I78f5c5274ef665b844e4f85648a77b74f9b953de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157991Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760998}
-
Thomas Tellier authored
Since the PIN view is not focusable anymore, this is dead code. Bug: 1043194 Change-Id: Ifd3e4cd8427abaca2bebd76187bba488bd2b4ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153441Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#760997}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24ea293cd25b..e59f718fc277 git log 24ea293cd25b..e59f718fc277 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 lepton@chromium.org SkQP: Fix document about running as native executable Created with: gclient setdep -r src/third_party/skia@e59f718fc277 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I5311557aa29aa308f3ca86e2278a3811164c78cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760996}
-
Wez authored
Fuchsia tests are always run by a host system matching the target's CPU (which may differ from the _build_ host CPU), so simplify the |data| dependencies of generated runner scripts to use |target_cpu|, allowing there to be a single list of required tools. Bug: 1024086 Change-Id: I6346b237f8b87646634d5691f1ceeedc79140639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152445Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#760995}
-
Olivier Robin authored
Add a flag to save MetricKit payloads. Saving the payload will require - a compilation flag that will be enabled only on canary. - setting an experimental setting JSON representation of MetricKit payload will be saved in Documents directory. Collecting this data will help developing MetricKit support in Chrome. Bug: 1017434 Change-Id: I5db5d7112859eb873ee68e8f7159f7ab9fe3dbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156905 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#760994}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3c27f7f4296ee71257be110aad31bbe69bdf024f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158429Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#760993}
-
Friedrich Horschig authored
This CL adds the controller scaffold of the bubble that proposes to users to move their local credential to the account-storage. See the linked bug for mocks. Bug: 1060128 Change-Id: Idb53ef749d0ad18ee4dcb5af5f98cfedecfc7f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159220 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760992}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3f4e5c456306..c9b28b9f3388 git log 3f4e5c456306..c9b28b9f3388 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 mennovink20@hotmail.com xcode warnings fix (#2188) Created with: gclient setdep -r src/third_party/glslang/src@c9b28b9f3388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I8ea0edd0b6e4deb8ec838994a743817104d98a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760991}
-
Allen Bauer authored
Hide the example combo-box selector if there is only one example to show. Part of Views Documentation effort. Change-Id: I9019148e54d7162bfb8b95a88c515504f130e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153307 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#760990}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/269ac5675039..56bc9f5a573c Created with: gclient setdep -r src-internal@56bc9f5a573c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com Change-Id: Id87ac1ca628089e935c014c28c63396fd7f376b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159130Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760989}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f9465beae14..150d04851644 git log 1f9465beae14..150d04851644 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 vapier@chromium.org cgroups: move NoOpContextManager API here 2020-04-21 vapier@chromium.org kernel_cmdline: convert to python3 only 2020-04-21 lamontjones@chromium.org toolchain_util: prepare even for POINTLESS builds. 2020-04-21 lamontjones@chromium.org toolchain_util: AFDO generation artifact cleanup. 2020-04-21 lamontjones@chromium.org toolchain: additional_args => profile_info 2020-04-21 shaochuan@google.com Cleanup chell-chrome-pre-flight-branch 2020-04-21 vapier@chromium.org dslib/iter_utils: convert to python3 only 2020-04-21 vapier@chromium.org git_unittest: untangle cbuildbot dep 2020-04-20 vapier@chromium.org upload_prebuilts: migrate to python3 only 2020-04-20 cjmcdonald@chromium.org pytest: Clean up & remove 'leaks_process' marker 2020-04-20 cjmcdonald@chromium.org pytest: Clean up & remove 'output_test' marker 2020-04-20 cjmcdonald@chromium.org pytest: Fix up some unittests to succeed when run in one process 2020-04-20 cjmcdonald@chromium.org pytest: Create fixture to prevent leakage of Manager processes 2020-04-20 davidmunro@google.com xbuddy: Fix cros flash to work with python 3. 2020-04-20 vapier@chromium.org paygen_build_lib: migrate to python3 only 2020-04-20 vapier@chromium.org cbuildbot: constants: finish migration to lib Created with: gclient setdep -r src/third_party/chromite@150d04851644 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iccf46ca1a32cd31a759d850c8c6c0b3c9ac96e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760988}
-
Ben Joyce authored
Temp steps were only needed when transitioning downstream targets to androidx. Bug: 1067070 Change-Id: I0501e21fe4586d146645ac68fb10774c71a69d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157683 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#760987}
-
Francois Doray authored
This CL adds back the entry in histograms.xml for ThreadPool.NumTasksInSequenceOnPush. This revert https://chromium-review.googlesource.com/c/chromium/src/+/2159312 removed the definition of the histogram, but we still need it since it was emitted in 84.0.4121.0. R=gab@chromium.org, bcwhite@chromium.org TBR=bcwhite@chromium.org No-Try: true Bug: 1071862, 1072977 Change-Id: I317056ceabc057d99273471d17e4a0c1bad8a731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159565Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760986}
-
Nicolas Ouellet-Payeur authored
This reverts commit 54aa10ad. Reason for revert: crbug.com/1073010 Original change's description: > [BrowserSwitcher] Deflake BrowserSwitcherServiceTest > > Previously, the tests waited for action_timeout(), to wait for LBS to > load the rules and write some files. As expected, this is fairly flaky, > and it slows down the tests. > > Now, `BrowserSwitcherService' exposes a new event for testing, which > fires once LBS has loaded the rules. This should reduce flakes by > listening for the event instead of using an unreliable timeout. > > Also rewrote some tests in a synchronous style, which improves > readability. > > Bug: 1044619, 1070400 > Change-Id: If1a2093cfe3bface73a46896ff2bc95b80ab2f2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152885 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760531} TBR=pastarmovj@chromium.org,nicolaso@chromium.org Change-Id: If573be05ce1a3d4a34449bd6038f16129cb4d1fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044619, 1070400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159313Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#760985}
-
Sylvain Defresne authored
This reverts commit b7db0ccb. Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. Original change's description: > Enables kInfobarUIRebootOnlyiOS13 by default > > This is now needed in order to enable this locally and not via a finch > config which might not land before the re-sping gets to users. > > Bug: 1071853 > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760756} TBR=eugenebut@chromium.org,sczs@chromium.org Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760984}
-
Leonid Baraz authored
Bug: b:153361703 Change-Id: I68934bd618382637a41dc3780009e5784269f147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147870Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760983}
-
Alexei Svitkine authored
The data reported is not useful and there are plans to revamp this information with something more actionable. Bug: 1072801 Change-Id: I21bbf56dd8d221fb795824eb432fea7f122059bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157835Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760982}
-
Kevin Ellis authored
This patch moves the processing of the keyframes rule into a separate method as a preliminary step in aligning the keyframe generate process for CSS animations with the spec (https://drafts.csswg.org/css-animations-2/#keyframes). Once this change is in, further refinement to align the algorithm with the spec should be easier to follow. Bug: 1070627 Change-Id: I04c558afa8f3aa9db85c8c473e4fbc5577633da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154824Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#760981}
-
Steven Bingler authored
The UMAs SameSiteDifferentSchemeResponse SameSiteDifferentSchemeRequest and the UKMs SameSiteDifferentSchemeReqsponse SameSiteDifferentSchemeRequest do not capture the complete/correct information relating to cookies that would be affected by schemeful same-site. This CL obsoletes and removes the metrics logging code along with the necessary framework code used to capture the metrics. Bug: 1066231 Change-Id: Ia4c952626ac8fbdf19e6da348ea9f6ca61ee043e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151481Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#760980}
-
Amr Aboelkher authored
This CL is doing the following: - Update the BUILD.gn correspondingly with the latest changes - Adding new patch for using absl optional instead of std - Update the Support-SHELL-in-chromium patch Bug: 1072286 Change-Id: Id3c4bc2da5183f92345440eb887f5391f8d7b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153443Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#760979}
-
Elly Fong-Jones authored
Bug: 1073062 Change-Id: I0f1895ebcf4a6169197ee6bb0b8a8fc05e6748eb Tbr: collinbaker@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158972Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760978}
-
Rainhard Findling authored
* Defines a separate visibility for safety check. * Hides safety check in guest mode. Bug: 1015841,1073023 Change-Id: I07990d36b90de2a0798499ee1098cb72325287ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159241Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760977}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I2a7ca6f4df896588a29eacf8beed05f11720145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108820Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#760976}
-
Elly Fong-Jones authored
Bug: 1044417 Change-Id: Iab0333296dfb31dbd4e402f2e06a7ccd5c038ab8 Tbr: apotapchuk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159310Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760975}
-