- 19 Sep, 2016 40 commits
-
-
ltian authored
1. Enable SearchEngineTabHelper on Android to auto-detect and fetch OpenSearch description document. 2. Add native function to retrieve recent visited search engines. 3. Allow recent visited search engine to be selected as default search engine. BUG=348360 Review-Url: https://codereview.chromium.org/2349473002 Cr-Commit-Position: refs/heads/master@{#419569}
-
brettw authored
Adds some missing dependencies, converts some to public. Adds a chrome_dll_resource target and move all direct includes of this header to this target. Review-Url: https://codereview.chromium.org/2354633002 Cr-Commit-Position: refs/heads/master@{#419568}
-
ultimatedbz authored
BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2350103003 Cr-Commit-Position: refs/heads/master@{#419567}
-
cwallez authored
BUG=634525 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel patch from issue 2354483002 at patchset 1 (http://crrev.com/2354483002#ps1) Review-Url: https://codereview.chromium.org/2354693002 Cr-Commit-Position: refs/heads/master@{#419566}
-
chfremer authored
This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.6. This CL is a step towards being able to reuse the classes VideoCaptureDeviceClient and VideoCaptureBufferPool as part of the Video Capture Mojo Service, because they implement functionality that is needed there. Expressed in class-diagram form, we want to go from [2] to [3]. Currently, the classes VideoCaptureDeviceClient and VideoCaptureBufferPool live in content/browser/renderer_host/media. Even though their functionality is not specific to renderer_host, their dependencies create a tight coupling to code that is. In order to use them in services/video_capture, we need to move them out of there (and probably into media/capture/video). In this CL we break the tight coupling by extracting interfaces and having the two classes depend on the abstractions instead of the implementations. The class VideoCaptureDeviceClient has a second type of tight coupling, which is that it knows about BrowserThread and wants to post tasks to the Browser IO thread. We break this dependency by moving the logic to forward calls to the Browser IO Thread into a decorator "PostOnBrowserIoThreadDecorator" (using the Decorator Pattern). No new files are created in this CL. Interfaces will be moved to new files in a new location in a follow-up CL. BUG=584797 TEST=This is a pure refactoring. No new functionality. All tests still pass. [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://docs.google.com/a/chromium.org/drawings/d/1jgDkxl1WvQCO-zeg87eLh5XkB4RP0wt46xlsB_XFfP8/edit?usp=sharing [3] https://docs.google.com/a/chromium.org/drawings/d/12yOdum03TP1dL7DmUjPxtAfSo16K8La6GJovSisqyRk/edit?usp=sharing Review-Url: https://codereview.chromium.org/2308533003 Cr-Commit-Position: refs/heads/master@{#419565}
-
bajones authored
BUG=628417 TBR=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2300543003 Cr-Commit-Position: refs/heads/master@{#419564}
-
kylechar authored
There are currently two ways a display can be closed in mustash. First, the NDD can update and indicated the display is gone. Second, when running off device the user can close the platform window. This CL unifies the two code paths. When running off device and the platform window calls PlatformWindowDelegate::OnRequestClose() the request is forwarded to PlatformScreen. PlatformScreen then tells the NDD to remove the fake display. The display configuration will update and the display will be gone. This allows the same display removed code path to get used in all cases. This also fixes PlatformScreen not knowing about the user closing a display. BUG=641012 Review-Url: https://codereview.chromium.org/2345043003 Cr-Commit-Position: refs/heads/master@{#419563}
-
mdjones authored
If requesting a desktop site on mobile, Reader Mode will no longer trigger unless its heuristic is set to ALWAYS_TRUE. BUG=647086 Review-Url: https://codereview.chromium.org/2342873005 Cr-Commit-Position: refs/heads/master@{#419562}
-
eyaich authored
BUG=chromium:633253 Review-Url: https://codereview.chromium.org/2348233005 Cr-Commit-Position: refs/heads/master@{#419561}
-
rdevlin.cronin authored
The ExtensionFunction test delegate basically just served as a way of getting the results from the function, but we already have that by simply setting the response callback in the function. Remove the DelegateForTests class and update uses of it to use the callback. Also add a response() field on ExtensionFunction for use in determining if the function succeeded or failed. Previously, code would rely on whether or not results_ were set, but this was wrong for a few reasons: - The absence of results doesn't always indicate failure - The presence of results doesn't always indicate success - In practice, we always send back an empty list value (even if results weren't previously set). Update code to use the response() value instead. BUG=648276 TBR=benwells@chromium.org (apps browsertest change) Review-Url: https://codereview.chromium.org/2348723002 Cr-Commit-Position: refs/heads/master@{#419560}
-
mohsen authored
Also, updated PaletteTray to use the new icon. BUG=646533 TEST=manually run Ash with --ash-md=experimental and check the icon Review-Url: https://codereview.chromium.org/2327943002 Cr-Commit-Position: refs/heads/master@{#419559}
-
justincohen authored
BUG= Review-Url: https://codereview.chromium.org/2346323002 Cr-Commit-Position: refs/heads/master@{#419558}
-
bmcquade authored
There has been a desire to better understand the breakdown of performance impact as a result of the doc.write intervention. We currently track script load time duration for the intervention. This change allows us to also track script execution time duration for the intervention. BUG=640260 Review-Url: https://codereview.chromium.org/2346813002 Cr-Commit-Position: refs/heads/master@{#419557}
-
rune authored
Review-Url: https://codereview.chromium.org/2350743002 Cr-Commit-Position: refs/heads/master@{#419556}
-
agrieve authored
Review-Url: https://codereview.chromium.org/2349743002 Cr-Commit-Position: refs/heads/master@{#419555}
-
dimich authored
Revert of Add access to Physical Web Service results (patchset #5 id:80001 of https://codereview.chromium.org/2330253002/ ) Reason for revert: Broke build (compile): https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/87504/steps/compile/logs/stdio ******************************************************************************** FindBugs run via: java -classpath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs" -jar /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/base/base_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/client/client_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/common/common_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/runtime_library/webapk_service_aidl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/spellcheck/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/variations/android/variations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_restrictions/web_restrictions_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/content/public/android/content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/device/geolocation/geolocation_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/base/android/media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/content/android/screen_capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/video/android/capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/midi/midi_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/bindings.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/system.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/net/android/net_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/printing/printing_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/android_mojo_bindings_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/blink_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_data_chart/android_data_chart_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_media/android_media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_protobuf/protobuf_nano_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_swipe_refresh/android_swipe_refresh_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_gcm_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_annotations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_design_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_appcompat_java_internal__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_vector_drawable_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_recyclerview_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/custom_tabs_client/custom_tabs_support_lib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/gif_player/gif_player_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/jsr-305/jsr_305_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/leakcanary/leakcanary_noop_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/ui/android/ui_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/url/mojo/url_mojom_gurl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/google_play_services_default_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/document_tab_model_info_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/public/public_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/core/dummy_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/bookmarks/common/android/bookmarks_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/content/browser/android/dom_distiller_content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/core/android/dom_distiller_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/android/gcm_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/instance_id/android/instance_id_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/invalidation/impl/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/location/android/location_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/navigation_interception/android/navigation_interception_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/ntp_tiles/android/ntp_tiles_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/policy/android/policy_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/precache/android/precache_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/signin/core/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/sync/android/sync_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/url_formatter/android/url_formatter_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar -exclude /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/chrome/android/chrome_java__findbugs/result.xml /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/chrome_java.jar FindBugs reported the following issues: EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.urlInfos At PwCollection.java:[line 20] EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.pwsResults At PwCollection.java:[line 21] ******************************************************************************** Original issue's description: > Add access to Physical Web Service results > > To allow access to Physical Web data, the URL info and Physical Web > Service data needs to be paired together. The pairing gives all relevant > information for a scanned URL. > > BUG=636490 > > Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd > Cr-Commit-Position: refs/heads/master@{#419531} TBR=cco3@chromium.org,dfalcantara@chromium.org,hayesjordan@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636490 Review-Url: https://codereview.chromium.org/2356553002 Cr-Commit-Position: refs/heads/master@{#419554}
-
ericrk authored
Both ContextCacheController and the CommandBuffer/GpuControl need access to a TaskRunner. CommandBuffer/GpuControl currently creates this TaskRunner internally in most cases. This change moves TaskRunner creation to the ContextProvider, allowing the same TaskRunner to be passed to both objects. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2286873003 Cr-Commit-Position: refs/heads/master@{#419553}
-
hubbe authored
As a bonus, we get warnings if you add a new enum value without updating gfx::ColorTransform. Review-Url: https://codereview.chromium.org/2338213009 Cr-Commit-Position: refs/heads/master@{#419552}
-
zijiehe authored
DirectX capturer requires dpi-awareness setting. BUG= Review-Url: https://codereview.chromium.org/2349883002 Cr-Commit-Position: refs/heads/master@{#419551}
-
tguilbert authored
cc::SurfaceId, gpu::Mailbox and ScopedSurfaceRequestManager need an unguessable identifier. Security recommends using 128 bits to make sure an ID is unguessable. However, there is no conveniently serializable way to represent 128 bits. This change introduces base::UnguessableToken, a 128 bit class with a cryptographically strong Create() function. UnguessableToken can be used by themselves, or as part of an aggregate ID. An empty UnguessableToken is a valid value. It is however illegal to send empty UnguessableToken across processes (because the resource that is supposed to be protected by the token would now be guessable). Sending empty tokens across processes is a security issue, and should be handled as such. This change also introduces the appropriate code to send tokens over IPC and Mojo. base::Optional should be used in cases where it may be valid to send no token (rather than sending an empty token). TEST=Added unittests. Also tested in a prototype that uses IPC and Mojo. BUG=643857 Review-Url: https://codereview.chromium.org/2333443002 Cr-Commit-Position: refs/heads/master@{#419550}
-
robliao authored
This allows the Browser Task Scheduler to check variations before metrics initializes and runs items on the blocking pool. BUG=636518 Review-Url: https://codereview.chromium.org/2342373002 Cr-Commit-Position: refs/heads/master@{#419549}
-
danakj authored
After forking OutputSurface, there are a lot of things on both OutputSurface and CompositorFrameSink that only belong on one or the other. This patch removes such things from each of them. Next up: Make OutputSurface::BindToClient not failable. Start renaming SwapBuffers and friends for CompositorFrameSink. TBR=dtrainor R=boliu, dtrainor@chromium.org, enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2349743004 Cr-Commit-Position: refs/heads/master@{#419548}
-
scottmg authored
Code was added already: https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/util/misc/metrics.cc?q=Crashpad.CrashReportSize&sq=package:chromium&l=24. R=asvitkine@chromium.org BUG=crashpad:100 Review-Url: https://codereview.chromium.org/2349993003 Cr-Commit-Position: refs/heads/master@{#419547}
-
eroman authored
CertErrors parameter. BUG=634443 Review-Url: https://codereview.chromium.org/2349093002 Cr-Commit-Position: refs/heads/master@{#419546}
-
dtseng authored
some containers, such as rows in Gmail's thread view, get focused. Ensure we speak the accessible name, but don't try to speak descendants. We only speak descendants for region and group roles. Any other role in ptractice leads to a lot of queued up output; for example, press escape while in Sheets. This results in a focus event on an application node containing almost all the content of the page. Finally, fix the leave rule so that it also ignores formatting a leave rule for a role that was part of the speak rule. This prevents things like "... row, exited row" when moving from row to row in Gmail's thread view. TEST=manual; chromevox_tests --gtest_filter=Output*.* BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2331163002 Cr-Commit-Position: refs/heads/master@{#419545}
-
bcwhite authored
BUG=644397 Review-Url: https://codereview.chromium.org/2332423002 Cr-Commit-Position: refs/heads/master@{#419544}
-
jbauman authored
Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #3 id:40001 of https://codereview.chromium.org/2342713002/ ) Reason for revert: We've got enough data now. Original issue's description: > Set crash key if WM_QUIT message is received on GPU message loop. > > Threads seem to be exiting unexpectedly, so to help debugging set a > crash key if an unexpected WM_QUIT message is received. > > BUG=647068 > TBR=scottmg@chromium.org > > Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 > Cr-Commit-Position: refs/heads/master@{#419057} TBR=dcheng@chromium.org,scottmg@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=647068 Review-Url: https://codereview.chromium.org/2346353002 Cr-Commit-Position: refs/heads/master@{#419543}
-
kbr authored
Revert of Prevent redundant DoWorks due to canceled delayed tasks (patchset #6 id:100001 of https://codereview.chromium.org/2320403003/ ) Reason for revert: Suspect that this CL caused breakage in Gmail and Hangouts per http://crbug.com/647484 . Original issue's description: > Prevent redundant DoWorks due to canceled delayed tasks > > To achieve this we make a few changes: > > 1. We only register the next wakeup with the TimeDomain, rather than all > of them. > 2. MoveReadyDelayedTasksToDelayedWorkQueue now registers the next > wakeup (if any). Since it removes all canceled delayed tasks from the > front of the priority queue this has the effect of not scheduling > wakeups for cancelled tasks. > 3. Tweaking the TaskQueueManager level delayed DoWork de-duplication > logic to only post a delayed DoWork if the task is meant to run before > any previously registered delayed DoWorks. > > BUG=638542, 605718 > > Committed: https://crrev.com/929cbb9f92b5570867c3842c80778243db81a013 > Cr-Commit-Position: refs/heads/master@{#418556} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638542, 605718 Review-Url: https://codereview.chromium.org/2353473003 Cr-Commit-Position: refs/heads/master@{#419542}
-
fmalita authored
We're looking at deprecating kStrokeAndFill_Style in Skia, so this CL's main focus is removing the use of the flag. While in this area, I've also updated the impl to draw the shadow using Canvas::DrawRoundRect instead of going through a path. R=reed@google.com,bruthig@chromium.org Review-Url: https://codereview.chromium.org/2349273002 Cr-Commit-Position: refs/heads/master@{#419541}
-
jyw authored
BUG=internal 29459582 BUG=internal 31162371 TEST=cast_alsa_cma_backend_unittests --gtest_filter=StreamMixerAlsaTest.* exercise stream volume API; listen for smooth volume transitions Review-Url: https://codereview.chromium.org/2341783004 Cr-Commit-Position: refs/heads/master@{#419540}
-
vmpstr authored
This patch moves some of the predecode image tracking to ImageManager. The other part depends on crbug.com/647402. Once the TileTaskRunner can keep a ref on scheduled tiles, then we can remove TileManager::locked_image_tasks_ as well. R=enne CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2345833002 Cr-Commit-Position: refs/heads/master@{#419539}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ff40d4569c8b..c36cf56a4fcc $ git log ff40d4569..c36cf56a4 --date=short --no-merges --format='%ad %ae %s' 2016-09-19 dskiba Support incremental Android installs in symbolize_trace script. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2350203002 Cr-Commit-Position: refs/heads/master@{#419538}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/e202bd8b71f6..613664b1bc64 $ git log e202bd8b7..613664b1b --date=short --no-merges --format='%ad %ae %s' 2016-09-19 jvanverth Remove unnecessary assert in GrBatchAtlas. 2016-09-19 csmartdalton skpbench CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2356433002 Cr-Commit-Position: refs/heads/master@{#419537}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#419536}
-
gayane authored
Review-Url: https://codereview.chromium.org/2347223003 Cr-Commit-Position: refs/heads/master@{#419535}
-
jdufault authored
TEST=ash_unittests BUG=645277 Review-Url: https://codereview.chromium.org/2324803003 Cr-Commit-Position: refs/heads/master@{#419534}
-
bmalcolm authored
Add default ShouldDisplayOverFullscreen method to NotificationDelegate that always returns false. Add implementation for NotificationsApiDelegate that returns true for ShouldDisplayOverFullscreen when the app that created the notificaiton is displaying fullscreen content. Note that this change does not enable this functionality. BUG=481318 Review-Url: https://codereview.chromium.org/2335293002 Cr-Commit-Position: refs/heads/master@{#419533}
-
tommycli authored
BUG=641626 Review-Url: https://codereview.chromium.org/2348693003 Cr-Commit-Position: refs/heads/master@{#419532}
-
hayesjordan authored
To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Review-Url: https://codereview.chromium.org/2330253002 Cr-Commit-Position: refs/heads/master@{#419531}
-
lgarron authored
Also adds `meaning=` tags so that the strings are translated separately for this exact context. BUG=645290 Review-Url: https://codereview.chromium.org/2342683002 Cr-Commit-Position: refs/heads/master@{#419530}
-