- 02 Mar, 2020 40 commits
-
-
Anna Malova authored
Bug: 1007815 Change-Id: Ie1e1b8702a25fd797e672eb4180e10a528d5ae74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082380Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746028}
-
Min Qin authored
BUG=1055424 Change-Id: I620bf468a1dbae88437e9db7f2f2a7c733485194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071068 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746027}
-
Jordan Taylor authored
This change adds phase to animation timeline. Phase currently only holds its read-only initial value of "inactive". Later updates will implement the full functionality for timeline states. Test verifies that animation.timeline.phase is accessible and equals initial value. It also verifies that the phase is readonly. Bug: 1046833 Change-Id: I1d887080f17692151ac97c7e89589dfefa185686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048943Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746026}
-
Geoff Lang authored
BUG=1043460 Change-Id: Iceab4aa65cb50bbe3be706cdfdee1564b8158298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081517Reviewed-by:
Jonah Ryan-Davis (use @google.com) <jonahr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746025}
-
Yi Xu authored
TBR=thakis@chromium.org Bug: 1047648 Change-Id: Iaa0ede16a8b173ee35ab89bf6615dd418571d11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080778Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#746024}
-
Evan Stade authored
This matches WebView as well as Android TextView. If a user initially dismisses the Autofill popup, this context menu item allows them to access Autofill again. Bug: 1056468 Change-Id: I2bee9d5960b92ed6b726402f7f570b09cad2eda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079039 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#746023}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *['\"](TypeError|Error)[\"'] *\} *(, *.)/assert_throws_js(\1\2\3/gs" And then manually fixing up whitespace. Bug: 1051932 Change-Id: I36cd1e17f36e92fe4a28461189f058f0fb11885e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080432 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746022}
-
Jan Wilken Dörrie authored
This change adds obtaining information about compromised credentials to the passwordsPrivate extension API. This is done via a getter, as well as an event that is fired when the credentials change. Furthermore, this change introduces a new PasswordCheckDelegate class that handles the implementation of these APIs. Bug: 1047726 Change-Id: I77d06a030cc823e665d5c49dec0eaed192104a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072742 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746021}
-
Hesen Zhang authored
- Exposed count and last timestamp of negative events and timestamp of last shown notification to ClientOverview based on the popular demand of client. - Update unit test with these fields. Bug: 1053659 Change-Id: Ie4502deba4e2c9460d6583ad2e01b19707478674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079549Reviewed-by:
-
Owen Min authored
Extension request are moved out of the pending list once user confirm the notification. However, there is no need to upload these requests anymore as long as admin made an decision. Bug: 1006899 Change-Id: I332917f15abf27a96c0ba42736841fd0316b7dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079643 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746019}
-
Stefan Zager authored
This is CL is a pure refactor with no functional change. The change to plumb a RasterInvalidationFunction through RasterInvalidator::Generate will be needed for SquashAfterPaint, when the call path into raster invalidation will involve calls through both ContentLayerClientImpl and GraphicsLayer. BUG=548184 Change-Id: Ic3003369f8e66f8c74f6ca884352ded60e827775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082482Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#746018}
-
Nazerke authored
This CL modernizes the InfobarContainerCoordinator - to use |browser| in the initializer - to remove the public property for webstatelist and dispatcher. - to use self.browser to get webstatelist and dispatcher values. Bug: 1029346, 892376, 1048412 Change-Id: I5cbe411bf7bdaae63552257c0f9613857bd67704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062270Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#746017}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ia387bfe81f5bbe7669859ad1212b9d8f1933d695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080258Reviewed-by:
-
Sylvain Defresne authored
Enable ARC (automatic reference counting) when building iOS specific files from components/open_from_clipboard and remove the use of scoped_nsobject. Also modernize the BUILD.gn file to not depend on the global sources_assignment_filter and to use "frameworks" instead of "libs" to list dependencies on frameworks. Bug: 1051997, 1018739 Change-Id: I92afb6ebbfe551fef12bd9a9f24ed120e64a0a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074277 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746015}
-
Luke Zielinski authored
This is carved off from crrev.com/c/2072639 to get around false positive on linux_layout_tests_composite_after_paint Bug: 937369 Change-Id: I0a968b13d36c4037ca7aeed20793afb000967aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080466Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746014}
-
Xida Chen authored
This is a follow-up to the CL: https://chromium-review.googlesource.com/c/chromium/src/+/2062752 In that CL, I should have mark the Throughput ukm obsolete but forgot to do it. Bug: 1048780 Change-Id: I5e060b0b13ddf3bbdcee58e807da3cf0a15d9c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079251Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746013}
-
Kevin Ellis authored
When CovertTimingForCompositor was updated to use TimeDeltas instead of doubles, a DCHECK(!infinity) was changed to a DCHECK that the scaled time offset had an unsaturated value. As large as the value is, it is not infinite and legitimate values for animation arguments can trigger a numeric overflow. Instead, simply reject the animation on the compositor. Bug: 1054853 Change-Id: I941735b2ca098e111b39b2b99fbd32924b5d877b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080455Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b03422a7370c..ae92244054c4 git log b03422a7370c..ae92244054c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 ilnik@webrtc.org Clean VP8 header parser 2020-03-02 phoglund@webrtc.org Make scenario tests more tolerant on iOS. Created with: gclient setdep -r src/third_party/webrtc@ae92244054c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057551 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iedfe74b07f95b17d9feac1633ac5abbd6b0d7314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746011}
-
Mugdha Lakhani authored
The dependency on ChromeAutocompleteSchemeClassifier is resolved by passing it in to OmniboxUrlEmphasizerHelper in components. The dependency on UrlConstants is resolved by reusing ContentUrlConstants. Bug: 1052375 Change-Id: I28f2380544fe592870ff633cfb67a37a7817a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075277 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746010}
-
Carlos IL authored
Feature has been launched for a while, this cleans up the finch flag and chrome://flags setting. Change-Id: I3c831f234236db80350642f9e74ff5b2db44353f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080859Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#746009}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7b1f947eb0a..b780372797ea Created with: gclient setdep -r src-internal@b780372797ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifb8873988fc58c90d9b7fa57bfca011ccc60d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083331Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746008}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34b020bf. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I263d6707a99cf8502c17f45dfd35356f0556c825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083053Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746007}
-
Carlos IL authored
This cleans up Mixed Content Site Setting (aka shield removal) from launched. This still leaves the feature behind a flag in case it needs to be used as a killswitch (that can be cleaned up after M82 branches). chrome: //flags since the flag has already expired and the change Change-Id: I413163573ee73953d354f6c0ed5c7be50d2644e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080896 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
James Cook authored
The identity service project was started circa 2017 as part of Chromium's servification efforts. The initial refactoring of identity code into the C++ signin::IdentityManager consolidated chrome's identity logic into a single location, improving the understandability and maintainability of the code. However, in late 2019 shifting priorities led to further work on the mojo service part of the project being deprioritized. By early 2020 there were only 2 clients of the mojo service, Assistant and DriveFS. Both ran only on Chrome OS and only in the browser process. These were migrated to use the in-process C++ IdentityManager. Since the mojo identity service now has no clients, and no new clients are planned in the immediate future, delete it. Bug: 654990 Change-Id: I9d86fe3f5d4a6435bd2440e859af89af031483c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079795Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates LocationBarModel class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Id9a6647395aac65bafd543529215fa827e5b1869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067070Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746004}
-
Joshua Pawlicki authored
Note that some were actually removed earlier, but not marked as obsolete. Bug: 1025210, 1037097 Change-Id: Ia6b85fff5a409655c6e73fe52ec00880806bc788 Fixed: 1025210, 1037097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074922Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#746003}
-
Dave Tapuska authored
In anticipation of moving the compositor ownership inside blink adjust the BeginFrame method so it doesn't take an argument to determine if recording of UMA/UKM should take place. It can easily be queried inside blink itself. Change-Id: I48a749fad7f6b051e7bdd0a556611871b563d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080434Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#746002}
-
Hui Yingst authored
If the browser is using an RTL language, the zoom toolbar should be displayed on the bottom left of the PDF viewer. As an extension, the PDF viewer gets its UI directions after loading translated strings from the backend with a latency. Due to this latency, the zoom toolbar will first show up on the right side of the PDF viewer by default and then switch to the left side after it gets all UI directions from the backend. To fix this issue, this CL will hide the zoom toolbar until all translated strings are loaded from the backend. Bug: 1038022 Change-Id: I6f49b888466fe9f4717c89c7b996feeda2777380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078747Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746001}
-
Peng Huang authored
This change adds thread_checker in GpuChannelManager to verify methods are called on GPU thread. This change also fixes a potential problem when gpu channel isn't created successfully. Bug: 978804 Change-Id: I7661f08d49a5af2ff3fb0a067357ad7fcb8e28ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083392 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746000}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fee07500..ff1896a1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I259e5905c1ad8056b059eeafcf0f2ea3b57b88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083045Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745999}
-
Randy Rossi authored
This should likely have been window.speechSynthesis Bug: None Test: Screen reader on chromecast display assistant Change-Id: I879bc288d1592dcc2e92e2700d0f751ae0790335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075046Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745998}
-
bttk authored
Bug: 1046181 Change-Id: I01effb7bd759b20932768a57ed1c80c74c26ad94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067415 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#745997}
-
Mila Green authored
The Mac implementation uses the out of process service. Win still doesn't have that, so the implementation is unchanged. Bug: 1048653 Change-Id: I70227020f79fc164b361cfcb998a041528a89dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078907 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745996}
-
Kevin McNee authored
This test leaks memory. Bug: 1057340 Change-Id: Ic2ef4b97e181a940f640ddd618c00fde2fee0149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082894 Auto-Submit: Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#745995}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7a3291dd131..777e146564b4 git log b7a3291dd131..777e146564b4 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 bsalomon@google.com Remove domain-uses-decal code from GrTextureProducer 2020-03-02 reed@google.com Do we still need bones on vertices for canvas 2020-03-02 borenet@google.com [recipes] Revert DM changes due to broken result files 2020-03-02 borenet@google.com [recipes] Speculative fix for empty properties Created with: gclient setdep -r src/third_party/skia@777e146564b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: If645ca461f7acd30c36b07787ab2faa69df8b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083333Reviewed-by:
-
Clark DuVall authored
This will help debug why exactly WebLayer is not getting package id 0x02. Bug: 1045262 Change-Id: Ib05d3eb81bf25120bf34d4997440c73cbbbdedb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080779Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#745993}
-
Callum May authored
Fix TSAN data race found in Edge TSAN environment Bug: 1055898 Change-Id: Ic8ef76e28bce4c2190dc5be66e21605f744a9a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072920Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Callum May <camay@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745992}
-
Anna Malova authored
Bug: 1007815 Change-Id: Iafc5e48f25325e51b3733a3e7b5a5fe436e0954c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080246Reviewed-by:
-
Arthur Hemery authored
This patch clears a frame name when a BrowsingInstance swap happened because of COOP. This happens as follows: 1. All COOP navigations force a browsing instance swap. 2. When swapping browsing instances, a new provisional frame needs to be created. 3. When creating a new provisional frame in response to a COOP-forced swap, the frame is created with a FrameReplicationState with an empty name/unique_name. 4. When the provisional frame is committed, this is detected in CommitPending(), which then clears the name/unique_name on the FrameTreeNode and replicates the name updates. - Fixes an issue in blink where the provisional frame would use the previous name instead of the replicated_state one passed as an argument. - Remembers when we had a switch that was COOP related and stores this state in the NavigationRequest. - When we create a RenderFrame and NavigationRequest has this state, we pass an empty name to the RenderFrame creation in the renderer. - When we get a DidCommit from the renderer and NavigationRequest has this state we update the name on the browser side in the FrameTreeNode. Together this should ensure that the new RenderFrame, as well as all the proxy references to it have the correct empty name at the end of the navigation. Bug: 1018655 Change-Id: I9262ba49d3c883e55a29aba1ca0d4e2011a1289c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027456 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745990}
-
Ian Clelland authored
Decimals are similar to floats, except that they have a maximum of 12 integer digits, and three fractional digits. They are represented as doubles for storage. This brings that portion of the implementation in line with the latest spec drafts (including serialization, which has been fixed since draft 15.) Tests are updated with the latest canonical tests from https://github.com/httpwg/structured-header-tests, as well as additional non-serializable-float tests from https://github.com/httpwg/structured-header-tests/pull/35. Bug: 1048754 Change-Id: I0205b37e25c3f1f0bcb0425f8a8588ec9c9e4b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055411 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745989}
-
