- 09 Jan, 2021 21 commits
-
-
Yuwei Huang authored
This CL adds silence detection logic for AudioCapturerMac so that it doesn't send empty audio packets and waste the bandwidth. Bug: 1161363 Change-Id: I891355b0ca31fb12eb40feb4f9b189645d36193c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618473Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#841737}
-
Yuheng Huang authored
story_test.StoryTest.WillRunStory in catapult The current CL needs to land before the following one https://chromium-review.googlesource.com/c/catapult/+/2618527 Bug: 1164464 Change-Id: Ibc25dbbf7ea1f0e5987a0146cd4ab806fa0e4325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618391Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841736}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61125414310a..affdce7627b1 2021-01-08 treehugger-gerrit@google.com Merge "Remove unnecessary dlog while parsing track event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I09e430ac16da8cbaee3f8b6fb0d9e2032bfe5ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841735}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00e43df25bea..6bf6963198aa 2021-01-08 johnstiles@google.com Remove context argument from short_circuit_boolean. 2021-01-08 robertphillips@google.com Improve flush-time op spew (esp. for DDL tasks) 2021-01-08 brianosman@google.com Fix 'out' and 'inout' params in user-defined runtime effect functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ib9571c1cee2a7dc63f3394fd316556eee9e95192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841734}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: Ibbde34d16df541c287f8542dec81e15d4664b05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616203 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841733}
-
Bartek Nowierski authored
IsPartitionAllocPCScanBrowserOnlyEnabled used to return false unconditionally on 32-bit architectures. This led to necessity to set up different populations in Omaha for each architecture, which is error prone. After changing this, the responsibility for checking the bitness falls now on EnablePCScanForMallocPartitionsInBrowserProcessIfNeeded. The caveat is that the population with PartitionAllocPCScanBrowserOnly turned on on 32-bit systems will now have to be ignored. This is ok because we get enough data on Windows. Make a similar change to EnablePCScanForMallocPartitionsIfNeeded for consistency, and overall clean up the code to look more symmetrical, while at it. Bug: 11297512 Change-Id: Ia4eccdbea149389e3a192c5b618cb938a701c388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597240Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#841732}
-
Xiaoqian Dai authored
Looks like kEmbeddedWindowEnsureNotInRect was introduced for mus and has been cleaned up partially. Clean up the remaining part. Bug: None Change-Id: I390338677625c8b12aa8d0016a8d32e40acb456b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600326 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841731}
-
Ken Rockot authored
Tests set up Local Storage in a temporary directory. If the directory has opened files during test shutdown, temp directory deletion can fail on Windows and cause test flake. This properly reorders LocalStorageImpl's shutdown synchronization logic so that we can ensure no LevelDB files remain open once the shutdown callback is invoked. Fixed: 1151226 Change-Id: Id9cad4ae8a305e12c965e1fb3d8908b739050cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617869Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841730}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11e6cfe60a92..61125414310a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If8e708789a5ede5640bf4760085119196516c63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841729}
-
Charlie Reis authored
We don't need to allow the CloudPrint hosted app to use restricted APIs after r841133. Bug: 1103302, 1100748 Change-Id: If8965b276a53cd00fa6822f870b7db78d77dfef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617873 Commit-Queue: Charlie Reis <creis@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841728}
-
cfredric authored
This cl adds 3 use counters: * one for use of the SameParty attribute; * one for when a cookie was excluded solely for SameParty reasons (i.e. in a cross-party context); * one for when a cookie was included by SameParty but excluded by SameSite. While I'm at it, this cl also: * renames the misleadingly-named `excluded_cookie` variable, since the cookie could be either included or excluded; * renames the EmitSameSiteCookiesDeprecationWarning, since the method does more than that; * and introduces a helper variable to make the loop body slightly more readable. Change-Id: I388e032651212769c2547ae64b426903ff7be0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616422 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841727}
-
Daniel Hosseinian authored
Setup the frontend pipeline for showing document properties and show some basic ones for now, including: - Title - Author - Subject - Application - PDF Producer Reshape the 'metadata' message to have a `DocumentMetadata` object in its 'metadataData' field, which can be directly passed to the `ViewerPropertiesDialogElement` without further processing on the frontend. Bug: 93619 Change-Id: Iffb8691f443781a700fc06a439506dd546f46865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610048 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841726}
-
Dale Curtis authored
This reverts commit 57cebabc. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164561 Original change's description: > DLP: Change DragDropDelegate::OnDragUpdated return type > > - Changed the return type of DragDropDelegate::OnDragUpdated > to return a struct of DragOperation and DataTransferEndpoint. > - The returned DataTransferEndpoint should be used in > DragDropController for allowing/disallowing dropping the > data according to the policy rules, See crrev.com/c/2595382. > > Bug: 1139886 > Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841675} TBR=sky@chromium.org,oshima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,ayaelattar@chromium.org Change-Id: I205a8bd3b7bdfdcddf74ccfdebfdf371ccc7b103 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1139886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617055Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841725}
-
Torne (Richard Coles) authored
This expired in M85 and we don't need any more data; delete the implementation and mark it obsolete. Fixed: 1088547 Change-Id: I9cf662751a746201a7fd921b5873c75d30d4acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618503 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841724}
-
Dale Curtis authored
This reverts commit 5a849c90. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164560 Original change's description: > [LanguageDetection] Pass language model to TranslateAgent. > > This change provides the file for the language detection model needed > in the TranslateAgent. > > Bug: 1151422 > Change-Id: I24870758adf8b00ee378ca7ccc55bd45edb164d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599580 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841678} TBR=dcheng@chromium.org,jam@chromium.org,sclittle@chromium.org,sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,perrier@chromium.org Change-Id: I7d33ec2acd918141ae310911550e3ffb86f336b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618475Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841723}
-
Aleks Totic authored
Test used to be flaky and there was a bug. Marking it as no flaky to close the bug. Ran the test for 100 tries on linux, no flakiness. Bug: 918664 Change-Id: Ibb92506852cb09747b757dfa1fcfbb3fd4f428ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617510 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841722}
-
Dale Curtis authored
This reverts commit 50bc0376. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164559 Original change's description: > Remove the app related full restore data when the app is removed. > > Add the class FullRestoreDataHandler to observe AppRegistryCache. When > the app is removed, remove the full restore data from both > FullRestoreReadHandler and FullRestoreSaveHandler. > > BUG=1146900 > > Change-Id: Ie55b6310e3e302ac4829b7c76c10880928266651 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608045 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841611} TBR=xiyuan@chromium.org,dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: Ib46d03a047b6c8145805ed2ba40e5c48c12d5d17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618763Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841721}
-
Michael Checo authored
Screenshot: http://shortn/_ldNJuxuRhF Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#dd35f9cb-3d67-452e-a98c-89635d8c31c3 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4756e38037d8ba4ba9ed9435f2f6a6a21d0e4b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557728 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#841720}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4f67a285e221..f3b585e8edf5 2021-01-08 tsepez@chromium.org Avoid integer overflow in RelocateTableRowCells(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164158 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I41efdd60480e820072c4fcefc6ad6f41bb0b6654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841719}
-
Daniel Cheng authored
Change-Id: I9d4c9bf676be75bc2b6bec5d18515de092b99d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616946 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#841718}
-
Dale Curtis authored
Since software overlays are controlled by a base::Feature, we need a new static method on DirectCompositionSurfaceWin for disabling the software overlay path using an internal static variable. R=zmo Bug: 1161215, 1160217 Change-Id: I3299a4f80881d45444dfbebaaf4bce2b581f2322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617000 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841717}
-
- 08 Jan, 2021 19 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e12745c2764b..128bf6a2b49f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145728 Tbr: dalecurtis@google.com,wjmaclean@google.com Change-Id: I8dbac9eaa27bf42c11f1f7f338208beeed3b7be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617049Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841716}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1315e1853a6a624ad8eafd88affeb1886abb13dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841715}
-
Tommy Li authored
The Canary/Dev experiment was successful, and we are adding this ablate flag to the fieldtrial_testing_config.json now to proceed to the Beta experiment. Bug: 1141539 Change-Id: I8cda087190af3a2ab9db5eb93606010208b4484f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616239Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#841714}
-
Becca Hughes authored
This is breaking on S-builds. BUG=1159812 Change-Id: I384a966e8b3f21ed5f6af0e829e982de966a050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617754 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#841713}
-
Daniel Hosseinian authored
Guarantee that every PDF metadata field is trimmed of whitespace characters, so users of the metadata do not have to worry about checking themselves. Consequently, change PDFiumEngine::GetMetadataByField() to PDFiumEngine::GetTrimmedMetadataByField(). Bug: 93619 Change-Id: Ie51c7099d147e50e4e507e43fcca3a17fbba183a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609655 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841712}
-
Anastasia Helfinstein authored
When the settings UI was improved, the underlying preferences changed. This updates the extension JS to use the new preferences. AX-Relnotes: Fix bug where settings opened every time Switch Access was enabled. Bug: 1162750 Change-Id: I0c09fb35aba5f3182cfeeb82d3767acacb496285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618580 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#841711}
-
Dominic Mazzoni authored
WebContents::RequestAXTreeSnapshot is used for several things, including supporting Assistant on Android and Chrome OS, generating tagged PDFs, speaking the text of a page on macOS, and determining the page language for Translate. On Android, requests are timing out on large pages; Assistant wants results in 3 seconds. This change adds additional parameters to RequestAXTreeSnapshot to enable it to run faster, by limiting the number of nodes, excluding offscreen nodes, and returning partial results after a timeout elapses. This change adds test coverage but does not change any code to use these new parameters, so there shouldn't be any side effects of landing this patch. A follow-up will change the Android callers to pass different parameters. Bug: 1161541 Change-Id: Ie2394b451a53636d833944448157ae4300dabd7a AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602697Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841710}
-
Scott Violet authored
If consent is not given, then the code paths are never entered that delete state. BUG=1164104 TEST=AndroidMetricsServiceClientTest* Change-Id: Iaf5a750888b3e0727cad41e02ba10150f2d4c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617238Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841709}
-
Josiah K authored
Currently, when Switch Access captures a switch, it doesn't care which device it comes from. For example, if you have a Bluetooth switch that emulates keyboard keys '1' and '3', those keys will also be intercepted for Switch Access from your built-in Chromebook keyboard. Ideally, we would be able to distinguish between keys depending on the device they come from. Structural code in place at crrev.com/c/2613009. Before: https://screenshot.googleplex.com/7StUsjssf5XqmzG After: https://screenshot.googleplex.com/4EhHjsYdJUqBQ4G Fixed: 1163371 AX-Relnotes: N/A. Change-Id: I610e25bd9057db2ecb7b470e3990ef4a27c0444b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610992 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841708}
-
Ghazale Hosseinabadi authored
This CL documents extension layer's interactions with service worker layer. Bug: 1152530 Change-Id: If66b51440d79400f619ca8b03ae72897976aa813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559213 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841707}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa449cf3b0d0..038ae1448ac1 2021-01-08 jmadill@chromium.org Vulkan: Fix up varying component limits. 2021-01-08 jmadill@chromium.org Program: Move more common code to ProgramLinkedResources. 2021-01-08 m.maiya@samsung.com Vulkan: Add GL_EXT_clip_control entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I0c97a36e0c136aa7a38e91a3a616f55576ee2bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618598Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841706}
-
Simon Pelchat authored
Bug: 1163983 Change-Id: Ic16c8a3015d29df741fbd50b4496205255bc5512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618541 Commit-Queue: Simon Pelchat <spelchat@chromium.org> Auto-Submit: Simon Pelchat <spelchat@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#841705}
-
Adam Langley authored
This root may now be used by Google. Change-Id: I7ad0c8348a21cfa1f00ea4d1bdfa0360f6cace52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618543 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841704}
-
Daniel Cheng authored
As of https://crrev.com/c/1684998, FrameLoader::Init() no longer calls FrameLoader::DetachDocument(). Since this was the only case where the Document and DocumentLoader could be null, FrameLoader::DetachDocument() no longer needs to handle this case. Bug: 855189 Change-Id: I10fe2b6ecc6765e73675676dda72c666401b5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617001 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841703}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/59450acba8d5..3be8a6b93877 2021-01-08 cjamcl@chromium.org [Lighthouse] Avoid reprocessing the same Network events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I490d59fe08c542767939335720fe41f8de3fe02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841702}
-
Xianzhu Wang authored
1. Move the code checking requirement of overflow clip for printing from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). 2. Combine LocalFrameView::ClipPaintRect() into LayoutView::ViewRect(), so that all code paths calling ViewRect() (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport overriding aware. This means that the overriding viewport is reflected in the paint property tree, and CompositedLayerMapping::RecomputeInterestRect() no longer needs to apply the viewport clip separately. Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841701}
-
Mingjing Zhang authored
This CL checks if the |history_service| is valid before it is used to build a DomainDiversityReporter. This is a guard against unexpected crashes in DomainDiversityReporter which always requires a valid history service. Bug: 1161727 Change-Id: Ie946abe755f7a32bf7b7173e3b146326459edcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611668Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841700}
-
rbpotter authored
Bug: 1132403 Change-Id: Ia48978c88c7c4c04172ed7fc64a187cb4af37427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616880Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841699}
-
rbpotter authored
Add js_library targets for: model_settings_availability_test model_settings_policy_test model_test Bug: 1000989 Change-Id: Ida87d1c829e06fb3026f8251d7fe5c36012a3d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617214Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841698}
-