- 04 Oct, 2018 40 commits
-
-
Martin Kreichgauer authored
This change extracts an abstract base class called FidoDiscoveryBase from FidoDiscovery. The FidoDiscovery::Observer interface is moved into the base class, and its signature is changed to allow observing the instantiation and destruction of FidoAuthenticator instances rather than FidoDevice. I.e. FidoDiscovery::Observer::Device{Added,Removed} becomes FidoDiscoveryBase::Observer::Authenticator{Added,Removed}. FidoDiscovery takes on the responsibility of instantiating and owning FidoAuthenticator instances (more specifically, FidoDeviceAuthenticator instances). The AuthenticatorMap in FidoRequestHandlerBase now only holds plain FidoAuthenticator pointers, rather than owning the unique_ptrs. This gets us closer to getting platform-y authenticators (Touch ID, Windows) injected via Discovery implementations, rather than implementing custom interaction between FidoRequestHandlerBase and AuthenticatorImpl for them (see SetPlatformAuthenticatorOrMarkUnavailable). Better naming might have been "FidoDeviceDiscovery" for FidoDiscovery and perhaps "FidoDiscovery" for FidoDiscoveryBase, but that would be a rather large diff. A sensible additional refactoring might be to make FidoDeviceAuthenticator own its associated FidoDevice. Change-Id: I05d9c24819745c784fef3898bec8d6bb63d2f503 Reviewed-on: https://chromium-review.googlesource.com/c/1256016 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596882}
-
Katie D authored
This makes Slides read more smoothly, but will not differentiate between spaces between words and paragraphs in intonation. DOM ordering is used rather than visual ordering, this is unchanged. Bug: 809734 Change-Id: Ieb17eef53f4de360f2d1f13e8a561d3aa05af115 Reviewed-on: https://chromium-review.googlesource.com/c/1262086Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596881}
-
Robert Ogden authored
Also adds a "Settings" link on Android only that opens the Data Saver settings menu, and related UMA. Bug: 889124 Change-Id: I087a4719671d5ce811c52331f2906e1e4202ced4 Reviewed-on: https://chromium-review.googlesource.com/c/1258972Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#596880}
-
Tarun Bansal authored
NavigationPredictor: Normnalize the final anchor element prediction score to between 0.0 and 100.0. This makes it easier for different experiment arms to change the scales of different anchor element properties and still compare the final anchor element score. Bug: 891736 Change-Id: I7378fe3d8fe68cde32c6216802b077432758562a Reviewed-on: https://chromium-review.googlesource.com/c/1259142 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Maks Orlovich authored
Android WebView limits cache to 20MiB as of now, which resulted, before this change, in a 2.5MiB size limit for individual resources... resulting in parallel fetches to those resource failing due to lack of a cache entry to back multiple readers. This bumps the limit to at least 5MiB to mitigate somewhat. Bug: 890973 Change-Id: Ic6b587414c85d47dbc62411d508446e33cb5cd17 Reviewed-on: https://chromium-review.googlesource.com/c/1262575Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#596878}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/38772e9f7456..d8ac668fad02 git log 38772e9f7456..d8ac668fad02 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 tsepez@chromium.org Remove CPWL_Wnd::GetClassName() and overrides. 2018-10-04 tsepez@chromium.org Remove CPWL_EditCtrl::m_pEdit null checks. Created with: gclient setdep -r src/third_party/pdfium@d8ac668fad02 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I390f8b85edb0e19e2bcf4a7dc18b0a276efe840e Reviewed-on: https://chromium-review.googlesource.com/c/1262776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596877}
-
Benjamin Shaya authored
Bug: 117179835 Test: cast_audio_backend_unittests, tuning tool Change-Id: I57b1a3343c5964b96761eef4e2936da6cf5105c0 Reviewed-on: https://chromium-review.googlesource.com/c/1258314 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#596876}
-
Michael Spang authored
This is not used in production as the linux ImageTransportSurface strictly perfers the surfaceless version. It also never quite worked correctly as we can't emulate the EGL default framebuffer fully on top of surfaceless. Bug: none Test: compile Change-Id: I21a51df5bce5f1a7221611d92b929624fef44a0a Reviewed-on: https://chromium-review.googlesource.com/c/1262616Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596875}
-
Bailey Berro authored
- Adds support for placeholder text to cr-searchable-drop-down - Adds example share path \\server\share to File share URL field in the add share dialog. Bug: chromium:889287 Change-Id: I0ee1bc39e10acec419e4ec8935e6a45caa790a18 Reviewed-on: https://chromium-review.googlesource.com/c/1258309 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596874}
-
Michael Spang authored
This is not used with surfaceless; vsync timing information comes via the PresentationCallback. Bug: none Test: compile Change-Id: I73895bc913dfc2cc03381debcac83108828301d2 Reviewed-on: https://chromium-review.googlesource.com/c/1262615Reviewed-by:
-
Michael Spang authored
This function has no call sites. Bug: none Test: compile Change-Id: I8865153bb65b430809a5a5e1bbbe540c3c5b816f Reviewed-on: https://chromium-review.googlesource.com/c/1262434Reviewed-by:
-
Scott Violet authored
The comment implies it can only be used from tests, which isn't entirely right. BUG=none TEST=comment only change Change-Id: I56ab2fa84fa87b94d29481ba8d9457b2470218ac Reviewed-on: https://chromium-review.googlesource.com/c/1261979Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596871}
-
Andrew Luo authored
Bug: 814405 Change-Id: I55b8c06553a45c24a5527bc5b482d19d9d76fd8f Reviewed-on: https://chromium-review.googlesource.com/c/1262915Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596870}
-
Nasko Oskov authored
In order to better handle messages sent from RenderFrames in the renderer process during unload event, we should keep the browser side objects alive as long as possible. This CL moves ownership of subframes to RenderFrameHost, which can allow the subframes to live until the unload handler of the top parent has completed running. The CL is just a mechanical move of the ownership and does not change the lifetime of subframes for now, which will come in a follow up CL. Bug: 609963 Change-Id: I52456dc1bf68cb15caab527c16c96ddd13a80838 Reviewed-on: https://chromium-review.googlesource.com/c/1098562Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596869}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c92be0189275..bf0d2438ae53 Created with: gclient setdep -r src-internal@bf0d2438ae53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d393e0c019d1100abf565dc5db9fcca0506329a Reviewed-on: https://chromium-review.googlesource.com/c/1262775Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596868}
-
Mitsuru Oshima authored
Requesting new rotation while coyping layer used to cancel the existing rotation and moved to new one, which was causing an issue in Android CTS. Instead, apply the requested orientation immediately and move to next rotation. This still skips the pending request if yet another request is made while doing rotation animation. I don't think this will cause issues on Andrid so I'm leaving it as is. Bug: 891737 Test: covered by unittests. Change-Id: Ic558ecccf594664d1f7b91b830aca33f5ba89d9f Reviewed-on: https://chromium-review.googlesource.com/c/1257143 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596867}
-
Marijn Kruisselbrink authored
This reverts commit bdb69cb2. Reason for revert: Failing checkbins on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/3814 Original change's description: > Google Credential Provider for Windows. > > Initial commit of COM object implementation. > > Bug: 789588 > Change-Id: I2926f9a46f898c236251131e7e2b215e2bdb967a > Reviewed-on: https://chromium-review.googlesource.com/c/1190583 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Marc-André Decoste <mad@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596836} TBR=rogerta@chromium.org,pastarmovj@chromium.org,mad@chromium.org,thakis@chromium.org,fdoray@chromium.org,zmin@chromium.org,jochen@chromium.org,grt@chromium.org Change-Id: Ia05d3d5a987d780da8c2f0f922becf67a145cc14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789588 Reviewed-on: https://chromium-review.googlesource.com/c/1263048Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#596866}
-
Jacob Dufault authored
When the basic auth widget appears, it is fetching the parent widget using WebContentsModalDialogHost::GetHostView. CaptivePortalDialogDelegate overrides this to return the captive portal widget, which is hidden. Thus, the auth widget is also hidden because its parent widget is hidden. I believe the correct long-term fix is to not share a WebContents instance bewteen OoobeUIDialogDelegate and CaptivePortalDialogDelegate. However, that seems like a much riskier change. Add a hacky check to return the widget for OoobeUIDialogDelegate if the CaptivePortalDialogDelegate widget is currently hidden. Bug: 890976 Change-Id: I0d974449d7eb425a8bb99dcc8d34eb6582c097e7 Reviewed-on: https://chromium-review.googlesource.com/c/1263040Reviewed-by:
Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#596865}
-
Reilly Grant authored
This change refactors the ProfileAuthDataTests to use the CookieManager interface provided by the Network Service rather than calling the net::CookieStore interface directly. Bug: 792678 Change-Id: Iae3283932b932998dd7acfe1b7006de7a5d0176c Reviewed-on: https://chromium-review.googlesource.com/c/1263039Reviewed-by:
-
erikchen authored
The test control is responsible for synchronizing certain renderer state (such as Focus). The test runner must wait for this state to synchronize before launching the layout test, as otherwise there will be races. Change-Id: I6a01ae66ff4b6040184b86035576a32968010499 Bug: 889036 Reviewed-on: https://chromium-review.googlesource.com/c/1262375Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596863}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4ead90b0373..49b0f6eb413b git log b4ead90b0373..49b0f6eb413b --date=short --no-merges --format='%ad %ae %s' 2018-10-04 fjhenigman@chromium.org Vulkan: read pixel buffer alignment must be 4. Created with: gclient setdep -r src/third_party/angle@49b0f6eb413b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6aa7d4f778c7193be54d2442836dfedc1b5443bb Reviewed-on: https://chromium-review.googlesource.com/c/1262975Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit 162bfa65. Reason for revert: Seems to be causing leaks in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/24959 Original change's description: > Events: CustomEvent.detail should use ScriptValue::V8ValueFor > > Storing details as TraceWrapperV8Reference is not good. > We should use ScriptValue and return it using V8ValueFor(). > > Bug: 891598 > Change-Id: I7ff310ed6fda629ed316e99e8ac13fd10b5aed53 > Reviewed-on: https://chromium-review.googlesource.com/c/1257472 > Reviewed-by: Jinho Bang <jinho.bang@samsung.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#596795} TBR=yukishiino@chromium.org,jinho.bang@samsung.com,haraken@chromium.org,ggrace.kim93@gmail.com Change-Id: I354de04091d5a8a40e99a6a5ea072557b84cc790 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891598 Reviewed-on: https://chromium-review.googlesource.com/c/1262968Reviewed-by:
-
Eric Roman authored
Bug: 721403 Change-Id: I126d12c56012f27a0962987b98c52f8bbd50ef92 Reviewed-on: https://chromium-review.googlesource.com/c/1260384Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596860}
-
Hector Carmona authored
Minor tweaks to font face, font weight and spacing. Bug: 874118 Change-Id: Ibe968ddcc5ac3ffc6462c0981286db695c5888f6 Reviewed-on: https://chromium-review.googlesource.com/c/1258606 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596859}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58887bc3c186..ae16b74365f4 git log 58887bc3c186..ae16b74365f4 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 mtklein@google.com Reland "hash tf, and whole colorspace" 2018-10-04 mtklein@google.com remove deprecated SkRect::MakeFromIRect() 2018-10-04 jvanverth@google.com Implement more SkImage_GpuYUVA functionality 2018-10-04 mtklein@google.com remove SkColorSpace::toXYZD50() 2018-10-04 mtklein@google.com tune SkOpts::hash_fn() quality 2018-10-04 brianosman@google.com Remove unused Options parameter from SkImageGenerator::getPixels 2018-10-04 brianosman@google.com Remove scaling support from SkBitmapCacheDesc, and unused factories 2018-10-04 halcanary@google.com SkPDF: build shared lib with skia_enable_pdf=false 2018-10-04 halcanary@google.com SkQP: update script tools/skqp/make_universal_apk 2018-10-04 brianosman@google.com Use SkPMColor4f in OverrideInput, remove some kruft from SkGr 2018-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5541a6c86a64..76dd2d6f9f5e (2 commits) 2018-10-04 halcanary@google.com SkCanvas: remove unused SkCanvas::InitFlags 2018-10-04 mtklein@google.com Revert "hash tf, and whole colorspace" 2018-10-04 stani@google.com Update android apps to latest android plugin Created with: gclient setdep -r src/third_party/skia@ae16b74365f4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ia00c61d93e72282897253ab0f527e5e83126b979 Reviewed-on: https://chromium-review.googlesource.com/c/1262093Reviewed-by:
-
lanwei authored
When we use Ctrl+F to open the find bar to seach text in the page, we should not pop up the virtual keybaord. Bug: 871756 Change-Id: I64fa8337668f823aeb6f5d5af2aae0e9fc50e684 Reviewed-on: https://chromium-review.googlesource.com/c/1257582Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#596857}
-
Mrunal Kapade authored
This patch enables system wake lock on blink side by making use of ServiceManager Connector and WakeLockProvider. BUG=873030,257511 Change-Id: Ie4cb38124d0072d12d663ef4d1ae7311a1233460 Reviewed-on: https://chromium-review.googlesource.com/c/1256220 Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596856}
-
Karan Bhatia authored
This CL moves most of the test code in ExtensionWebRequestHelpersTestWithThreadsTest.TestHideRequestForURL in the chrome/ layer to a similar test in the extensions/ layer, thereby de-duplicating code. BUG=884932 Change-Id: Ic7b3907e1a87e20959839461559f881ffabaed2c Reviewed-on: https://chromium-review.googlesource.com/c/1260493 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596855}
-
Marijn Kruisselbrink authored
This reverts commit c9bd3947. Reason for revert: test is flaky in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/35061 Original change's description: > [Background Fetch] Add WPT tests for BackgroundFetchRegistration::abort > > Simplify event dispatching code, and also allow for match/matchAll to be > called with the abort event. > > Change-Id: I3a9d17102f176f7c68131ea144e555a44ffd6ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/1261477 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596723} TBR=peter@chromium.org,nator@chromium.org,rayankans@chromium.org Change-Id: I70bb246625c9d98707c6f61a91dc2dd658b1027f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1262965Reviewed-by:
-
Becca Hughes authored
Adds support for gain transient which will pause all other media sessions when it gains focus. When it loses focus the top most session will resume playing. This is used for short media that should not play over the top of other media sessions. Also adds the Resume method to the MediaSession mojo interface which is needed for resuming sessions. BUG=891534 Change-Id: I4d00f2602c46c03680305f8f750294776afdbc24 Reviewed-on: https://chromium-review.googlesource.com/c/1258975 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
R=jchinlee@chromium.org BUG=864817 Change-Id: I706e97f576cbb04d4f3928d00e3b3de006b859e5 Reviewed-on: https://chromium-review.googlesource.com/c/1263036Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596852}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1cac54c9..fdd620c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide4cfac07e8b1bc5b069221cc124d3f650063675 Reviewed-on: https://chromium-review.googlesource.com/c/1262620Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596851}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I0310c4d85db952e5ee518f7f5aa61eb33341acb7 Reviewed-on: https://chromium-review.googlesource.com/c/1258982 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596850}
-
Steven Bennetts authored
Original CL: https://chromium-review.googlesource.com/1226191 This CL moves some common flag/switch wrappers into the callers to remove unnecessary dependencies on keyboard_util.h. With the upcoming Chrome/Ash separation, the wrappers cause more confusion than they improve readability. This CL also moves some keyboard_util.cc code only used in KeyboardController to that class. For minor changes to input_ime_api_chromeos.cc, approved in Take 1: TBR=shuchen@chromium.org Bug: 843332 Change-Id: I4e6ee790190dbf10cd64a8d3a18fbeca982fce07 Reviewed-on: https://chromium-review.googlesource.com/c/1259478 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#596849}
-
Christopher Thompson authored
This change special-cases the |support_url| used for Symantec SSL interstitial pages "learn more" link. The new support URL (p=symantec) will take users directly to a specific Symantec errors section of the help center article. Bug: 891465 Change-Id: Ie3262418767496c24c421db24f740cfa2aeb9f2c Reviewed-on: https://chromium-review.googlesource.com/c/1262637Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#596848}
-
Reza.Zakerinasab authored
This preserves colorType and alphaType of the original image. TBR=fserb@chromium.org Bug: 892281 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iebd663cd45199ab7a22e5d98d671dbf54bee9fb3 Reviewed-on: https://chromium-review.googlesource.com/c/1262427Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#596847}
-
rbpotter authored
(1) Escape key events on the provisional dialog itself (not on <body>) need to be caught in the dialog in order to prevent them also closing the Print Preview UI and the destinations dialog. (2) Add a test for the provisional destinations dialog opening/closing behavior. Bug: None Change-Id: I28e4f0cf1e3bd98ab30a92ac768fe8c59dd3ad9c Reviewed-on: https://chromium-review.googlesource.com/c/1258508 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596846}
-
Sebastien Marchand authored
Change-Id: I532976c3cec5dbfee2c11cfa1fecceff202b720b Reviewed-on: https://chromium-review.googlesource.com/c/1258298 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#596845}
-
Daniel Cheng authored
Bug: 891686 Change-Id: I5770942e18ee8a9221f322101bcc2793d74d3695 Reviewed-on: https://chromium-review.googlesource.com/c/1262617Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596844}
-
Francois Doray authored
This is step 8 of go/finch-best-practices. Bug: 691886 Change-Id: If2eaf11b08e975bd1dfa864e1ff8b2a90c70d6bf Reviewed-on: https://chromium-review.googlesource.com/c/1249906Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#596843}
-
