- 28 Jan, 2020 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I98b03a9458420711b4674d77239c98256cac6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024541Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735952}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I4bede74331ade6af2776fe665b4e682f031d45aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987070 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#735951}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a5dab00ae22..260c788d77ca git log 4a5dab00ae22..260c788d77ca --date=short --first-parent --format='%ad %ae %s' 2020-01-28 peah@webrtc.org AEC3: Added multi-channel support for the capture delay functionality Created with: gclient setdep -r src/third_party/webrtc@260c788d77ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045910 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I806d1174dd8336643d28a1a1bfd6b0a559e7295d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735950}
-
Finnur Thorarinsson authored
Bug: 895776, 656015 Change-Id: I196ae815f631376f0ea6cbb26fdadf4e61e2a38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023791 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735949}
-
Kevin Ellis authored
CommitStyles provides a convenient way to update the style of an element, avoiding the need to keep finished animations persistent in order to stack effects. A typical use case is: const anim = elem.animate(keyframes, {..., fill: 'forward'}); anim.finished.then(() => { anim.commitStyles(); anim.cancel(); }); Spec: https://drafts.csswg.org/web-animations-1/#dom-animation-commitstyles Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/H5sz_dg6fKc/1X7K7U4XCgAJ Bug: 981905 Change-Id: I37f61960480517e0a8f3427938cf799de4c6e9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017673 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:Robert Flack <flackr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#735948}
-
Maksim Ivanov authored
This relands the commit 8fd76b23 that got reverted in commit 319c9b41 due to failing on official trybots. The fix in the reland is to suppress the sync consent screen that is normally enabled on the "branded" builds and that was breaking test expectations (the test expected the user session to start straight away after the successful authentication without any extra screens). Original change's description: > Add browser tests for smart card SAML login > > Provide test coverage for the scenario where a new user authenticates > via SAML using a smart card (or, generally speaking, using a security > token via an extension using the chrome.certificateProvider API). > > This also provides some test coverage for the <security-token-pin> > Polymer element used on the Login Screen. > > Bug: 1033936 > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734510} Bug: 1033936 Tbr: alemate@chromium.org, hendrich@chromium.org Test: run the test locally with is_chrome_branded=true Change-Id: I0e8394bb78030137c7570d58c2462a773c13ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017430 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735947}
-
Mustaq Ahmed authored
Bug: 1046256 Change-Id: If98bfe75ce859bd9b88c39923c740618129c8d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024915 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735946}
-
Nektarios Paisios authored
If the provided text marker is between lines, such as when on a soft line break or on an ignored position that separates lines, we return the previous line when VoiceOver asks for the line text marker range. This is the same to how the WebKit code in Safari works. See webcore/editing/VisibleUnits.cc::endOfLine(VisiblePosition&, LineEndpointComputationMode, bool) in the WebKit source code. Also, this patch temporarily switches to CreateNextLineStartPosition for computing the end of the line range. This should not have any drastic user visible behavior change, but it's important to do until CreatNextLineEndPosition is fixed to handle ignored positions. Failure to introduce this workaround would delay fixing of line navigation in Docs with VoiceOver. R=dmazzoni@chromium.org Bug: 1015408 Change-Id: Ifeb67d4de688fddace461568e064fc9768024fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023277 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#735945}
-
Elly Fong-Jones authored
This is a reland of fd84ab8a. This change: 1) Includes a new cipd package version that contains the 'size-classic' binary from the 10.15 SDK, missing in the original package 2) Can be coordinated with a re-land of the internal CL (https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2404878) to keep the perf builders happy - they are stuck on the 10.14 SDK for reasons currently obscure. Original change's description: > mac: roll to 10.15 SDK > > This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the > 10.15 SDK. > > Bug: 1023913 > Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#725141} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723 > Cr-Commit-Position: refs/heads/master@{#730238} Bug: 1023913 Change-Id: I62d9e82673b2d3f4993fbd08654fed85c2319cfb Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#735493} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024490 Cr-Commit-Position: refs/heads/master@{#735944}
-
Dominique Fauteux-Chapleau authored
Add code to use the appropriate drag-data, drag-file and paste strings instead of just defaulting to the upload strings. Removes the optional part of the access point since it's used to determine the appropriate string now. Bug: 999145 Change-Id: I115cd567f94d9c4ca7a4befdff386ba76163ae20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016965 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#735943}
-
Gauthier Ambard authored
This CL fixes how the NavigationManager reloads the page with a different user agent when there is a redirect after opening a new tab. In that case the last committed item before the redirect is nil. The last committed item should be used. Fixed: 1046342 Change-Id: I18323b14fdc6a727163f25da36f5dacb4f13b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023560 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#735942}
-
Guillaume Jenkins authored
Now that the WindowsSpellChecker class is in its own file, the component tests that were testing its methods should also move to a corresponding windows_spell_checker_unittest.cc file. The tests were initially testing the methods inside the spellcheck_platform namespace, but those methods were simple pass-throughs to the WindowsSpellChecker class, so it made sense to simply reuse those tests for WindowsSpellChecker directly. #Squeegee Bug: 463364, 1035044 Change-Id: I11a46e67d5529063a8f63e7e55de62013ba8627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023466Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#735941}
-
Md. Hasanur Rashid authored
The Chromium C++ style guide recommends that DVLOG is used as it "avoids bloating the release executable and in debug can be selectively enabled at runtime". Bug: 519010 Change-Id: I1d896ea332426b8d3ec281a4b313221e8b8fb19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024251Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#735940}
-
Yi Gu authored
The tests under virtual/ are also flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2Nzcy9maWx0ZXItZWZmZWN0cy9pZGxoYXJuZXNzLmFueS5odG1sDA TBR=schenney@chromium.org Bug: 1042453 Change-Id: Ib0cab652bb61b23012c12260974a5645b83e2c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024455Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735939}
-
Aga Wronska authored
Bug: 1043712 Change-Id: I480956cb5b6af11443fdf00890351c1cabec5832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023301 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/985f7cf5466a..f1dc5730d8ef Created with: gclient setdep -r src-internal@f1dc5730d8ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If635632fd0cba63f2829359233c19d919d143617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025064Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735937}
-
Maria Kazinova authored
The FormData extraction code was racing against new page load even though FormData was already passed into a function in string format. Now the FormData is extracted from a passed in string. Bug: 418827 Change-Id: I845b539974b57d1f430016f4500af5a4da5fcbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022771Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#735936}
-
Yi Gu authored
The test AutofillInteractiveTestWithHistogramTester.BasicFormFill is flaky on TSAN. See bug for details. TBR=battre@chromium.org Bug: 1045709 Change-Id: I98b1e26cecf46ad3ed886ce2b99690e93478a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024921Reviewed-by:
-
Stephen Chenney authored
Two tests had bad ref images, the rest fail mostly due to aliasing differences with a couple that really seem to fail. TBR: fs@opera.com Bug: 1044742 Change-Id: I17a7ad5c2e7b2657b1df4b970134bafb8444b6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024180 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#735934}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I773c77e737c0d82d47845d0f2a0f6d2616cc66ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025065Reviewed-by:
-
chrome://safe-browsing/#tab-rt-lookupXinghui Lu authored
This flag will be useful for testing on Android, because it takes memory threshold into account. Screenshot: http://screen/7NSFgNqotba.png Bug: 1014202 Change-Id: I5c647c73228a875144df514ea344203cd0e46583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024409Reviewed-by:
-
David Bokan authored
Programmatic smooth scrolls should also be instant if the smooth scroll flag is explicitly disabled. Previously landed in https://crrev.com/c/1536759 https://crrev.com/c/2009842 https://crrev.com/c/2022356 To reland, this CL force enables the scroll animator in Blink web tests. Without this, the usual flow for determining if the animator is enabled is followed, which leads to inconsistencies. On Mac, the animator is enabled in Chrome but not in content shell. This leads to inconsistencies with other platforms (Mac tests ran without smooth scroll while Linux/Windows ran with) and ensuring we test what we ship. This change required some minor fixes to tests that assumed instant scroll on Mac (and uncovered one real bug). Second reland fixes a few more tests on Mac. See diff from original patchset for changes. Third fix addresses flakiness in some of the Mac tests. Original patchset has reverted CL. TBR=flackr@chromium.org,nasko@chromium.org Bug: 944583 Change-Id: I6b1ccb719b6bbed2b6d7495efa4d7846424796d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024163Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735931}
-
Daniel Vogelheim authored
This introduces a "sample_prefix" to CSP sample reports, for non-user derived data. Reason: CSP reports clip the sample to 40 characters. Trusted Types reports prepend the sink name to the 40-char clipped sample. That part should not be counted towards the limit. Bug: 991195 Change-Id: Id7a44d815d27a6bd341187c1318ccae1fd234ef7 Co-Authored-By: ssanfilippo@chromium.org Co-Authored-By: vogelheim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763678Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735930}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I1ddc44348261707de426dc3b4168196145a52f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017463 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735929}
-
Armando Miraglia authored
After manual testing on a Ubuntu distribution (more precisely a XUbuntu 18.04) I was able to determine that libnss_compat is needed by ALSA to communicate with libnss and be able to read the groups available on the system. This CL adds the affected library to the loaded list of libraries in the audio sandbox hook for linux. Bug: 1032949 Change-Id: I779158f6cf4eb48ef6b29469ee52181f0c69a70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023893Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#735928}
-
Wez authored
IntlHash is no longer a valid DOM |code| value, so remove it from the DomCode tables, along with the associated KeycodeConverter work-around for it having a native keycode indistinguishable from US Backslash on all platforms, except at the actual USB Usage level. Bug: 952051 Change-Id: I0774105ab845ce5cbda475e9ae19f792745eca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020708 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735927}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I2cb1c8961842dafcec1e755567133bf8730ef7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017406 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99dead98309c..f76da63fbdfc git log 99dead98309c..f76da63fbdfc --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kjlubick@google.com [canvaskit] Update build script to support latest Emscripten Created with: gclient setdep -r src/third_party/skia@f76da63fbdfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ib54e1fdd041fc472e30335b6bd8607775dc4f75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025061Reviewed-by:
-
Jonah Ryan-Davis authored
There was a mismatch between methods of retrieving GLX extensions in Chrome, causing certain available/used extensions to not appear on about::gpu. Additionally, there is an opportunity to cache the extension string and save calls. Bug: 1043761 Change-Id: I39bde9702daf9b5cf80a5cc1c9a030ef56623913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015644 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735924}
-
Avi Drissman authored
This is part of the work of cleaning out sdk_forward_declarations. BUG=1044828 Change-Id: Ifc1affd27e949b4d46d94d10b001f6988df8b290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019585 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735923}
-
Austin Eng authored
This reverts commit 4c3c01fd. Reason for revert: See crbug.com/1046362. Suspect that the Clang roll is causing a breakage on the Dawn CQ. No Dawn changes in the regression range, so reverting this suspect CL. Original change's description: > Roll clang n332890-c2443155-2 : n340584-68051c12-1. > > Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. > > This increases the clang version from 10 to 11. > > Bug: 1030664 > Change-Id: I8b7ad7f85895abda80e45860ab7e0215e6740d13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020894 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735635} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Id2b490358eb3e9a7d4d220ab87cd357e895e218d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024456Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#735922}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9709fb4b440..315382afa699 git log d9709fb4b440..315382afa699 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skyostil@chromium.org Revert "timeline: Support new style slice ids ('id2')" 2020-01-28 abennetts@google.com Introduce a repository filter for commits. 2020-01-28 skyostil@chromium.org timeline: Support new style slice ids ('id2') Created with: gclient setdep -r src/third_party/catapult@315382afa699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045197,chromium:639003 Tbr: skyostil@google.com Change-Id: I67c6879c8133b2609b1e65dec1191b0aeb20e54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025059Reviewed-by:
-
Etienne Pierre-doray authored
This histogram is expired. It is also causing dead lock issues when called from WorkerThread::Start. Bug: 1043353 Change-Id: Ica96db5b06ed85a84953413b6be0cc5b2213e9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016163 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#735920}
-
Sebastien Marchand authored
The current convention is to not send notification when the system exit memory pressure, this isn't ideal as it doesn't let stateful listeners know that they should stop their intervention. This CL was uploaded by git cl split. R=morlovich@chromium.org Change-Id: Ief0ffac5125e55a233e483e2a749e65927fc6894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017046 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#735919}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0681dd61d3b0..821d564bc789 git log 0681dd61d3b0..821d564bc789 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 rharrison@google.com Rolling 5 dependencies and updating expectations (#975) Created with: gclient setdep -r src/third_party/shaderc/src@821d564bc789 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I54bd6a6d4ec0415decf1a22c5c74857eac521e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025057Reviewed-by:
-
Guido Urdaneta authored
Bug: 1017219 Change-Id: I06d6990385f0e251fcffbf7b5149731022c4b2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023894 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#735917}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/759ef9738531..912cec0c6822 git log 759ef9738531..912cec0c6822 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 tvanderlippe@chromium.org Add istanbul-diff to node_modules Created with: gclient setdep -r src/third_party/devtools-frontend/src@912cec0c6822 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b4cdb7d1c23682c5ea8ec8ef0414f6737e7e88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025060Reviewed-by:
-
Yi Gu authored
This test passes on several bots but is marked as Crash only. Update the expectation accordingly. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/mouse-scrolling-on-div-scrollbar-thumb.html TBR=bokan@chromium.org Bug: 979408 Change-Id: I12d30310e567f08b3093236a9a098fd5d41074b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024538Reviewed-by:
-
Yao Xiao authored
What: Currently we only know ad status of a LocalFrame. This patch will add the status to RemoteFrames. Why: This makes it easier to implement some ad detections - sticky ads, interstitial ads, etc. Those detections will involve frequently querying the layout information and is_ad information of a Frame. So we tag remote frame to avoid going through the browser process each time we want to know ad status on a remote frame, so that the detection/intervention can probably all be done on the renderer side. How: Add the "ad_frame_type" bit to FrameReplicationState. In ContentSubresourceFilterThrottleManager::ReadyToCommitNavigation, set the frame replication state and also notify all RemoteFrames about the new status. Testing is done within content/ to avoid exposing the proxy details outside of content/. Bug: 939370 Change-Id: I26fd2acb10b3a5e837aacdc3d3f3e2a05563694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913074 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735914}
-
Tim Volodine authored
The test is flaky on the android-pie-arm64-rel bot. BUG=1046382 NOTRY=true TBR=chouinard@chromium.org,xingliu@chromium.org Change-Id: Ib10da045ae988a1e12a268fff1c9a7ddfe55e1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023500 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735913}
-
