- 13 Apr, 2018 40 commits
-
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a115e67e50..54a81e45ddfc $ git log 53a115e67..54a81e45d --date=short --no-merges --format='%ad %ae %s' 2018-04-12 kkinnunen Add support for downloading Windows VS toolchain from a HTTP URL Created with: roll-dep src/third_party/depot_tools BUG=chromium:830569 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I891b5ae2d18128cdd16a03343ea05136c498974c Reviewed-on: https://chromium-review.googlesource.com/1011666Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550609}
-
Hans Wennborg authored
Bug: 828582 Change-Id: I85864722c577268d9c95a0d9c37cf7197b04e5d3 Reviewed-on: https://chromium-review.googlesource.com/1012028Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#550608}
-
David Roger authored
Dice Milestone 2 was enabled by default in CL: https://chromium-review.googlesource.com/c/chromium/src/+/975561 However this is causing issues when signing into Google properties on the web, because the new server endpoint rejects most of the client IDs. This restores the previous behavior. Bug: 829220 TBR: jwd Change-Id: I3d7c22cb10f0d900c8d897369b063ac236f12146 Reviewed-on: https://chromium-review.googlesource.com/1011620 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#550607}
-
Rune Lillesveen authored
If the default font-size changed, and media queries have font relative lengths, then media query evaluations may have changed. Bug: 830119 Change-Id: I912adddcdbd05b729678cff14d16245a35bca3e1 Reviewed-on: https://chromium-review.googlesource.com/1000852 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550606}
-
stkhapugin@chromium.org authored
Modifies the format types passed to the URL formatter in GetURLForDisplay() on iOS to trim after host. Bug: 821801 Change-Id: Ib744a161d0488b5e0f3ee8e0d81947da17bb22cb Reviewed-on: https://chromium-review.googlesource.com/1007079 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550605}
-
Francois Doray authored
The browser/ and renderer/ subdirectories no longer exist in components/task_scheduler_util/. There is no good reason to keep the common/ subdirectories, everything can be moved directly to components/task_scheduler_util/. This is the last phase of the clean up planned in https://crbug.com/810049 TBR=asvitkine@chromium.org Bug: 810049 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If5d000edfd1bd689950ab8f8a6992ecbfbb93c78 Reviewed-on: https://chromium-review.googlesource.com/1005788 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550604}
-
Egor Pasko authored
The strings present in kCommandNames needs to be handled in ExecuteCommands(). Also fix a random typo. There is a not-landed patch to use the batch mode: https://codereview.chromium.org/2112013003/ Due to a bug in this patch the command 3 was never passed to cachetool, and hence this problem was not noticed. Bug: None Change-Id: I0f5dbdf96e0e771b265400f5b87eee356722ccd4 Reviewed-on: https://chromium-review.googlesource.com/1010290Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550603}
-
Kuo-Hsin Yang authored
https://crrev.com/c/980742 replaces EstimatedMemoryFreedKB() with GetEstimatedMemoryFreedOnDiscardKB() which always returns 0. It confuses Chrome OS Tab Manager and all tabs except the front tab are discarded. It's a quick fix to make tab discard work on Chrome OS. Bug: 832517 Change-Id: Ic72be7a7535bf6e0a48a6f6efa9afc28635813c8 Reviewed-on: https://chromium-review.googlesource.com/1011885 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550602}
-
Maksim Ivanov authored
* Store the challenge-response key information in KeyDefinition; * Support the new challenge-response user key class in the to/from cryptohome protos conversion code. This is preparatory work for implementing the smart card sign-in in Chrome OS. This CL alone is expected to bring no change of behavior. Some more details for the context: This CL is part of effort for allowing signing in via a cryptographic token (e.g. a smart card) instead of a password. The actual secret passphrase (used for protecting the local cached data) isn't shared with the browser anymore. Instead, all structures related to the user's key in the browser memory and in the D-Bus protocol are containing only the *public key information*. When an authorization using such key takes place (e.g., when mounting the user's cryptohome), the cryptohomed daemon will issue a challenge request to the browser, and the browser has to respond with the signature of the challenge. Bug: 826417 Test: chromeos_unittests --gtest_filter=CryptohomeUtilTest* Change-Id: I7ef230a8f9829ffd88e4489338ff84d91466de31 Reviewed-on: https://chromium-review.googlesource.com/1000492 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#550601}
-
Charlie Harrison authored
This will make it less cumbersome to add more tools or add subdirectories. TBR=jochen@chromium.org Bug: None Change-Id: Id6c1a41087ea4a3b9f25b9ea41905149b3580ac9 Reviewed-on: https://chromium-review.googlesource.com/1011683Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#550600}
-
Friedrich Horschig authored
This is the first step of shaping the keyboard accessory into a MVC-component as proposed in the Clank rearchitecture. It only introduces the model and the controller of this component and tests to verify the rudimentary design. The wiring to the view (which technically exists as KeyboardAccessoryView but needs to be restructured as well) will follow in the next CL. Bug: 828832 Change-Id: I791cf4a0a59671c5d674e50a6912d7242350290b Reviewed-on: https://chromium-review.googlesource.com/1007084 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550599}
-
tzik authored
This method should be a const method to be consistent to NowTicks() in base::TickClock, which is also converted to a const method at http://crrev.com/821f0e338ebbe420 Bug: 789079 Change-Id: I6b5c9bcee2d730214298ae7a7136ea6b312ad079 Reviewed-on: https://chromium-review.googlesource.com/1001213 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550598}
-
Gauthier Ambard authored
This CL adds a state to the toolbar button. This new state, "Spotlighted" is used to put emphasis on a button in the toolbar. It can be used to show that the page is bookmarked, or to indicate to which button the popup menu displayed is linked (done in a future CL). Bug: 817752 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I954cb0b26a577212ca8e3d8840b99f5be4aa1a2d Reviewed-on: https://chromium-review.googlesource.com/1000785 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550597}
-
Owen Min authored
Building the protobuf based on Input from extension API: 1) Machine name 2) OS information (x86/x64) 3) OS User 4) Chrome Profile and its extensions/plugins Other information that is stored in Chrome. 1) OS Information (Platform name and its version) 2) Browser version/channel. 3) Current profile ID based on its path 4) All policies affect the current profile. Please note that only one profile will be added into the report. Change-Id: I703ff554932388611c9839473b7dcadcf0cac3c1 Reviewed-on: https://chromium-review.googlesource.com/986946 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550596}
-
Ramin Halavati authored
Disables: WebviewLoginTest.StoragePartitionHandling WebviewProxyAuthLoginTest.ProxyAuthTransfer Bug: 832608 Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38 TBR: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1012036Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550595}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70bb7daa4183..b5d17629393d $ git log 70bb7daa4..b5d176293 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 weigua Add rtanalytics to cras group. Created with: roll-dep src/third_party/chromite BUG=chromium:831250 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib9c500c47360820e455d31ad23024bd67808710e Reviewed-on: https://chromium-review.googlesource.com/1011665Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550594}
-
Kent Tamura authored
"run_benchmark dromaeo" doesn't use this directory. Bug: 829695 Change-Id: I4389a8cf6845c9cb02ac2fc5da0866acfbf6ea52 Reviewed-on: https://chromium-review.googlesource.com/1009343Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550593}
-
James Darpinian authored
Bug: 526748 Change-Id: Ie906b8dbb2d8325ab17700178115c8b33c8bc037 Reviewed-on: https://chromium-review.googlesource.com/1011331 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550592}
-
Koji Ishii authored
Following bot results are included. 4757 4758 4759 4760 4761 4766 4772 4774 40 lines were removed and 18 lines were deflaked by consecutive results since 4715. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1f3034023e22209b4f093a90787dac832025029d Reviewed-on: https://chromium-review.googlesource.com/1009542 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550591}
-
Rune Lillesveen authored
Use a separate ComputedStyle object as initial style base for resolving font relative units for @viewport rules. When we used the ComputedStyle on LayoutView for this, it had to be mutable since length resolution may set HasViewportUnits. Use a mutable member of ViewportResolver instead so that we can eventually make the LayoutObject member immutable. Bug: 813068 Change-Id: I385e2f0ea387d9c4d5e75fa576ab7f79a2b14c98 Reviewed-on: https://chromium-review.googlesource.com/1000692 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550590}
-
Rune Lillesveen authored
Move custom style computation to TextControlInnerEditorElement and make sure its style does not rely on the input host LayoutObject. Necessary to be able to compute all elements' style in the RecalcStyle pass. Bug: 813057 Change-Id: I823ca67b5ddaba08ce7adfc26a29f45f73d88b8f Reviewed-on: https://chromium-review.googlesource.com/925701 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550589}
-
Justin Cohen authored
Bug: 831144 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I03012e23d9adce4ccf14d7ae697c62b048443d72 Reviewed-on: https://chromium-review.googlesource.com/1011128Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550588}
-
Mikel Astiz authored
The class is a key piece in the design doc ([1], accessible for Google employees only) and will be used by the future USS bridge, to be introduced in follow-up patches. Ideally, SessionStore is an abstraction on top of SyncedSessionTracker that in addition supports [de]serialization to/from disk. In the current form, in diverges slightly from the design doc because direct mutable access to the underlying SyncedSessionTracker is exposed. TODOs have been added to address this in the future. [1] https://docs.google.com/document/d/1UGM1yhHznmXvfeGvckdzBcrE6GLpgk7LsLmgPhFcIdk/edit# Bug: 681921 Change-Id: Ia483faf7256b5c6296f33236b42974697f4e6f4e Reviewed-on: https://chromium-review.googlesource.com/973222 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#550587}
-
Mikhail Pozdnyakov authored
This patch introduces mock implementations of the Sensor and SensorProvider mojo interfaces to the WPT tests for Chromium. The ongoing WPT issue for the Generic Sensor tests automation: https://github.com/w3c/web-platform-tests/issues/9686 Bug: 816462 Change-Id: I8e4880ee5269b07f0bf68a2752038e128d166c55 Reviewed-on: https://chromium-review.googlesource.com/980886Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#550586}
-
Ramin Halavati authored
Disables the following flaky tests: PrerenderBrowserTest.FirstContentfulPaintTimingNoCommit PrerenderBrowserTest.FirstContentfulPaintHiddenNoCommit Bug: 832597 Change-Id: Ied5180778c46c29579e6335b638d5758f32e9b45 TBR: droger@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1012027Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550585}
-
Erik Luo authored
Side-effect-free evaluation may call ScriptWrappable::Wrap() or ToV8(), which can invoke constructors. Since wrapping is assumed to be safe, this CL automatically whitelists bindings-generated constructors. Bug: 829571 Change-Id: I00133e04eb6b8307ea9c4924aafc5332f69f0abd Reviewed-on: https://chromium-review.googlesource.com/1000813Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550584}
-
Thiemo Nagel authored
Only modify the out parameters when there's actual state to be returned. Also, when PKP lookup fails due to pinset out of bounds (that should not happen, I guess) the method only returns false if there is no STS state either. Bug: 749059 Change-Id: Ida1fe3e60d2eb5c9bbc1625cd4b8b6550f9b716d Reviewed-on: https://chromium-review.googlesource.com/973610Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550583}
-
Ramin Halavati authored
TBR=ortuno@chromium.org Bug: 832544 Change-Id: Ifd414f8e86d4a791723c925f647c524436d4f807 Reviewed-on: https://chromium-review.googlesource.com/1012032 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550582}
-
Vadym Doroshenko authored
Before this CL, only when passwords are synced then sign-in password is saved, this CL removes condition on synced passwords. Also IsSyncAccountCredential is returned to the state before CL https://chromium-review.googlesource.com/c/chromium/src/+/932743. Bug: 816988 Change-Id: Ib1bfad08a8a85ed9107e3df042c450ec93629526 Reviewed-on: https://chromium-review.googlesource.com/999713 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550581}
-
Henrik Boström authored
This resolves the onIceConnectionStateComplete probmise when iceConnectionState reaches either 'connected' or 'completed' and fixes the race if it had already reached these states before the function was called. This fix is speculative. I am no longer able to repro the TIMEOUT locally with or without the fix. Bug: 829401 Change-Id: I1dec90250d640d93498c59a932ab5e84a3b96f15 Reviewed-on: https://chromium-review.googlesource.com/1012029Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550580}
-
Henrik Grunell authored
Removes unnecessary getting of the interface each processing pass. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5097dee52d62f5f29bac9a2d760595ccfe54046f Reviewed-on: https://chromium-review.googlesource.com/1011615Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550579}
-
Ned Nguyen authored
Bug:831745 Change-Id: Ic68c7a02a81ba288a050a6405e3ffc77149adbc0 TBR=eyaich@chromium.org NOTRY=true # tests in PRESUBMIT Change-Id: Ic68c7a02a81ba288a050a6405e3ffc77149adbc0 Reviewed-on: https://chromium-review.googlesource.com/1011255 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#550578}
-
Antonio Gomes authored
Instead, base::BindOnce and base::OnceClosure are used. This is driven-by CL that allows the presubmit hook to let other changes to this file to be uploaded. BUG=714018 Change-Id: I0adbfe6bc5a2195e52310bebcd5a1c00e85ef244 Reviewed-on: https://chromium-review.googlesource.com/1011304Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#550577}
-
David Roger authored
Token revocation is only best effort and has no guarantee to go through. However existing code was just giving up if the network was down. This CL improves the behavior, by waiting until the network is available before sending the revocation request. Bug: 824791 Change-Id: I1bed2b1d28e5e827a07be0797fe6a56a38778a29 Reviewed-on: https://chromium-review.googlesource.com/1004616 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#550576}
-
Rob Percival authored
It's useful to know how long successful queries take, without failed queries potentially skewing the histogram towards lower values. Some failures may even occur before a DNS query is sent, so the existing DnsQueryDuration histogram really measures how quickly LogDnsClient handles a request to obtain an inclusion proof (successful or otherwise). This is useful, as a measure of its throughput, but unhelpful for determining how fast an inclusion proof is obtained in the case of success. BUG=506227 Change-Id: I133f2f30abd104281d51906079cf859e62556ffc Reviewed-on: https://chromium-review.googlesource.com/1010303 Commit-Queue: Rob Percival <robpercival@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550575}
-
stkhapugin@chromium.org authored
Adds a new flag, kFormatUrlOmitPath, that formats URL by omitting everything after the hostname, like path and query. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3f98fd52a6e5fbb404fb87d72cdb4bbebe2d15b5 Reviewed-on: https://chromium-review.googlesource.com/971481 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550574}
-
Antonio Gomes authored
This is a preparation CL for migrating CustomizationWallpaperDownloader from URLFetcher to SimpleURLLoader. It brings in no functionality change, but it prepares the ground for the use of EmbeddedTestServer rather than FakeURLFetcherFactory. Basically, the manifest URL can not be static/constant because of the way EmbeddedTestServer::GetURL works. BUG=None Change-Id: I30dfc24ed9083d952bfa9c0c72be1ea9350f5b5e Reviewed-on: https://chromium-review.googlesource.com/1011302Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#550573}
-
François Beaufort authored
This CL makes sure that calling video.requestPictureInPicture() shows a Picture-in-Picture window and that setting disablePictureInPicture to true or calling document.exitPictureInPicture() hides the Picture-in-Picture window. Bug: 806249 Change-Id: Ifa9e6df55c913d6eb68fd0fbb59450d3d516ee1c Reviewed-on: https://chromium-review.googlesource.com/1006956Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#550572}
-
Rob Percival authored
This does not appear to be used by anything. When it was added in 2011, there was some musing about using it but it seems it never was (https://codereview.chromium.org/7518028/diff/12006/net/dns/dns_config_service_posix.cc#newcode52). Bug: 831665 Change-Id: I1181594cb9f84ba406228075834c4fbfed42a21a Reviewed-on: https://chromium-review.googlesource.com/1007664Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#550571}
-
Patrik Höglund authored
Our win bot is broken by extensions/common/extension_unittest.cc, but I can't even find that file in the chromium source tree! Let's try to get off of 'all' once and for all. Chromium isn't building all for the most part, so we are sensitive to breakages in obscure targets. It's not clear if building the remote webapp is enough to prevent the breakages in http://crbug.com/820041; we failed to repro that one on our workstations because of nacl build magic, but we didn't conclude that the bot couldn't have caught the issue since it was fixed while we were working on it. Well, IIRC. Let's try this, and if we get more breakages in pnacl_newlib because of webrtc_overrides problems, let's revisit the problem and see if we can build some kind of integration test with pnacl so we detect these errors earlier without building magical targets (or all for that matter). Bug: None Change-Id: Ibc0441ffa17c046f18b5a9b8a82c111f1b03d0f9 Reviewed-on: https://chromium-review.googlesource.com/1011609Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#550570}
-