- 11 Jun, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
No behavior is changed. This CL introduces a new extension API to allow Password Settings to move a user password from the device to their account. The API is not called yet and is left with NOTIMPLEMENTED(); Future CLs will: a) add the relevant logic to PasswordManagerPresenter, the same way it is done for most passwords JS APIs; b) call the API from the new "Passwords on this device" page (crrev.com/c/2228159). As a note, the method in the PasswordsPrivateDelegate takes the sender web contents because it will be needed to retrieve the password manager client. Bug: 1090372 Change-Id: I76859af0ab22fa074a802d785ad7c9a0fc3fa912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232371Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#777316}
-
Bartek Nowierski authored
Bug: 1069567 Change-Id: I5b039c91a070e1dd327b9314f44e04fcdaff088a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241360 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777315}
-
Benoit Lize authored
Change-Id: Id873ece712a5897fb67a69028cbe7a615d8356bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241120Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#777314}
-
David authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/8fh0ebVYS74R6DRd47yTZqM_Gm86TT9kKx9GjwvFnNAC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006100800_RC00.html Bug: b/158156293, b/138961540, b/158264226, b/156989235, b/134635466, b/158273198, b/156566771, b/134975059, b/158054879 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iba1eb11d1bd9e0aa3b1e7dbf660276f047915822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239139 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#777313}
-
Henrique Ferreiro authored
DragOperationPrivate and DragOperationGeneric are modeled after the corresponding values form NSDragOperation, but they don't have any corresponding meaning on the Web. The first step to remove their usage from Chromium is to not using them when creating DataTransfer objects in Blink. This also provides a fix for a regression introduced in https://crrev.com/c/2196167, where the Mojo serialization for a DragOperation fails if the value isn't one of the Mojo enum values, as happens for "move", which Blink was assigning the value DragOperationMove | DragOperationGeneric. Bug: 1093536, 1093193. Change-Id: I0fc2b65439b8b9ad2efbb7ba54e233a195d85b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239840 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 90538310. Reason for revert: Causes an additional crash Original change's description: > Fire webrtc log upload callback only when it is not null > > Nested null callbacks can cause crashes. > > Bug: 1090007 > Change-Id: I967b0f1365ce4df1f489b595344bf247e2fac9df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237890 > Auto-Submit: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776613} TBR=guidou@chromium.org,marinaciocea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090007 Change-Id: I84e7aa42a3a0d2be54acaa42a1e7aaa05bbc88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241114Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#777311}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591399286-b39212858debc8dd3bf1b48362b37180826018ff.profdata to chrome-win64-master-1591862337-51b5f2ed74f339e6e324f6777979fb62f66b655e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaf4ae03c61f065890c09967250477a0918194db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777310}
-
Julie Jeongeun Kim authored
This CL moves printing::SkiaDocumentType to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy PrintHostMsg_GetDefaultPrintSettings. Bug: 1008939 Change-Id: Id4622825e97443dd7d96c65ac9d28a8c8fb9c552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231922Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#777309}
-
Ramin Halavati authored
This reverts commit 030a0e3e. Reason for revert: Removed metrics are needed for other studies. Original change's description: > Remove two Autofill OffTheRecord metrics. > > Removes the following expired metrics and cleans up: > - Autofill.SuggestionShown.OffTheRecord > - Autofill.SuggestionAccepted.OffTheRecord > > Bug: 1088632, 1088634 > Change-Id: Ic5e0d5e821b6de743d769e6828d0828511142499 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228549 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774971} TBR=holte@chromium.org,cfroussios@chromium.org,rhalavati@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1088632, 1088634 Change-Id: Ia5a72d7161990c5457a20d99c19ce424fcabe128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236476 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#777308}
-
Alexey Baskakov authored
We should reset WebContents state between enqueued web app installations. WebContents::Stop() or WebContents::ClosePage() don't help: we need full reset with completion callback. Probably this CL will be merged into M-84. TBR=treib@chromium.org Bug: 1086778 Change-Id: If5ea81a62d5de1c0c95745f386dbd2ff3ae7fa6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237542Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#777307}
-
Kuo Jen Wei authored
Make the following changes for new video snapshot and pause button: 1. Enlarge the window mode App window size to 850x478. 2. Add new 'recording' state associate with duration from start to stop of MediaRecorder as well as the present of two new buttons. 3. Add new 'recording-paused' state associate with the paused state of MediaRecorder. Bug: 1054314 Test: tast run <DUT> "CCAUI*" Change-Id: Ica7855e319721f61823db2b0e6208129a3c22cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231921 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#777306}
-
Marina Ciocea authored
" This reverts commit d4714372. Reason for revert: Introduces regression: when the host end of the mojo pipe gets disconnected, the observer will not get rebound on the next call from the host, and it will lose Device Stop and Device Change updates. See crbug/1093728. Original change's description: > [Media Device Management] Check if the interface is already bound. > > > > While testing locally I have encountered and issue such that an > > interface would be bound while already bound. This fixes that behavior > > so that the related DCHECK is not triggered. > > > > Similar issue and fix: http://crbug.com/817873#c7 > > > > > Bug: 997661 > > Change-Id: Ifcd1342bd9cbf2c2895e5b7f2c1967c06b2a84d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903197 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713772} TBR=guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997661, 1093728 Change-Id: Ia2d7ee5a1e2b5b1e4ef2613d25e71d97df738a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240853Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94573edcd72c..fbdd5786ca23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1032596,chromium:1088073 Tbr: ksakamoto@google.com Change-Id: I8d4376e6cc67d9e186fc31aa0c5d1ae087f1f47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240755Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777304}
-
Gauthier Ambard authored
The omnibox should only be hidden on non-incognito NTP. Fixed: 1090521 Change-Id: I521a466b92eb29ccbef78e90b4c6e02aedff091c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236410 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#777303}
-
Anders Hartvoll Ruud authored
The serialization must follow the "serialize an identifier" algorithm, otherwise characters like U+0009 CHARACTER TABULATION will not be escaped correctly. Bug: 973830 Change-Id: I2dc943a74900adaf147e1615070c152a78cb5767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238117Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#777302}
-
Mugdha Lakhani authored
This functionality is covered in PageLoadMetricsBrowserTest for the most part, and this CL adds another metrics check after which the PrerenderBrowserTest test can be removed. Bug: 898955 Change-Id: Ic482516272d59f3c47b807a57e5d108b93c9c7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239839Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#777301}
-
Nazerke authored
Bug: 1072370 Change-Id: If7e78a94be562fbc432ac451b097a06b5d5d07b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235714Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#777300}
-
Sylvain Defresne authored
This reverts commit b71212e2. Reason for revert: break the build (downstream). Original change's description: > [ios] Use framework style includes for MDC headers > > This is a follow up cleanup which will allow removing some GN targets. > > Bug: 1017165 > Change-Id: Icc42e69cd88c722523cb7ec2eb38420a9357edc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232862 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777026} TBR=sdefresne@chromium.org,eugenebut@chromium.org,yuweih@chromium.org Change-Id: I36aeccb4a8fab471099e45913c35af80baaa9e05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240856Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777299}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/da3a87690c..2eba343b51 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/da3a87690c..2eba343b51 Bug: None Change-Id: Iabbf435113fb589f252cf671a4c0485f10d77b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238829Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#777298}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591847470-e9a3ba2de654706356c199369cb3647da2838543.profdata to chrome-mac-master-1591862337-2d108d6b8770e8c80e52db48b7dacf69f901eb8c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I817d9e43a6cc90b8337b71d8976b3d1246c466da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241280Reviewed-by:
-
Richard Townsend authored
Several possibilities entering this function: 1) We're parsing with kForceSynchronousParsing (no background parser, tokenizer_ defined) 2) We're parsing with kAllowAsynchronousParsing without a background parser started (no tokenizer_) 3) We're parsing with kAllowAsynchronousParsing _with_ a background parser started (no tokenizer_) 4) We're parsing with kAllowDeferredParsing (with tokenizer_) The previous code called PumpTokenizerIfPossible _only_ if tokenizer_, wasn't defined, so the implication is that this operation should be done synchronously and only if the background parser isn't being used. The new code either pumped the tokenizer immediately, or deferred the pump. This CL restores the previous behaviour. Bug: 901056, 1087032, 1087325, 1087753 Change-Id: I7ed8ee0eea91eb7786e07a82b399f40f0c651dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235836 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#777296}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3641ff737818..b919bc889e1d 2020-06-11 bclayton@google.com Fix signed / unsigned mismatch warning (#2266) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Id1e5a28c11d47ffb3a157e4703ce6fbfbe4de64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239660 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa617c8a..bfc0d2f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I278ae6aa98a15ae210a1997a2844ebce3061ad91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237992Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777294}
-
Lei Zhang authored
There exists many base::DeleteFile() callers that want to use PostTask() APIs to delete a file on another task runner. To do so, they have to write: base::BindOnce(base::IgnoreResult(&base::DeleteFile), path, false) To simply the callers, and help transition base::DeleteFile() to remove its |recursive| boolean parameter, add base::GetDeleteFileCallback(). Now, callers can just write: base::BindOnce(base::GetDeleteFileCallback(), path) Use base::GetDeleteFileCallback() in chrome/, content/, and ui/. Bug: 1009837 Change-Id: I06fc6c9585dcb04034b5b25f18f3e96ed94d32c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203412Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
FontMetrics::UnderlineThickness() returns an Optional<float>, but this code was dereferencing the value without checking if there was one (using value()). This made the following check of the Optional<> dead/redundant. Instead receive the Optional<> without dereferencing it. Also use value_or(...) to return the auto value or the specified value depending on if the latter exists or not. Bug: 785230 Change-Id: Id85ac107600ef26f2edc738048abe657b9db3bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238932Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#777292}
-
Bao-Duy Tran authored
Also alpha-sort some nearby entries. Change-Id: I2a22f0d178cc5b6246eaec5f5d0b49a3ba620641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230155Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777291}
-
Rune Lillesveen authored
With BlockHTMLParserOnStyleSheets enabled, adding the completed stylesheet would happen on parsing finished without a BeginFrame() which made this test fail with that flag on. Adding BeginFrame() here shows that a @font-face rule in a stylesheet will notify the AdTracker about the src url being fetched before it's actually fetched. It's quite likely that is a bug, but BeginFrame() is anyway correct to make sure the loaded sheet is active. Bug: 891767 Change-Id: I206c468dbde97a0a25bfcba5d169954a333124f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239569Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#777290}
-
ssid authored
Adds a new data source to tracing for adding reached code profiles to traces, using the base/ reached code profiler. Temporarily uses existing callstack_iid field to write protos. Sets up background tracing config for reached code profiler. The profiler is turned on using the existing ChromeFeatureList.REACHED_CODE_PROFILER feature for the next session. The background tracing system will enable a scanerio and upload traces with reached code profiles when this feature is turned on, similar to startup tracing. Refactor creation of perfetto config to include filters for data sources, instead of piggybacking on categories. This allows us to include only reached code profiler for tracing. Refactor tests to allow sharing of common mock producer code, for adding test for reached code profiler data source. BUG=916263 Change-Id: I6de7c959e3229ebc9946478eb31940a3e224a4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131713Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
In the context of the migration started last year to migrate all the uses of old mojo types to the new ones, today I've found that there were a few bits that we could remove and either migrate easily or outright remove them, now that nearly all the instances of those old types have been migrated. Therefore, this CL does a "sweep" and does the following cleanups in different places, so that we get closer to the point where no old types are present: * Migrate uses of old types to the new ones in a couple of places where they were not migrated (i.e. MockChromePrompt, TestService). * Remove unused templated methods from //ipc still using old types. * Remove unused Interface{Ptr,Request} variants of helper methods Connector::BindInterface(), InterfaceProvider::GetInterface() and LocalInterfaceProvider::GetInterface(). * Remove unused includes for header files related to old mojo types. * Delete strong_associated_binding_set.h (not even being compiled). TBR=blundell@chromium.org,halliwell@chromium.org,achuith@chromium.org,achuith@chromium.org,kinuko@chromium.org Bug: 955171 Change-Id: Ia4ca6f3f68bc1d6d4fd4016ed16c07ff132ea19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235699 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:Eugene But <eugenebut@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#777288}
-
Hirokazu Honda authored
We have used gfx::BufferUsage::SCANOUT_CAMERA_READ_WRITE for camera capture use case. A content of the buffer is written by the camera service, rendered by GPU and also might be read by a software encoder and a hardware-accelerated video encoder. A hardware-accelerated video encoder requires their specific alignment on an input buffer. The above buffer must satisfy the alignment condition if the input buffer is encoded by the hardware-accelerated video encoder, which is the Zero-Copy use scenario (go/cros-vide0Capture). The buffer must be allocated with HW_VIDEO_ENCODER mask to request a buffer allocation stack (e.g. minigbm) the encoder's alignment. SCANOUT_CAMERA_READ_WRITE usage doesn't contain HW_VIDEO_ENCODER mask. This CL replaces it in capture stack with SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE. It is equivalent to SCANOUT_CAMERA_READ_WRITE + HW_VIDEO_ENCODER mask. Bug: 982201 Test: tast run camera.* on krane Test: Camera preview and recorded video look good with CCA on krane Change-Id: If45d4a44aaead8de497571274f14563a89415077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234684Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5279786. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" b2436c3b "Ensure cloning a template element into an inactive document does not crash." 027aefc6 "OPTION element: Update OPTION label even if it has invalid markup" 0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." e106756f "[COOP] Access reporting. Update the test." b447a3ac "De-flake cross-domain-iframe.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I925dea1c885377ffd42dbd926f573237bea0b4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237997Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777286}
-
Rachel Wong authored
This CL adds the Mojo broker interface and associated structs for Local Search Service. The next CL will add StructTraits to allow for easy conversion between the Mojo structs and their C++ counterparts. Bug: 1092767 Change-Id: Ib4ca2dd1a61ccc775a36d4f99776bcdc62256b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235575Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#777285}
-
Bao-Duy Tran authored
Things were moved approx 8 years ago: https://crrev.com/10735074. Change-Id: I14829a47fb7221310fb54f24e1dec96b9a1118dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230435Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777284}
-
Kunihiko Sakamoto authored
external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html is failing after http://crrev.com/777259. TBR=aaronhk@chromium.org No-Try: true Bug: 1093709,1091267 Change-Id: Ifc285409dd7c1f014d0c8450ace0ccfb538ba3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241052Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#777283}
-
Ramin Halavati authored
This reverts commit 8149e2bd. Reason for revert: Removed metrics are needed for other studies. Original change's description: > Remove four Bookmark metrics. > > The following metrics were used to measure Incognito mode usage and are > expired: > - Bookmarks.BookmarkAllTabsWithTabsCount.Incognito > - Bookmarks.BookmarkAllTabsWithTabsCount.Regular > - Bookmarks.AddedPerProfileType > - Bookmarks.UsageCountPerProfileType > > Added code to support these metrics is also cleaned up. > > Bug: 1088669 > Change-Id: I22fd2ac7392be179c275afa079bfd961672fc95f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228550 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775949} TBR=sky@chromium.org,holte@chromium.org,rhalavati@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1088669 Change-Id: I4a2c4287795db4ec57112e0c5fc6589ea47ea99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235824Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
TBR=khushalsagar@chromium.org Bug: 1067662 Change-Id: I6a9c6de903d7b4b3f6dd5caa118f9f1af9fb8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239144Reviewed-by:
-
Kent Tamura authored
Bug: 1069817 Change-Id: I9d4966bcffeeffae8d457e01d070fc5c276259bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239779 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#777280}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591732735-0015e64d5031c088448e4bf6bbe4dc15e4f90ad0.profdata to chrome-win32-master-1591847470-22394db4eae687d46ca49599d3bc16bb448d2db1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id0e9226097aeca175d56e69bae86032b249a4adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240751Reviewed-by:
-
Harald Alvestrand authored
Test is flaky. Bug: 1093198 Change-Id: Ia2310631c6ce3aa1f4dcb65890996c72ee7b36ee No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241112Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#777278}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3eb327e8c3c..45510ad8a778 2020-06-11 capn@google.com Validate the SPIR-V code in debug builds 2020-06-11 capn@google.com Add a triangle rendering benchmark 2020-06-11 capn@google.com Add glslang dependency to VulkanBenchmarks 2020-06-11 capn@google.com Add glslang as a submodule 2020-06-11 capn@google.com Move CMake build targets for PowerVR samples before unit tests 2020-06-11 capn@google.com Add microbenchmarks for vkCmdClear*Image 2020-06-11 capn@google.com Add back vulkan.hpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1ce9f46277fe163a8e2922649ad945d1f8947d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239661Reviewed-by:
-
