- 21 Aug, 2018 40 commits
-
-
Matt Mueller authored
It was accidentally re-disabled in a bad rebase in https://chromium.googlesource.com/chromium/src/+/3787780199f8ef7bfa5e977aab8180766b10ddad Bug: 859594 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2dd6b15dba5639657ddc4deadc4afe6468cd529a Reviewed-on: https://chromium-review.googlesource.com/1182309Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#584817}
-
Brandon Wylie authored
Bug: 875087 Change-Id: I1165ed0c6e65caf377d556de769bec878c0698cd Reviewed-on: https://chromium-review.googlesource.com/1179223 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#584816}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a16d9c72d60f..94822b57c10e git log a16d9c72d60f..94822b57c10e --date=short --no-merges --format='%ad %ae %s' 2018-08-21 rharrison@chromium.org Roll code coverage DEPS ahead Created with: gclient setdep -r src/third_party/pdfium@94822b57c10e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9014bdb016464c3b8c7bd9995acaea0ee865c0b7 Reviewed-on: https://chromium-review.googlesource.com/1183583Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584815}
-
Robert Sesek authored
Bug: 850878 Change-Id: Id8a8a9546a18671ec8654e8a73156de77a377b26 Reviewed-on: https://chromium-review.googlesource.com/1183621Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584814}
-
Friedrich Horschig authored
Currently, the keyboard accessory uses the focused view in the activity as view to check for keyboard visibility. This works most of the time, when an input field is focused but it's thinkable that the focus moves away (most likely programmatically) which could lead to the observed crashes. This CL now ensures, that the focused view is exclusively used when a keyboard needs to be shown and the detection (which relies on the content area layout) is always invoked with the content view. Bug: 876231 Change-Id: Ib65c7985987291cd2b85098b920106dbde40753d Reviewed-on: https://chromium-review.googlesource.com/1183423Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584813}
-
Jordy Greenblatt authored
In the course of preparing the Settings UI to interact with feature prefs via the MultiDevice service, it became very cumbersome to pass around data without some utilities common to the components. This CL factors out some such utilities into their own behavior and passes around feature data using the behavior Note that this CL does not change the components' relationships with feature prefs as that is in the next change, but the behavior is a convenient intermediate point and should make the other significantly easier to review/work with. Note also that not all the components yet use the behavior but they almost all will as it becomes more relevant over the next few CLs. Change-Id: Iaeec623bd534287893f6c204a0fdf524ac0bfd77 Reviewed-on: https://chromium-review.googlesource.com/1179820Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#584812}
-
Christopher Cameron authored
Mechanically move the following functions either from BridgedNativeWidget to BridgedNativeWidgetPublic or from direct manipulation in NativeWidgetMac to BridgedNativeWidgetPublic: - SetVisibilityState - SetVisibleOnAllSpaces - SetMiniaturized - SetOpacity - SetContentAspectRatio - SetWindowTitle - MakeFirstResponder Add state tracking for visibility, miniaturization, and window key status to BridgedNativeWidgetHostImpl. Merge the new visibility tracking in with the existing compositor visibility tracking. Bug: 859152 Change-Id: I750986e6732bc54ff12e90a75e9d649a34895682 Reviewed-on: https://chromium-review.googlesource.com/1182962 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584811}
-
Manas Verma authored
Previously there was a single access point for both the sign-in promo and the manage cards prompt, shown after saving a card locally. This change creates a separate access point for the manage cards prompt. Bug: 855186 Change-Id: Ibdf036ac12a9ea7cce27abde41b368b7736ccb63 Reviewed-on: https://chromium-review.googlesource.com/1169630 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584810}
-
Helen Li authored
Cookies setting and getting can be blocked by a NetworkDelegate. This CL adds NetLog events so they can aid in the investigation of cookies bugs. Bug: 875849 Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 Reviewed-on: https://chromium-review.googlesource.com/1181244Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584809}
-
Anna Offenwanger authored
Runtimes should only be handled by the XRRuntimeManager. VRServiceImpl needs to know if capabilities have changed, but does not need to know if runtimes were added or removed, so we can merge those functions into one and remove XRRuntime from VRServiceImpl, which will forward this end. Also moved logic to check in the runtimes if an XRDeviceImpl is presenting to the manager. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4e155dbb4ff603572338a0d543ca030cd574ffb8 Reviewed-on: https://chromium-review.googlesource.com/1181685Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584808}
-
Max Moroz authored
Bug: 817798 Change-Id: Ie6201fc2db25d5b3cfada1868a6b160b2f096740 Reviewed-on: https://chromium-review.googlesource.com/1183695 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584807}
-
Ryan Meier authored
While importing a theme, browser_theme_pack now runs through a pass to ensure that tab title text for background tabs maintains a minimum contrast ratio with the tab background. Bug: 871026 Change-Id: Ic1d76c9d50ac0255de671916138933dd96af49ef Reviewed-on: https://chromium-review.googlesource.com/1173491 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584806}
-
David Black authored
Adds supported deep links for: - What's on my screen - Take a screenshot Bug: b:112735795 Change-Id: Iac56423d298c8a722679adba6f5942dc8fc9bcf2 Reviewed-on: https://chromium-review.googlesource.com/1180080 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584805}
-
Christopher Cameron authored
Make NativeWidgetMac::SetFullscreen go through BridgedNativeWidgetHostImpl instead of directly manipulating BridgedNativeWidget. Make note of subtle state tracking behavior in BridgedNativeWidgetHostImpl::SetFullscreen. Change BridgedNativeWidget's fullscreen transition functions to go through the BridgedNativeWidgetHost interface instead of calling into NativeWidgetMac directly. Move tracking for GetBoundsForRestore from BridgedNativeWidget to BridgedNativeWidgetHostImpl. Change BridgedNativeWidget from pulling size constraints in BridgedNativeWidget::OnSizeConstraintsChanged to having the NativeWidgetMac push these constraints to BridgedNativeWidget. Bug: 859152 Change-Id: Ie33b79becf1ccd1d476e8033cb078d0ffe75463f Reviewed-on: https://chromium-review.googlesource.com/1182673Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#584804}
-
John Budorick authored
Bug: 866032 Change-Id: I1ae69024219ab6c730d5995914af68b64c89910c Reviewed-on: https://chromium-review.googlesource.com/1180483 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584803}
-
Philip Rogers authored
This patch removes a negative z-index children check from PaintLayer::GetBackgroundPaintLocation. This lets backgrounds paint in the scrolling contents layer in the presence of negative z-index children, fixing the painting of background-attachment: local. This patch also removes a DCHECK that was hit when a foreground layer and kBackgroundPaintInScrollingContents coexisted. This DCHECK[1] could be hit for root layers without the functional change in this patch. As the test in this patch shows, kBackgroundPaintInScrollingContents and foreground layers work together, so this patch makes non-root-layers use both, and removes the DCHECK. What are foreground layers? A foreground layer is created if a stacked PaintLayer has composited negative z-index children that should wedge between the layer's background and the layer's contents. The foreground layer will have the normal-flow contents in this case. See the comment above foreground_layer_ in composited_layer_mapping.h. [1] DCHECK originally added in: https://crrev.com/9a2cdc8d96d. Reading the comments, I think the DCHECK was intended to ensure the background would not be painted into the foreground layer. Bug: 861948 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7409cbe9ac61fed444856df342d0707d6babab09 Reviewed-on: https://chromium-review.googlesource.com/1173532Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584802}
-
Robert Sesek authored
Change-Id: I220dd3b48482e26d94d4f2a8a8fcd08097038a9d Reviewed-on: https://chromium-review.googlesource.com/1183701Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584801}
-
Erik Chen authored
The first attempt to land this CL failed because there is one consumer that attempts to isolate a target called 'official_tests' which also has type 'additional_compile_target'. This is a misuse of the unofficial API for mb.py, but is not trivial to fix. This CL simply marks this as a special case a leaves a TODO for the responsible party. > The command generates a .isolate for every compatible gn target. > > This will be used by the deterministic builder to check that all isolates > dependencies are identical between two builds. > > Bug: 870731 > Reviewed-on: https://chromium-review.googlesource.com/1176441 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584268} Change-Id: I1d31870b0513911b3ff6ebe296ea812b9036bf45 Bug: 876065, 875713, 870731 Reviewed-on: https://chromium-review.googlesource.com/1182621 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584800}
-
Xiaohui Chen authored
Bug: b:112857091 Test: locally build and test Change-Id: I9deac6849662a48263966b01012553046f5aa328 Reviewed-on: https://chromium-review.googlesource.com/1182448Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584799}
-
akaba authored
Content rendering timeout will now set the fallback to the first Surface after navigation instead of invalidating it. Bug: 861769 TBR: piman@chromium.org Change-Id: I145a482cc084398d6687aa749acd563c9a07c6e2 Reviewed-on: https://chromium-review.googlesource.com/1174707 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584798}
-
Alexei Filippov authored
The tracing is now initiated by the browser process. There's no need to start it in renderer anymore. TracingStartedInPage event is not going to be produced anymore. It has been replaced with TracingStartedInBrowser. Change-Id: I9e7759f7f792421d3f32fd21e82066e13a4901dc Reviewed-on: https://chromium-review.googlesource.com/1182287 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584797}
-
Jacob Dufault authored
Also polish shelf item background color. Bug: 839604 Change-Id: I85f3762ff2a8073a71b72e1478a2a36898f6142e Reviewed-on: https://chromium-review.googlesource.com/1180270 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584796}
-
Mohamed Heikal authored
dskiba@ wrote some startup scripts to get startup performance metrics via running chrome locally multiple times and capturing capturing/analyzing trace events. These work when specific usecases are not implemented as benchmark stories (eg: WebAPK startup) Scripts were originally written for personal use so may not be the best quality but they are useful so should be included in the chromium repo rather than only on his personal git. Change-Id: I04e711db61ed26e7f9d531756f6b4699476406d5 Reviewed-on: https://chromium-review.googlesource.com/1168156 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584795}
-
Sergey Ulanov authored
Previously --disable-gpu process was passed to context process to prevent it from starting GPU process. It no longer disables GPU process, but GPU process should not crash once https://crrev.com/r/1178754 lands. Bug: 867052, 874533 Change-Id: If2baf7aa50dd9ccb6ee5442d079f50c1908ed72c Reviewed-on: https://chromium-review.googlesource.com/1178881 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584794}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bcdf5f1a944e..c3da6716d42d git log bcdf5f1a944e..c3da6716d42d --date=short --no-merges --format='%ad %ae %s' 2018-08-21 peah@webrtc.org AEC3: Adding another config parameter and matching json reader with config 2018-08-21 ilnik@webrtc.org Move FakeCodec to separate target and behave like real encoder. 2018-08-21 mbonadei@webrtc.org Add documentation for WEBRTC_EXCLUDE_BUILT_IN_SSL_ROOT_CERTS. 2018-08-21 srte@webrtc.org Removes unused reserved bitrate in BitrateController. 2018-08-21 sprang@webrtc.org Simulcast screenshare adjustment to temporal layers, bitrate 2018-08-21 ssilkin@webrtc.org Allow VP9 flexible mode. 2018-08-21 oprypin@google.com Revert "Default runner to junit4" 2018-08-21 nisse@webrtc.org Delete unneeded forward declares of RtpReceiver 2018-08-21 nisse@webrtc.org Add accessor methods for RTP timestamp of EncodedImage. Created with: gclient setdep -r src/third_party/webrtc@c3da6716d42d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:868610 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I51baac50b1606da6758274aa36eb085ed595d85e Reviewed-on: https://chromium-review.googlesource.com/1183537Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584793}
-
Wez authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib3e4cfd6eac23f6950831751d5f079f48738c4c7 Reviewed-on: https://chromium-review.googlesource.com/1176553Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#584792}
-
Anthony Vallee-Dubois authored
1/ Add new Ranker config to field trial testing 2/ Set the default model to be consistent with the 99% Finch group Bug: 852921 Change-Id: I04497f6a80d810a506e40b7ff9e4d1500ffc191c Reviewed-on: https://chromium-review.googlesource.com/1179814Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#584791}
-
sczs authored
Bug: 838823 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If039925b436a01310906be0bbf74807f3310b2cc Reviewed-on: https://chromium-review.googlesource.com/1176862 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584790}
-
Alex Newcomer authored
This CL is exactly the same as the previously landed versions, but I landed a CL which fixes the errors in asan tests, linked below, so this should be safe. https://chromium-review.googlesource.com/c/chromium/src/+/1180073 TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org Bug: 871843 Change-Id: I259e2c1177d05b050cea5638818a01cc82f24ea7 Reviewed-on: https://chromium-review.googlesource.com/1181770Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584789}
-
Devlin Cronin authored
Move Permissions registration out of the body of ExtensionsClient::Initialize() and into the ExtensionsAPIProviders by introducing ExtensionsAPIProvider::AddPermissionsProviders(). Have each provider register their associated permissions, and have a common ExtensionsClient initialization step call into them in order to trigger the registration. Bug: 873937 Change-Id: Idfc55d0690dd8cf77f62b63650deec2ae42623a2 Reviewed-on: https://chromium-review.googlesource.com/1177181Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584788}
-
Alex Newcomer authored
Remove the background highlight in tablet mode for the AppList SearchBoxView. Bug: 866653 Change-Id: Id43065944a877d8e44a123df60be2caf2a79b52a Reviewed-on: https://chromium-review.googlesource.com/1182281Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584787}
-
Alex Newcomer authored
Show a context menu between apps in homecher-tablet mode. Don't show a menu between apps in laptop mode. Bug: 869623 Change-Id: Idfb8f5d970f7716397ec42769b0e6a8f4473acb1 Reviewed-on: https://chromium-review.googlesource.com/1180249 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584786}
-
Moe Ahmadi authored
Adds test to ensure the upstreaming infobar and the local save infobar appear as expected after form submission. Bug: 867106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3fe6355385b8737c23e0ff51e500d4ca98c196df Reviewed-on: https://chromium-review.googlesource.com/1179962 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#584785}
-
Juan Antonio Navarro Perez authored
This first version just adds an entry point for the script, and simple api calls to test-results server to retrieve the json data. Bug: 875251 Change-Id: I14de8275e1e9ffe28935d5e172add60011ec5b62 Reviewed-on: https://chromium-review.googlesource.com/1179837 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584784}
-
Friedrich Horschig authored
In various cases, the accessory tries to restore or create a state even if there is no valid tab that would allow that. This CL tests and handles cases like early onResume() or willTabClose() events gracefully by binding states only to valid active tabs. Bug: 875188 Change-Id: Ie718358e0c30779656f450eea4427dd4d0e474f2 Reviewed-on: https://chromium-review.googlesource.com/1183491Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584783}
-
Thoren Paulson authored
In some situations we should not turn on the screen, such as launching an app that supports audio-only devices on a device that can play audio without the screen on. Bug: internal b/110169298 Test: test on Sony TV Change-Id: I3615f2fa7ac696b4d6843a4f560572b27ab39d8f Reviewed-on: https://chromium-review.googlesource.com/1180363Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#584782}
-
Matthew Jones authored
This patch adds a feedback source for the split toolbar that identifies whether the feature is enabled. Change-Id: I5a1455c246e9ad5a6a2d36a452a580678fe59dd0 Reviewed-on: https://chromium-review.googlesource.com/1181575Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584781}
-
John Abd-El-Malek authored
Bug: 821021 Change-Id: I420e1c9493b4eea33632e4b8b20c18b0a3abcb01 Reviewed-on: https://chromium-review.googlesource.com/1182009Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#584780}
-
chrome://safe-browsingDaniel Rubery authored
Example usage is: CRSBLOG << "debug messages " << this; It should serialize all objects in the same way as the regular LOG macro. Bug: 874693 Change-Id: I761184f919129a62dbde741bf97cf4a1d1cdb1ad Reviewed-on: https://chromium-review.googlesource.com/1181654 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584779}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: Icbc5143b5e18d390c09902235827494d646dc7b9 Reviewed-on: https://chromium-review.googlesource.com/1183307Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584778}
-