- 15 Dec, 2020 40 commits
-
-
Nancy Wang authored
This CL is the 3rd option to resolve the crash of below call stack: AppWindowLauncherItemController::GetAppWindow(aura::Window*, bool) AppWindowLauncherItemController::SetActiveWindow(aura::Window*) AppWindowLauncherController::OnWindowActivated() One possible guessing is the AppWindowLauncherItemController object has been deleted, but still used by AppServiceAppWindowLauncherController. So modify the destruct function, and set the controller as null in AppWindowBase. BUG=1128491 Change-Id: Ied59f857653aa0a136cbe9f903ff79ce5856e34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586647 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837244}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55054d67. With Chromium commits locally applied on WPT: 64eda80d "Fix ShapeDetection handling of broken HTMLImageElements" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I30d4fd1624de295859e68c327d0a7497f3c49346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592136Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837243}
-
Pavel Yatsuk authored
The test fails on Marshmallow Tablet Tester: https://ci.chromium.org/ui/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/14859/overview BUG=1158435 TBR=arbesser@chromium.org Change-Id: I124226263188ee3b2d389780dec0fd83dff0d951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593181Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#837242}
-
danakj authored
This is a reland of c7326b7f Canvases may have different color formats than N32, and when we pull the content of them into a cpu bitmap through SkImage::toLegacyBitmap() we need to convert that to N32 format if we're going to send the bitmap over IPC due to security restrictions of the BitmapN32 mojom type. This does that conversion in the blink ShapeDetector and adds a test with a float16 color format canvas which would cause the IPC sending to be dropped (and the renderer to crash). TBR=dcheng Original change's description: > Use skia.mojom.BitmapN32 in Detection mojoms > > These bitmaps are safer for transport from untrustworthy sources since > all bitmaps should be in N32 format and the browser can make bad > assumptions as a result. > > R=dcheng@chromium.org, reillyg@chromium.org > > Bug: 1144462 > Change-Id: I7d02cb187c62be37259f445a182f8c971aa03661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580483 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835685} Bug: 1144462 Change-Id: I23ef3df85049a7111830c5d272c02b69f9d7cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593827 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837241}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/97752ea021f7..b1d06a4d0549 2020-12-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Id3c0bad8abc395bab19dab0dd53502cc9fbbc9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837240}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b82504a..e6fc34eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If61db0bae6683f2b37f93196384905868058a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837239}
-
Carlos IL authored
Also adds a chrome://flag entry. This still requires chrome to be built with XFA support, otherwise the flag is a no-op. Change-Id: Ic7fe253afb05797fdf0b663c46a2272774438827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570693 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837238}
-
Allen Bauer authored
Per the parent CL, cl/2550367, this adds more human-readable formatting of the event flag values. Bug: 1156656 Change-Id: If74014e08bdf51cbd77f9045b9a2c55a98f78a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582814 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837237}
-
Liquan (Max) Gu authored
This CL removes the static abortForInvalidDataFromRenderer and uses the dynamic method of the same name. The two methods executes the same code essentially, so this CL causes no behavioural change. Bug: 1157847 Change-Id: I21ea9cd860c98b4ab0552f3261e63c6f187154d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592013 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837236}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f22b977bc4c0..664301800ba2 2020-12-15 yuhengh@chromium.org Increase inspector log timeout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1152598 Tbr: skyostil@google.com Change-Id: I695f246506235a93793f114b9d7d6b21f5e151c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593989Reviewed-by:
-
Jeremy Roman authored
These will be needed past M90, and it's convenient to update now to avoid forgetting later. Change-Id: I3eb65f5bd8bc46bdcb488ed1e020e71e2d353d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593473 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837234}
-
Brian Ho authored
When Python 3 was enabled for Chromium builds [1], generate_device_policy_remover.py started failing. In particular, Python 3 no longer exposes a global `reload`. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2515787 [2] https://stackoverflow.com/questions/961162/reloading-module-giving-nameerror-name-reload-is-not-defined Bug: 1158819 Change-Id: I37a8411702ee4a6e6d19a9117296d6889387996a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593470 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#837233}
-
Sunny Sachanandani authored
Force compositing scale factor to be at least a reasonable minimum value to prevent dependent values such as scroll deltas in the compositor going to zero. It's possible for the calculated scale factor to go to zero since it depends on intermediate CSS transforms which could have zero scale. Includes a unit test and browser test, the latter of which crashes prior to the fix due to DCHECK in mojo serialization code that prevents a compositing scale factor of 0. Bug: 1157776 Change-Id: Iba40a0174e94c89babe576dc73d2913bc5bfeeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587709Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#837232}
-
Alex Newcomer authored
This is used for ClipboardHistory (//ash/clipboard). This CL involves: - Adding logic for menu bounds - Consolidating usage of bubble bounds for the ClipboardHistory menu. Bug: 1131724 Change-Id: I0c1a99ff28ce4342f8cb5f4a1a9882d9e7564c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583205Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837231}
-
Nick Czajka authored
This change modifies drag_behavior.js to allow for keyboard-based dragging. Keyboard-based and cursor-based drags are mutually exclusive. Bug: 1077365 Change-Id: I7c435182d87487b46484fa999c05aa56eb10122e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568434 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#837230}
-
Khushal authored
R=sunnyps@chromium.org,vasilyt@chromium.org Change-Id: I05c71327515666b6b212b3d0e23f0a8b4e0ab726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593734 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#837229}
-
Hui Yingst authored
Adds a new Pepper-free graphic interface SkiaGraphics, which is backed by an SkSurface, and accepts SkBitmap as input. SkiaGraphics interface will be used for the non-Pepper PDF plugin. Bug: 1099020 Change-Id: Ib8b6f9173fd70102a86358b0dfe640a0e516a7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559537 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837228}
-
Bin Du authored
The Default profile on Chrome OS is used before the user signs in. The sync settings are always disabled on the Default profile. Bug: b:175067939 Change-Id: I67c8f341f9ea5ea0b0d08261dc0d5b6fdf4814aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587658 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#837227}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608033365-e862b5d2dea1d73e4832544c4ed0bdce55caf8f7.profdata to chrome-linux-master-1608054952-237303eeff32fc09fadd9f8e86812521d687784d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I367862c00a0f7a3f69c4a6e986b7f7031eaf399f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594069Reviewed-by:
-
Chan Li authored
Bug: 1147992 Change-Id: Idb07a5a41d36aac1e46b3a354adca00884c3d9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591715Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#837225}
-
Robert Ogden authored
While this test was disabled due to a flake, the code under test was removed. Code and test added: https://chromium-review.googlesource.com/c/chromium/src/+/1589011 Code removed: https://chromium-review.googlesource.com/c/chromium/src/+/2101318 Bug: 991035 Change-Id: Ic2ab95718fc8e2772ead0bdbfe69acb3058b63be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593179Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#837224}
-
Eugene Zemtsov authored
When resizing from 200x50 to 50x200 using libyuv::kFilterBox, libyuv::I420Scale overreads behind the last row. It doesn't happen after switching to kFilterBilinear. libyuv bug: https://bugs.chromium.org/p/libyuv/issues/detail?id=875 Bug: 1158178 Change-Id: I1ebc4ae1911d9a186f005af27a43e5484c927231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593229Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#837223}
-
Matt Menke authored
Wire NetworkIsolationKey through DomainReliabilityMonitor. Also add a feature to enable/disable partitioning DomainReliability on NetworkIsolationKey, enforced at the DomainReliabilityMonitor layer. Bug: 1138994 Change-Id: I953b1b05f09f063d361c7ddec684f5f5428ba2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588248 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#837222}
-
Solomon Kinard authored
Bug: 1133624 Change-Id: Ie640d3e9202766ab43e8b26b7accceaaa36e18cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554031 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#837221}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/985db28c6fae..b35ae002390e 2020-12-15 bajones@chromium.org Fix erroneous validation logic for BindGroupLayoutEntry 2020-12-15 cwallez@chromium.org Fix comment that says "control case" when it isn't. 2020-12-15 bclayton@google.com end2end: Enable DepthReplacing tint tests 2020-12-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8df62847f40a to e07510293160 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I10fb5231d805714f8dba3bd8f7c9b264564a02b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593710Reviewed-by:
-
Oriol Brufau authored
ToPositionInDOMTree(PositionInFlatTree::FirstPositionInNode(*host)) was returning a position anchored to the shadow root. This could trigger a null deref in NeedsLineEndAdjustment(), since a shadow root has no layout object. This patch makes ToPositionInDOMTree keep the same anchor when the offset is 0. This is consistent with what happens for LastPositionInNode positions, and also consistent with ToPositionInFlatTree. Also adjusts SelectionTypeAdjuster::AdjustSelection to use a forward selection if the range is collapsed, even if the original selection was backwards. This avoids a DCHECK failure due to the change above. Bug: 1155342 TEST=PositionTest.FirstPositionInShadowHost TEST=PositionTest.LastPositionInShadowHost TEST=SelectionAdjusterTest.AdjustSelectionTypeWithShadow Change-Id: If141c18cf73ebd33b21de2130c326386d8efeec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584762 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837219}
-
Eugene But authored
Bug: 688063 Change-Id: Ib172e591591024bcd7303a6064a8132eec792dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592389 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#837218}
-
Michael Hansen authored
This renames SendPreview to PayloadPreview and adds it to the ShareTarget mojo struct for use in providing a preview on the receive confirmation page. Screenshot: https://screenshot.googleplex.com/5R5rox9hmHGQikm.png Change-Id: I16a56d193ba9c531c5a8b3dc703810b8fa2fca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579837 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837217}
-
Mila Green authored
Bug: 1151106 Change-Id: Idb834ea3e9a16360284d7567c8764dd5afcec5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593169Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837216}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9fd03062f5fd..41545839b323 2020-12-15 morlovich@chromium.org Add ability to edit UA-CH for custom devices. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073909 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd628a1312a514a839a33664bc86e9733c3703d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593708Reviewed-by:
-
Caroline Rising authored
Bug: 1109316 Change-Id: I2d7a708c0da67f3492d0a6ef335843946c296409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593828 Auto-Submit: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#837214}
-
Mason Freed authored
These APIs have been deprecated since Aug 2018 [1], disabled by default since Oct 2019 [2], and removed from Origin Trial support since Oct 2020 [3]. This CL removes the code to support these two features completely. This is being done in one large CL for two reasons: 1. It is hard to untangle all of the dependencies of this code to be able to land this in multiple CLs. 2. Doing this in a single CL will allow the effects (progressions, hopefully, but we'll see) to be more easily tracked. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1850795 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2458126 Bug: 937746, 1157927, 1158001 Fixed: 1129465 Fixed: 1157500 Change-Id: I45d77960fa77e2bba3f5b301e3fb7372bb659c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586019 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837213}
-
Shakti Sahu authored
This CL fixes an issue in download home paginator where more button required more than one clicks to show the items for the next date. This was happening because the current page count didn't keep track of how many items are being shown for the current date. Bug: 1018355 Change-Id: I14b8ff5121d40a0698c288a3ade14c12e946d0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583114 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#837212}
-
bttk authored
This change replaces LocationBar#updateStatusIcon() and LocationBar#updateLoadingState(boolean) with LocationBarDataProvider.Observer#onSecurityStateChanged(). Methods in the Observer definition are now sorted alphabetically and have empty default implementations. Methods in implementations of the Observer are also sorted alphabetically and follow a pattern where they are simple lists of calls to private methods that perform the actual logic of updating different parts of the UI. Bug: 1142883 Fixed: 1156982 Change-Id: I5157f7aa3c0ba6af84e7222e7e222791d456d28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518776 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#837211}
-
Jeremy Roman authored
Disable PDFExtensionTestWithTestGuestViewManager.CSPFrameAncestorsOverridesXFrameOptions due to flakiness. Bug: 1158890 Change-Id: Ie73a18c1442446c2df8881137851dbdc36484adb Tbr: ericlaw@microsoft.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593692Reviewed-by:
-
Michael Thiessen authored
This test was failing to finish an Activity it started, causing other tests in the batch to fail. Bug: 1158861 Change-Id: Iaf76edf98ca19770c23365913174275bb4e6106a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593691Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837209}
-
Ryan Keane authored
This CL modifies the CastRuntimeAudioChannelBroker to split the factory implementation into a separate file, with linking conditioned on the type of build. Bug: b/170958431 Change-Id: Id7d0a41ac3ab7430d09a583045941b5e9d37333b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570389Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#837208}
-
Wenyu Fu authored
DeferredStartupHandler.waitForDeferredStartupCompleteForTesting were timing out with previous timeout. ChromeActivityTestRule was working properly because this call was called when NTP is fully loaded, which the flaky test case did not. Thus increase the time out to deflake. Bug: 1157611 Change-Id: I4587c151659000c8962b40b74b4bc3575ec0e6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590550 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#837207}
-
Scott Lee authored
It has been mostly successfully. https://screenshot.googleplex.com/BwPYVjGzVU4rVfq Sampled a failed step and verified that the failures was from the test itself. https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/736526 Bug: 1084332 Change-Id: I1abe93a96d2347fd377938388b6b1ceda74c3ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593907Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837206}
-
Corentin Wallez authored
Bug: chromium:1136231 Change-Id: Icc0b0da8d45c12eb76c079ba21303b41bf16c403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593608 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#837205}
-
