- 20 Sep, 2019 40 commits
-
-
Stephen McGruer authored
This reverts commit bf2af3a0. Reason for revert: Speculative revert due to memory metric regression - crbug.com.1004669 Original change's description: > Add ontransition{run, start, cancel} to GlobalEventHandlers > > https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A > > Bug: 868224 > Change-Id: I68b33822badc36c3cebcdca7bf6f47d834160270 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797226 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696699} TBR=chrishtr@chromium.org,xidachen@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868224, 1004669 Change-Id: Icbf013b21a3cb384ac396dff97ae1e7485e9db21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816818Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698491}
-
danakj authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1799386 Page zoom level is a page/view concept, but the code to manage it is currently in RenderFrameImpl, though only run when it is the root frame. This doesn't dramatically change ownership of responsibility but moves the code up into RenderViewImpl. RenderWidget still goes through RenderFrameImpl (though more explicitly) to set the zoom level on the RenderView. And RenderWidget takes responsibility for closing the page popup instead of having multiple "set page zoom" methods on RenderViewImpl. This uncovered some spooky action-at-a-distance and makes it more explicit and documented, though no less unfortunate. A local root LocalFrame does not initialize with the correct page zoom value because it has no parent to read it from. We (accidentally?) worked around that by setting the RenderView's page zoom to its current value when navigating a (new) LocalFrame, which would call into blink's WebView and walk through the entire frame tree setting the value on everything, eventually also on the new LocalFrame. Now on navigation, for a local root, we call RenderWidget's UpdateWebViewWithDeviceScaleFactor() which does the same thing by re-setting the WebView's page zoom factor. This was done when making a new main frame in multiple places (RenderView and RenderFrame both called it in the same CreateFrame() callstack). Now it is consolidated to a single place on navigation for the main frame and child frames giving them more consistent behaviour, and going explicitly through this method that should go away if things were well designed, rather than re-setting the RenderView to its own value. Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered throughout RenderViewImpl and RenderFrameImpl. What we need is for 1) The Page to be updated with PreferCompositingToLCDText when the device scale factor changes. 2) The WebView to be updated when the device scale factor changes. 3) The LocalFrame of a local root needs its page zoom set by poking the WebViewImpl to walk through all frames and set it. Web tests also have 2 places to set the page zoom factor: One is on the WebView, and one is on a LocalFrame directly. Both of these skip past content. When setting the zoom factor on WebViewImpl directly, content believes the zoom factor is still at the default. When SynchronizeVisualProperties events come in it sees the content value hasn't changed, so it does not set a zoom on blink. This allows the web tests to override the value secretly behind content's back and not have content fix it. This patch changed web tests via eventSender to set the value in content so that they agree. This means content receiving SynchronizeVisualProperties IPC will race with the test setting the page zoom and we need to prevent the IPC from overwriting the zoom set from the test. A test-override-zoom-level is added to RenderWidget to support this, similar to device scale factor. Secondly, the path to set page zoom factor on LocalFrame directly takes things a step further and changes the zoom behind the back of WebViewImpl also. This means the zoom factor has no chance to combine with the device scale factor, as WebViewImpl combines these 2 to set a zoom on the LocalFrame. That resulted in incorrect test results. It also continues to prevent content and blink from agreeing and causes SynchronizeVisualProperties updates to race with the test. This patch drops this second method for setting the zoom factor via internals, leaving just the eventSender path, which goes to the main frame RenderWidget. Web tests were also resetting the zoom level on the WebViewImpl directly from the TestRunnerForSpecificView::Reset(). Instead, we have EventSender reset the zoom back to 0 (the default) on the RenderWidget. R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I1c59f78c194410302fc9d95c549b7cfaa08b3784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811859 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#698490}
-
danakj authored
The LatencyInfoSwapPromiseMonitors do not need to be heap allocated, they are destroyed within the same stack frame where they are created but they are put on the heap because the LayerTreeHost is treated as being possibly null. The LayerTreeHost would only be null if the RenderWidget is closing, and an IPC is received on the handler through some other channel. Instead, don't call to the handler from RenderWidget::HandleInputEvent if the RenderWidget is closing. Then no null checks are needed, and the LatencyInfoSwapPromiseMonitors can be created on the stack. Also narrow their lifetime to just be around the method call that they are monitoring, for clarity. R=avi@chromium.org Bug: 994926 Change-Id: I47a04f248479a6266fba673ea0a2e98ce1671e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812915Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698489}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib196ebb2f7a29f89106978144f0137c0c917c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808457 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#698488}
-
Ken Rockot authored
This is a first step towards eliminating the File Service and migrating DOM Storage code into the Storage Service. File Service and its only clients (DOM storage objects) are moved off of Service Manager APIs. LocalStorageContextMojo and SessionStorageContextMojo are changed to own their own FileService instance, now constructed directly over a directory path. No functional changes intended in this CL. Bug: 994911,977637 Change-Id: I2ffd0bef670304a0dc3c103981139603521a14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778801 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#698487}
-
arthursonzogni authored
The bot is not running in debug mode, causing one new test to fail: SecurityExploitBrowsertest.InvalidBeginNavigationInitor. The bug is easy to fix, which I already have a fix for. TBR: lowell@chromium.org Bug: None. Change-Id: Icd4e2b52829db155e5644e207f10ccae2932fc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816472Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698486}
-
danakj authored
These methods simply call to the underlying LayerTreeHost. Expose the LayerTreeHost directly on RenderWidget and in frame_test_helpers (instead of through LayerTreeView) and have these callers call to the LayerTreeHost instead of calling it through LayerTreeView. R=avi@chromium.org Bug: 994926 Change-Id: I07326b55e6c2de1a70df798689c0685df5525a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812912Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698485}
-
Alexandre Frechette authored
Change-Id: Ie542c2ea632f7bddf50914f7af611bb5911ca427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798823Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#698484}
-
Allen Bauer authored
Change-Id: Ia62b8b0376012143db82661c50437f17cfdab2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809602 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698483}
-
Bo Liu authored
Need to specify support package name in manifest now. Change-Id: Ibc8b3f9d50ab2c39cf36d90a4d2e6bf82b618d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816439 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#698482}
-
Manu Cornet authored
In the newest shelf redesign, the shelf size changes depending on whether the user is on the home screen or "in app". To make that work, we need to have the shelf config observe changes in app list visibility (from the app list controller). This change makes sure the shelf config initialization happens after the app list controller is instantiated, so that the shelf config can add itself as an observer in a future CL. Bug: 982512 Change-Id: I6889156bf1c5aa06972dbeb304bd468afbadf12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816819 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698481}
-
Clemens Arbesser authored
This change makes it possible for users to select a date/time range. The UI ensures that the range is non-empty and valid, i.e., that the end of the range is after the start of the range. For now, this uses the stock android DateTimePicker in a popup dialog. Adjusting the start of the range to after the end of the range will automatically clamp the end of the range to the new start value, and vice-versa. A short demo video is in the bug linked below. Bug: b/139121989 Change-Id: I0c99db66ea1350e81a3aba1246602f7aab8fce4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803437 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#698480}
-
Etienne Pierre-doray authored
Previously, Promise::Then/Catch would take a |RejectCb| that handles a rejection, which should not be misinterpreted as the rejection cb (callback to trigger a rejection) returned by ManualPromiseResolver::GetRejectCallback(). This CL fixes the ambiguity and renames it CatchCb. Similarly, ResolveCb becomes ThenCb. Note: ECMAScript defines promise constructor: Promise(function(resolve, reject){}) where |reject| is the rejection callback similar to ManualPromiseResolver::GetRejectCallback(). Meanwhile, it defines p.then(onFulfilled[, onRejected]). Bug: 906125 Change-Id: Ia402d38eed205c80365ce6e1fd2947ffab272a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814705Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#698479}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 050ac990. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I12658ace628f32a223fa270e95cbb2dce24ebe51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816396Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698478}
-
Julie Jeongeun Kim authored
This CL converts DiscardableSharedMemoryManagerPtr and DiscardableSharedMemoryManagerRequest to new Mojo types. It also update CreateGpuService from viz_main.mojom and methods and members which implement it. Bug: 955171 Change-Id: I3f02534df354edcc5baa09383ac0ad551e91d155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808950Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#698477}
-
Marc Treib authored
The audio-service version was already marked flaky on Mac, but it's flaky on other platforms too. The non-virtual version is also flaky everywhere. TBR=mlamouri@google.com Bug: 1000051 Change-Id: I85f90e83e12169d5cd15b033e13b8d06b8149fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816549Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698476}
-
Tanisha Mandre authored
- Adding identifiers to error and edit icon views. - Tests error icon appears for invalid fields. - Tests Add button is disabled until form is valid. Change-Id: I1409f141e84075fecde9aebe4817dd5f6973e0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811253 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#698475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2126635fbb7e..b5271b8e5167 Created with: gclient setdep -r src-internal@b5271b8e5167 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3a5328b3f25583deb21ae8f1b2e56f53b3fe238a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815688Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698474}
-
Yasmin authored
HelpText is only available for Click to Call and not the other sharing features, so move the logic to Click to Call. Bug: 988461 Change-Id: I11bb24498205ed5c33da0e0bed0f3f58e726bc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816559Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698473}
-
Tanisha Mandre authored
- Inline checking functionality added for Text Field Edit Items - A field is checked as it is typed and an error icon is displayed for invalid fields for the add credit card screen. - The invalid fields have red text. - Delete test for checking if add button is enabled and disabled. This test no longer passes since the behaviour has changed and new tests are added in https://chromium-review.googlesource.com/c/chromium/src/+/1811253/4 Bug: 1002891 Change-Id: I2b38c2d4c27e33ebfedafd4c514f4a214f4047d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798347 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#698472}
-
Marc Treib authored
TBR=eroman@chromium.org Bug: 1005128 Change-Id: I7d3567acab0a6e82f1288e10534fc7ed08594154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815126Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698471}
-
Fredrik Söderquist authored
This refactors said methods to have straighter code-flow, attempting to document the relevant conditions in them. The calls to SMILTimeContainer::NotifyIntervalsChanged() is sunk out to the respective callers. A minor change in behavior is that EndListChanged() now actually considers the argument it gets passed rather than always using Elapsed(). Bug: 998526 Change-Id: I1286ad3debbccdb3a894edbaf966822e025c7de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813343Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#698470}
-
Erik Chen authored
The code should resize the local frame's widget, not the main widget [which assumes that the main frame is local]. Bug: 1000438 Change-Id: I039ec8292fdf8902a1ed68622219de6ad242292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804332 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698469}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c70b7fb..32d64a5d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie7474a0f081e3b310223f936d6e46fe63156987c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698468}
-
Mohamed Amir Yosef authored
This API encapsulates all the logic to unblacklist a website. Follow up patches will use this API to simplify the saving logic at higher layers. Change-Id: I4f7bd987e5c6b9b43dce3faeeea7e39b003a3599 Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807242 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#698467}
-
Christian Dullweber authored
Adds a flag to enable the new cookie controls UI for users who already block third-party cookies. Bug: 967668 Change-Id: Iabf20b9175460e8b624c3b91f843156cde546a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810522 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#698466}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/edf199a0b96c..eb06d51adc82 git log edf199a0b96c..eb06d51adc82 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 lalitm@google.com metrics: fix build on Windows 2019-09-20 fmayer@google.com Merge "Get full path for libraries." 2019-09-20 lalitm@google.com Merge "bazel: some more small fixes" 2019-09-20 fmayer@google.com Log Build ID when so was not found. 2019-09-20 fmayer@google.com Merge "Add testdata to Android.bp for perfetto_unittests." 2019-09-20 treehugger-gerrit@google.com Merge "Fix base64 issue in adb controller" 2019-09-20 treehugger-gerrit@google.com Merge "Disable left config bar while recording" 2019-09-20 primiano@google.com Merge "Fix sqlite percentile.c in bazel" 2019-09-20 primiano@google.com Merge "Amalgamator: don't pull .pb.h headers in amalgamated header" 2019-09-19 lalitm@google.com Merge "Refactor parser for all graphics related event" 2019-09-19 lalitm@google.com Merge "bazel: add java and gensignature rules and "fix" formatting of build rules" 2019-09-19 fmayer@google.com Pull trace parsing to trace_to_text utils. 2019-09-19 fmayer@google.com Merge "Use heapsample timestamp for ts col of database." 2019-09-19 lalitm@google.com Merge "perfetto: run gen_bazel to update BUILD file for sched_compact" 2019-09-19 nicomazz@google.com Merge "Persist state variables & Implement webusb connection listener" 2019-09-19 hjd@google.com Merge changes I23d79e8c,I38885537 2019-09-19 rsavitski@google.com Merge "compact_sched: traced_probes writer" 2019-09-19 treehugger-gerrit@google.com Merge "compact_sched: config & trace protos" 2019-09-19 taylori@google.com perfetto-ui: Add link to bug 2019-09-19 primiano@google.com tools/gen_bazel: Standalone Bazel build Created with: gclient setdep -r src/third_party/perfetto@eb06d51adc82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135923303,chromium:111169965 Change-Id: I129927c36d18f8300b27d33f852c212be0f7b4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698465}
-
François Doray authored
This adds a historical_histogram_data.md file in which data from the ThreadPool.NumTasksRunWhileQueuing.* histogram is reported. Actions to improve the situation described by this histogram are recommended. Bug: 906079 Change-Id: I4872b6e0c38979161547c8e40ff3125bb971d50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804789 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698464}
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::OmniboxPageHandler and OmniboxPage interfaces. Bug: 955171 Change-Id: Ida97b44d4b34f01af1cd8f9784e02f794041fcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808842 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#698463}
-
Elly Fong-Jones authored
This change: 1) Makes DesktopMediaListView un-focusable; it gives no useful indication of focus and provides no behavior when focused so it primarily serves to confuse. Note that it does have an OnKeyPressed handler, but that is invoked while its child views (the sources) are focused so that behavior remains. 2) Makes DesktopMediaSourceView use the menu selected foreground color rather than the focused border color to indicate selection. Using the latter led to the appearance of a focus ring on the selected element even when the involved source view does not have focus. 3) Makes DesktopMediaSourceView use a focus ring to indicate focus rather than an old-style dashed focus rectangle. 4) Removes DesktopMediaPickerViewsTest.ListViewHasInitialFocus since the list view is no longer supposed to have focus initially (or ever) Bug: 982226 Change-Id: I0118313883eec60c2685662e9cc9c672bccd18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811758 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698462}
-
chrome://autofill-internalsDominic Battre authored
This CL chrome://autofill-internals to Chrome on iOS as well as web_view on iOS. Bug: 928595 Change-Id: I416cbce554ee4a0e9930f3c3a51da8c98166357d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807244Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#698461}
-
Mugdha Lakhani authored
now that we're using BackgroundTaskScheduler everywhere, since version 76, for this purpose. This was previously attempted several months ago but was deemed too soon: https://chromium-review.googlesource.com/c/chromium/src/+/1601264 Add logic to migrate any existing scheduled GCMNetworkManager tasks to BackgroundTaskScheduler. Update C++ logic, remove feature name, and update tests that use BackgroundSyncLauncher. Bug: 924490 Change-Id: Idf791117267a5c4c0aabc3bb213ec3354cf54ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809310 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#698460}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/feee1e4c3671..fb59a6aa3f71 git log feee1e4c3671..fb59a6aa3f71 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 mbonadei@webrtc.org Return `const char*` from ToString(RTCErrorType error). 2019-09-20 nisse@webrtc.org Delete dead code inside #ifdef WEBRTC_ISAC_FIX_NB_CALLS_ENABLED Created with: gclient setdep -r src/third_party/webrtc@fb59a6aa3f71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0aa6becabd89ca649bcdb2b972e9c4ac6e1d2dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698459}
-
François Doray authored
Since the blocking and non-blocking have been merged, there is no need to report data for blocking tasks in separate histograms. This CL also makes passing an |histogram_label| to the constructor of ThreadPoolImpl optional. If no |histogram_label| is provided, no histograms are recorded. This CL takes advantage of that to not record histograms from TaskEnvironment. Bug: 1002318, 995496, 982145, 980409, 972890, 972888, 972883 Change-Id: Ib192f80fc7a706780f0e75bed14df6b58a7db9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813780 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#698458}
-
Henrique Ferreiro authored
Convert the implementation and all users of the discards::mojom::DetailsProvider, GraphChangeStream and GraphDump interfaces. Bug: 955171 Change-Id: I907a35b6175b6c0b8bf45fab141d58fa2ae6baeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805666 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#698457}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d86a5801e4d..8b762286def9 git log 0d86a5801e4d..8b762286def9 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 vapier@chromium.org cros_build_lib: drop unused traceback helper Created with: gclient setdep -r src/third_party/chromite@8b762286def9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I496814180f2296ebcc7c6fe6bd95a53d56742ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698456}
-
Marc Treib authored
TBR=afakhry@chromium.org Bug: 1006101 Change-Id: Ic9fce0ed5078d8a9e5854b6a1e0e19fe46757877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816464Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698455}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 13bdae8541c3fc5acf6ee7de78ec5ab8446848e4`. Binary-Size: crbug.com/1006159, 70KB growth due to afdo heuristics change Bug: 1005146 Change-Id: I057b3095a61b1886b8fc4f00e2f31566362ba9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814797 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698454}
-
Henrique Ferreiro authored
This CL ports BindInterfaceInGpuProcess to accept a mojo::PendingReceiver and makes the minimum changes to get all users to compile. This is required for later CLs that depend on this function. Bug: 955171 Change-Id: Ib70d2b5612d7905fabde2e7aeff941c4d219f302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801146 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#698453}
-
Tanisha Mandre authored
-Normalise the 'region of interest' rectangle to make it usable by the Vision request. - Retrieve the rect from the Preview Overlay View to ensure it is only being received from view related files and doesn't need the camera connection to be setup. Bug:1005216 Change-Id: I2d66fe77dee961ee44387bd42aea7df72f1cf48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810531 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#698452}
-