- 06 Nov, 2020 40 commits
-
-
David Schinazi authored
This CL is part of our investigation into internal bug b/167728915. It adds a workaround in our parsing code to ensure that we ignore obsolete Finch configs. This CL also removes the simulated crash that allowed us to demonstrate that obsolete Finch configs were being seen in the wild. We no longer need these simulated crashes because they didn't provide any useful information beyond proving that there is indeed an issue with Finch. R=nharper@chromium.org Bug: 1144986 Change-Id: I7b0d462d12e93018c05ae28467f6990efb8fa1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520418 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825101}
-
Tom Anderson authored
This is a partial revert of 7e489781. It turns out removing GLX is not necessary since it's already dynamically loaded. Using GLX allows us to remove dependencies on dri2, present, and xf86vidmode. R=sunnyps Bug: 1066670 Change-Id: I44b79b06de76a043f38dfd9270eee980134a7816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523661Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825100}
-
Chris Lu authored
Bug: 1138603 Change-Id: I3872769228ae5d5f6088cbd662b76546a318cb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518269 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#825099}
-
Yulun Wu authored
Dark/Classic shelf use light inkdrop highlights. Bug: 1144136 Change-Id: I5690f73458c623fc82e7f891bfb3bdda963cb386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515200Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825098}
-
Darwin Huang authored
Also, add some comments... Bug: 1145787 Change-Id: I64fc705e671f5534d523d2b9c1ec1d7f01b64c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522575 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825097}
-
Nate Fischer authored
No change to production logic. This adds a tool for generating enums.xml from ProductionSupportedFlagList and uses it to update enums.xml. This also adds a new PRESUBMIT check run the script every time the flag list is modified to remind developers to update enums.xml. This makes some minor lint fixes to android_webview/tools/* which were blocking upload. Test: vpython android_webview/tools/generate_flag_labels_test.py Test: out/Desktop/unit_tests --gtest_filter=AboutFlagsHistogramTest.* Change-Id: Ib427e2bf1ff462766ec5671736cfc9be57db8528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521468 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#825096}
-
Jeroen Dhollander authored
This forces us to remove all dependencies on //chromeos/services/assistant, which in turn will allow us to move the implementation to a different mojom service. I ended up choosing a pretty simple cut where I introduce a new |cros_libassistant| target that contains the interfaces that are currently used both by |AssistantProxy| and the Assistant service. Things in this target will eventually have to move over to the new mojom service. Bug: b/171748795 Test: compiled & deployed Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Idb58d45c59b97f3d906fa7e2e148198ec25813a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518213Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825095}
-
Reilly Grant authored
This change fixes the PositionOptions.https.html Web Platform Tests by configuring the Geolocation API so that no location is available in web_tests. This allows, once 'geolocation' permission has been granted, the tests to run as expected. Follow-up work in this area could add a test_driver method to set a simulated geoposition and move the tests in web_tests/geolocation-api into external/wpt/geolocation-API. Bug: 745079 Change-Id: Ib916f6a2db779c39d6104db0d5a06af6751f7059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519932Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#825094}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f12ca50..a16002b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c45616d63b18285a875afa27620e67c085acda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522244Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825093}
-
Trevor Perrier authored
This CL adds logging to help determine where an issue loading native resources with an override locale present occurs. One theory is that checks in ResourceBundle.getLocalePakResourcePath fail because the Java context can not find override assets. This CL logs whether or not the asset path was found. If it is found we will know that the issue is on the native side, if it isn't found we know the (current) blocker is on the Java side. Bug: 1143026 Change-Id: Iab1275cd5b0dd09e12808bafa4379ac3f519b126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520421Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#825092}
-
David Roger authored
The signin interception bubble and the password bubble cannot be shown at the same time (for UX reasons, they are shown at the same place). In some cases, they could be shown one after the other, but it's unclear how to make that a good experience. This CL gives priority to one bubble over the other (which is simply suppressed). The logic is as follows: - the password UPDATE bubble is always shown, and signin interception is suppressed in this case - the password SAVE bubble is only shown if the signin interception is not shown. To suppress the signin interception, a check on PENDING_PASSWORD_UPDATE_STATE is added in dice_web_signin_interceptor. To suppress the save password bubble, a new credentials filter subclass is created (it was not possible to use the existing sync_credentials_filter, because it is in components and cannot depend on the signin interception). ShouldSave() may be called before or after signin interception (or even both). If it is called after, the bubble can be suppressed by checking if signin interception is in progress. If it is called before, then the bubble uses the same logic as the interception code to know whether the bubble will be shown. This logic is extracted in GetHeuristicOutcome() and shared. At the time of the password check, only the email is known (not the Gaia ID). In order to be able to use the interception logic there, that interception logic is converted to use emails instead of Gaia ID. Note that the heuristic outcome may not be available in some edge cases: - kAbortAccountInfoNotCompatible - kAbortAccountInfoTimeout and in that case the password bubble is oversuppressed. According to experimental metrics (histogram Signin.Intercept.HeuristicOutcome), these are rare events (less than 3% of the outcomes combined). Bug: 1076880 Change-Id: Ib1816020a0df88248b93e04ce2278f30c550e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468119 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#825091}
-
Rakina Zata Amni authored
Currently DeferredOnStartLoadingResponseBody keeps the body's ScopedDataPipeConsumerHandle around until it gets flushed. This might result in the pipe blocking the network service if we're deferred for a long time, which is likely if a page is put into the back-forward cache. With this CL, DeferredOnStartLoadingResponseBody will drain the original body pipe and channel the data into a new pipe, so that data coming from the network service will be handled quickly even when deferred. Bug: 1137682 Change-Id: Id4dadf4b85657c57821696443e72725fe188cfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513314 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825090}
-
Xiaocheng Hu authored
Bug: 1146598 Change-Id: I9db61697c36d139e6e60d8f94eba3b5806c43803 Tbr: csharrison@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522197Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825089}
-
Erik Chen authored
This CL adds a hack to blink that causes Lacros to user the Linux user agent for netflix.com instead of the ChromeOS user agent. This allows Lacros users to watch Netflix. A proper solution is blocked on the CDM team, ETA Q2 2021. Bug: 1114866 Change-Id: I8b510a9c0886d7f472d932416d60ad404093384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521140 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825088}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cb5c5e17289..70bb18d7c99d 2020-11-06 tdenniston@google.com [svg] Implement feColorMatrix filter 2020-11-06 adlai@google.com Totally block trying to flush a ddl drawmgr 2020-11-06 kjlubick@google.com [canvaskit] Clean up readPixels API on Canvas and Image 2020-11-06 reed@google.com Move image sampling options into their own header 2020-11-06 johnstiles@google.com Reland "Add memsets to the GrBlockAllocator unit tests." 2020-11-06 johnstiles@google.com Improve constant folding for int vectors. 2020-11-06 johnstiles@google.com Add Literal<T> and getVecComponent<T> for template code. 2020-11-06 brianosman@google.com Fix merge conflict in RELEASE_NOTES.txt 2020-11-06 kcbanner@gmail.com - GrGLPath: Fix hitting an assert when a style applies a path effect that results in an empty path 2020-11-06 egdaniel@google.com Fix formatting nit. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Icdb7a30f5f3ce94e2a0543342edbe26fe40067ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825087}
-
Xing Liu authored
Adds an observer method to notify update for reading list backend. Bug: 1139133 Change-Id: Ic5483e075086d48334a9e347125048b5699c2560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519151Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825086}
-
Ossama Mahmoud authored
Currently, in the fingerprint enrollment flow we instruct the users to place their fingers either on the power button or on the fingerprint sensor without specifying the exact location of the fingerprint sensor In this CL, the aria_labels are updated to provide the users with the exact location of the fingerprint sensor on their devices. Bug: 1146413 Change-Id: Ibbf8bb23485380a0be17fbe29f03c3f69df2bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523323 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825085}
-
Michael Checo authored
- Provides "customSort" function to scanning select elements that use the select behavior. "customSort" should cover all custom sorting needs by allowing callers to provide their own comparison function and an optional conversion function that can be used to sort on any field. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I8bed8c9b2c70f066ac219fcd2c10f17063c9489d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518237 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825084}
-
Becca Hughes authored
It is not used anymore since the test refactor. Change-Id: Ic8a5d95665f15f5d3498e4c29d8ffd7af6d82c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481684 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825083}
-
Gabriel Charette authored
The trace event will be called "ThreadController active" and be in the "base" tracing category. It will be activated for each active nested loop ThreadController is involved in (i.e. all loops but purely native nested loops -- undetectable). The implementation uses a stack of active run-levels (replacing some existing run-levels counters). This is is simpler than the alternatives as the amount of conditions to enter/exit a run-level are too many to hope to get manual accounting right: Enter: - DoWork() coming from Run() - DoWork() coming from native HandleWorkMessage - BeforeDoInternalWork() coming from Run() or native as well - DoIdleWork coming from a native nested loop (this one is surprising but happens on Mac because the |idle_work_source_| gets invoked first when the |work_source_| isn't signaled and a native nested loop starts..!) Exit: - DoIdleWork() - Quit() (was it already idle or not?) - Exit nested loop (was it already idle or not?) - Exit native task (was there a native nested loop within that native task that we need to "end" now?) Two tricky cases: Nested native task : Native task => native nested loop => native task vs Subsequent native tasks: Native task A (returns), Native task B BeforeDoInternalWork() was refactored as a scoped object because we need to be able to observe when a native task is done to capture Native Task => Nested native loop => End native task (needs to end the native loop, we aren't otherwise notified about it). We need to capture begin/end to be able to differentiate nested native tasks from subsequent native tasks (e.g. in a nested RunLoop without application tasks). The stack-based approach + scoped native work handles all of these cases across both ThreadController impls. R=altimin@chromium.org, fdoray@chromium.org and regular runtime. Example trace @ goto.google.com/oasrn Test: Locally with startup trace, nested loops (tab drag-out-of-window), Bug: 899897, 1074019 Change-Id: I68831ce92a66da8b91a523d931846262182b5de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226216 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e9cf1a8e1bd..31623e15a8a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I288055f3d4bd7752ac44c4848a68c66545f3e85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523540Reviewed-by:
-
Jesse Schettler authored
Update the string for the color mode dropdown label to match the UI spec. Bug: 1059779 Change-Id: Ia5d2e97e12b7913387e7400fe4816bef8a2802bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522900 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Theresa Wellington authored
This test was only failing on tablets, so conditionally disable to retain some coverage. TBR=jinsukkim@chromium.org Bug: 1145195 Change-Id: I12cd015f6c370b177402b6f2f30d00f22dda362a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522903Reviewed-by:
-
Jesse Schettler authored
Add a new ScanJobObserver to receive updates for in-progress scan jobs. The observer is implemented by and passed from the scan app to the browser in calls to ScanService::StartScan(). Bug: 1059779 Change-Id: Ic9e73d688f7639cf8a892e8f5d269840d1b981c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508435 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
John Delaney authored
This web feature's enum was marked obsolete on https://crrev.com/c/2518106, but the corresponding mojo entry was not updated causing the following presubmit warning to trigger: ** Presubmit Warnings ** FeatureObserver enum has been updated and the UMA mapping needs to be regenerated. Please run update_use_counter_feature_enum.py in src/tools/metrics/histograms/ to update the mapping. Change-Id: I6b5aaa40b3c2f5da293bcd54f8cb65fdc222ec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522960Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825077}
-
Theresa Wellington authored
Disable this test on M emulator due to flakiness TBR=siashah@chromium.org Bug: 1146477 Change-Id: If8bc27db6b1ff252a782657da11199da53d67612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523558Reviewed-by:
-
Roland Bock authored
Returning an optional struct which is only filled in case the call is successful does not require an extra bool to indicate success. The change removes said bool. This is a documentation-only change. Change-Id: If7406703e0cbd91a77c590383ea3430978d1c9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523174Reviewed-by:
-
rbpotter authored
The scenario the test is checking is very uncommon (requires PDF printer to be disabled, and no printers connected). Flakes are likely related to the new temporary dom-if added around the user manager. Disable the test for now, until the timing issue can be resolved or the dom-if can be removed. Bug: 1146513 Change-Id: I613557e4fe877e0f4bb2fff5c160a65692cc0eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523248 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#825074}
-
Thomas Lukaszewicz authored
This CL adds support for the feedback button on non ChromeOS desktop platforms Windows, Mac and Linux. See below for details on new feedback bucket. https://docs.google.com/document/d/1vepB7t_cYatX_-jNkVbkv49WSVPCk80ueHlg7oW6TIA/edit Bug: 1099917 Change-Id: I795ac19fe9e4fb5b8655c721ca9bf62b9728f992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523489Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825073}
-
Krzysztof Olczyk authored
Add [Stable] to: * mojo_base.mojom.File * mojo_base.mojom.ProcessId * mojo_base.mojom.UnguessableToken These are fundamental types that are unlikely to require any non-compatible changes. Making them stable is required for their use in stable versioned interfaces. Change-Id: I6f21e248dc995f790024e86ae5afe312d51b584c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521117 Auto-Submit: Krzysztof Olczyk <kolczyk@vewd.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31623e15a8a0..7abf802320ca 2020-11-06 primiano@google.com Merge "native-heap-profiler.md: fix Target processes anchor" 2020-11-06 treehugger-gerrit@google.com Merge "metrics: Tweak RAILMode interpretation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd6d33382491fa36d5f85db432438bd0476ed9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522965Reviewed-by:
-
Taylor Bergquist authored
Previously, with tab scrolling on and stacked tabs both on, the tabstrip was being put into the ScrollView, but stacked tabs never let the tabstrip width grow beyond the available width, so it never became scrollable. Now, tab scrolling prevents stacked tabs layout from being enabled. Bug: 1145746 Change-Id: I1e2196138566e3998a59639baeb6dfe9e3742065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522509Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#825070}
-
Filip Gorski authored
Bug: 1075602 Change-Id: I4f053a11ad6dcb564e9fa766daa3abd30de516cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522924Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#825069}
-
Sam Maier authored
Change-Id: I1285b1d76184bec795025a4157a5770275a8300f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523438 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825068}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/91bb7506bd20..b674f8a27725 2020-11-06 qyearsley@chromium.org Edit depot_tools recipe_modules docstrings for consistency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I289c4420d798bca18b8916d4e1d53118ee113416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523375Reviewed-by:
-
Justin Donnelly authored
Bug: 1000444 Change-Id: I9a4261f503999c89e5f53da7110b15deecbe3cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523239 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825066}
-
Pavel Yatsuk authored
Icon resource id will be set from native feature code. ResourceMapper::MapToJavaDrawableId() will be used for mapping from native constant to Android resource id. This CL adds logic to porpagate the icon resource id to MessageBannerView. BUG=1123947 R=twellington@chromium.org Change-Id: I6c57d9ddd180f229bedffdae3c677fd2c8efc32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523472 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This class uses NearbyConnector to request a connection, then send/receive messages when the connection has been completed. Also removes some "const" qualifiers in WireMessage so that operator=() works correctly. Bug: 1106937 Change-Id: I8925a48a65e2706b694d585d551f790691a03071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512515 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825064}
-
cfredric authored
This CL also adds a PrintTo(SchemefulSite, ostream) function overload, to allow tests to produce better error messages. Bug: 1143756 Change-Id: I90e594eb5c355deb28344f75c1aa5e91402b2044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519753 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#825063}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8b6cf636df1..4ed9d3498dcf 2020-11-06 vhau@google.com Modify gralloc0 implementation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I805f368d9e4922bd94f9acfa1b8a42361709e4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522608Reviewed-by:
-
