- 26 Oct, 2018 40 commits
-
-
Xi Han authored
This CL instantiates the ServiceManagerContext before creating the BrowserMainRunner. It splits the startup path into two, with/without starting the full browser. The changes are implemented behind a flag "allow-start-service-manager-only". Bug: 846846,729596 Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568 Reviewed-on: https://chromium-review.googlesource.com/c/1113802 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#603092}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f git log 603c5da17491..e2fd74b48f6f --date=short --no-merges --format='%ad %ae %s' 2018-10-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e2fd74b48f6f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I81513ad4b54319c199819eb08a01adf504aa1bcf Reviewed-on: https://chromium-review.googlesource.com/c/1301537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603091}
-
Vladislav Kaznacheev authored
Bug: 876125 Test: manual Change-Id: I4e68cb980e829c4070d2735dd6dc4e1b6649d539 Reviewed-on: https://chromium-review.googlesource.com/c/1300217Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#603090}
-
Yi Gu authored
This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I7fd64fcfb4a135d13e02574602111299d672139f Reviewed-on: https://chromium-review.googlesource.com/c/1301563Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603089}
-
Nico Weber authored
This function is now used to zip the remoting installer on mac. That zip contains a .sh script that the build server extracts and tries to run, so make sure it remains executable after unpacking. Bug: 875279,870611 Change-Id: Ia515a997f9d67943daa8e09907b52ec070650de2 Reviewed-on: https://chromium-review.googlesource.com/c/1301793 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603088}
-
Jeremy Roman authored
This removes deprecated uses of V8CallBoolean, and takes advantage of the fact that some of these complicated objects can be more concisely constructed from script. Bug: 670615 Change-Id: Ie4a3cc6404559240a7cb0ea07736e7db0648f4d8 Reviewed-on: https://chromium-review.googlesource.com/c/1299339 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603087}
-
Roger Tawa authored
Bug: 899077 Change-Id: I5247aee260df04a450b485b6b55d25c2ae1fc2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1300107 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f75bf6c00916..bb4f1a567bdc Created with: gclient setdep -r src-internal@bb4f1a567bdc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8c5493e3815fa709d7a527b8b29bc1f547a16c4a Reviewed-on: https://chromium-review.googlesource.com/c/1301538Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603085}
-
David 'Digit' Turner authored
The trace_event_argument.h header was renamed to traced_value.h in a previous CL, this one updates all includes in //ui/ to use the new header. BUG=898787 R=sadrul@chromium.org,sky@chromium.org,thakis@chromium.org Change-Id: I8943695f5764134d2191235ee72a2575b1676607 Reviewed-on: https://chromium-review.googlesource.com/c/1301465Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#603084}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a5d543ce21cd..2769cd540c1e git log a5d543ce21cd..2769cd540c1e --date=short --no-merges --format='%ad %ae %s' 2018-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f54583b6..a539a245 (602763:603045) 2018-10-26 kthelgason@webrtc.org Allocate CMBlockBuffers using a memory pool. 2018-10-26 terelius@webrtc.org Reland "Encode RTC event logs in new format." Created with: gclient setdep -r src/third_party/webrtc@2769cd540c1e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3442c5036f6ba61b9675eb64f2643927597ac32b Reviewed-on: https://chromium-review.googlesource.com/c/1301536Reviewed-by:
-
Alex Clarke authored
They didn't reveal any leads, and are somewhat expensive. Bug: 798554, 897751 Change-Id: Id22b59ccd43b823902c48a4b5f324ccea07e9649 Reviewed-on: https://chromium-review.googlesource.com/c/1301463Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603082}
-
Friedrich Horschig authored
With this CL, there will be a KeyboardVisibilityDelegate specific to the ChromeActivity. This allows to consider keyboard extensions whenever the delegate is called. That means, if an accessory sheet is open, for every component listening or querying the keyboard, it will appear as if the sheet was a native keyboard. This defeats a lot of bugs in which components treat the accessory different from the keyboard (see linked bugs below). Bug: 894747, 895779, 881784, 898468, 897579 Change-Id: I52c234092b78f449f343c2166f9b3b1e52772a66 Reviewed-on: https://chromium-review.googlesource.com/c/1286426 Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#603081}
-
Alexander Timin authored
Address a common pattern of usage by replacing MessageLoopCurrent comparison with explicit method call. R=gab@chromium.org TBR=gab@chromium.org CC=alexclarke@chromium.org BUG=891670 Change-Id: I0f6a7f2c65c9f39dd26abf592dc59efc14b07f57 Reviewed-on: https://chromium-review.googlesource.com/c/1296499 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It doesn't add any functionality over v8::Date::New. Change-Id: Iec74a51f344309b382ed9170e4de0ed672326454 Reviewed-on: https://chromium-review.googlesource.com/c/1299836Reviewed-by:
-
Stepan Khapugin authored
Changes the shortcuts background color to clear. Change-Id: I72d6ca59600fa29e191cf85144526aa573f828e9 Reviewed-on: https://chromium-review.googlesource.com/c/1296252 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#603078}
-
Alex Clarke authored
This patch adds ScheduleWork / ScheduleDelayedWork deduplication which improves the perf test results. Unlike ThreadControllerImpl this deduplication logic is main thread only because I'm assuming the overhead of the locks isn't worth it. Bug: 897751 Change-Id: I879ad904e41c820180712702c66c4afd66cb3fae Reviewed-on: https://chromium-review.googlesource.com/c/1301462 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Alexander Timin authored
Do not use MessageLoopForIO as it is used to post tasks anyway. R=gab@chromium.org TBR=gab@chromium.org BUG=891670 Change-Id: Ib255c6a5a5dd55c2654eaa284d43d7f78f06b244 Reviewed-on: https://chromium-review.googlesource.com/c/1299239 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603076}
-
David 'Digit' Turner authored
The header was renamed in a previous CL, this one updates all users under third_party/blink. BUG=898787 R=skyostil@chromium.org, vollick@chromium.org Change-Id: I7af7fb328588132e5047e6c60ccec028fe516dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1301436Reviewed-by:
-
Owen Min authored
Bug: 898673 Change-Id: Ic61ce99371e3b466f4123691e2544e30afb65f0b Reviewed-on: https://chromium-review.googlesource.com/c/1298303 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603074}
-
chaopeng authored
Based on Windows folks reply, this scroll lagging issue is because the message hit test to wrong window (Intermediate D3D Window) and need to forward to the correct window (Chrome Legacy Window), but Chrome Legacy Window is holding the input queue lock so Intermediate D3D Window can not forward the message. This fix adding 3 window extended styles to Intermediate D3D Window: WS_EX_LAYERED | WS_EX_TRANSPARENT | WS_EX_NOREDIRECTIONBITMAP The first two should make the window transparent for input, and the third avoids allocating a bitmap that would otherwise be allocated with WS_EX_LAYERED. WM_PAINT, WM_ERASEBKGD and ClearInvalidContents() also removed because they unnecessary for transparent layered window. Bug: 871257 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic708b4d2a5a37f8e2e98e425c1be8b28de41d001 Reviewed-on: https://chromium-review.googlesource.com/c/1299342 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603073}
-
Daniel Bratell authored
Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Jochen Eisinger authored
This mirrors the calls on OAuth2TokenService::Observer::On{Start,End}BatchChanges. Bug: 897113 Change-Id: I6a436baf28f4bf629da8a9b037cd5ab04c644fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1296249 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603071}
-
Tim Volodine authored
Implement the WebViewClient.onReceivedLoginRequest callback for Android WebView in the Network Service enabled case. This patch makes sure the header is properly parsed and the callback executed. Also updates the test filter with the tests fixed by this patch. Tests fixed: -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnGoogleCom -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnNonGoogle -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginWithNullAccount BUG=893562,841556 Change-Id: I91bfb1e3d9ffb8783cc0952e0498f2e428976a7e Reviewed-on: https://chromium-review.googlesource.com/c/1292052 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
David Bienvenu authored
Use static initializer for condition_ member var instead of win api call. Bug: 891924 Change-Id: I61860a13f286389cf955a74d8e4b3e5c3d30bbb9 Reviewed-on: https://chromium-review.googlesource.com/c/1299916Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603069}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/954de5bd..cce05b09 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd81927f8c1bc3605be07c330d3e10aa8988c6ab Reviewed-on: https://chromium-review.googlesource.com/c/1301560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603068}
-
Xi Han authored
In this CL, the entire ResouceBundle is initialized in the ChromeFeatureListCreator. This prevents loading parts of the data pack earlier and then add it to the ResouceBundle when the full browser starts. Bug: 846846,729596 Change-Id: Ia254252288ead936bde8cb65b12cf2fecbfc106f Reviewed-on: https://chromium-review.googlesource.com/c/1292516 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95dfa5223ac6..a5d543ce21cd git log 95dfa5223ac6..a5d543ce21cd --date=short --no-merges --format='%ad %ae %s' 2018-10-26 mbonadei@webrtc.org Set minSdkVersion to 16 for AppRTCMobile_stubbed_video_io_test_apk. Created with: gclient setdep -r src/third_party/webrtc@a5d543ce21cd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa9936e687006c3a5db37a4da4f93e51ee1998ac Reviewed-on: https://chromium-review.googlesource.com/c/1301535Reviewed-by:
-
Maks Orlovich authored
Only true is ever passed here now, so this is latent. Change-Id: I1afd9c466aca857a99ac2cf932185aa899a228cc Reviewed-on: https://chromium-review.googlesource.com/c/1300036Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603065}
-
Gaurav Dhol authored
base/process/memory_win.cc(35,2): error: Unsupported platform Bug: 893460 Change-Id: I207473a8d4dc7c4d5fc01dae10fde51db0bdfab2 Reviewed-on: https://chromium-review.googlesource.com/c/1298832 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 884310 Change-Id: I0f14c7dfcb2a6c54e52ac4f18328095e4af78db2 Reviewed-on: https://chromium-review.googlesource.com/c/1300778Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#603063}
-
Zakhar Voit authored
This is a reland of 75d0995f I've fixed the start-up crashes with DCHECK enabled (see diff from PATCHSET-1 to PATCHSET-3). Original change's description: > Updated AllowedUILocales to handle preferred languages. > > Updated AllowedUILocales to limit not only the ui locales but also the > available preferred languages. Renamed AllowedUILocales to AllowedLanguages to > better indicate that. > > Bug: 579660 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3 > Reviewed-on: https://chromium-review.googlesource.com/c/1256570 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597559} Bug: 579660, 695042 Change-Id: I5d499843fb500fa9d2852559dedc08adfd012da0 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1280270 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603062}
-
Ross McIlroy authored
The V8 context shouldn't be accessed when generating context independent code. Convert some string equality operations which require a context to the StringEquals function which does not. BUG=chromium:898076 Change-Id: Ia9a01b27fa9fcfc0c19268a3c862f2174eda7e1d Reviewed-on: https://chromium-review.googlesource.com/c/1301459Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0607ea1bb336..f75bf6c00916 Created with: gclient setdep -r src-internal@f75bf6c00916 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id2397e8ea045abc3ce9f73236197d8de37b33111 Reviewed-on: https://chromium-review.googlesource.com/c/1301534Reviewed-by:
-
Alex Clarke authored
We don't need task timing on the UI thread, so this patch arranges for time only to be sampled if we have an observer that needs it. Bug: 897751 Change-Id: I5915efdb903813a574ca05cee316cb30fa75b39c Reviewed-on: https://chromium-review.googlesource.com/c/1297425 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
This reverts commit 3767b2ad. Reason for revert: This CL is innocent. I fixed the issue separately: crrev.com/c/1297853. Original change's description: > Revert "Show notification counter even on lock screen" > > This reverts commit 155c0b00. > > Reason for revert: This breaks the lock screen notification. > > Original change's description: > > Show notification counter even on lock screen > > > > - Unblock notifications in SessionStateNotificationBlocker > > - Hide the message center by seeing the session sate (previously, it > > saw the count of notifications) > > - Change height below scroll, by checking the visibility of message > > center (previously, it checked only the height) > > > > Bug: 893945 > > Test: manual > > > > Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880 > > Reviewed-on: https://chromium-review.googlesource.com/c/1282426 > > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601824} > > TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org > > Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 893945 > Reviewed-on: https://chromium-review.googlesource.com/c/1296330 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601930} TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org Bug: 893945 Change-Id: Iaee3fc6e7dcb996be1406897b07f571991a7e3db Reviewed-on: https://chromium-review.googlesource.com/c/1301037 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603058}
-
Christian Dullweber authored
Rebuild leveldb for LocalStorage when deleting all cookies. This will remove traces of deleted data from disk. This change adds a RewriteDB() method to leveldb.mojom and adds handling of error cases, where the database service becomes unusable and closes the mojo connection. TBR: michaelbai@chromium.org Bug: 823071 Change-Id: I639ce21d7578d19e45ea9b7329b6ccbdfab8b527 Reviewed-on: https://chromium-review.googlesource.com/c/1162172 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#603057}
-
Guido Urdaneta authored
It is easy to produce explicit universal cases for discrete sets of boolean values since there are only to possible values. This CL adds an specialization so that the common case of a set with {true,false} is considered universal. This helps simplify some of the constraints processing code for audio, which contains many boolean properties. Bug: 731170 Change-Id: Ie7cd41a161f9de93fbc13273d44d2cccaa217522 Reviewed-on: https://chromium-review.googlesource.com/c/1299004Reviewed-by:Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#603056}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb69b988..954de5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24da46138da7edfac9d4e51784e0327c58190ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1301555Reviewed-by:
-
Adam Rice authored
https://chromium-review.googlesource.com/c/1262055 introduced CHECK statements to BodyStreamBuffer::CloseAndLockAndDisturb to verify that the stream is not garbage collected during execution of the function. None of the CHECK statements have been hit, so we can reasonably conclude that this is not happening in practice. These CHECKs should not be included in a stable release, so remove them. BUG=882599 Change-Id: I6c132ffd81c6642df7f4d9628b76f108f24bc2ed Reviewed-on: https://chromium-review.googlesource.com/c/1296571Reviewed-by:
-
Adam Rice authored
Copy the the original values of selected DOM constructors, methods and getters to the binding object during global object initialisation. Then access them via the binding object in the V8 extras transferable streams implementation. This protects the implementation from modifications to the global object. Constructors copied: MessageChannel DOMException Methods copied: EventTarget.prototype.addEventListener MessagePort.prototype.postMessage MessagePort.prototype.close MessagePort.prototype.start Accessors copied: MessageChannel.prototype.port1 MessageChannel.prototype.port2 MessageEvent.prototype.data DOMException.prototype.message DOMException.prototype.name BUG=897046 Change-Id: I72e40951e5c45f51c957dfa277044a210b054675 Reviewed-on: https://chromium-review.googlesource.com/c/1291191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
