- 30 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f37083edf0ef..7b275a5af161 git log f37083edf0ef..7b275a5af161 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 ramakrishnan.nikhil@gmail.com [sfnt] Separate WOFF sources and headers. 2019-05-30 wl@gnu.org [base] Fix `make multi'. Created with: gclient setdep -r src/third_party/freetype/src@7b275a5af161 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com Change-Id: I01992f0f80a6178f5d5fa0292f6da5e3a10eac7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664899}
-
John Budorick authored
Bug: 731375 Change-Id: I8a84393090effed7ff357d565a53ed1fd7788f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636599 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#664898}
-
Sky Malice authored
Bug: 968611 Change-Id: I5710626293133e424a80a231f672802fa6c92c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636826Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#664897}
-
Hiroshige Hayashizaki authored
This reverts commit 716c8e2b. Reason for revert: causes media_unittests failure on MSan bots https://crbug.com/968626 https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests Original change's description: > media/gpu/linux: Create DmabufVideoFramePool. > > DmabufVideoFramePool is used to allocate and recycle DMA-buf backed > VideoFrames. It is used by hardware accelerated video decoder. Besides > allocating and recycling VideoFrame, it also provide these functions: > > - Limit the number of buffers to prevent client from draining the > memory. > - Query the original frame by the wrapped frame. > > BUG=941330 > TEST=media_unittests > > Change-Id: I368d620fa0c8fb2b1a03c3479c08bad54acd55da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527911 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664664} TBR=sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org Change-Id: I747757f64d63973d129e640e0ba78173e01090dc Bug: 941330, 968626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636597 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#664896}
-
Nate Fischer authored
This fixes the Accept-Language request header when the Network Service is enabled by adding back q-values for language entry (to properly denote user preference). No change to legacy code path. Bug: 968287 Test: out/.../bin/system_webview_shell_apk launch 'https://httpbin.org/headers' (verify header has q-values) Test: run_webview_instrumentation_test_apk --enable-features=NetworkService,NetworkServiceInProcess -f AcceptLanguageTest#* Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: Ideb10bdf299505b40d96df8c771509a11c102ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637451Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664895}
-
Andrew Luo authored
Bug: 924194 Change-Id: I2e3938ec9cffe07910e2618fa88e0c82a7ccf3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574214Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664894}
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 968296 Change-Id: Icc38b3bbe9cb1c8d66fb1fe004e6a970ac90b826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637740Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664893}
-
Matt Falkenhagen authored
These could be useful to analyze performance, e.g., to see whether renderer process initialization was slow vs the renderer was too busy to receive the Start Worker IPC. Bug: 968424 Change-Id: I46230c92cdc8f28e11730bfc04bdb427a3f35ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636993Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#664892}
-
Manas Verma authored
The GetDetailsForGetRealPan request will return the type of authentication required and potentially a dynamic nonce for the authenticator to sign. Bug: 949269 Change-Id: I35b53f59415d8cc353ea501af6ad8b73eda47f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589695Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#664891}
-
Martin Kreichgauer authored
This change extracts the static-only public interface of CredetialMetadata into non-member functions. The nested UserEntity class is also moved out of CredentialMetadata and the remaining (private) encryption and authentication functionality moves into a .cc-only class called cryptor. No functional changes intended. Bug: 967388 Change-Id: I77d315f684c828c30b7099206ac830e6b54c1ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631393 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#664890}
-
Salvador Guerrero authored
Some parts of BrowserContext (such as VideoDecodePerfHistory and DownloadDB) depend on //components. The components they depend will going forward need to depend on a component service that is build with a SimpleKeyedServiceFactory, which requires a SimpleFactoryKey. For most use-cases, this key can be retrieved from Profile in //chrome, and used in all of //components, since the implementation of the key lives in //components/keyed_service/core. However, that is not the case for code in //content or other embedders of //content such as ChromeCast, headless and Fuchsia. This CL therefore updates the subclasses of BrowserContext in these embedders to provide and own a SimpleFactoryKey: CastBrowserContext HeadlessBrowserContextImpl WebEngineBrowserContext TBR=blundell@chromium.org Bug: 943170 Change-Id: I021b817c576c789b9ef059e882c6f8bfe1bd1b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616422 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664889}
-
Matt Falkenhagen authored
Change-Id: I47993d4e2537948db5844621050cd1ebdb977748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635082Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#664888}
-
Miguel Casas authored
This CL addresses a TODO() [1] to only fill |chromium_image_ycbcr_420v| on ChromeOS if minigbm supports it. A few recent CLs made this info available on GpuFeatureInfo so it can be queried upon construction. [1] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.cc?type=cs&q=ycbcr_420v&sq=package:chromium&g=0&l=1099 Bug: 646148, 911754 Change-Id: Ie22ffc3e4ce6dc996fcab6e16a7c88f0a2508b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636465Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#664887}
-
Matt Falkenhagen authored
The spec changed recently at https://github.com/w3c/ServiceWorker/issues/1307. Also refactor the tests to eliminate duplicate code and properly cleanup. Bug: 968436 Change-Id: I56d649769a64d064dc7342961dd6c4763df7e037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637019Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#664886}
-
Suman Kancherla authored
A bounce approval is when a user initially denies permission on a session request consent dialog or aborts the consent flow, only to restart the consent flow within a minute and grant permission. Bug: 962755 Change-Id: Ibf16344e951b72c910c2c380f31a0e06d29ad94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627212 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664885}
-
John Abd-El-Malek authored
Waterfall should be enough because we expect failures that are specific to this config to be rare. We also don't want to run the tests twice on the CQ for capacity reasons. Bug: 953463 Change-Id: I2d2e217512e4d2d3d181ff5eda0f7caec403af6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636222 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#664884}
-
John Emau authored
Using string substituion to create the log level accessible name. Previsouly these strings were concatenated which makes localization difficult. Screenshot: https://i.imgur.com/pfm8akV.png Change-Id: I141c0ccb5453936d665b7432e0fc5f1659677247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629488Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#664883}
-
Erik Jensen authored
The new gRPC telemetry service uses the ChromotingEvent proto directly rather than taking a dictionary of key-value pairs, so the proto needs to be imported into Chromium. Bug: 968348 Change-Id: I55e79fec24761fb1e3274a0e406cb3d93d10578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636550 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#664882}
-
Pavel Shmakov authored
The api is introduced in https://android-review.googlesource.com/c/platform/frameworks/support/+/960642 Bug: 960453 Change-Id: Ie606b4c236ac1aa6000c0c3e501dfcbd8c18cfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635609Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#664881}
-
danakj authored
The LocalMediaStreamAudioSource can stop and recreate the AudioInputDevice, passing the same |this| to each, and running the same |started_callback_| when it starts. This means the callback needs to support being run more than once. R=guidou@chromium.org Bug: 968499, 953861, 751838 Change-Id: I293db74f3068dfa6971550cf09321837b311f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636827Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#664880}
-
Robbie McElrath authored
We don't need these tests now that the Network Service is launched on stable. Bug: 920038 Change-Id: I82de992770b8f820321e884b121b7e9ee2904eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633191Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#664879}
-
Lan Wei authored
This test is currently failed on this bot because of memory leak https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak Bug: 606367 Change-Id: Ie7b7ee195cfbfa4afc51bada69f5e2a471f537f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637697Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#664878}
-
Daniel Nicoara authored
The region is in surface space not in display space. Bug: None Test: Run "wayland_fullcreen_client --transform=90" and touch surface. Change-Id: I982ce55e92236a07ee441d6cb38c872a86c786d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636600 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#664877}
-
Yuwei Huang authored
Change-Id: I843a4e6d667c7b86dfd95c092414bb478d9f860b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637048 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#664876}
-
Kyle Milka authored
On Desktop add a shortcut to the Google Search page to the list of most visited tiles if the user does not have custom links. If the user already has the maximum number of MV tiles the last one will be replaced with this new shortcut. Bug: 962558 Change-Id: I6f3bf15f380cf02292ad738d65bf125c739dd68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626955Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#664875}
-
Christian Dullweber authored
Enable the experiment and remove fieldtrial config. Bug: 823071 Change-Id: Icfc5dcd411e4e92e9a9ead96bcd51bea2fa39aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634839 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#664874}
-
Josh Nohle authored
See design at http://go/cros-devicesync-v2-scheduling. The added DeviceSync logic has nearly identical behavior to Enrollment scheduling. The notable difference is that DeviceSync v2 does not make periodic requests. Support for InvokeNext processing is added. ClientDirectives received from CryptAuth may contain an InvokeNext field specifying that an Enrollment and/or DeviceSync request should be made after the current Enrollment or DeviceSync attempt finishes successfully. These subsequent requests are handled internally by the scheduler. Bug: 951969 Change-Id: Ib8b4ed98ee8f3e493379c20bd14e1ce5473aaac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630030 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#664873}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/31adc7db3619..f404713905ef git log 31adc7db3619..f404713905ef --date=short --no-merges --format='%ad %ae %s' 2019-05-30 saklein@chromium.org cros_uprev: Simplified cros_mark_as_stable. 2019-05-29 seanabraham@chromium.org chromeos-config: Disable moblab-generic-vm-pre-cq tests Created with: gclient setdep -r src/third_party/chromite@f404713905ef The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1f7312486c7bc48cf340b29e391d208e6e3252c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664872}
-
Eugene But authored
This CL makes changes to the files, so they compiled without errors with EG2. Updated EG1 build target with proper EG1 defined. This CL does not add files to EG2 target, because tests are failing due to EG2 helper absence. Relanding reverted: https://crrev.com/c/1632591 Patch 2 remove changes from forms_egtests.mm which broke slim-nav bot. Bug: 922813 Change-Id: I1efbe63abdb7d5624d16af479e4fe68621272d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637034Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664871}
-
Yun Liu authored
Sometimes coverage data might not be generated on device due to wrong configs or tests and command will fail to pull data or remove data. Don't throw exception so that runner can still print result. Bug: 843307 Change-Id: Ie08cf676ca1ca2fb0d3ed4a087d31042c0f0a0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636568Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#664870}
-
Antoine Labour authored
This reverts commit 35454c17. Reason for revert: crbug.com/968645 Original change's description: > Use shared images in CopyVideoFrameYUVDataToGLTexture > > Use an explicit shared image allocation for the intermediate texture > that is used in both the source and destination GL contexts. > > Bug: 882547 > Change-Id: Ibd37bb16a1a43860976c9b35feadd576e099df4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633530 > Auto-Submit: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664539} TBR=sandersd@chromium.org,piman@chromium.org Change-Id: I7e277608fa156f91f9c12f8d98498d770397d9ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637683Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664869}
-
Chris Cunningham authored
InMemoryDB is usually reserved for Guest and Incognito accounts. But recent experiments by liberato@ hinted (noisy stats, other factors may be responsible) that forgetting all your data at the boundary of each browsing session might be good for prediction quality. Lets see :) Bug: 968331 Change-Id: I6803a206266bf7ff6c39d4f6b4c12534c391900d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636475Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#664868}
-
Shimi Zhang authored
This reverts commit c6bc9419. Reason for revert: Caused compile error on bots. Original change's description: > Added XR session request consent dialog for Android > > The consent dialog strings - title, body, button texts - are all shared > between Android and Windows. > > Bug: 963637, 962755 > Change-Id: I4d3f090db1ee2487f305b6993b2851c112df594c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620695 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Carlos Pizano <cpu@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664808} TBR=ddorwin@chromium.org,mthiesse@chromium.org,cpu@chromium.org,klausw@chromium.org,billorr@chromium.org,tiborg@chromium.org,sumankancherla@chromium.org Change-Id: I0dc662ef94d94aec48d1ea303299f6c066f702b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963637, 962755, 968680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637374Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664867}
-
Shimi Zhang authored
This is to match TextView's behavior, see b/122818072. TextView passed its locale to TextSelection/TextClassification, this locale is from an inner mTextPaint object, TextPaint is a subclass of android.graphics.Paint. The default locale in android.graphics.Paint is set to LocaleList.getAdjustedDefault(). [1] Note that there is still a gap between WebView and TextView since TextView has API to set locale, but WebView doesn't. [1] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/graphics/java/android/graphics/Paint.java#491 Bug: b/122818072, 710505 Change-Id: Iaaf07656e7c852f30ac0b5ae76108583fc5105da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636311Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664866}
-
Caitlin Fischer authored
In the label experiment on desktop, a LabelFormatter is not created a surprising number of times. I suspect this is due to the condition that forms have a name field, so I am removing this condition in hopes of increasing the number of times a LabelFormatter is successfully created. Bug: 968207 Change-Id: Ic41bfe2025f720d2385071c96f956ba7c1f0c141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635633 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664865}
-
Eugene But authored
This module does not have actual tests yet. Notable changes: - add ios_chrome_ui_eg2tests_module module - add ios_chrome_ui_eg2tests_module to ios/chrome/test/earl_grey2:all_tests target This CL follows the same pattern as https://crrev.com/c/1628171 Bug: 866147 Change-Id: Iaac2b480054e221e8b3b9b8a8b07292608e27742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636483Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664864}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e18325d988a5..b4f93115c39b Created with: gclient setdep -r src-internal@b4f93115c39b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I56d5ce87b17ec3903b28fa25793f748a609b701b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637410Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664863}
-
Koji Ishii authored
This patch fixes the top and bottom of inline boxes for the `top` and `bottom` values of `vertical-align` not to include their paddings. The spec[1] says align with the top/bottom of boxes. Line box in CSS is special that paddings are included to draw background and borders, but are not included when computing their heights[2]. All impls agree that the top/bottom in this case is the latter; i.e., not to include paddings. [1]: https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align [2]: https://drafts.csswg.org/css2/visudet.html#inline-non-replaced Bug: 968438 Change-Id: I034d0390e3695e8a3fcc737f94fc5561e16cd617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637006 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664862}
-
John Budorick authored
Bug: 968586 Change-Id: I30437e802a3fccfa6658dc7ae2a49911a5be11f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636719 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#664861}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9779b146cdfe..3acbc749e4a6 git log 9779b146cdfe..3acbc749e4a6 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 ehmaldonado@chromium.org gclient: Make it possible to set target_rev to a commit hash. 2019-05-30 borenet@google.com [git-cl] Fix crash in "git cl upload" Created with: gclient setdep -r src/third_party/depot_tools@3acbc749e4a6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: I51fb1d0031a2861e13bfec855c9ef42f4276b8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664860}
-