- 07 Jan, 2021 40 commits
-
-
Egor Pasko authored
Restrict Linker functionality to be "package private", do not expose the whole Linker API to clients. Reduce verbosity in code comments about the Linker, and reformulate them in terms of RELRO producer/consumer, rather than process type. This way the App Zygote can become the RELRO producer without contradicting all these explanations. Remove ChromiumLinkerParams. Previously I thought that in the new protocol it would expand, but now I realized that it is better to extend the messages that happen later in Linker lifetime. Extract the bundle exchange between linkers in different processes into LibraryLoader's inner class. This looks cleaner because it makes the communication protocol handled in one compact place. Before this change it was nontrivial to verify that communication is not racy. The plan is to add functionality to the MultiProcessMessageHandler to make it possible to sometimes move the RELRO FD from isolated processes into the browser process, without leaking a lot of knowledge about it outside of the package o.c.b.library_loader. With this change the MultiProcessMessageHandler will make sense to move to another file. Bug: 1154224 Change-Id: I2c027961530947a93bca44ce70b8b9dcd25e1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607931 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#840993}
-
Fergal Daly authored
This replaces render_frame_created_ and was_render_frame_ever_created_. We should also be able to get rid of must_be_replaced in a follow-up. Bug: 1163815 Change-Id: Ib8f20e4b98b1ceeb268149e219e247691859da66 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599784 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840992}
-
Francois Beaufort authored
This CL removes services/device code of the Web NFC API to reduce binary size of the Desktop build. Bug: 520391 Change-Id: I63cd742e8a185acd755354664d27348fd5bf17c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595421Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#840991}
-
Alice Wang authored
This CL moves ccountPickerDialogFragment to signin.ui target. Bug: 1159804 Change-Id: I887a245b7eca166de19c76a7c87c709de3239a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608833 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#840990}
-
Stephen Chenney authored
Bug: 916825 Change-Id: I2235cc1331deb857a69bc15938c16551727f4ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610685 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#840989}
-
Taylor Brandstetter authored
Commit log: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2c26785bed47 Bug: chromium:1163228 Change-Id: Ic5f5783afd359036e154e1f08da60a75afebb5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613956Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Auto-Submit: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#840988}
-
Anastasiia N authored
Extend OAuth2Login.SessionRestoreTimeTo* and OAuth2Login.PostMergeVerification/PreMergeVerification histograms. Bug: 1144817, 1138295 Change-Id: Id22d47526780d7d7afeea1cc57e782d8358c9b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601359Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#840987}
-
Ramin Halavati authored
Create and use an ephemeral Guest profile if user has chosen Guest option in signin intercept. Bug: 1157764 Change-Id: I9d00b7c06897bcb0ebfd35c36289502acab6ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611955Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#840986}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I53681c35b7c7cb37ddc924cb5e9e2b51844f60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614405Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840985}
-
Sami Kyostila authored
If the last delayed task in a queue is cancelled and swept away, we ended up comparing an invalid iterator with the end of the queue. Depending on where the new end of the queue ends up being, this can cause us to try to cancel an invalid task, potentially triggering a crash. Bug: 1155905 Change-Id: I9df4a2802dbaf3da733f8bde72f394b8fe0b7fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612970 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#840984}
-
Daniel Cheng authored
When a window proxy is initialized for a child frame, it must be reinitialized on every subsequent navigation to correctly hook up the window proxy (which may have cached JS references). Previously, this was only happening for the main world window proxy. One visible side effect is that if an extension cached a window proxy reference to a frame that was then navigated, the cached reference would not work until something else forced the window proxy to be reinitialized. Fixing this has an unintended side effect in an inspector protocol test which logs context creation: since isolated world window proxies are reinitialized in an arbitrary order (specifically, HashMap iteration order), the expected results become arbitrary as well. Instead of hoping that iteration order remains consistent, update the test to only log the context creation events it actually cares about. Change-Id: I11d7e13f7c2810d1c662ccf40f37c880e5026db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607680 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840983}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..ccaf6dbd5c6e 2021-01-06 primiano@google.com Win port: add base::getopt_compat If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Test: Test: perfetto_unittests --gtest_filter=GetOpt* Change-Id: I1d31283c15d4a1670648e89f2dee3e78d06db3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840982}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_ScriptedPrint message to ScriptedPrint() in mojom::PrintManagerHost. While this sync message is handled, PrinterQuery::GetSettings() triggers the print setting dialog box. If users don't have any action on the dialog it could cause the unresponsive dialog. So, it uses SetBlocked() to ignore the unresponsive dialog. Bug: 1008939 Change-Id: I9aa91e55479befc6917fb3006871ed89e5209ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569167Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#840981}
-
Daniel Hosseinian authored
Bug: 1048812 Change-Id: I28771f02ae2afd793ab92e52d29cd9665bbb7504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613948 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840980}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f902efb9511c..7f2db542af0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie64bb52ff4172c23ca143634b8667ae97ed17bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614122Reviewed-by:
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/d9581878fcf8..702a79c7d773 $ git log d9581878f..702a79c7d --date=short --no-merges --format='%ad %ae %s' 2020-12-30 huangdarwin Fix a problem handling sub-queries with both a correlated WHERE clause and a "HAVING 0" clause where the parent query is itself an aggregate. Created with: roll-dep src/third_party/sqlite/src Bug: 1160602 Change-Id: Ie960e77153efcb9205cb8369d03623a44a883597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613955 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840978}
-
Alex Ilin authored
There is a couple of bugs related to the color picker <div> having `position: relative`. This CL removes `position: relative` from the top-level div and adds a nested div with `position: relative` to place the color picker icon and a hidden input element on top of it. Fixed: 1162053, 1161660 Change-Id: I1e856bb58a3508bc2deb9ce84487ea7a8cb95d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611274Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840977}
-
Luca Hunkeler authored
JITT should only trigger when both the "get help" and "proactive help" swtiches are turned on. Bug: b/176071036 Change-Id: I978d49c1c288fc422343ccf49eea0573ac51d215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613046 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#840976}
-
Satoshi Niwa authored
This reverts commit 43cd4f53. This time, I removed DCHECK and also inlined FilePath("/").AppendRelativePath() directly in the caller. BUG=b:171847983 TEST=unittest Change-Id: I4ff3ed1313a0eb38457b8b1d2c1ca1ddf450473f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612789Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#840975}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Iaf93f3d21f0b54d5afc10d3e9506cadc0d8fcd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601834Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#840974}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609977525-bd4b14e8a3331d25b143eda6470a50c1959dbc36.profdata to chrome-linux-master-1609999114-921ab7abd39e739e3d7a532c01a17e7e41151562.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5476ba06720fd3cae7efbd1f653ed30e562ee2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614037Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I76a9174f1d1650039a0baee832a798ca6de4d57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614347Reviewed-by:
-
Luciano Pacheco authored
This is a reland of 74ee693e The correct change description is: Files app: JS modules for background: test_util.js and metrics_start.js Original change's description: > Files app: Move global entities used from foreground > > Move launchFileManager() from `launcher` namespace and registerDialog() > from global namespace to the interface FileBrowserBackgroundFull. > > This keeps consistent all access from foreground page going through this > interface. > > Bug: 1133186 > Change-Id: I91157545620013baeef6eaa0143a5758a289a8ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612254 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Auto-Submit: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Jeremie Boulic <jboulic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840950} Bug: 1133186 Change-Id: Ie9a47233d8248befb516e704b3634298d1bdc860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612256Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840971}
-
Ramin Halavati authored
There are several trigger points for calling Browser::Create in browser_navigator.cc which do not check if browser can be created for the given profile. Checking for possibility of browser creation is added to these cases and a nullptr is returned if browser can't be created. Bug: 1162794 Change-Id: Ie06419165700c41acd69f30945bd11471961443e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609130Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#840970}
-
Sreeja Kamishetty authored
This CL fixes all the MetricsWebContentsObserverTest which checks for ERR_NO_IPCS_RECEIVED event during deletion of page after navigating away. As with BFCache, page is kept alive after navigating. ERR_NO_IPCS_RECEIVED is logged during desturction of a page which happens when page navigates away. But with BackForwardCache, page is stored in back-forward cache. We also add BackForwardCache::IsBackForwardCacheFeatureEnabled() to //content/public to check if BackForwardCache is enabled or not. Bug: 1157426 Change-Id: I989a033f55a7f626b426c3c013c136f00f35e704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611007Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Colin Blundell authored
We will need to refactor PolicyEngine::CanPerformFullUrlLookupWithToken() as part of enabling Gaia-keyed URL lookups in WebLayer: the parts that integrate with Chrome signin and sync will need to be pulled out into a separate method. This CL prepares for that refactoring by reordering this method so that the common checks are all first followed by the checks that are specific to signin/sync integration. There is a slight behavioral change in this CL: - Currently, if the user has enabled enhanced protection and the primary account is available, the value of the kRealTimeUrlLookupEnabledWithToken feature is not taken into account. However, if the user has enabled enhanced protection but the primary account is *not* available, PolicyEngine::CanPerformFullUrlLookupWithToken() will short-circuit out if the kRealTimeUrlLookupEnabledWithToken feature is not enabled. - In this CL, if the user has enabled enhanced protection, the value of the kRealTimeUrlLookupEnabledWithToken feature is not taken into account (full stop). This behavioral change reflects the originally-intended behavior (cf. https://chromium-review.googlesource.com/c/chromium/src/+/2103582). The current behavior of considering the value of the feature if the user has enabled enhanced protection but the primary account isn't available came in unintentionally as part of https://chromium-review.googlesource.com/c/chromium/src/+/2138164. This behavioral change also entails a slight modification of the PolicyEngine unittest: the unittest was previously testing a case where enhanced protection was enabled, the user was not signed in, the kRealTimeUrlLookupEnabledWithToken feature was disabled, and sync was enabled. The result in this case differs before/after this CL, but this case also doesn't reflect reality: it's not possible for the user to be syncing browser history without being signed in. We update the test to have the cases reflect reality. Bug: 1080748 Change-Id: I075bdb7567b8b35a266b2c3cc85258db5a91d042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610095Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#840968}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18e4d8661753..8978b61a6b13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I6082f31053fee308c94b48ac526b22671bcf1100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614223Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d64a3193cd49..f39e76846d7f 2021-01-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 302da256 to ebb8289a (437 revisions) 2021-01-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b9e179f1f239 to 7b2f93895418 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I4329bdd4f367c4e40633448de25a85b93b7ea4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614029Reviewed-by:
-
Jérôme Lebel authored
Adding completion UUID, to make sure EG tear down waits for completion from -[SceneController dismissModalDialogsWithCompletion:dismissOmnibox:] Some flakiness in the tests shows that |drainUntilIdleWithTimeout:| is not enough to make sure all views are fully dismissed before |removeAnyOpenMenusAndInfoBars| returns. Explanation of the flakiness: The test failure is related to: DCHECK(!self.tabSwitcherIsActive) [1], during the teardown. This DCHECK is in |completionWithBVC| completion block. This block is only used by |dismissModalDialogsWithCompletion:dismissOmnibox:| when the tab switcher is not opened [2]. So the only way to reproduce this failure, is to open the tab switcher while the views are being dismissed. During the tear down, |removeAnyOpenMenusAndInfoBars| calls |dismissModalDialogsWithCompletion:dismissOmnibox:|, and then |closeAllTabs| is called, which opens the tab switcher. This is why I suspect |[ChromeEarlGreyUI waitForToolbarVisible:YES]| is needed in +[ChromeTestCase removeAnyOpenMenusAndInfoBars]. [1] https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/main/scene_controller.mm;l=1940 [2] https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/main/scene_controller.mm;l=1960 Fixed: 1143204, 1146459 Change-Id: I152850dbe5844c96ed64919a3a791f44b94f6be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612844 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#840965}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/sync_file_system/drive_backend/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: Ib619c24eff3778cf658acfef90009e240d7cea09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611088 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840964}
-
Darwin Huang authored
Add a preliminary readme to help readers of the code quickly parse the directory. Change-Id: I9393282b5bd26a534ae141a4bb83d91da0504f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614119 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
Performance improvements have been landed, and limits reduced after testing on a weak cloudtop system in debug mode. This may be enough. Bug: chromium:1160616 Change-Id: I5ca85af0dd8bbd99f094025d979dbb7b1617d698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611714Reviewed-by:
Tal Pressman <talp@google.com> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#840962}
-
Eugene But authored
Flag has expired in M88 Change-Id: Ie67fc34e530e0cd4727dee064398de035948e8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597877Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840961}
-
Alice Wang authored
This CL moves SigninPromoController to signin.ui module. Bug: 1159833 Change-Id: I2a65cf55b81cd928c8b93dc21fd61729560c0fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598913Reviewed-by:
-
Alice Wang authored
This CL cleans up usages of toCoreAccountInfo in account picker tests. Bug: 1147417 Change-Id: I0f77d76032701f281ea56cb298f76830ea50f3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612885Reviewed-by:
-
Maksim Sisov authored
When CreateDmabufBasedBuffer call fails, it calls a gpu terminate callback internally, which must be installed before the host buffer manager is used. Bug: 1160261 Change-Id: I90ea974ce9dbec5f36c3fae63002e573e80c7a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609827Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#840958}
-
Luciano Pacheco authored
This reverts commit 74ee693e. Reason for revert: Submitted with the wrong CL description. Original change's description: > Files app: Move global entities used from foreground > > Move launchFileManager() from `launcher` namespace and registerDialog() > from global namespace to the interface FileBrowserBackgroundFull. > > This keeps consistent all access from foreground page going through this > interface. > > Bug: 1133186 > Change-Id: I91157545620013baeef6eaa0143a5758a289a8ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612254 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Auto-Submit: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Jeremie Boulic <jboulic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840950} TBR=lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jboulic@chromium.org Change-Id: I70623d88b81d98d33009db117d6771c09ee29149 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612790Reviewed-by:
-
Rakina Zata Amni authored
Currently we only track the latest same-document NavigationRequest in RFHI, so if a new browser-initiated same-document navigation got into the commit stage before an older browser-initiated same-document navigation's DidCommit IPC gets processed, we'll delete the older NavigationRequest and re-create the NavigationRequest later with NavigationRequest::CreateForCommit, which incorrectly assumes that it's for a renderer-initiated same-document navigation, getting the wrong values for browser-initiated navigations-related attributes such as intended_as_new_entry and nav_entry_id. Bug: 1155414, 1133115 Change-Id: I4d4658d34982f1bb895d6b3dba497bbc6db7341c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599677 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#840956}
-
Min Qin authored
BUG=1154456 Change-Id: I0164f8a4ffd2364ee25f480caa3d5647d80226ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613556 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46d3f02acfab..ca94d1da8597 2021-01-07 syoussefi@chromium.org Vulkan: Refactor generated code in xfb emulation path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic9a4eb4c4cb1024e8b491c893eae8ef3e3a0e73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614026Reviewed-by:
-
