- 24 Aug, 2018 15 commits
-
-
James Cook authored
Neither the mustash team nor the accessibility team has any concrete plans to ship this. We can always restore it if we change our minds. This eliminates a couple IsAshInBrowserProcess() checks in //ash. Bug: 876115 Test: ash_unittests Change-Id: I60928f52facc4a4d382dff2c4c373d967f203f0a Reviewed-on: https://chromium-review.googlesource.com/1187563Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585679}
-
Yuwei Huang authored
This CL makes HostViewController request to autohide the home indicator (the bar acting like a virtual home button), so that user can see things on the bottom after the home indicator times out. This CL is dependent on internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/666568 Bug: 876014 Change-Id: I4d5e3f983100dd43f84f5d422bba31207707c651 Reviewed-on: https://chromium-review.googlesource.com/1187655Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#585678}
-
Trent Apted authored
This is the last Gallery unittest not closure compiled. Bug: 867700 Change-Id: I6e4c2b2cf23b80967e060d838dd3872b55306daf Reviewed-on: https://chromium-review.googlesource.com/1184644Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#585677}
-
Ben Pastene authored
We're low on capacity. Will re-enable the tests when we've refreshed the pool. NOTRY=true Bug: 877280 Change-Id: Ibfe66c0e0a6cdbf7c7c954b2f636fee1f970d0c4 Reviewed-on: https://chromium-review.googlesource.com/1187678 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585676}
-
Boris Sazonov authored
Some informational messages in preferences use text appearance that is normally used for preference summaries (for example, the link to 'Sync and other Google services' in PrivacyPreferences that is shown if UNIFIED_CONSENT is enabled). This CL improves TextMessagePreference to support messages in summaries and updates PrivacyPreferences to use TextMessagePreference, thus fixing the alignment issue there. No longer used TextMessageWithLinkAndIconPreference is removed. Bug: 864806 Change-Id: Ia4375a767a34eadbdc82a7ebd8fa0e90a3e254a5 Reviewed-on: https://chromium-review.googlesource.com/1187152Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585675}
-
Devlin Cronin authored
Add a line to the tooltip of the extension action indicating if the extension either wants access to the current page or has access to the current page (don't indicate if it neither has nor wants access). Add tests for the same. Bug: 876930 Change-Id: Id3da1e77df0f1f1a3109d06be8da1dfa23f543fb Reviewed-on: https://chromium-review.googlesource.com/1185401 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585674}
-
Justin DeWitt authored
This reverts commit 1501aabf. Reason for revert: crbug.com/877063 speculative fix. Original change's description: > Clang: stop building with GCC/libstdc++ from Ubuntu Precise (roll 338452-1:338452-2) > > Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang > that would work on Precise or later. These days, all bots and developers are on > Trusty or later, so this should no longer be necessary. > > Bug: none > Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78 > Reviewed-on: https://chromium-review.googlesource.com/1183915 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585067} TBR=thakis@chromium.org,hans@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: I632e2e47d856d2c7df7e629f12068903e149d166 Reviewed-on: https://chromium-review.googlesource.com/1187344Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585673}
-
Scott Haseley authored
This CL defines the live tab count buckets, adds a namespace and helper methods for defining metrics bucketed by live tab count, and adds unit tests that test example metrics. Actual metrics will be implemented in follow-up CLs. Design doc: https://docs.google.com/document/d/1FB6Pv5Pu0jbYJwSfnqSeufHVOGEt9-d1agpzA4_CC-k/edit?usp=sharing Bug: 861796 Change-Id: Idd510da5f3c40f9c4d5d1dc292fb6b4139217af2 Reviewed-on: https://chromium-review.googlesource.com/1166215 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585672}
-
Vladimir Levin authored
This patch ensures that when the fragmentainer iterator returns a fragment that has an empty clip, we skip generating a fragment for it. This is important since a fragment that has an empty clip can share the logical top with the subsequent fragment, meaning that we cannot use the logical top to uniquely identify a fragment. This patch addresses this issue. Furthermore, we typically skip painting fragments that have empty clips anyway (for obvious reasons), so this should not impact painted contents. R=chrishtr@chromium.org, wangxianzhu@chromium.org Bug: 870521 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f2f6311e0c3c75e4a8d114f13476ce8774e8218 Reviewed-on: https://chromium-review.googlesource.com/1187234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585671}
-
Nigel Tao authored
Specifically, those *.json files live in "/usr/share/chromium/extensions/web_apps", not one level above that. This matches what arc_default_app_list.cc does for external ARC apps, after substituting s/arc/web_apps/. In the future, we may still merge all of those directories into one, but we will start with segregrated extensions, ARC apps and web apps. Change-Id: I79176f00b7c3c19b87468465c2640fde89498da6 Reviewed-on: https://chromium-review.googlesource.com/1166272Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585670}
-
Nigel Tao authored
Change-Id: I5df92149a180050e7c1583f891dc8d1b181b32f3 Reviewed-on: https://chromium-review.googlesource.com/1185339Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585669}
-
Scott Little authored
This test is flaking on the Fuchsia bot, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/16873 TBR=kmarshall@chromium.org Bug: 876894 Change-Id: I455c56835af050aa1f9ff6715a6243500cc06e1d Reviewed-on: https://chromium-review.googlesource.com/1187552Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#585668}
-
Kevin Marshall authored
Previously, ChildProcessLauncherHelper would bind a ServiceDirectory connection on the launcher thread. The binding would attach to the asynchronous dispatcher of the launcher task runner's thread, rather than the client thread. This generated some test flakiness during test teardown. This CL moves the ServiceDirectory binding call so that it runs in the client thread instead. Bug: 876894 Change-Id: I53e05d79a24ab8347e3df697f65f84601f618f40 Reviewed-on: https://chromium-review.googlesource.com/1187125 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585667}
-
Yuwei Huang authored
This CL allows the iOS client to display desktop that is partially obstructed by the notch while allowing user to pan the desktop out of the obstructed area, similar to what we have done on the Android client. This CL also changes the previous logic that handles keyboard height. We are now using DesktopViewport's SetSafeInsets() methods to adjust for the keyboard rather than just changing the surface size. Bug: 876014 Change-Id: I428cf2552acb3bc33cf932890a9395428d969a40 Reviewed-on: https://chromium-review.googlesource.com/1186027Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#585666}
-
Ryan Cui authored
Moves plain Mash tests to FYI waterfall, while retaining a login test on the main waterfall as a sanity check. Bug: 874090 Change-Id: I86c60344610c2a4f99b35f9116c5366771a16c64 Reviewed-on: https://chromium-review.googlesource.com/1175222 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585665}
-
- 23 Aug, 2018 25 commits
-
-
Eric Karl authored
When Android goes invisible in OOP-D, it wasn't tearing down the display, which can lead to GL issues as we continue to use GL after the window (used to create the GL surface) is destroyed. In order to tear down the display for Viz, we need to invalidate our root frame sink ID. This change refactors things so that we always invalidate the root frame sink ID on going invisible, and re-register it on becoming visible. This allows both viz/non-viz to share the same logic. As registering/unregistering isn't doing much in non-viz case, this doesn't add significant overhead there. Bug: 863049 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1589e402185fd9e2cdb007d3d8cd739f303ad48a Reviewed-on: https://chromium-review.googlesource.com/1184376Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#585664}
-
Tom Anderson authored
BUG=876586 R=sky Change-Id: Iac4f45a4aec1a905b75332ed7b365d1a2fce1d87 Reviewed-on: https://chromium-review.googlesource.com/1187223 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585663}
-
Paul Miller authored
Commit 0c0fc42d moved AwVariationsServiceClient's "channel == unknown ? stable : channel" logic into a new android_webview::GetChannel. But this is confusing because the new GetChannel retains the variations-specific comment, and the name "android_webview::GetChannel" might sound like all of WebView should be using this sanitized channel, when UMA still needs the un-sanitized channel. Move the variations-specific comment back into AwVariationsServiceClient and rename GetChannel to GetChannelOrStable. BUG=758290 Change-Id: I4590aa22b73424e14e47444c3fdf3abc151bf441 Reviewed-on: https://chromium-review.googlesource.com/1187271Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585662}
-
Aga Wronska authored
DeviceStatusCollector. DeviceStatusCollector takes day start as an argument. For enterprise reporting it is set to midnight as it was before. For consumer/child reporting it is read from UsageTimeLimits policy. If the day start changes data are aggregated into new day buckets whithout affecting pre-existing buckets. It means that previously stored data will not be mapped to the new day start buckets. Bug: 877178 Test: Run tests in device_status_collector_browsertests. Manually simulate status reports for enterprise and consumer. Change-Id: I60fe3a9f22149aefbfe81c0a48ddbf6ed29ce1fd Reviewed-on: https://chromium-review.googlesource.com/1184397 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585661}
-
akaba authored
The unit tests should start using SurfaceRanges instead of two SurfaceIds for simplicity. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If6d41f07d9f4735399e990aca9c4a8e93449324a Bug: 876731 Reviewed-on: https://chromium-review.googlesource.com/1184226 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585660}
-
Scott Violet authored
Only use the cursor at an embed point if the embedder isn't intercepting events. I'm assuming that if the embedder is intercepting events, then it's setting the cursor. This is the case for WebContents. BUG=877099 TEST=covered by test Change-Id: I04304a2ae8e668f5a7506378868c2a53eac7de0a Reviewed-on: https://chromium-review.googlesource.com/1187409 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#585659}
-
Jun Cai authored
Bug: 874651 Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d Reviewed-on: https://chromium-review.googlesource.com/1184306Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#585658}
-
Kurt Horimoto authored
This class now supports: - enabling/disabling a FullscreenModel, - sending broadcast values, - and notifying observers of service shutdown. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6d0b6964599aee1606dd992577ddc43d4ce43a4d Reviewed-on: https://chromium-review.googlesource.com/1185977 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585657}
-
Lan Wei authored
In GpuBenchmarking, for mouse wheel and touchpad scroll, we want to add "scroll_by_page" scroll option to GpuBenchmarking::SmoothScrollBy. Bug: 871970 Change-Id: If73cc2bb41a77499cfc6215b5d8fde09f33f6caa Reviewed-on: https://chromium-review.googlesource.com/1174993 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585656}
-
Thomas Guilbert authored
This CL uses RemoteMediaPlayer.getApproximateStreamPosition to implement FlingingRenderer::GetMediaTime(). NOTE: GMS core ignores stream position changes in the MediaStatus, when we have a pending seek. Calling both Seek() and Play() back to back in FlingingRenderer::StartPlayingFrom() sometimes causes the stream position update to be lost. This causes getApproximateStreamPosition to report a time that is out of sync with the cast device. We already use the autoplay flag when loading the RemoteMediaPlayer, so removing the call to MediaController::Play() doest not cause any problems. Bug: 830871 Change-Id: Ia5a6384cf11a77a6aa49e9669f015f7835c5a775 Reviewed-on: https://chromium-review.googlesource.com/1180511Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#585655}
-
akaba authored
This CL will force a surface to clear it's observed sinks when it gets garbage collected. This should fix the memory leak problem. Bug: 876884 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I957fa212053649bf095925f9e7a7da7cdc218829 Reviewed-on: https://chromium-review.googlesource.com/1185874 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585654}
-
Christian Fremerey authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1185262 Patch Set 1 is the same as the reverted CL % resolved merge conflicts. Patch Set 3 adds a fix for the issue that caused the revert. Issue Analysis: There was an (existing) race condition where video frames could still get delivered from the camera after the device had been stopped and the native object destroyed. The CL made this condition more likely to happen. -------------- Original CL description: This CL simplifies the threading of class VideoCaptureCamera2.java and by doing so resolves potential issues caused by concurrent access to member variables and Android video API calls. See https://bugs.chromium.org/p/chromium/issues/detail?id=857530 for details on issues. The simplified model is to (still) have the constructor and public API calls happen on a native thread, and to use a single dedicated thread owned by the class instance to post to, do work on, and call back into the native code. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1h1kva4VR1gaV3HVXaSYZFY41icfaB58j-WnHmJdyqc8/edit?usp=sharing Bug: 857530 Change-Id: I7e914fead264990fdd644c32b9ba6e681fa39dec Reviewed-on: https://chromium-review.googlesource.com/1187324Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585653}
-
Wez authored
- Move some APIs off of base::TestSuite, that we unnecessarily public. - Rename the various internal TestEventListeners to express purpose. - Add CheckForLeakedGlobals check, and DisableCheckForLeakedGlobals API. The latter is called by the content::ContentTestSuiteBase, since the various browser- and ui-tests running under that suite base run more like the browser itself, and so are expected to let global singletons leak. Bug: 875486 Change-Id: If749dfe8530abc4a5c13a840bbf8258d48c377c5 Reviewed-on: https://chromium-review.googlesource.com/1182612Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585652}
-
Sophie Chang authored
bshealy@ says this is ok in comment 21 of the attached bug. Bug: 867129 Change-Id: I00ea0620f556c33e8741cd565f62ec4bbd65c4a6 Reviewed-on: https://chromium-review.googlesource.com/1187516Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#585651}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/7a76b645a08c..10df8d1b5861 $ git log 7a76b645a..10df8d1b5 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 slavarnway Delete loopfilter_avx2.c 2018-08-22 remya.prakasan Highbd Warp module modified for alpha=0 and beta=0 2018-08-22 sanampudi.venkatarao Add eob logic for highbd 64x64 inv_txfm 2018-08-17 binpengsmail Early skip of FILTER_INTRA_MODE search 2018-08-21 angiebird Fix aomenc build err when coeff range check is on 2018-08-21 urvang Add a macro to reduce border extension. 2018-08-21 urvang Avoid redefining 2 macros. 2018-08-21 debargha Clamp to prevent rate overflow 2018-08-17 ravi.chaudhary Add unittest for encoder row based multi-threading 2018-08-16 binpengsmail Skip uv's tx search if y's cost is too large 2018-08-21 deepa.kg Account for mode cost for chroma RD early exit 2018-08-20 binpengsmail Fix speed feature skip_intra_in_interframe 2018-08-20 binpengsmail Add config flag for two_pass_partition_search 2018-08-16 tomfinegan Restore external frame buffer tests. 2018-08-20 johann.koenig convolve neon: hide unused functions 2018-08-20 johann.koenig av1 inv txfm: remove unused function 2018-08-20 sarahparker Remove outdated assert 2018-08-15 binpengsmail Speedup inter_txb_hash's tree generation 2018-08-20 debargha Prevent overflow in model_rd_from_sse 2018-08-20 johann.koenig av1 inv txfm: remove unused function (...) Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I0524db5a3bd1232afb968624ecdff031bf060ef3 Reviewed-on: https://chromium-review.googlesource.com/1187240Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#585650}
-
Evan Stade authored
1. Make sure located events go to the top container when it's revealed. This is accomplished with an EventRewriter which clears the target window, which had been provided by the window service, from the event. Without this, clicks on the top container are targeted to the web contents window because the Window Service doesn't know about the top container's window. In the long term, we may be able to remove this EventRewriter with a more general solution (e.g. improving how the window service targets the event in the first place). 2. Instead of mirroring the top container's layers, make the widget completely transparent except for the ash-provided window controls. Mirroring doesn't update the reveal widget in response to changes in the top container's layers, such as when a button is hovered and an ink drop is added. 3. Allow the reveal widget to accept events so that it's possible to interact with the window controls. Resize the reveal widget to be just big enough for the window controls so that clicks anywhere else will go straight through to the underlying top container view. 4. Make the browser-side non client frame view paint the frame bg. This is necessary because the reveal widget (i.e. window controls) is now on top of the container view and has no client-side rendering (what the mirroring view used to provide). Future issues to address: - the cursor is not updated (e.g. when hovering the omnibox) presumably because the cursor is coming from the window that the WS thinks is underneath the pointer, i.e. the web contents. Alternatives considered: - update the mirrored layers every time the layer tree changes. This doesn't seem to be easy to accomplish or likely to be very performant. - move the top container into the reveal widget. This somewhat works with a few tweaks here and there to code that assumes the top container is always in the browser widget, but ultimately it seems that making the reveal widget focusable causes difficulties with window activation and focus traversal. Bug: 640365 Change-Id: I03956c07354e20dadc2919f9a0402ce1f7b4a672 Reviewed-on: https://chromium-review.googlesource.com/1171547 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585649}
-
Lei Zhang authored
Merge two nearly identical code snippets with the same missing check into a helper function. Change-Id: I3ce38f19750ebb9f8efb3c4d150ce5eb7b462010 Reviewed-on: https://chromium-review.googlesource.com/1186268 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#585648}
-
Karan Bhatia authored
The enum value RulesetMatcher::kLoadErrorRulesetVerification is ambiguous and doesn't clarify the failure reason. Rename it to RulesetMatcher::kLoadErrorChecksumMismatch. BUG=None Change-Id: I451221e9a5a67181ecfc599563ff7a3e7f5d72f2 Reviewed-on: https://chromium-review.googlesource.com/1187371 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585647}
-
Tom Anderson authored
BUG=876586 R=sky Change-Id: I97d58a1fcb333781dfa2bceb4c3363b5c914e5df Reviewed-on: https://chromium-review.googlesource.com/1187197Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#585646}
-
Gang Wu authored
Remove old storage implementation for both Java and C++. Bug: 828935 Change-Id: Ib6144e206b513272510763559337dc6aa16e06b6 Reviewed-on: https://chromium-review.googlesource.com/1185794Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585645}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c9316dc. With Chromium commits locally applied on WPT: 2160c22c "Modify source path for wpt test of Accept-CH" 3152c6f7 "[UserTiming] Correct measure where start is undefined" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23214 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6143d70f2e62f0ee1517e5c493ad253d05efd80b Reviewed-on: https://chromium-review.googlesource.com/1187269 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585644}
-
Robert Ogden authored
Wires the Java bridge into the ToolbarModel to trigger the Omnibox Previews badge. Also includes a small pre-s13n hack to enable the Previews UI to be displayed when a HTTPS Lite Page Preview is shown. Bug: 871839 Change-Id: Ia279cd6793c4517d02534a3d16029809c16b34f1 Reviewed-on: https://chromium-review.googlesource.com/1180372 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585643}
-
Ned Nguyen authored
Bug: 828467 Change-Id: I26fea5488c36d930ef84990da3354ccc64c17aa5 Reviewed-on: https://chromium-review.googlesource.com/1187075Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585642}
-
Eric Orth authored
ResolveHostParameters::allow_cached_response is a direct replacement for RequestInfo::allow_cached_response. Defaulting to true, it controls whether or not a result can come from the host cache. ResolveHostParameters::source allows specifying a source (system vs async resolver) for a request. This is a replacement for setting the HOST_RESOLVER_SYSTEM_ONLY flag or directly using the async resolver classes. Just adding to C++ net/ API for now. Mojo version in next CL. Bug: 846423 Change-Id: Ie945745f595302ae745ffdab355ae1b13a993c4a Reviewed-on: https://chromium-review.googlesource.com/1185216 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585641}
-
Clark DuVall authored
This adds a new method to NetworkContext to write the cached data. Verified this worked by adding logging in URLLoaderClientImpl::OnReceiveCachedMetadata to make sure we were getting metadata. Previously, this would always have 0 size with network service enabled. Bug: 876836 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I359e8cf594ff8e4435872c7dae018b1ff9d3c044 Reviewed-on: https://chromium-review.googlesource.com/1185907 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585640}
-