GitLab

Indirections--

BUG=521334

Review URL: https://codereview.chromium.org/1296353004

git-svn-id: svn://svn.chromium.org/blink/trunk@200845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They flaked awhile back but have since ceased to flake.

BUG=521852
TBR=ojan

Review URL: https://codereview.chromium.org/1301903007

git-svn-id: svn://svn.chromium.org/blink/trunk@200844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per webkit-patch print-flaky-tests.

TBR=leviw@chromium.org
BUG=522640, 522641, 522642, 522645, 522646, 522647, 522648, 522649, 522651, 522652, 521091

Review URL: https://codereview.chromium.org/1294933007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No intended behavior change.

BUG=488634
TBR=rune@opera.com

Review URL: https://codereview.chromium.org/1294793004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The class has m_lineBreakObj, which has already been converted to the new API.
This CL updates the childRemoved method to use box->lineLayoutItem() for
comparisons to m_lineBreakObj and for iterating.

BUG=499321

Review URL: https://codereview.chromium.org/1296803004

git-svn-id: svn://svn.chromium.org/blink/trunk@200841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an SVG resource was destroyed, it would notify the
SVGResourcesCache, which would walk the entire cache, notify the layout
object and add a "pending" entry for the id referring to the
corresponding element.
This would mean that every layout object which had any kind of resource
would get a "pending" reference from every id to itself - regardless of
if it ever referred to a resource with the given id. In the particular
test, this resulted in a fairly large (ever-growing) "pending" element
sets because there was persistent resource references in the document.

Fix by only adding "pending" entries for the current clients of the
resource that's being destroyed.
SVGResourcesCache::resourceDestroyed is removed in favor of new method
detachAllClients() in LayoutSVGResourceContainer. The part that
unregistered the resource itself as a client is removed in favor of the
pre-existing call to clientDestroyed() already existing in
LayoutSVGModelObject::willBeDestroyed (delegated to from the resource.)
SVGResources::resourceDestroyed is changed to not call
removeAllClientsFromCache() on the resource being passed - this is
instead done once after having cleared the references in all the
clients.

With this change, the "cycle time" of the test in the bug changes from
linearly increasing to constant.

BUG=521334

Review URL: https://codereview.chromium.org/1302713003

git-svn-id: svn://svn.chromium.org/blink/trunk@200840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The newly added test VersionUtilMac.AppKitVersions had a logic error. It tried
to assert that IsOSMavericksOrEarlier() evalutes to false on 10.8 and 10.9.

Original issue's description:
> Fix the mechanism by which Blink determines OSX version number.
>
> Previously, Blink was checking NSAppKitVersionNumber against a compile time
> constant. This mechanism doesn't work (see the bug for more details). This CL
> converts the logic to use the same mechanism that Chromium uses.
>
> BUG=521034
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200708

TBR=thakis@chromium.org
BUG=521034

Review URL: https://codereview.chromium.org/1288823004

git-svn-id: svn://svn.chromium.org/blink/trunk@200839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates all callers in core/layout/line/ that call needsLayout()
on a LayoutObject.

BUG=499321

Review URL: https://codereview.chromium.org/1299273002

git-svn-id: svn://svn.chromium.org/blink/trunk@200838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the tin says, this TODO is no longer relevant since we no longer use
elementAt.

BUG=505965
NOTRY=true

Review URL: https://codereview.chromium.org/1292333003

git-svn-id: svn://svn.chromium.org/blink/trunk@200837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an object goes out of flow, it no longer contributes to the intrinisic
widths of its parents. We need to mark them for recalculation while we can
still walk that ancestry chain, i.e. before applying the style change.

BUG=521819
R=esprehn@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1294063005

git-svn-id: svn://svn.chromium.org/blink/trunk@200836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Two minor ref test modifications to make them more robust against
upcoming Ganesh changes.

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/1301903006

git-svn-id: svn://svn.chromium.org/blink/trunk@200835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=(none)

Review URL: https://codereview.chromium.org/1300143002

git-svn-id: svn://svn.chromium.org/blink/trunk@200833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the current implementation, MessagePort does not support sending an
ArrayBuffer as a transferable object yet and unexpectedly loses the buffer
without any warning.

BUG=334408

Review URL: https://codereview.chromium.org/1301953002

git-svn-id: svn://svn.chromium.org/blink/trunk@200832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345519

R=haraken@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/1300093003

git-svn-id: svn://svn.chromium.org/blink/trunk@200831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move a static member function hasRenderedNonAnonymousDescendantsWithHeight() out from PositionAlgorithm template class

This patch moves |hasRenderedNonAnonymousDescendantsWithHeight()| out from
|PositionAlgorithm| template class to simplify |PositionAlgorithm| class for
improving code health, since |hasRenderedNonAnonymousDescendantsWithHeight()|
doesn't depend on |Strategy| template parameter.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1289423005

git-svn-id: svn://svn.chromium.org/blink/trunk@200830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1305523003

git-svn-id: svn://svn.chromium.org/blink/trunk@200829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes |LayoutText::absoluteQuadsForRange| to consider leading and
trailing whitespaces by adjusting specified offsets by rendered portion of
characters.

Before this patch, |LayoutText::absoluteQuadsForRange| returns empty rectangle
for character offsets not in |InlineTextBox| objects.

BUG=389054
TEST=LayoutTests/fast/dom/Range/getClientRects-leading-trailing-whitespaces.html

Review URL: https://codereview.chromium.org/361683002

git-svn-id: svn://svn.chromium.org/blink/trunk@200828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves a member function |parentEditingBoundary()| in
|PositionAlgorithm<Strategy>| template class for a preparation of making it
as static function in "VisibileUnits.cpp" since it is used only in
"VisibileUnits.cpp".

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1298233004

git-svn-id: svn://svn.chromium.org/blink/trunk@200827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Fix up some comments.

 * Rename resourcesCacheFromLayoutObject to resourcesCache; let it take
   a Document& instead (to reflect the wider "scope" it has), and make it
   return a SVGResourceCache& since the cache will always be present if
   SVGDocumentExtensions are.

 * Drop redundant qualification.

BUG=521334

Review URL: https://codereview.chromium.org/1288903003

git-svn-id: svn://svn.chromium.org/blink/trunk@200826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in CacheStorage.

 - WebServiceWorkerResponse* (ownership not transferred)
  => const WebServiceWorkerResponse&
 - WebVector<WebServiceWorkerResponse>* (ownership not transferred)
  => const WebVector<WebServiceWorkerResponse>&
 - WebVector<WebServiceWorkerRequest>* (ownership not transferred)
  => const WebVector<WebServiceWorkerRequest>&
 - WebServiceWorkerCache* (ownership transferred)
  => WebPassOwnPtr<WebServiceWorkerCache>
 - WebVector<WebString>* (ownership not transferred)
  => const WebVector<WebString>&
 - WebServiceWorkerCacheError* (ownership transferred)
  => WebServiceWorkerCacheError

1/3: https://codereview.chromium.org/1284173004/
2/3: https://codereview.chromium.org/1284283003/
3/3: https://codereview.chromium.org/1296723005/

BUG=493531

Review URL: https://codereview.chromium.org/1284173004

git-svn-id: svn://svn.chromium.org/blink/trunk@200825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=442555

Review URL: https://codereview.chromium.org/1297433004

git-svn-id: svn://svn.chromium.org/blink/trunk@200824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces enum class |TextAffinity| as replacement of enum
|EAffinity| and rename |DOWNSTREAM| and |UPSTREAM| members to capitalized name
|Downstream| and |Upstream| to follow Blink coding style for improving code
health.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1293593004

git-svn-id: svn://svn.chromium.org/blink/trunk@200823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |nodeIsUserSelectNone()| out from |PositionAlgorithm| template
class to "EditingUtilities.{cpp,h}" to simplify |PositionAlgorithm| class for
improving code health, since |nodeIsUserSelectNone()| doesn't depend on
|Strategy| template parameter.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1301933002

git-svn-id: svn://svn.chromium.org/blink/trunk@200822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also make it impossible to access WorkerThread::workerGlobalScope
on a wrong thread at least from outside the class

BUG=520012,460445

Review URL: https://codereview.chromium.org/1305453003

git-svn-id: svn://svn.chromium.org/blink/trunk@200821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As part of detaching a LocalFrame, its subframes are also detached. Should the
detachment of those subframes trigger a nested detach of the LocalFrame that
initiated their detachment, the LocalFrame being returned to after having
detached the subframes could well be in a detached state. The detach steps that
followed (FrameLoader operations) weren't prepared for being in a detached state
(following r199143) and failed.

And the FrameLoader shouldn't have to gracefully handle being used in a detached
state, so add an is-detached check to the LocalFrame's detach steps before continuing.
Leaving early if so.

R=dcheng,japhet
BUG=520014

Review URL: https://codereview.chromium.org/1290053003

git-svn-id: svn://svn.chromium.org/blink/trunk@200820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, https://html.spec.whatwg.org/#the-htmloptionscollection-interface,
there is no exception throwing mechanism defined when negative values are passed. In such case
we should just ignore the values and avoid using the custom binding for such usage.

Trying to set any value greater than 10000 will be ignored with the existing
length unchanged.

BUG=345519

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1292653003

git-svn-id: svn://svn.chromium.org/blink/trunk@200819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is split out from [1] where we support multiple author origins in
terms of shadow dom scopes. The vector of MatchedProperties contains
matched declarations from all origins in the order in which they should
be applied. For !important declarations, they are applied in the same
order within the same origin, but the order of the origins are different
as the cascading order is:

  - UA important
  - Author important
  - Author
  - UA

We used to have two ranges, one for UA and one for author to accomplish
this. However, with the normal/!important cascading order for
declarations from different shadow doms, we need multiple author ranges:

  - UA important
  - Author important scope n
  ...
  - Author important scope 1
  - Author scope 1
  ...
  - Author scope n
  - UA

We introduce an ImportantAuthorRangeIterator to iterate through the
author ranges and add iterator-style iteration for each range through the
MatchedPropertiesRange class.

As the applyMatchedProperties code is hot, I've run the blink_perf.css
tests locally. Some improved by 2-4%, some became worse by similar
percentages.

[1] https://codereview.chromium.org/1224673002/

BUG=487125
TEST=fast/css

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200697

Review URL: https://codereview.chromium.org/1282243002

git-svn-id: svn://svn.chromium.org/blink/trunk@200818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=n/a, since no behavior changes.

BUG=393155

Review URL: https://codereview.chromium.org/1299463004

git-svn-id: svn://svn.chromium.org/blink/trunk@200817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520849

Review URL: https://codereview.chromium.org/1292503003

git-svn-id: svn://svn.chromium.org/blink/trunk@200816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://crbug.com/510650#c4 describes the details of the data flow.

1/3 blink: https://codereview.chromium.org/1265133002/
2/3 chromium: https://codereview.chromium.org/1271733002/
3/3 blink: This

BUG=510650,517837

Review URL: https://codereview.chromium.org/1280733002

git-svn-id: svn://svn.chromium.org/blink/trunk@200815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves a member function |atEditingBoundary()| in
|PositionAlgorithm<Strategy>| template class as static function inside
"Position.cpp" to simplify |PositionAlgorithm| class for improving code halth.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1288553007

git-svn-id: svn://svn.chromium.org/blink/trunk@200814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test expectations changed slightly due to slight changes in
V8's implementation of stack overflow error message.

R=hablich@chromium.org
BUG=chromium:522399

Review URL: https://codereview.chromium.org/1289673010

git-svn-id: svn://svn.chromium.org/blink/trunk@200813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes bufferedAmount-after-send.html and removes it from the flaky
tests list.

BUG=520615

Review URL: https://codereview.chromium.org/1295723003

git-svn-id: svn://svn.chromium.org/blink/trunk@200812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522399
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1291313005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522376
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1294243003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |computeInlineBoxPosition()| out from |VisiblePosition| for
a preparation of moving |computeInlineBoxPosition()| out from |Position|
to make |Position| class simpler for improving code health.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1302713002

git-svn-id: svn://svn.chromium.org/blink/trunk@200809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of a redundant argument DOWNSTREAM from
|PositionWithAffinity| constructor call sites to simplify source code for
improving code health, since default value of affinity is |DOWNSTREAM| in
a constructor declarations.

This patch is a preparation of introducing |TextAffinity| enum class as
replacement of |EAffinity|, http://crbug.com/522038.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1300493003

git-svn-id: svn://svn.chromium.org/blink/trunk@200808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522274

Review URL: https://codereview.chromium.org/1291543005

git-svn-id: svn://svn.chromium.org/blink/trunk@200807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521927

Review URL: https://codereview.chromium.org/1294313002

git-svn-id: svn://svn.chromium.org/blink/trunk@200806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Get rid of unused member function rootEditableElement() in PositionAlgorithm<Strategy> template class

This patch gets rid of unused member function |rootEditableElement()| in
|PositionAlgorithm<Strategy>| template class to simplify source code for
improving code health.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303673002

git-svn-id: svn://svn.chromium.org/blink/trunk@200805 bbb929c8-8fbe-4397-9dbb-9b2b20218538