- 30 Jul, 2016 16 commits
-
-
rouslan authored
BUG=632915 Review-Url: https://codereview.chromium.org/2198623002 Cr-Commit-Position: refs/heads/master@{#408824}
-
rnephew authored
Revert of [Android] Set platform mode as default for perf tests. (patchset #1 id:1 of https://codereview.chromium.org/2189773002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=632922 Original issue's description: > [Android] Set platform mode as default for perf tests. > > BUG=615157 > > Committed: https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159 > Cr-Commit-Position: refs/heads/master@{#408665} TBR=mikecase@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615157 Review-Url: https://codereview.chromium.org/2201563002 Cr-Commit-Position: refs/heads/master@{#408823}
-
andersoncss authored
BUG=621070 Review-Url: https://codereview.chromium.org/2142413003 Cr-Commit-Position: refs/heads/master@{#408822}
-
mcasas authored
After moving geolocation to device, the presubmit kept saying that I had to run git cl format, so here we go. No new code, just ran: clang-format -i -style=Chromium device/geolocation/*.h clang-format -i -style=Chromium device/geolocation/*.cc Review-Url: https://codereview.chromium.org/2200483002 Cr-Commit-Position: refs/heads/master@{#408821}
-
asargent authored
This should make it both show up in the "Dev APIs" section at the bottom of the /apps/api_index page, but also have its own standalone page at /apps/clipboard. Review-Url: https://codereview.chromium.org/2200443002 Cr-Commit-Position: refs/heads/master@{#408820}
-
dpapad authored
It was used to re-position the CBD dialog correctly, but its usage was removed as part of migrating to native <dialog>. BUG=625332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2193953002 Cr-Commit-Position: refs/heads/master@{#408819}
-
thakis authored
BUG=none Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50 Review-Url: https://codereview.chromium.org/2071463002 Cr-Original-Commit-Position: refs/heads/master@{#408739} Cr-Commit-Position: refs/heads/master@{#408818}
-
msramek authored
1. Change the footer color to that of secondary text (i.e. --paper-grey-600). 2. Replace the 12px bottom margin with padding, so that this 12px high area at the bottom becomes a part of the scrollable region. Screenshot: https://screenshot.googleplex.com/aodmwFZfdrq BUG=595580 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2191283002 Cr-Commit-Position: refs/heads/master@{#408817}
-
estade authored
alt-tab confuses translators. BUG=b/30495226 Review-Url: https://codereview.chromium.org/2195923002 Cr-Commit-Position: refs/heads/master@{#408816}
-
tommycli authored
This property is not used that much, and can be removed. BUG=608115, 628502 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2184893002 Cr-Commit-Position: refs/heads/master@{#408815}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/395e5365f02a..a6464cb626ec $ git log 395e5365f..a6464cb62 --date=short --no-merges --format='%ad %ae %s' BUG=599932 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2195913002 Cr-Commit-Position: refs/heads/master@{#408814}
-
khushalsagar authored
Just a clean up as a part of Layers cleanup. BUG=625284 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2185973005 Cr-Commit-Position: refs/heads/master@{#408813}
-
stevenjb authored
This CL correctly formats the network and proxy sections of the internet detail page. It also introduces internet_shared_css.html for common styling. BUG=609156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2179223004 Cr-Commit-Position: refs/heads/master@{#408812}
-
dbeam authored
I checked that it worked, but not that it matched what the label says. My bad. R=dschuyler@chromium.org BUG=632679 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2193353002 Cr-Commit-Position: refs/heads/master@{#408811}
-
ben authored
(Mojo) Shell types have been renamed elsewhere in Chromium, specifically ServiceRegistry is split into two parts: - InterfaceRegistry, for registration of interface factories in code that implements the interfaces - InterfaceProvider, allowing binding of named interfaces in code that consumes them. This reflects this naming scheme into Blink, which uses only the Provider half. R=esprehn@chromium.org http://crbug.com/632874 Review-Url: https://codereview.chromium.org/2196843003 Cr-Commit-Position: refs/heads/master@{#408810}
-
fsamuel authored
This CL makes use of the newly introduced Array DataViews in cc StructTraits in order to improve serialization (and to a lesser degree deserialization) performance. This CL improves serialization performance by an average of 18% on an HP Z620. Deserialization performance improves between 7 to 10%. Prior to the ability to inspect Array and Struct DataViews in parent StructTraits, we had to do extra work at serialization time in order to capture state that spans individual structs within a larger struct. This CL addresses two of those cases: 1. Previously, QuadList maintained an extra array of materials. This array existed so that we could preallocate the appropriately typed DrawQuads during deserialization. StructTraits assume a preallocated type and populated fields in that type. Alternatively we could have deserialized DrawQuads into unique_ptrs, but cc required that we allocate DrawQuads inline within a buffer in order to minimize the cost of allocations (there can be hundreds of DrawQuads in a CompositorFrame). 2. Previously, SharedQuadStates were serialized independently of DrawQuads. However, in in-memory form, DrawQuads refer to SharedQuadStates via raw pointers. In order to allow DrawQuads and SharedQuadStates to deserialize independently, as was required previously by StructTraits, a third array was serialized "shared_quad_state_references" which was equal in size to the QuadList. Each slot corresponded to an index in the SharedQuadStateList. After the QuadList and SharedQuadStateList were serialized, shared_quad_state_references updated the raw pointers in the DrawQuads in the quad list to refer to the SharedQuadStates. This required revisiting all deserialized DrawQuads again. In both 1. and 2. additional state needed to be allocated on the heap during serialization. In pprof profiling, it became apparent that much of the cost of serialization was in SetupContext. This CL eliminates that cost. Performance measures are available here: https://docs.google.com/a/google.com/spreadsheets/d/13Y0I-BVDrQC4RHIzMSs0vl0QPe8xFAhYMUAXaxoEqgg/pubhtml BUG=624459 TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2174843003 Cr-Commit-Position: refs/heads/master@{#408809}
-
- 29 Jul, 2016 24 commits
-
-
japhet authored
This moves all of ResourceLoader's non-trivial response handling logic to ResourceFetcher, and changes the ordering of some steps to better match other callbacks. Old order: - Access control checks in ResourceLoader::didReceiveResponse() - Resource::responseReceived() - Access control checks in ResourceFetcher::didReceiveResponse() - FetchContext::dispatchDidReceiveResponse() New order: - Access control checks in ResourceLoader::didReceiveResponse() (now in ResourceFetcher) - Access control checks in ResourceFetcher::didReceiveResponse() - FetchContext::dispatchDidReceiveResponse() - Resource::responseReceived() BUG= Review-Url: https://codereview.chromium.org/1975373002 Cr-Commit-Position: refs/heads/master@{#408808}
-
pfeldman authored
TBR=dgozman Review-Url: https://codereview.chromium.org/2197823002 Cr-Commit-Position: refs/heads/master@{#408807}
-
caseq authored
Initially broken by https://codereview.chromium.org/2150783002 BUG=629530,630030 Review-Url: https://codereview.chromium.org/2193323002 Cr-Commit-Position: refs/heads/master@{#408806}
-
jyasskin authored
BUG=597178 Review-Url: https://codereview.chromium.org/2191323004 Cr-Commit-Position: refs/heads/master@{#408805}
-
kulshin authored
Previous change passed the sender to FontFallback init, but not DWriteFontCollectionProxy which is what really matters. This will ensure that both classes get the right sender. BUG=631254 Review-Url: https://codereview.chromium.org/2196493003 Cr-Commit-Position: refs/heads/master@{#408804}
-
estade authored
Side note: if we had just used .icon files, besides the massive proliferation of them that would have been necessary, we'd have worse rendering at fractional scales like 1.5x because we'd be filling fractional pixels. However, to actually get the better drawing at fractional scales, the network technology badges (LTE, G, etc.) will also have to be vectorized. BUG=617306 Review-Url: https://codereview.chromium.org/2201443002 Cr-Commit-Position: refs/heads/master@{#408803}
-
nyquist authored
The BlimpClientSession will be going away, so this CL takes part of it and splits it up into smaller parts and moves them to //blimp/client/core/session. They will be used by the BlimpClientContextImpl. BUG=611097 Review-Url: https://codereview.chromium.org/2187893002 Cr-Commit-Position: refs/heads/master@{#408802}
-
rsesek authored
R=jrummell@chromium.org Review-Url: https://codereview.chromium.org/2196453003 Cr-Commit-Position: refs/heads/master@{#408801}
-
vakh authored
BUG=543161, 624567 Review-Url: https://codereview.chromium.org/2196553002 Cr-Commit-Position: refs/heads/master@{#408800}
-
chrome://invalidationspnoland authored
invalidation_service_android never updated its logger instance's state, since the state is always enabled. This meant the logger only ever reported the state as its initial value, which is transient_error. This change causes invalidation_service_android to update the state to enabled upon construction. R=pavely@chromium.org BUG=630406 [sync] re-enable SyncTest#testRename Review-Url: https://codereview.chromium.org/2201503002 Cr-Commit-Position: refs/heads/master@{#408799}
-
agrieve authored
Just needed to make the aar's java_prebuilt targets depend on the resource targets so that would be deemed the resource owners within write_build_config.py BUG=632362 Review-Url: https://codereview.chromium.org/2190283002 Cr-Commit-Position: refs/heads/master@{#408798}
-
jshin authored
1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM Review-Url: https://codereview.chromium.org/2188333002 Cr-Commit-Position: refs/heads/master@{#408797}
-
mcasas authored
No new code, just shuffling files around -- commands: git mv content/browser/media/webrtc content/browser/ tools/git/mass-rename.py BUG=632020 Review-Url: https://codereview.chromium.org/2193343002 Cr-Commit-Position: refs/heads/master@{#408796}
-
wangxianzhu authored
The flakiness may be because sometimes the test was started before the image is loaded. Now start the test in onload. Remove wrong baselines that were created based on wrong results when the test failed on the bots. BUG=622898 Review-Url: https://codereview.chromium.org/2188383002 Cr-Commit-Position: refs/heads/master@{#408795}
-
fdoray authored
Currently, TaskRunner::PostTaskAndReply and WorkerPool::PostTaskAndReply can only be called when ThreadTaskRunnerHandle::IsSet(). The reply is posted back to the thread on which PostTaskAndReply was invoked. With this CL, these methods can also be called when SequencedTaskRunnerHandle::IsSet(). The reply is posted back to the sequence on which PostTaskReply was invoked. This change is a prerequisite to implement base::PostTaskAndReply which must work from a sequenced task https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa5k/edit#heading=h.gf6e3bwrxqqs BUG=553459 Review-Url: https://codereview.chromium.org/2180953002 Cr-Commit-Position: refs/heads/master@{#408794}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/28aad26a05ee..395e5365f02a $ git log 28aad26a0..395e5365f --date=short --no-merges --format='%ad %ae %s' BUG=630300 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2196483005 Cr-Commit-Position: refs/heads/master@{#408793}
-
kolos authored
Replace WebString with base::string16. AutofillAgent sends to PasswordAutofillAgent base::string16, but they are wrapped into WebString and and unwrapped to base::string16. That doesn't make sense. Review-Url: https://codereview.chromium.org/2187253002 Cr-Commit-Position: refs/heads/master@{#408792}
-
jbauman authored
The Microsoft MFT we're using doesn't pass through the bind flags correctly so sharing textures with ANGLE doesn't work. Review-Url: https://codereview.chromium.org/2188423002 Cr-Commit-Position: refs/heads/master@{#408791}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#408790}
-
waffles authored
BUG=623804 Review-Url: https://codereview.chromium.org/2190083002 Cr-Commit-Position: refs/heads/master@{#408789}
-
scottmg authored
Use raw pointers instead of unique pointers to reduce size. See linked bug for size details. BUG=631416 Review-Url: https://codereview.chromium.org/2193693003 Cr-Commit-Position: refs/heads/master@{#408788}
-
enne authored
This bug started after r408172. In some situations when navigating, the SetNeedsBeginFrame messages that is sent from the CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is received by the RenderWidgetHostImpl while the RenderViewHost is swapped out and before it has swapped back in. In these cases, if this message is dropped, the renderer will never tick new frames and the tab will freeze. This appears to be racy, as the renderer finds out that it is visible and sends this message before the view host is swapped in. To fix this race, always allow the SetNeedsBeginFrame message to be received while being swapped out so that the RenderWidgetHostView can be in the correct state when it is swapped in. R=sievers@chromium.org BUG=632276 Review-Url: https://codereview.chromium.org/2197783002 Cr-Commit-Position: refs/heads/master@{#408787}
-
qyearsley authored
Many test methods in unit tests have names much longer than 30 characters. I think this is fine for test method names, since they're meant to be descriptive, but not necessarily short and memorable. Review-Url: https://codereview.chromium.org/2192213002 Cr-Commit-Position: refs/heads/master@{#408786}
-
dewittj authored
This is an inefficient intermediate step to support multiple client IDs in a single API call. TODO: update native backend to support multiple Client ID search. BUG= Review-Url: https://codereview.chromium.org/2187033002 Cr-Commit-Position: refs/heads/master@{#408785}
-