1. 24 Jun, 2019 2 commits
    • tby's avatar
      [Dolphin] Clean up config proto. · aa6fd34b
      tby authored
      Right now, we don't have any important experiments running. I'm taking
      this as a chance to do some cleanup of the recurrence ranker config proto
      now that our API is mostly stable. This CL renumbers the fields and
      removes some that were reserved. This changes the config proto hash and
      will result in all on-disk models being thrown out.
      
      Bug: 921444
      Change-Id: I35283117e489f58f57cea1cb842a43c5c02de44c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670284Reviewed-by: default avatarCharles . <charleszhao@chromium.org>
      Commit-Queue: Tony Yeoman <tby@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#671569}
      aa6fd34b
    • Nicholas Hollingum's avatar
      Fixed a use-after-free in exo::Pointer · da8ef10a
      Nicholas Hollingum authored
      Basically you can get the UAF by binding to either one of the delegates
      twice.  Naturally (as a comment suggested) this doesnt make much sense,
      but its still an attack surface so this fix will stop it.
      
      The fix means that if a user binds the delegate's interface twice, then
      we will only keep the latest one alive, and we simulate removal of the
      pointer interface for the other (which prevents it from invoking methods
      on that pointer during its destruction).
      
      Bug: b:135720248
      Change-Id: I39f4ca1602058efa650a51a41e3ce7b955bb43bd
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670574
      Commit-Queue: Nic Hollingum <hollingum@google.com>
      Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#671568}
      da8ef10a
  2. 23 Jun, 2019 21 commits
  3. 22 Jun, 2019 17 commits