GitLab

This allows to use StackContainers (including StackVector) in
range-based for loops without using the {container()} accessor.

R=dcheng@chromium.org

Change-Id: I86145db459f5328270c61e299a903eeed91c2db4
Reviewed-on: https://chromium-review.googlesource.com/c/1371866Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615832}

This reverts commit aed99d7e.

Reason for revert: Speculative revert for the compile failure on Android and ChromeOS, because this CL is the single CL that shows up in the blamelist of both failed builds.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5507
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59554

Original change's description:
> Fix SVG-As-Background sizing
> 
> Addresses a TODO where we were snapping the intrinsic size of an SVG image,
> even when that is no longer useful. This was posing issues with operations
> using aspect ratio, because the computed aspect ratio on the snapped value
> was wrong when then used on un-snapped values.
> 
> R=​fs@opera.com
> BUG=855882
> 
> Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c
> Reviewed-on: https://chromium-review.googlesource.com/c/1370486
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#615798}

TBR=fs@opera.com,schenney@chromium.org

Change-Id: I6bd43ac3ad23393be353249657566e9080cd69c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855882
Reviewed-on: https://chromium-review.googlesource.com/c/1373285Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615831}

The test uses Shared Workers but Android doesn't support it.

Also, this CL removes unnecessary [ PASS ] expectations for the test from
FlagExpectations.

Bug: 154571, 913906
Change-Id: I7fb0bb8769f7b6e594d18606a93fc5d90a6853ed
Reviewed-on: https://chromium-review.googlesource.com/c/1373410
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615830}

The test is rewritten using the existing marking infrastructure avoiding
methods that are only compiled in debug mode.

Change-Id: Ica9eea97d244c8db7b655e7c8745169d8c6620f2
Reviewed-on: https://chromium-review.googlesource.com/c/1371875Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615829}

This CL makes sure Picture-in-Picture window size never gets bigger than
allowed.

Change-Id: Id008900ef18b85efa5823747f6529dd0d5abc57d
Reviewed-on: https://chromium-review.googlesource.com/c/1363279Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#615828}

Using wpt-import in Chromium 74610c85.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I56bee3c7a48f1117ecb880020f5293b0125185fe
Reviewed-on: https://chromium-review.googlesource.com/c/1373271Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615827}

Instead of static class, expose client hints as a keyed service.
Next CL would add a new abstract class client_hints_controller
in //content, and make client hints in //chrome, a derived class
of the client_hints_controller. This would allow
content to directly call the methods to determine which client
hint headers should be added.

Change-Id: I8971e77a23dd49f2f25ba8036ca8ea76c24ca2a4
Bug: 875703
Reviewed-on: https://chromium-review.googlesource.com/c/1368208
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615826}

Chrome app name (and channel) is not automatically shown on Android
prior to N and needs to be explicitly added. This is correct for media
capture notifications.

Bug: 901536
Change-Id: Ic22dc4d1f90ac4e1be7d95778ffecb099c09f6c1
Reviewed-on: https://chromium-review.googlesource.com/c/1352788Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615825}

This change adds a new executable to Windows called chrome_proxy.exe which
opens chrome.exe with all arguments forwarded.

In a future patch bookmark app shortcuts will be updated to point to
chrome_proxy.exe instead of chrome.exe so they don't pick up the
chrome.VisualElementsManifest.xml file when pinned to the Windows 10
start menu. This fixes a bug where pinned bookmark app shortcuts all
use the Chrome logo instead of their own.

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1362695
with the rename logic to account for chrome_proxy.exe not existing.
Diff: https://chromium-review.googlesource.com/c/chromium/src/+/1367385/1..2

Bug: 732357
Change-Id: If670aaec69532aa7f2d8094470aabac716aa8035
Reviewed-on: https://chromium-review.googlesource.com/c/1367385
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615824}

Bug: None
Change-Id: I8eab3c0203df3997f846a4508644534492d82043
Reviewed-on: https://chromium-review.googlesource.com/c/1372550
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615823}

Change-Id: I32f9f08a4efcc0a9e8e0fcb4bc42a8965f7c0763
Reviewed-on: https://chromium-review.googlesource.com/c/1373369Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615822}

Currently, the App Service's extension-backed app publisher only serves
enabled (i.e. ready) extensions. Also serving disabled and terminated
extensions matches AppListControllerDelegate::GetApps in
app_list_controller_delegate.cc and ExtensionDataSource::AddApps in
app_search_provider.cc.

For example, disabled apps might still be shown in the UI, but with a
grayed out icon.

BUG=826982

Change-Id: I896d33cf574d4016a73b372003445329ae895e8e
Reviewed-on: https://chromium-review.googlesource.com/c/1367071
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615821}

Using wpt-import in Chromium aed99d7e.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I733950880044e2778d5b961027e0e11cf53c3baf
Reviewed-on: https://chromium-review.googlesource.com/c/1373140Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615820}

We never enabled it by default, and have no plans to, so we should just
remove it.  QUIC also makes it less useful, and TLS 1.2 0-RTT session
restore means it potentially mutates state.

It also leaks also leaks data between profiles, including (but not
limited to) incognito profiles, since it relies on global system state.

TBR=sergeyu@chromium.org

Bug: 914007
Change-Id: Id9c333216661ee538cc6ce6e2b7f70b899393367
Reviewed-on: https://chromium-review.googlesource.com/c/1371938Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615819}

https://skia.googlesource.com/skia.git/+log/5beabfe91862..b0b5835a1715


git log 5beabfe91862..b0b5835a1715 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-12-11 michaelludwig@google.com Add additional test to blacklist for 405
2018-12-11 ethannicholas@google.com Perform Vulkan resets in a background thread
2018-12-11 scroggo@google.com Better testing of SkCodec to 565
2018-12-11 reed@google.com move intercepts impl into textblob


Created with:
  gclient setdep -r src/third_party/skia@b0b5835a1715

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I57517d793abab25ab137c3c9f45c1104f496d34d
Reviewed-on: https://chromium-review.googlesource.com/c/1372898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615818}

This change keeps the original transition type and adds
PAGE_TRANSITION_FORWARD_BACK as qualifier.

Change-Id: Ia3b59c3d555223a66a5553cbba2ff1ebf3b28f0c
Reviewed-on: https://chromium-review.googlesource.com/c/1371883Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615817}

https://webrtc.googlesource.com/src.git/+log/ad858d1231e7..60446b8d5f30


git log ad858d1231e7..60446b8d5f30 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 84fd8a4f..7f93585b (615612:615733)
2018-12-12 amithi@webrtc.org RID parsing for Simulcast support.
2018-12-11 emircan@webrtc.org Reland 2: Add VP9 Profile 2 to default profiles
2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 573be063..84fd8a4f (615506:615612)
2018-12-11 ouj@fb.com Make CONNECTION_WRITE_TIMEOUT configurable for ice connection
2018-12-11 steveanton@webrtc.org Convert MediaSessionFactory to return unique_ptrs
2018-12-11 steveanton@webrtc.org Convert TransportDescriptionFactory to return unique_ptrs
2018-12-11 artit@webrtc.org Add support to nested third_party licenses in generate_licences.py
2018-12-11 sprang@webrtc.org Don't trigger too many probes when max allocated bitrate changes.
2018-12-11 andersc@webrtc.org Mark functions using old factory classes as deprecated.


Created with:
  gclient setdep -r src/third_party/webrtc@60446b8d5f30

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib3f9b6c9784717f90e2a22afe3baa53ac9d29164
Reviewed-on: https://chromium-review.googlesource.com/c/1372901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615816}

 - FileTransferController uses ProgressCenter in its contructor
   - add externs_list deps to externs backend ProgressCenter

No change in test behavior.

Bug: 914197
Change-Id: I12d91732edd9fec52c44af54d9c88a6e9f98719a
Reviewed-on: https://chromium-review.googlesource.com/c/1373050Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615815}

First failing build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/12423

TBR=kbr@chromium.org

Bug: 914206
Change-Id: Ia1130a35e1e8ba87e09217367351d08c168dee50
Reviewed-on: https://chromium-review.googlesource.com/c/1372637Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615814}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: Ic1db4648fbf6e7d3f0fcb2fb3f14d3b4e1444dcc
Reviewed-on: https://chromium-review.googlesource.com/c/1373092Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615813}

Bug: 910890
Change-Id: I794b1574ed19b4e16391abe6035ffe16aa905452
Reviewed-on: https://chromium-review.googlesource.com/c/1372712Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615812}

Bug: 853593
Change-Id: I4c3a8b4e21b283cce61579973c94236dfc057904
Reviewed-on: https://chromium-review.googlesource.com/c/1318771
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615811}

 - ImportController @types refer to {CommandHandlerDeps}
  - add externs_list deps UI externs/command_handler_deps.js
 - And the same for FileManagerCommands

No change in test behavior.

Bug: 914197
Change-Id: I9f71b677f22961d0e14ac55834ca0a9b0cea180a
Reviewed-on: https://chromium-review.googlesource.com/c/1373051Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615810}

It didn't actually use the return value anymore (after conversion to SimpleURLLoader in r610189),
so just return a boolean.

Bug: 837753
Change-Id: I9712f1520db8203f821e36c738c290c783d97dbe
Reviewed-on: https://chromium-review.googlesource.com/c/1372913Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615809}

Previously, gfx::SkColorTypeToVkFormat() wasn't mapping
kRGB_888x_SkColorType because VK_FORMAT_R8G8B8_UNORM was not supported
by Skia, but it should be able to handle that image format now.

Bug: 861853
Change-Id: Ic2b861f42628946484efb872aaf0c43aad5d660b
Reviewed-on: https://chromium-review.googlesource.com/c/1372724Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615808}

Bug: 839646
Change-Id: I0b28b079bd5e44d8f8d9a6057d2740b4f6bc9bcb
Reviewed-on: https://chromium-review.googlesource.com/c/1370373Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615807}

TBR=bnc@chromium.org

Change-Id: I66259745a37998a96ef8010f6026385bec2d3197
Reviewed-on: https://chromium-review.googlesource.com/c/1372918Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615806}

Bug: 905524
Change-Id: Ia07addff101cf05b2fb21309963ca9298c7a26e9
Reviewed-on: https://chromium-review.googlesource.com/c/1371284
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615805}

https://pdfium.googlesource.com/pdfium.git/+log/f78267e16157..407a081da693


git log f78267e16157..407a081da693 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 tsepez@chromium.org Remove fragile script index mechanism.
2018-12-12 tsepez@chromium.org Remove strings/hashes from element-atttribute table.


Created with:
  gclient setdep -r src/third_party/pdfium@407a081da693

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2e69e4733b02f5289be6046dffe3cb7d45bc104d
Reviewed-on: https://chromium-review.googlesource.com/c/1373129Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615804}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79ff98db91ae..45637bf3b4b6


Created with:
  gclient setdep -r src-internal@45637bf3b4b6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:891313,chromium:790258,chromium:790231,chromium:790219,chromium:790217
TBR=mmoss@chromium.org

Change-Id: Icf6596623081a153d9725e1c03f1be538d056670
Reviewed-on: https://chromium-review.googlesource.com/c/1372900Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615803}

Add benwells@ as an OWNER of component_extensions_whitelist to approve
new component Chrome Apps.

Bug: None
Change-Id: If570b26b5446baa84f1ca7dcae96175d9b37ba66
Reviewed-on: https://chromium-review.googlesource.com/c/1372271Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615802}

This CL drops the closure_compilation bot for everything except the
closure_compiler directory, since the bot only runs a Closure Compiler
test now.

Change-Id: I5f9149af0ff27ae87a294e72282e019ce926ce96
Reviewed-on: https://chromium-review.googlesource.com/c/1345790
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615801}

https://chromium.googlesource.com/angle/angle.git/+log/611bbaabb28c..3a2562287939


git log 611bbaabb28c..3a2562287939 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 jmadill@chromium.org Update ANGLE_multiview validation.


Created with:
  gclient setdep -r src/third_party/angle@3a2562287939

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I6e7dc7d7885ad01898d3993e239befac0e84fc1e
Reviewed-on: https://chromium-review.googlesource.com/c/1372897Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615800}

WebUI: Add common class to use on all the labels/text in settings row, update 'People' settings rows to use it

Bug: 686905
Change-Id: I97e750e55e73b54451f87e34f6b0570a6b89dd71
Reviewed-on: https://chromium-review.googlesource.com/c/1359331Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615799}

Addresses a TODO where we were snapping the intrinsic size of an SVG image,
even when that is no longer useful. This was posing issues with operations
using aspect ratio, because the computed aspect ratio on the snapped value
was wrong when then used on un-snapped values.

R=fs@opera.com
BUG=855882

Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c
Reviewed-on: https://chromium-review.googlesource.com/c/1370486
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#615798}

Locally reproduced the test failure and determined that async setup in
FocusRowBehavior was often not actually completed before tests were
started. Waiting for one more render to ensure async setup is complete
prevents the flakes.

Bug: 913197
Change-Id: Ifb893927ecf83666f5edb201c81cb5ce49791fc0
Reviewed-on: https://chromium-review.googlesource.com/c/1372831Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615797}

TBR=kinuko@chromium.org

Bug: 843412
Change-Id: I36cd63ab1c3b0b0541d458fa91d3b8c8759356f6
Reviewed-on: https://chromium-review.googlesource.com/c/1373049Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615796}

In r1067519, we added a UMA histogram for ViewsTextServiceContextMenu,
but we only changed enums.xml and not histograms.xml. This patch
fixes this.

TBR=sky@chromium.org

Bug: 838710
Change-Id: I5cdd9e0c76e2c5a7bace9ae3f80883ed905a26c8
Reviewed-on: https://chromium-review.googlesource.com/c/1358615Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615795}

 - FileTasks uses Crostini in its contructor
  - add externs_list deps to externs backend Crostini

No change in test behavior.

Test: browser_tests --gtest_filter="FileManagerJsTest*FileTasks*"
Bug: 914197
Change-Id: I3c8c925cd7ffa24420c2986b624dcc5870b08783
Reviewed-on: https://chromium-review.googlesource.com/c/1372990Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615794}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52411ecf1fa5..e76041196062


git log 52411ecf1fa5..e76041196062 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@e76041196062

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ifebca200a0fd5fc4d4696f6efedbfaa42eeda63a
Reviewed-on: https://chromium-review.googlesource.com/c/1372896Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615793}