- 24 Nov, 2020 40 commits
-
-
Nate Fischer authored
The underlying issue was a component build problem fixed by https://crrev.com/c/2553969. These are safe to reenable now. Fixed: 1144945 Test: run_webview_instrumentation_test_apk -f AwSettingsTest.testMediaPlaybackWith*UserGesture Change-Id: I750a7c7c8163586f35dc86224e3eaf6047f0786c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558778 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830701}
-
Yi Gu authored
The entire test suite has been disabled on TSAN. This patch disables some tests (flakiness score >1000) on all platforms. TBR=guidou@chromium.org Bug: 1127211 Change-Id: I06e5de9da09ecdbab0fab612587f694d8cddb3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558994Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830700}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606218923-9c6085eb8d1087e580649b9899e3b8b35853f279.profdata to chrome-linux-master-1606240669-c1104e164a95943470032f861bc56133b735d819.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06ab437d69b45e81347f734b716df83007981cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830699}
-
Sharon Yang authored
Improve and add unit tests. Bug: 1117601 Change-Id: Ida2c296d61042b3217e399d2ce4a349f24dbddc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545767Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#830698}
-
Elly Fong-Jones authored
This document outlines how to go from: class MyDialogDelegateView to: class MyDialog creates/configures a separate DialogDelegate creates/configures a separate View Change-Id: Ied2f1e9dfa7c910100c2485016e8eda4531e53b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545751 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830697}
-
Jamie Madill authored
EGL_EXT_device_query is now exposed as a client extension in ANGLE. We can remove the code and TODO that checks for a display extension. Bug: angleproject:5372 Change-Id: I452657c25be017336c07caa091b5e594c1be2a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557219 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#830696}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iee955e7eac105236d440102aadaf4fe09b96bbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558736Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#830695}
-
Robbie McElrath authored
Bug: 1097244 Change-Id: If4b88e957f0a91d76694f68dce2a91515cff6ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551620Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#830694}
-
Klaus Weidner authored
The attributes were defaulting to optional, leading to invalid access. Mark as required in IDL and add an additional check to enforce a positive number for widthInMeters. Bug: 1151619 Change-Id: Ib2353478f93330d76072b9bfc69bc189bc5523aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556918 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#830693}
-
Alice Wang authored
This CL moves WebSigninBridge to signin.services target. Bug: 1152432 Change-Id: I5736852287f6dfdfd6577ec7cca7b6b99ef5a8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556845Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830692}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606218923-39c9d0a9fc77b1c3938c028a8199ea0790d9dbca.profdata to chrome-mac-master-1606240669-251229982c87402ee7b9ccf8ab49774406a74762.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic8d8235c85d51b28c13464fc71f42830f1c94c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558991Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c983c977f266..f66650677465 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ezemtsov@google.com,yigu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ezemtsov@google.com,yigu@google.com Change-Id: Ia958cda0e06e431afcf7ffe475110cbaf3a8fc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830690}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4314.0-1605523684-benchmark-88.0.4324.12-r1 to 89-4324.9-1606128713-benchmark-89.0.4334.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8cb2134036d0a85cc69cafea3c0a51d9023e07bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558833Reviewed-by:
-
Yi Gu authored
The two tests are still very flaky with high score (>1500): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=not_site_per_process_blink_web_tests%20(with%20patch)&tests=external%2Fwpt%2FFileAPI%2Fblob%2FBlob-stream TBR=mek@chromium.org NOTRY=True Bug: 1092048 Change-Id: I0375ea2a60f9a95ada3108539fb053ac297999c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558996Reviewed-by:
-
Yi Gu authored
TBR=yaoxia@chromium.org Bug: 1152528 Change-Id: Idd35652c77e2ed921f7241373a88cf70b8069225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558171Reviewed-by:
-
Thomas Tellier authored
Bug: 1147043,1104336,1050589 Change-Id: Ib3b327975298edc35c53322cf1aba03f8342b010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547292 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#830686}
-
Wenyu Fu authored
Add a privacy disclosure when ToS is skipped by policy in the FRE. The privacy disclaimer will be displayed on screen for 1 second before FRE is finished. Bug: 1108564, 1128158 Change-Id: I5f912e62484a5255bfda27db0318c0e92d541903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548293 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830685}
-
Dave Tapuska authored
The View implementation had a few more things that the frame left as a todo. Talking with wjmaclean@ it seems that the view implementation should just be used for this code as it handles things like long press gestures which were added after the frame code was written. BUG=1097816 Change-Id: Ic912c5d6fe9fda4183b25006c4b7631b37dade3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551791 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830684}
-
Eric Seckler authored
Not doing this may be causing flakes in other tracing tests later. Bug: 1141233 Change-Id: I67f5ad3b746a06a23de055b34b7c3236105b1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558791 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#830683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9490b30c229adb7b7ddcc5286b2895393a1ce6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557783Reviewed-by:
-
David Maunder authored
This is for a new feature where we display price alerts in the Tab card in the Tab grid switcher as price drops are identified for shopping related websites. Bug: 1151401 Change-Id: Id2adfed52195da36ced7ca6baf37a70ac536f686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552624Reviewed-by:
-
Andrew Grieve authored
This reverts commit 4727f47b. Reason for reland: Cronet test fixed in crbug.com/1136963 Original change's description: > Revert "Enable whole-program devirtualization for arm64 Android build." > > This reverts commit 4f9f1598. > > The CL being reverted causes cronet_test_instrumentation_apk to crash > on builder "android-cronet-marshmallow-arm64-rel". > > Bug: 1115229 > Change-Id: I2b177353b00a57befe488e0bbef242a2b585162c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376316 > Auto-Submit: Nick Harper <nharper@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802814} TBR=nharper@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1136962 Change-Id: Ib9dd654111d6f45915c0b7ed1e454fb29668ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416569 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830680}
-
Sam Maier authored
Bug: 1139446 Change-Id: I3613007c5480aa59d4931b82dbaf352a30576179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553856 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Many spots using forward_variables_from(invoker, "*") were not allowing these two variables to be set in outer scopes. * Introduce a helper variable "EXPLICIT_FORWARDS" for use with the recommended pattern of: forward_variables_from(invoker, "*", [ "testonly", "visibility" ]) forward_variables_from(invoker, [ "testonly", "visibility" ]) * Ensures this pattern is used in android templates, test.gni, and BUILDCONFIG.gn * Documents this pattern in writing_gn_templates.md * Adds a PRESUBMIT.py for it * Fixes visibility of a few blink targets now that test() respects it. Bug: 862232 Change-Id: Ib71dbf34be76131fc749c721aea856e1146bc69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454427 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#830678}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b35dd76cd5f6..4c5dd5d863c4 2020-11-24 ehmaldonado@google.com [owners] Add tests for GetFilesApprovalStatus If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Idb42a0ee2ce0a9f16c7054905a10ada6dc918be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558173Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ibf476785b974d86e52a32c81cb12f04e46d684da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556517 Commit-Queue: Dan S <danan@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830676}
-
Yi Gu authored
The test has been "Timeout" in addition to "Failure": https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=virtual%2Fthreaded-prefer-compositing%2Ffast%2Fscrolling%2Flistbox-wheel-event.html TBR=mustaq@chromium.org NOTRY=True Bug: 841567 Change-Id: Ib8813e61070fbb202a313c9e5f33c56c0026058f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559090Reviewed-by:
-
Fredrik Söderqvist authored
Move duplicated CSSValue creation to a helper function and put the LengthBox in a local variable. Change-Id: Icf06db6282d7c310717e8f0e9f18b547a9d7be41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558339 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#830674}
-
Jordan Bayles authored
This patch updates debugging breaking in openscreen's logging platform. TBR=btolsch@chromium.org Change-Id: Id0d855b898e32d38ed99fb2e7ef67534b40a9fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555585Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#830673}
-
Stepan Khapugin authored
Adds necessary observation code and plumbing to the tab switcher view controller to add UI in the future. Bug: none Change-Id: I5912042ecf4634b7a8c0b3628b40505293cfcdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536454 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830672}
-
Camillo Bruni authored
Introduce ModuleTestBase::CompileModule for simplifying module compilation for tests with the upcoming streaming compilation changes. Bug: 1061857 Change-Id: I8ad38331a4d2a0a4fd4d0b9fff749d91f848bdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557506Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830671}
-
Hiroshige Hayashizaki authored
While previously v8::Undefined was returned on errors, this CL changes it to empty v8::Local to align ExecuteScriptInIsolatedWorld() with other script evaluation methods (that already return empty handles or equivalents). This is probably safe because: - The v8::Undefined was introduced in 2012 at https://source.chromium.org/chromium/chromium/src/+/fcf7ab1ff6c5280d37007531821a1260ea92dd66 According to the codereview at https://bugs.webkit.org/show_bug.cgi?id=88451#c19, empty handles were changed to `v8::Undefined` due to lifetime-related issues around `v8::Array`. This is no longer relevant. - The (indirect) callers of ExecuteScriptInIsolatedWorld() are either: - Callers that don't use the return values. - RenderFrameImpl::JavaScriptExecuteRequestInIsolatedWorld() (see below). - ScriptInjection::InjectJs() that converts both empty handles and `undefined` into `base::Value()` in ScriptInjection::OnJsInjectionCompleted(). - components/translate callers that have DCHECK()s with non-`undefined` types. - Test-only helpers that don't expect errors (and thus neither empty handles or `undefined`) in successful cases. RenderFrameImpl::JavaScriptExecuteRequestInIsolatedWorld() converts the result of ExecuteScriptInIsolatedWorld() into `base::Value` in RenderFrameImpl::JavaScriptIsolatedWorldRequest::Completed(), but this previously didn't handle empty handles (failed at DCHECK() in V8ValueConverterImpl::FromV8ValueImpl). This CL fixes this so that it converts both empty handles and `undefined` into `base::Value()`, which is consistent with other callers. Tests: weblayer_instrumentation_test_apk: - org.chromium.weblayer.test.ExecuteScriptTest#testClearedOnNavigate - org.chromium.weblayer.test.ExecuteScriptTest#testScriptIsolatedFromPage in - android-pie-x86-rel - android-pie-arm64-rel - android-marshmallow-arm64-rel After this CL, WebScriptExecutor::Execute() returns empty handles on errors, regardless of main/isolated worlds. Bug: 1111134 Cq-Include-Trybots: luci.chromium.try:android-pie-x86-rel Change-Id: I288827b5b39ba05f625da53b486797f64e53fda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545745Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#830670}
-
Ben Kelly authored
This CL translates the path-to-regexp regular expression generator from typescript to c++. Its based on the code here: https://github.com/pillarjs/path-to-regexp/blob/125c43e6481f68cc771a5af22b914acdb8c5ba1f/src/index.ts#L532-L596 We deviate from the path-to-regexp code in a couple minor ways. First we only return a list of group names instead of the full "key" objects containing prefix, suffix, etc. Second, the code structure is reordered a bit to make early-return style more readable. Bug: 1141510 Change-Id: I4018cf99a91665a1661c5fe93f8eac4eb0bd3223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528938Reviewed-by:
-
Max Curran authored
course of a page load. Two key values within Translate are the source language (language of the web page) and the target language (the user's language). This new code will track the source and target language over the course of a page load and record the initial and final languages for every page load. We want to record both the initial and final values, because the user can manually change both the source and target language. In addition, this new code will record the number of times the target language is changed. We do not do the same for source language, because we expect the user to change that much less frequently. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 111486 Change-Id: Ibb9fec8f2f831aaf7bea09a543167c0220d795ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543342Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#830668}
-
Tomasz Wiszkowski authored
This change updates the priority of the Clipboard suggestion so that these are shown above the MV tiles. Bug: 1150086 Change-Id: I56dbb496ebd7e784ab1ca387f155648fe943fa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556212 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#830667}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4314.0-1605528048-benchmark-88.0.4324.12-r1 to 89-4324.9-1606129869-benchmark-89.0.4334.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia0c0b93a447ab78a115b36995a30762292b34674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558832Reviewed-by:
-
Patrick Noland authored
This replaces an expensive, synchronous process of fully re-classifying the current autocomplete match(es) by passing an extra bit of information when we receive the notification that suggestions have changed. Bug: 1149683 Change-Id: I5ea0cc556bdb6fb843d8a1e7b0e1ef6424fa4d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536373 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830665}
-
Yi Gu authored
The test has been flaky on Windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaFeedsWebUIBrowserTest.ConfigTable TBR=beccahughes@chromium.org Bug: 1141621 Change-Id: Ibe9ca8baba96963c40bc99858916c100587b01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558170Reviewed-by:
-
Reilly Grant authored
Issue 839117 prevents the Exposed attribute from working properly on partial interfaces. There are therefore a handful of attributes which manually check the type of worker they are being requested in and return null rather than being undefined. This change adds tests for this behavior in shared workers. Bug: 839117 Change-Id: If79929622e8f98a01e059dc90ff1514131035487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538501 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830663}
-
Collin Baker authored
Bug: None Change-Id: Ib69156aa0fd3ca5c943e7ba324052943aa5254aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550487Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#830662}
-
