GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f2c29ad3..2ff41ff5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icc592027c4d70dcd85bb11d780c1f285eeb0898a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415548Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807768}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: Iae7196ba7fb37ce04d6660113ba42f872d5fba2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415330Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807767}

Demo: https://screenshot.googleplex.com/47REAoUwTx7sigJ.png

This CL:
1. Introduces |PhoneHubInterstitialView| with a customized layout that
   can be reused by onboarding, disconnecting/connecting and error
   state UI.
2. Introduces |OnboardingView| which serves as an entry point for
   eligible users to set up the Phone Hub feature.

Remaining work includes implementing the button click handlers.

BUG=1106937,1126208

Change-Id: Ib1b93b47ee1b715c991811b35afdfdc57b2f5c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406662
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807766}

Removing the check of the size of the shared files from
share_service_impl, but leaving the unit tests prepped to cover these
cases to validate that the platform-specific implementations check this
when they are processing the shared files.

The scenario being fixed with this change is sharing native files,
easily exercised with the Web Share Test page:
https://w3c.github.io/web-share/demos/share-files.html

When these files are initially created as blobs they are marked as being
of unknown size, and though the navigator_share code does check their
size as part of the Share operation, this check does not modify the
actual blob, so when it is serialized the recorded size will be the max
uint64 value. Matching the Android implementation, this postpones the
file size check till the files are actually being processed (in the
platform-specific implementations).

Bug: 1035527
Change-Id: I59ea9bfadb06205ae155f31947fa04093f06503d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415431Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#807765}

Provide some basic info of the host of the focused text field to system
IME via private extension API. With these information, IME will identify
some known faulty clients then demote its input.ime APIs (even disable
advanced features) to make the typing on these client works basically.

Context for the CL:
Due to some faulty implementation of their text operations in some
clients' text field (e.g. Terminal for Linux, Text app, Android app...)
in ChromeOS, they don't work not properly with predefined ChromeOS IME
APIs (e.g. chrome.input.ime.deleteSurroundingText, setComposingRange...).

Therefore, typing on these client are always difficult with unexpected
results. Detailed example can be found in the bugs attached.

Tested=Some popular cases in local VM and Kevin device in skylib.

Bug: b/162183648,b/163645900
Change-Id: Ib43e9ccba7e9620b7189153d956ef685f80fb29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405046
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807764}

https://dawn.googlesource.com/dawn.git/+log/c23676954838..19b910d7964b

2020-09-16 cwallez@chromium.org Make dawn components support CMake's BUILD_SHARED_LIBS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I21db8799c13d31375002abac0c9abcd05475aa6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414639Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807763}

This is a reland of eea2a6fb

Original change's description:
> Add build flag for building //chrome in a DFM
>
> This change adds much of the support needed for building //chrome in a
> DFM. Some TODOs have been scattered around for follow up changes. A gn
> flag enable_chrome_module has been added to toggle the DFM.
>
> The main pieces here are (when the gn flag is enabled):
>   1. All //chrome Java code will be moved into a "chrome" DFM.
>
>   2. All DFM Java code will also be moved into the chrome DFM.
>
>   3. All //chrome-specific definitions in the <application> manifest are
>      moved to the "chrome" DFM manifest. This was done by moving all of
>      the definitions in the main AndroidManifest.xml into a jinja macro
>      which can either be called in the main AndroidManifest.xml or in
>      the DFM AndroidManifest.xml.
>
>   4. Resources needed in the base AndroidManfiest.xml are moved to a
>      separate target so they can be included only in the base module.
>
>   5. Changes were added to lint.py to allow linting the chrome DFM
>      manifest along with the base manifest to avoid unused resource
>      errors.
>
> Still TODO in follow ups:
>   - Address TODOs added in this change.
>   - Make a similar change in //clank.
>   - Deal with org.chromium.chrome.browser.ChromeBackupAgent which must
>     be referenced in application tag of the base manifest, but will be
>     defined in the chrome DFM.
>   - Change the application class to allow loading with isolated splits.
>   - Collect loadable modules from DFMs and put in base.
>   - Probably more...
>
> Bug: 1126301
> Change-Id: I3fac243101eb2fb1e4af21ee99c2349fb074677b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412553
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807704}

TBR=agrieve@chromium.org,mdjones@chromium.org

Bug: 1126301
Change-Id: Ia1af90628c17c3d538c2fea4d48584bcc09ae725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415489Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807762}

This change fixes the ContentSettingBubbleModelTest.Geolocation unit
test when the macOS Core Location API is enabled, as this adds a new
state the UI can be in when system-level location permission has been
denied.

Bug: 1051591
Change-Id: I59325fa180e9e2a4f8ea5d0295f34287fd4f3cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413208
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807761}

If the content settings bubble for the geolocation permission is showing
the "turned off" message because system-level geolocation permission is
denied a NOTREACHED() was reachable because the radio buttons normally
shown in this bubble are hidden.

This change tracks whether the UI is in this state and disables the
call to CommitChanges() that normally happens when the dialog is closed.

Bug: 1128118
Change-Id: I0039b0c061dd95a330b936c39b9bde714fb31071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411450Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807760}

Refactors SessionCrashedBubbleView to use DialogModel.

Adds a DialogModelLabel which supports links for text and refactors
body text to share that code. These are used for DialogModelCheckbox as
well.

Bug: 1106422
Change-Id: I573d685d87674be72e3cd8122ec481be72cd089d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407334
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807759}

Reset the contact downloader if the download fails. Adjusted unit test
to pass only if the contact downloader is reset.

Change-Id: Id684f77127280a6a6585618d5c75236b9ad92c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414780
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#807758}

This adds a toggle to the action bar to allow the user to toggle the
offline availability of files. Also change the corresponding command to
get entries from selection as it is only used on the file list and
never in the directory tree.

The entire dialog-header should have font size 14px, so move that too.

Bug: 1115025
Change-Id: I734c2939002728c492a9e042fb8302ce7b907e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409687Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807757}

Unions may bypass the conversion between raw pointers and the CheckedPtr
representation (that stores extra information in the top bits).  This
may lead to runtime crashes (e.g. when storing a pointer into a union as
a raw-pointer, but extracting/dereferencing it as a CheckedPtr;  OTOH we
note that such coding pattern might in general result in an undefined
behavior - https://en.cppreference.com/w/cpp/language/union says "[i]t's
undefined behavior to read from the member of the union that wasn't most
recently written").

Additionally, presence of a CheckedPtr might mean that a union
destructor will be deleted (if CheckedPtr has a non-trivial destructor).
This may introduce build errors after the rewritten code is used with
BackupRefPtr variant of CheckedPtr.

Because of the problems above, after this CL the rewriter will emit
union fields as blocklist candidates.

Bug: 1069567
Change-Id: I7295a3025bf14d7337430f5ee4dc5d0f5b151fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228126
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807756}

Make it clear that it's unsafe to use this on invalid RFH pointers.

Courtesy of dcheng@ for pointing this out in a code review.

Change-Id: Ide6d6a3ca7274d1179109ca05463416a4c5696c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415428Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807755}

Explains what chrome-untrusted:// is and why was it introduced.

Change-Id: Ib7795aff9a10c111becebb12794610eac0c9d944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359857
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807754}

Matching mocks at go/parallels-design

TBR=jamescook@chromium.org

Bug: 1129266
Change-Id: I859353032b5695738f3f026fbaf3890f29d8a669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413678
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807753}

This reverts commit 281923e5.

Reason for revert: https://crbug.com/1129271

Original change's description:
> infra/config: All builders use a task service account for Goma access.
> 
> Made all builders to use the task service account to access Goma.
> I removed options from lib and made use_luci_auth=true mandatory.
> 
> Bug: crbug.com/1105814
> Change-Id: I8c0dff203a96e34db0b5ec1ac79b70289e2ae9e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411561
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806951}

TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,yekuang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: crbug.com/1105814, 1129271
Change-Id: Ic626ee4d6e86bbc9d0e15bbe6f8be89e414bcdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415749Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807752}

When analyzing .so files that are not from .apk files, unstripped .so
files must be used to get symbol information, but it's not useful to
report unstripped section_sizes.

Rather than add a --stripped-elf-file parameter, always run "strip"
before measuring section sizes (since the command is really fast).

Bug: None
Change-Id: I840fe02a9d3795cb8b1ba3f46c909f20f9997062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411651Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807751}

ServiceWorkerStorage had assertions that some methods like
UpdateToActiveState() should always be called after other methods
like FindRegistrationXXX(). While these were valid assertions,
these would not be satisfied any longer when ServiceWorkerStorage
is moved to the Storage Service and it starts supporting
crash recovery. Any public storage methods can be called without
preliminary method calls after the Storage Service recovered.

This CL replaces these assertions with lazy initializations.

Bug: 1055677
Change-Id: Ic6e69ea9c4b6e20839445a6788a575503e3fe0df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409483
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807750}

Support calls like ax_dump_tree --chromium to dump Chromium acctree.
Prototype the feature on mac.

Bug: 1124366
Change-Id: I5b02161d6542cd4be9963045d149fca078cfff04
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410027Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807749}

This CL runs |SplitCompat.installActivity| in |ChromeActivity| for
bundle builds that have an app override language set.

Currently the Android language decouple only works for languages
already in the list of system languages.  These language splits are
stored in /data/app while language splits downloaded by the app are
stored in /data/data/. |SplitCompat.installActivity| should let Chrome
activities use the language splits in /data/data/.

Bug: 1128698
Change-Id: I61fe63cdadbbc9f26d8beca2ba34f0631f65d0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412824Reviewed-by: Fred Mello <fredmello@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807748}

Bug: 1113364
Change-Id: Ie32f243366da8081e9b7f1b8bfdf01fb64b38780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402288
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807747}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I807eb80d13a70a14c6e1aedfe08efd5e057e1c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415668Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807746}

This reverts commit a359d11d.

Reason for revert: Suspicious to be causing test failures on several bots.  Examples are:
https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests

Original change's description:
> clang tot bots: Force-enable memoryssa-based dse
> 
> Now that the flag is off-by-default again upstream, let's force it on
> on the tot bots to see if things work with it on.
> 
> TBR=akhuang
> 
> Bug: 1127713
> Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807727}

TBR=thakis@chromium.org,akhuang@google.com

Change-Id: I794de306768b4415f5404cacab6a69862d4f81e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413686Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807745}

This reverts commit 5df44d19.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 807737 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVkZjQ0ZDE5NWYxNjNlZjAxOWJjNjM1OTlmMWRjMDM0ODM2MjhlOWUM

Sample Failed Build: https://ci.chromium.org/b/8868949173902754864

Sample Failed Step: compile

Original change's description:
> cablev2: add authenticator logic.
> 
> This change adds logic for a caBLEv2 authenticator which is disconnected
> from the concrete Java code that will come in a later change.
> 
> BUG: 1002262
> 
> Change-Id: Iebb2734f48de484b20a97295a0985ba790bf2fb3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411150
> Commit-Queue: Adam Langley <agl@chromium.org>
> Auto-Submit: Adam Langley <agl@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> Cr-Commit-Position: refs/heads/master@{#807737}


Change-Id: I315c049f48bca2f52692201e6ed9f00e267b9b7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG: 1002262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414783
Cr-Commit-Position: refs/heads/master@{#807744}

IsTabStripEditable() is typically only false if the tabstrip is in an active drag state: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_strip.cc;l=1177;drc=dd5c0ffe3d68d76ceabf50e2b058f1bb27dea8e7

Also, IsTabStripEditable() is exclusively used in extensions: https://source.chromium.org/search?q=istabstripeditable&ss=chromium

In tests, and especially in extensions tests, and *especially* in unit tests, the tabstrip is never in an active drag state, so a reasonable default for IsTabStripEditable() is true.

(My motivation for changing this now is because I'm trying to write an extensions unit test for the Tabs API.)

Change-Id: Idc4b5d709f8032584ce178a486b214646192de71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414994Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807743}

last_searched_text_ wasn't being set to the initial text displayed in
the find bar, so when OnAfterUserAction got called after an arrow key
was pressed, it thought the search text had changed and a new Find
needed to be run. This fixes that.

Bug: 1127666
Change-Id: I06f155942a7902eb99407ff7d17409168cc4e2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415328Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807742}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9fa7597dbe5..029801bea6c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC dalecurtis@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1110346
Tbr: dalecurtis@google.com
Change-Id: I1125e1afd4592003f66bf21ea020c3ac00cd4644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415212Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807741}

Bug: 999351
Change-Id: I61eb4b49a29da33eade85ceac53e01c4d029530e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414968
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807740}

ChromeCustomizeThemesHanlder was setting an incomplete theme info for
third-party themes. This CL fixes this and adds a regression test.

Fixed: 1129027
Change-Id: Ifd69087c3bd91ac98267dc4adcf50d7b780f49fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414299
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807739}

This reverts commit 3ec270e4.

Reason for revert: src-internal DEPS roll happened. Relanding this CL.

Also update mb_config.pyl to use the new gn arg to skip widevine
signing on public "offiical" Mac builders.

This fixes compile errors like:
  ERROR: Cannot find Widevine signing cert!

Original change's description:
> Revert "widevine: Add `ignore_missing_widevine_signing_cert` gn arg"
>
> This reverts commit 175e67fe.
>
> Reason for revert: Needs to wait for src-internal DEPS roll to be landed.
>
> Original change's description:
> > widevine: Add `ignore_missing_widevine_signing_cert` gn arg
> >
> > When Widevine CDM host verification signing failed due to no
> > signing cert, the build process will fail by default. However,
> > developers making local builds typically don't have those certs.
> > This CL introduces `ignore_missing_widevine_signing_cert` gn arg
> > so the error caused by missing Widevine signing cert could be
> > ignored.
> >
> > By default, `ignore_missing_widevine_signing_cert` is set to false
> > on official bots (is_official_build=true) to catch real failures.
> > Developers needing to set `is_official_build` can manually set
> > this gn arg to be true to suppress the error.
> >
> > Bug: 1127616
> > Change-Id: I41a43e922399497c75f1f967219d41d1566d90dc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412933
> > Commit-Queue: John Rummell <jrummell@chromium.org>
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Reviewed-by: John Rummell <jrummell@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#807513}
>
> TBR=xhwang@chromium.org,mmoss@chromium.org,jrummell@chromium.org
>
> Change-Id: I9a67901d83a13881180fcfe63cecb240cc5ebcde
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1127616
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414652
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807559}

TBR=xhwang@chromium.org,mmoss@chromium.org,jrummell@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1127616
Change-Id: I2857b1a306688e42b370108ab55dc8744f794a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415369Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807738}

This change adds logic for a caBLEv2 authenticator which is disconnected
from the concrete Java code that will come in a later change.

BUG: 1002262

Change-Id: Iebb2734f48de484b20a97295a0985ba790bf2fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411150
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#807737}

The android cronet testers were copied with new names in
https://crrev.com/c/2406696.

Bug: 1105234
Change-Id: I45563e45110afebe90be02607d6f54e9a53fc71a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415208
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807736}

This CL updates the DevToolsExperiments enum to include the
keyboardShortcutEditor experiment that will be introduced in the
frontend here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2271229
It also updates DevToolsAction to include new actions added by
that frontend CL.

Bug: 174309
Change-Id: I38dc2ce6ca24fb7a3a1f15e08b978b7b28addf72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405543Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#807735}

This is a code health follow up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/2409057/comment/777838a4_d0d60afc/

This CL reorders the construction of the ExternalInstallOptions result
such that each field's logic is self contained in the same location.

Change-Id: I733f4d52d21f917f4d257ac6060da42c180b2121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409666
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807734}

Tab modal dialogs cause the renderer to pause and block showing and
hiding the status indicator. Because of this, we can't reliably destroy
and recreate as needed since we rely on signals from the renderer to do
so.

This CL reverts most of the optimizations done by destroying and
recreating the view, and instead, only drops the bitmap cache in
ViewResourceAdapter after the status indicator is hidden.

Bug: 1126964
Change-Id: I5f879a5cd56e68025811624c82928166ca583b0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411164
Auto-Submit: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807733}

Blocking all iframes on an allowlisted website is very
restrictive and causes a lot of problems. This cl assows same-domain
iframes on the allowlisted main page unless they are explicitly blocked.
The cl will run a safe search on those iframes.

Bug: 1128018
Change-Id: Iccb6dfeb53b2e6823710a93edee3b7e592f6fd94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404144
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807732}

Always configure the uma checkbox even when it does not show on the
screen when fragment is created. Noting that un-official builts might be
impact by this change.

Bug: 1129014
Change-Id: I383a65d9f4ed05e8255139829b2a473a25b298a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414841Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807731}

A previous CL [1] introduced a bug where clicking on the Manage Settings
link would not open the settings page. This CL fixes that bug.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2269385

Bug: 1124502
Change-Id: Ic3de09d07f1c00af34bbf241f2b750ea263f016b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405043
Commit-Queue: Rachel Wong <wrong@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807730}

Progress on using XPS to print on Windows is blocked on out-of-process
print drivers.  Update the milestones for both --use-xps-for-printing
and --use-xps-for-printing-from-pdf beyond that of
--enable-oop-print-drivers.

Bug: 1008222, 1034053
Change-Id: I7af7d0d97370b2bf942bd0f10e2c1f10f659d617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415372Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807729}