- 06 Nov, 2019 1 commit
-
-
khmel@chromium.org authored
This fixes: tooltip position in case content is scrolled. average power computation. allows digits in normalized names. TEST=Locally BUG=b/143532713 Change-Id: I25f7976f2cb9832d05a93f2bea1d2590ba454516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899894Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712817}
-
- 05 Nov, 2019 39 commits
-
-
Patrick Noland authored
TBR=aliceywang@chromium.org Bug: 1020068 Change-Id: I3a32b199482852f197973792d6de3f14f3a93729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900468Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#712816}
-
Sergey Ulanov authored
enable_cbcs_encryption_scheme flag was set on all platforms except Fuchsia. There is no reason this feature needs to be disabled on Fuchsia. Remove this flag. Bug: 1021308 Change-Id: If79065f337119f9098254f21caa12bec79609b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898640Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712815}
-
Nico Weber authored
Bug: 1002490 Change-Id: I99765485b46e05c66d373115e1f7b77f545354bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899896 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712814}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad04327df8c5..3c0e86a87d08 git log ad04327df8c5..3c0e86a87d08 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 honghaiz@webrtc.org Add a field trial to use only the higher 64 bits to find network handle from an ipv6 address. 2019-11-05 alessiob@webrtc.org RNN VAD: prepare for SIMD optimization Created with: gclient setdep -r src/third_party/webrtc@3c0e86a87d08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ida3335789f81d53f7a7659ec989c3e00f62d1f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899339Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712813}
-
Tom Anderson authored
This CL adds support for some additional X11 color types: RGB565, ARGB4444, RGBA1010102. Also avoid unnecessarily rendering into an RGBA8888 buffer and converting to the window format; just render into the correct format directly. Also simplify/refactor some code. BUG=1016383 R=rjkroege Change-Id: I08051526b81d364a236c37654fda1be6bad1bc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899324Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712812}
-
Raymes Khoury authored
Change-Id: I4c16fce1dd6377e83663850a78df718915291756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900508 Auto-Submit: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#712811}
-
Dana Fried authored
Instead of watching and unwatching the thumbnail associated with a hover card every time the mouse moves on or off a tab (or something grabs mouse focus) we now watch a handful of thumbnails of tabs we've recently hovered. Note that re-watching a tab with a valid thumbnail is mostly a no-op. Bug: 1021332 Change-Id: I55646c89514a001052cd6d453ffe3a3b6e11a731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899388 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#712810}
-
Xianzhu Wang authored
Previously we updated fragments of link highlights during paint, and called LocalFrameView::SetForeignLayerListNeedsUpdate() when we had less fragments than before, but SetForeignLayerListNeedsUpdate() should be called before paint because it deletes paint controller. Now separate the work into a new step LinkHighlightImpl::UpdateAfterPrePaint() to update the link highlight fragments and call SetForeignLayerListNeedsUpdate() when the number of fragments changes. Bug: 1021470 Change-Id: I4d81a522844e957aebcb406fb36044297872ab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899317Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712809}
-
Matt Menke authored
Bug: 997049 Change-Id: I5093e48e16a6fe11167a20e3868b66e1b14558d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898485 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#712808}
-
khmel@chromium.org authored
As described. TEST=Locally BUG=b/143532713 Change-Id: I601d43bc1d7d0f1eb061674b9b1537f990e3f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900166Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4306aa57..db6f5198 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13f7454f6658f86ae7d4b3b924344016affb9e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899797Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712806}
-
Thomas Tellier authored
Bug: 1007873 Change-Id: I60e4c7972d5e261b666f745017747d1ad8eda043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834221 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712805}
-
Xinghui Lu authored
Launch bug: crbug.com/1006375. Bug: 995926 Change-Id: I28143ab04cabe15243e5bde7ac4d0b48708ae9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898440Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712804}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5364042c0287..38f84022167e git log 5364042c0287..38f84022167e --date=short --no-merges --format='%ad %ae %s' 2019-11-05 dburger@chromium.org Extend paladin build timeout for goma slow build bug. Created with: gclient setdep -r src/third_party/chromite@38f84022167e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c715571fab9c1172c51a28a756ab3827c2ed4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900366Reviewed-by:
-
Mei Liang authored
This CL implements the basic component functionality and adds some general tests. Change-Id: Idbacd856128e3b584a618d85c400beec36918fa4 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879331 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712802}
-
Renjie Tang authored
Hope the fuzzer will be able to crash and give out helpful stack trace. Change-Id: Ie9a42b465eb966c10d52e4e263ed331a227d3e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900261Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712801}
-
sczs authored
When too many Infobar Banners are dismissed and presented right after the other by stopping their Coordinators, the Banners won't be queued, and the dismissal animation of the first one might cause the second banner to be presented after its own Coordinator has been stopped, leaving a presented bannerVC. This CL stops animating the banner dismissal whenever its Coordinator has been stopped. Bug: 1020199 Change-Id: I2f44867e5265abea8d18c94641c78e2b2c42b656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898747Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#712800}
-
arthursonzogni authored
RenderFrameHost::delegate_ is never null. New CLs are adding more and more null check for this, just to be sure, because there are locations where this is checked. This patch remove all the location where is checked to avoid this to spread further. Bug: None. Change-Id: I5ba7903a199fdb3117df6adf514e187b0a36ea0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899501 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712799}
-
Kurt Catti-Schmidt authored
This change adds a nullptr check in GetFragmentRootParentOf. AXFragmentRootMapWin maps from HWND to fragment root, and it was assumed that an existing fragment root with a valid HWND will always have its child delegate available via GetChildNodeDelegate. However, this bug demonstrates that this assumption is incorrect. gets called during the destruction of any WebContents while the HWND is still valid. In the repro case I found, ToolbarActionView::UpdateState initiates a layout during tab restore, which ends up firing accessiblity events, which end up doing tree traversal and hit this crash. A unit test was added that reproduces this specific scenario and which crashes without the nullptr check. RenderWidgetHostImpl: :DetachDelegate will get us in this state, and it Bug: 1021633 Change-Id: I344651844f093b81f7b8fbdfade54f1c7bd029f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900095 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712798}
-
ziyangch authored
Bug: internal b/140189221 Test: Cast from Youtube to Android TV. TTS on Android Things. Change-Id: I1cc4e355a0644ff35193a62c47f7fa748de17fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900151 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712797}
-
Carlos IL authored
This fixes a bug that caused commands to be non-functional on a subresource triggered SB committed interstitial if a different type of interstitial had been shown on the same webcontents previously. The bug was triggered depending on the order different WebContentsObservers were installed (which determines the order DidFinishNavigation is called in them). This CL changes the observer that needs to fire first so it uses ReadyToCommitNavigationInstead. Bug: 1021334 Change-Id: I3e6683279523dc6b74a2266fdd2bf05e0ab4d132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896346 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#712796}
-
Ken Rockot authored
Removes dead code inside Data Decoder that was there to support its use through Service Manager clients which no longer exist. Bug: 977637 Change-Id: I379787ff50cf2d12bc364f17ed1d6a42d2c1b836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892671 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#712795}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6be491b7bb57c3950d4fbb97fdd4a141e3fa4d63..d709b0d8926707f3143d8cf7c84350e49e56ec38 Bug: none Change-Id: I5f3eb59927053d83d5fef89a4821529cc7198f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900212 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#712794}
-
Toni Barzic authored
This effectively enables the feature by default. BUG=1005366 Change-Id: Id0144ca37888516a530a34cdc65d05d3a796078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894415Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712793}
-
Shimi Zhang authored
No logic change, add @VerifiesOnP and make the version check at call site of SmartSelectionMetricsLogger.create(), hopefully it will not try to load SmartSelectionMetricsLogger class on below P, so it will avoid class verification failure on below P. Bug: 1021642 Test: Current tests should pass. Change-Id: I4df098ef8e074b93629aeba12608efbfc636c850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900290Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712792}
-
Ken Rockot authored
This removes the last vestiges of Service Manager dependency from Data Decoder and its clients. Everything is ported to use the new DataDecoder client API. Bug: 977637 Change-Id: I36b011a5f5935195d5ad7352c9aca87ef14007de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892558Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Peter Boström authored
Adds pbos@ and tbergquist@ as placeholder owners for TabContextMenu_ entries in tools/metrics/actions/actions.xml. Bug: None Change-Id: I0d36329aab5ffe00f0df908b3c8d58e144cc8380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898469 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712790}
-
Mike Wittman authored
Moves the metadata processing for upload into a separate class as it's somewhat complex but self-contained and has a narrow interface. This also allows the behavior to be tested more directly, simplifying the tests. Bug: 976864 Change-Id: Icd608d1665337fa7e8e5168d1e87e529acbd84cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897359 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712789}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e600381cfd17..f168baf4df53 Created with: gclient setdep -r src-internal@f168baf4df53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:922813,chromium:None,chromium:None,chromium:None,chromium:984162,chromium:1004848,chromium:None,chromium:None,chromium:None Change-Id: I666b6a7e013138497d61b91f4d36181b1a305b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712788}
-
Joshua Pawlicki authored
TBR=bsheedy@chromium.org Bug: 1014754 Change-Id: I4692c3e3a306b0576ac91291624b72be141fff68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900193Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712787}
-
Kehuang Li authored
We got crashes when accessing AudioInputCallback around the time we Stop/Close CastAudioInputStream. The audio_io.h is ambigeous on if the impl of Stop should be sync or async, but mostly it should be sync as AudioOutputStream::Stop. CaptureServiceReceiver::Stop is posted to another thread, and complete async, which explain the crashes we met. Therefore, add an internal stop function and let the public Stop wait for the internal stop completes. Bug: internal: 143908196 Test: On device and unittests. Change-Id: I9f6cfbd6457873094ce8c11ec6399b73012526dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898720Reviewed-by:
-
Xiaoqian Dai authored
When the window drag starts or slows down, fade in overview windows. Bug: 997885 Change-Id: Ica9e256df32babeb6dab3d7d027447217a577c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900127 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a13b461e6e0..1803f4ef6fe7 git log 7a13b461e6e0..1803f4ef6fe7 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 bungeman@google.com Revert "Fix empty run handling in trivial shaper iterators" 2019-11-05 robertphillips@google.com Revert "Reland "Implement sample mask and sample locations support in Vulkan"" 2019-11-05 robertphillips@google.com Revert "Add a "conservative raster" flag to GrPipeline and implement in Vulkan" 2019-11-05 bungeman@google.com Fix empty run handling in trivial shaper iterators 2019-11-05 fmalita@chromium.org [skottie] Streamlined gradient stop merger 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-05 mtklein@google.com implement SkColorFilterShader::isOpaque() 2019-11-05 csmartdalton@google.com Add a "conservative raster" flag to GrPipeline and implement in Vulkan 2019-11-05 egdaniel@google.com Add new macro for checking device lost when making Vulkan calls. 2019-11-05 borenet@google.com [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 ethannicholas@google.com Reland "Implement sample mask and sample locations support in Vulkan" 2019-11-05 mtklein@google.com unify program() and uniforms() 2019-11-05 brianosman@google.com Reland "Fully embrace skcms types in SkColorSpace API" 2019-11-05 bsalomon@google.com Cleanup kGray_8 readback. 2019-11-05 fmalita@chromium.org [skottie] Fix trim path mode interpretation 2019-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6c7208f93d6e..67527cb45293 (10 commits) 2019-11-05 fmalita@chromium.org [skottie] Use SkColor4f for gradient color stops 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-05 benjaminwagner@google.com Fail Skpbench on unsupported hardware 2019-11-05 herb@google.com Speed up diff canvas using small bit vector 2019-11-05 mtklein@google.com add color filter support Created with: gclient setdep -r src/third_party/skia@1803f4ef6fe7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: Ic218823881780ad07ce18c4aae79b9c15a20c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900120Reviewed-by:
-
Eric Stevenson authored
Necessary for converting test JNI in content to use proxy natives. Bug: 997199, 890452 Change-Id: Id08769bcc349204e35dc1324dda659905f0c3311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888379Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712783}
-
Matt Jones authored
Bug: 1021318 Change-Id: I98b7163f149a82f737f04ede5fd2817c6bb3108d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900091Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712782}
-
David Benjamin authored
Change-Id: I464eecb3ca7ef5417b89378588593d05c452592a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899897 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates the GestureManager mojo client in Blink to the new BrowserInterfaceBroker, and adapts the code in the browser process to register the binder from PopulateChromeFrameBinders(), instead of doing it right inside UnhandledTapWebContentsObserver. UnhandledTapNotifierImpl. Additionally it also adapts ShowUnhandledTapTest helper class so that it properly set the mock overrides for BrowserInterfaceBroker, as it was done before for InterfaceProvider. Bug: 936482,1006361 Change-Id: I9f369e41cb8441043646b34fd67e1902f7010383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887615 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712780}
-
Ryan Hansberry authored
This will help to more easily identify why users cannot find their Tether hosts when they provide feedback reports. Change-Id: Iff6d51f7e27eef36ed0312ba5c6ef61979ee8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900246 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712779}
-
Joshua Pawlicki authored
" This reverts commit 55549387. Reason for revert: breaks gfx_unittests on (none) GPU on Mac FallbackFontCommonScript/RenderTextTestWithFallbackFontCase.FallbackFont/common21 Expected equality of these values: missing_glyphs Which is: 1 0 Original change's description: > Fix RenderText itemization for complex emoji > > > > This CL is a refactoring on the way RenderText do > > ItemizeTextToRuns for the corner cases where a run > > should be split in grapheme clusters. > > > > The previous code was naming these cases: > > * Unusual characters > > * Special characters > > * Non-regular characters > > But they should be more specific on the purpose of splitting the runs. > > > > Also, the algorithm used for splitting a sequence of codepoint > > was based on the code block of the corresponding codepoints > > and few cases where trying to merge adjacent codepoint in > > a grapheme. The algorithm was incorrect multiple cases (e.g. emoji). > > > > Unicode provide a way to split a sequence of codepoints into > > grapheme and grapheme clusters. > > They provide a state machine which is using the codepoint proporties > > to decide if the current location is a grapheme boundaries. > > > > The ICU library is providing an API over the character properties > > to help iterating over graphemes. > > * ubrk_open > > * ubrk_first > > * ubrk_next > > * ubrk_close > > > > The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is > > providing an easy to use wrapper over that API. > > > > > > The current CL is replacing the previous characters based splitting > > algorithm by the graphemes based version. > > > > > > > > See emoji sequence: > > http://www.unicode.org/reports/tr51/ > > 1.4.5 Emoji Sequences > > > > The full emoji list: > > * http://unicode.org/emoji/charts/full-emoji-list.html > > Emoji data, used to make our unittests: > > * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt > > > > > see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/) > > see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h > > see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h > > Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712704} TBR=robliao@chromium.org,asvitkine@chromium.org,etienneb@chromium.org Change-Id: I6ea8c752e40ed07522d0d336ada289934c899477 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900433Reviewed-by:
-
