GitLab

This reverts commit 164f881f.

Reason for revert: Caused a failure https://build.chromium.org/p/chromium/builders/Android/builds/74079

Original change's description:
> 📺 Use video aspect ratio to determine PiP params.
> 
> Use the bounds of the fullscreen video to determine the starting
> bounds for the PiP transformation and the aspect ratio of the PiP
> window.
> 
> Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe
> Reviewed-on: https://chromium-review.googlesource.com/536974
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485916}

TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org,jochen@chromium.org

Change-Id: I91b3e716c02bd5c41cf93d3fde04e0874d26d3e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/566865Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485929}

This reverts commit 54275e80.

Reason for revert: breaks ios_showcase_egtests downstream. Failure details: https://paste.googleplex.com/6470224534568960 - fails on all simulator bots.

Original change's description:
> [ios showcase] Removes ios/web dependency.
> 
> Showcase is intended to be a standalone UI app and as such should not reference 
> //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain 
> instance and thus implicitly being an //ios/web embedder, instead directly inlining the 
> minimal parts of that startup that are needed (initializing base::CommandLine and loading resources).
>  
> As part of that change, this CL eliminates Showcase bundling //ios/web resources.
> 
> Bug: 738880
> Change-Id: I0a3d3494838cc588034feb48443d24ddf1bec03a
> Reviewed-on: https://chromium-review.googlesource.com/565453
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485815}

TBR=blundell@chromium.org,lpromero@chromium.org,sczs@chromium.org

Change-Id: I8f2daeb1adeabe4622e312b5bc1d70a5591bd68e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 738880
Reviewed-on: https://chromium-review.googlesource.com/566864Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485928}

Following bot results are included.
723 724 728

884 lines were removed by consecutive passes since 643 (Jul 6),
excluding the bot troubles yesterday (701-711). This should undo all
additions during the bot troubles.

TBR=eae@chromium.org
NOTRY=true

BUG: 591099
Change-Id: I5c62411bf0a3b32a5c1c95fc94c2d0c5dd3a6d10
Reviewed-on: https://chromium-review.googlesource.com/567939
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485927}

Bug: none
Change-Id: Iba0bacce5bd0baf9079bab9a8ce0e2bb4f884fca
Reviewed-on: https://chromium-review.googlesource.com/565405Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485926}

Bug: 532989
Change-Id: I2295d05c59e24f8ae36d763a38c65188b2495675
Reviewed-on: https://chromium-review.googlesource.com/559047
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485925}

Bug:657041

Change-Id: Idafd23621f458dfd73757899bca952f470f31767
Reviewed-on: https://chromium-review.googlesource.com/563299
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485924}

Bug: 728199
Change-Id: I386530410dcafa76cfe2be91744e6d82a5ea232e
Reviewed-on: https://chromium-review.googlesource.com/552639
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485923}

TabSockets are intended to either be installed into the main world or
a isolated world created by Page.createIsolatedWorld.  Previously we
only supported a single TabSocket per WebContents but that's unfortunate
with OOPIF.  This patch lets us support multiple TabSockets up to one
per world per frame.

The mojoms have changed a bit with
TabSocket::AwaitNextMessageFromEmbedder moving to 
HeadlessRenderFrameController::SendMessageToTabSocket which simplifies
recieveing a message from the embedder since a hanging IPC is no
longer needed.

Original patch: https://chromium-review.googlesource.com/c/543160/

Bug: 546953
Change-Id: Iab134b78d3cbfcbdb00ada15a6ae6d3b253727a8
TBR: jochen@chromium.org, mkwst@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/565404Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485922}

This makes stamping folder trees with closed folders significantly
faster, without making any noticeable impact on fully-open trees.

Bug: 727177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I087898598b265a396aeb6e178487ee8a5ece8d5a
Reviewed-on: https://chromium-review.googlesource.com/566205Reviewed-by: Christopher Lam <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485921}

This is preparation to split LayoutSelection start/end calculation w/o 
canonicalization.
This CL also fixes issue that Selection API consider editable boundary incorrectly

Bug: 739062
Change-Id: I84623287faebcb3bc5c497abf1d9560a54f5d751
Reviewed-on: https://chromium-review.googlesource.com/566208Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485920}

It used to be used for file URLs and TransportSecurityStatePersister as
well, but this CL moves those over to using the task scheduler. Can't
just always use that for the cache as well due to the cache needing a
SingleThreadTaskRunner, and getting one of those from the task scheduler
is a bit more resource intensive.

BUG=734199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2977693003
Cr-Commit-Position: refs/heads/master@{#485919}

A plain "NoDevicesError" with no further explanation was confusing to
developrts when there were devices but all failed with some errors.

Bug: 732724
Change-Id: Ib4d2bff47ca85da3212e28394f6d41742df7cf53
Reviewed-on: https://chromium-review.googlesource.com/558072Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485918}

There have been some reports of these features not working together. This 
test tries to ensure that they do work.

Bug: 732154
Change-Id: Ieccd55603d35a92342a868fc7753f3af98a4aed7
Reviewed-on: https://chromium-review.googlesource.com/567505
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485917}

Use the bounds of the fullscreen video to determine the starting
bounds for the PiP transformation and the aspect ratio of the PiP
window.

Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe
Reviewed-on: https://chromium-review.googlesource.com/536974
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485916}

This patch changes |TypingCommand::DeleteKeyPressed()| to utilize early-return
style and const-variable with splitting function for improving readability.

Change-Id: I8f153fdefca3d1f6575a127d31c24746fd7b3724
Reviewed-on: https://chromium-review.googlesource.com/566743Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485915}

Bug: 603559
Change-Id: Ib9316295cee0226fe19c966e47b0c5a6a730db44
Reviewed-on: https://chromium-review.googlesource.com/567504
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485914}

Since jumbo is still disabled by default and there is no active
bot that checks things, it is best to check that jumbo_excluded_sources
are correct also when jumbo is disabled.

Bug: 713137
Change-Id: I85bb92f283be240a704ce3ec0d5765933ba52016
Reviewed-on: https://chromium-review.googlesource.com/563683
Commit-Queue: bratell at Opera <bratell@opera.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485913}

Most of setting headers in the passwords seciton on iOS already use Title Case,
except for the headers of the saved and blacklisted lists of passwords.

This CL fixes that by creating new strings for iOS settings inside
ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings
from the password_manager component (components/password_manager_strings.grdp).
That string was also used by the old (non-MD) desktop settings, which have
already been deprecated. The MD settings on desktop use the Title Case as iOS
should as well, but the MD settings strings are consistently saved in
chrome/app/settings_strings.grdp, where they cannot be shared with iOS.

The CL creates the new string instead of sharing the one from MD settings,
because sharing has no benefit (on no build both strings are included, so no
storage spared) and has the drawback of binding the style of both strings
forever together.

The CL does not remove the component string yet. The old desktop settings code
is still in the codebase, and the shared string (used only by the old settings)
should be deleted once those old settings are deleted.

The CL was approved in https://chromium-review.googlesource.com/c/567181. This
is a verbatim copy of that CL, but re-uploaded after Gerrit issues prevented me
to actually land the original one. Hence I'm TBR-in lpromero@ who approved the
original.
TBR=lpromero@chromium.org

Bug: 740952
Change-Id: I455b8f2a5edd1089916a7b87f20eddc3b274a2b7
Reviewed-on: https://chromium-review.googlesource.com/567930Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485912}

This CL removes |throttles_to_register| and introduces |AddThrottle()|.
This will be easier to know understand in which order the throttle are
inserted into |throttle_|.

Some throttle were not inserted in the right order. AncestorThrottle
and MixedContentThrottle for instance.

BUG=733099
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2967363002
Cr-Commit-Position: refs/heads/master@{#485911}

Revert of Fixes redirects to external apps when navigating from PWA. (patchset #9 id:280001 of https://codereview.chromium.org/2969143002/ )

Reason for revert:
Test failures from new test WebappNavigationTest#testNewTabLinkToExternalApp on hromium.android/Marshmallow 64 bit Tester.

BUG=741568

Original issue's description:
> Fixes the redirect to external apps when navigating from PWA.
>
> This is done with avoiding explicit chrome package name (using
> component name instead) and using
> EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent.
>
> With this patch the redirect works, however it takes a long time for CCT to
> consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect
> in ChromeTabbedActivity is almost instantaneous. Result is that
> for _blank links CCT shows up briefly before redirecting to an external app.
> In a follow up it should be investigated why it is the case and if it cannot
> be improved, we might need to bypass CCT in such case, which would diverge
> from existing navigation paths for _blank links in Clank.
>
> BUG=740402
>
> Review-Url: https://codereview.chromium.org/2969143002
> Cr-Commit-Position: refs/heads/master@{#485831}
> Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e

TBR=dominickn@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,piotrs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=740402

Review-Url: https://codereview.chromium.org/2975883003
Cr-Commit-Position: refs/heads/master@{#485910}

Also removes Context -> Application downcasts in callers.

Review-Url: https://codereview.chromium.org/2966193002
Cr-Commit-Position: refs/heads/master@{#485909}

This CL refactors AtomicSequenceNumber to adopt <atomic>, and removes
StaticAtomicSequenceNumber, which is no longer needed after C++11.

Change-Id: Ia061cd4af76bbd630dc6fbc0e791b11013b0cd67
Reviewed-on: https://chromium-review.googlesource.com/566979Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485908}

Part of a refactoring to split the OS dumps out of the
process memory dumps.

Bug: 718809
Change-Id: Ia76a5d0ba3f2d907db5bf92bac830b9e7e3223be
Reviewed-on: https://chromium-review.googlesource.com/544881Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485907}

It was jumping back to the UI thread and back because the
PrefProxyConfigTracker required it. Now that that's no longer the
case, get rid of the extra thread hops. The same thing has already
been done to chrome/'s IOThead.

BUG=734199

Review-Url: https://codereview.chromium.org/2943783002
Cr-Commit-Position: refs/heads/master@{#485906}

Make sure overlay damage is updated correctly for fullscreen
and translucent overlays.

BUG=705290
TEST=cc_unittests --gtest_filter=*Overlay*

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I83c80ddb47495e185fc247c93e71aeb230504cb4
Reviewed-on: https://chromium-review.googlesource.com/558508
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485905}

Having two sets of templates named ToElement caused compilation failures
when both templates were visible to the compiler at the same time.
Since one of the templates doesn't benefit from being a template
this patch renames it and makes it an ordinary function.

R=fs@opera.com, tkent@chromium.org

Bug: 738389
Change-Id: Ia6247ad0f794cc4094f3f73cd7492ad5d94407c2
Reviewed-on: https://chromium-review.googlesource.com/567141Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#485904}

This patch changes "editing/selection/select-bidi.html" to use
|assert_selection()| for improving readability.

Bug: 230267, 679977
Change-Id: I9d6c40660ee3c1e2c14748989e90cd6543743cf2
Reviewed-on: https://chromium-review.googlesource.com/566792Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485903}

This reverts commit 4053f7ad.

Reason for revert: V8 bot was not obsolete (obsolete name maybe).
Why was it deleted? It is part of the V8 CQ.
https://crbug.com/741505

Original change's description:
> Clean up //testing/buildbot/*.json files to remove obsolete builders.
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I0b58757a8c56cf1ae9a5ba82fe2d485651f3c52e
> Bug: 662541
> Reviewed-on: https://chromium-review.googlesource.com/558381
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485851}

TBR=phajdan.jr@chromium.org,dpranke@chromium.org,kbr@chromium.org,martiniss@chromium.org

Change-Id: I056aa71fcae296adc08aa4baf7f2f465d2e1511c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 662541,741505
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/566961Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485902}

Add edchin@ and gchatz@ as owners of the badge view files within the
reading list directory.

Bug: none
Change-Id: I4eace37f01184d72a838c519f06cb848e50391bb
Reviewed-on: https://chromium-review.googlesource.com/567798Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485901}

After the fix to V8 (https://chromium-review.googlesource.com/c/563301/)
the following tests should not fail anymore.
deqp/functional/gles3/texturefiltering/*
deqp/functional/gles3/textureformat/*
deqp/functional/gles3/textureshadow/*
deqp/functional/gles3/texturespecification/*

Bug: chromium:725664
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I66255692b1c3a763a3cb1ccb087d00b7c1828328
Reviewed-on: https://chromium-review.googlesource.com/552551Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485900}

Bug: none
Change-Id: I48da5486779d4874a75d573b09c79b503925d992
Reviewed-on: https://chromium-review.googlesource.com/567900Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485899}

ConsumeShorthandVia2LonghandAPIs is a modified version of Consume2Values
of CSSPropertyParser. The difference between the two is that the new
version expects component longhands to have API impl already  as it will
forward parsing logic to component longhands API via ParseLonghandViaAPI.

Consume2Values will be deprecated soon, when shorthand properties 
are ribbonised (i.e. have their own APIs). Until then, there is a slight 
code duplication between the two versions, see crrev.com/c/564875 for discussions
why it is necessary.

In addition to ConsumeShorthandVia2LonghandAPIs, the cl also contains the following 
* Implement API for shorthand property scroll-padding-block as a use case of 
ConsumeShorthandVia2LonghandAPIs.
* Change ConsumeShorthandVia4LonghandsAPI to ConsumeShorthandVia4LonghandAPIs.
- Also updated "margin" API to reflect the naming change.


Bug: 668012
Change-Id: I45d1f5177c5ff3f381a24085ecde0647c5e08baf
Diff: https://gist.github.com/a54354ab973c928d2717251b56caeb57/revisions
Reviewed-on: https://chromium-review.googlesource.com/565662Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485898}

This CL removes the usage of the Google password from sync as discussed
over email.

Email from zea@:
"That's all legacy code really. It's only used for people with very old
sync accounts that might still be based on their GAIA credentials, and
should only be used once as we'll immediately transition that account.
I'm fine with removing that logic."

This CL also removes the usage of password from ChromeOS (and the
method RefreshSpareBootstrapToken), as GoogleSigninSucceeded method
is only called by SigninManager (not from SigninManagerBase) that
is not used on ChromeOS. 

Bug: 
Change-Id: I43d5cdf38d5b9ff97f13e31b5c2069203a803565
Reviewed-on: https://chromium-review.googlesource.com/565512Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485897}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f2c153fc..6c835897

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I519ce32c7724b1e98dc773e289ea405a52ae73be
Reviewed-on: https://chromium-review.googlesource.com/567631Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485896}

Background:
- When the GPU thread is *in-process* it runs inside the browser process.
- GpuChildThread is a ChildThreadImpl and a IPC::Listener.
- When GpuChildThread sees an error (or shutdown) of its IPC channel,
  it quits its message loop (= stops the thread).

Problem:
The browser process' IOThread calls InProcessGpuThread::StopSoon()
while the in-process GPU thread destructs itself.

When InProcessGpuThread::StopSoon asks for task_runner() the in-process
GPU thread has - sometimes - already destructed itself and its
MessageQueue. The IOThread then sees task_runner() == null and crashes:

[FATAL:ref_counted.h(484)] Assert failed: ptr_ != nullptr.
0 base::debug::StackTrace::StackTrace()
1 base::debug::StackTrace::StackTrace()
2 logging::LogMessage::~LogMessage()
3 base::Thread::StopSoon()
4 base::Thread::Stop()
5 content::InProcessGpuThread::~InProcessGpuThread()
6 content::InProcessGpuThread::~InProcessGpuThread()
7 content::GpuProcessHost::~GpuProcessHost()
8 content::GpuProcessHost::~GpuProcessHost()
9 content::BrowserChildProcessHostImpl::TerminateAll()
10 content::BrowserProcessSubThread::IOThreadPreCleanUp()
11 content::BrowserProcessSubThread::CleanUp()
12 base::Thread::ThreadMain()
13 base::(anonymous namespace)::ThreadFunc()

Solution:
If a thread runs in the browser process, only Thread::Stop should
stop its message loop. Otherwise, QuitWhenIdle could race Thread::Stop.

BUG=258935

Review-Url: https://codereview.chromium.org/2973723003
Cr-Commit-Position: refs/heads/master@{#485895}

This matches the behavior of --force-device-scale-factor.

Move the checks for "is the color profile forced" from
the implementation of ICCProfile::FromBestMonitor to the
call sites to avoid layering violations.

Bug: 740663
Change-Id: I8f37b8b5ca6300465a1e7e0132e587378805a813
Reviewed-on: https://chromium-review.googlesource.com/565763
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485894}

As a result of centralizing script execution and load/error event
dispatching into ScriptLoader::ExecuteScriptBlock(), ExecuteScript(),
DispatchLoadEvent() and DispatchErrorEvent() are now called only
from ScriptLoader.

Bug: 686281
Change-Id: I47f7b1c0d79d9d7bc586cb02028d72260f20be7b
Reviewed-on: https://chromium-review.googlesource.com/557383
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485893}

This is a generated CL to rewrite base::Bind to base::BindOnce where
the result of base::Bind is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

An explainer of OnceCallback is available here goo.gl/YZiUL1.

The rewriting tool is in //tools/clang/base_bind_rewriters. To build and
run locally, follow //docs/clang_tool_refactoring.md.

This conversion makes almost no behavior change except that a bound
objects are passed-by-move to the target function.

Bug: 554299, 714018
Change-Id: Ief819fd7850d61a377300d61fd5a317104084c77
Reviewed-on: https://chromium-review.googlesource.com/547179Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485892}

Now that ResourceLoadScheduler depends on WebFrameScheduler, and it is
useful to enable ResourceLoadScheduler even on platform unit tests,
let's introduce a simple mocked WebFrameScheduler that allows
calling MockFetchContext::GetFrameScheduler(), and use it to call
{Add|Remove}ThrottlingObserver() for testing.

This also makes it possible to remove the test-only purposed
GetTaskRunner() method from the MockFetchContext, and makes
FetchTestingPlatformSupport consistent in terms of Blink scheduler.

Bug: 729953
Change-Id: Ib5ab2ad1c5b6ce2b4267667ad0b0cacbb1cc8f17
Reviewed-on: https://chromium-review.googlesource.com/563216
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485891}

This patch fixes two issues in NGInlineNode::ComputeMinMaxContentSize()

1. The max-content algorithm was incorrect. Fixed to compute the max of
   line widths when available width is infinite.
2. Negative text-indent can make min > max. CSSWG test indicates we
   should take min of the two values in the case.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2974823004
Cr-Commit-Position: refs/heads/master@{#485890}