- 10 Dec, 2019 40 commits
-
-
Finnur Thorarinsson authored
This CL adds a circular background to the Zoom icons (on top of the navigation_bubble_shadow). The circular background supports Dark mode (is gray when Dark mode is enabled, and white when not). Bug: 656015 Change-Id: Ibf91c607add40be77807b88f66a7ed82f2955266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959031 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#723392}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1dc90350c4e57acc99575912cc6f2e0c17a60687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723391}
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION to adopt new downcast helpers. This CL removes DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION for - HTMLFormControlElement, - HTMLFrameElementBase, - HTMLPlugInElement, - HTMLMediaElement Bug: 891908 Change-Id: Ia8d6ede04931b596fe347e59cca0dc15bfbee335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959912Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723390}
-
Wez authored
Bug: 1025372 Change-Id: I0489b76bf859ab097f5c4e62a55938cbdd7064e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957174 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#723389}
-
Mark Cogan authored
There is no longer a cast service to initialize, so the cast service init can be removed from the provider. This also removes use of TabModel in the provider API. Change-Id: If618ff507104bfdd41d38b01cd9ec7087a7e66e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960450 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723388}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1023677 Change-Id: I6584031bf0f103e6036009dfcac49b5541bce09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957550 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723387}
-
Philipp Hancke authored
adds webrtc-internals support for pc.onicecandidateerror so that it shows up in webrtc-internals dumps BUG=webrtc:3098 Change-Id: I671e59d8f7b634896f89445c90e274e7c18449bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959965Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#723386}
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION to adopt new downcast helpers. This CL removes DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION for - SVGSMILElement, - SVGFELightElement, - SVGGeometryElement, - SVGGraphicsElement, - SVGPolyElement Bug: 891908 Change-Id: I8c9a76272baa2d8a911ea60d57f263b142301e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958425Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723385}
-
Mihai Sardarescu authored
This CL removes the account mappings from the GCMStoreImpl during the migration of the CoreAccountId from email to a Gaia ID. This is required as the key of account mapping map stored on disk which was based on the email does not correspond to the account ID once the identity manager starts using Gaia IDs as the identifiers of an account. Bug: 1028505 Change-Id: Ie4470d4f36a1fc7e15d488daf1ca5919932fd02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954020Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#723384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d1980c3a28d4..b2f0eb83d735 git log d1980c3a28d4..b2f0eb83d735 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 vapier@chromium.org portage_util_unittest: drop fileinput usage 2019-12-10 achuith@chromium.org chrome_chromeos_lkgm: Add abandon message. 2019-12-10 achuith@chromium.org chrome_committer: Refactor arg passing. 2019-12-10 achuith@chromium.org cros_flash: Allow cros flash to be run from simple chrome. 2019-12-10 ahassani@chromium.org common_util.py: return string from GetFileSha256 2019-12-10 matthewb@google.com licensing: Delete obsolete section of licenses.py module docstring. 2019-12-10 matthewb@google.com licensing: Update some URLs and wrapped lines. 2019-12-10 vapier@chromium.org cbuildbot: drop build_before_patching/do_not_apply_cq_patches 2019-12-10 sanikak@chromium.org auto_updater: Modifying FixPayloads() method for LabTransfer usecase 2019-12-10 andrewlamb@chromium.org Add function to get package root in source tree. 2019-12-10 achuith@chromium.org path_util: Default to os.getcwd() 2019-12-10 vapier@chromium.org trybot_patch_pool: delete unused FilterGitRemoteUrl 2019-12-10 saklein@chromium.org Sdk/Update example input: Remove second board. 2019-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-09 achuith@chromium.org flash_unittest: Use better mock for os.path.exists 2019-12-09 vapier@chromium.org cbuildbot: drop unused Chrome PFQ modules 2019-12-09 vapier@chromium.org run_tests: clear root owned cache files 2019-12-09 saklein@chromium.org Build API: Add synced directory mechanism. Created with: gclient setdep -r src/third_party/chromite@b2f0eb83d735 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I9ab4f3f96b5e304d4ce3baef65dc540c3b20a067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960396Reviewed-by:
-
jongdeok.kim authored
This CL enables to increase/decrease gfx::Size by gfx::Insets. Addition/subtraction(assignment) operators are added to gfx::Size. size() method is also added to gfx::Insets. Change-Id: I03f57ccf3447d6b06857ce358a3433dd61148180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913235 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#723382}
-
Mikhail Khokhlov authored
Removes trace processor output from logs. Unifies log format. Leaves at most one info log message per processing stage. Bug: 981349 Change-Id: I7cc5abe2e8d06504ca2ff885800d23798251d10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953605Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#723381}
-
Raphael Kubo da Costa authored
* 43df68be51 testdriver.js: Make set_permission() take a PermissionDescriptor, not a name * 302caa87f6 Add `Set Permission` API to testdriver.js (#20461) * 18921c7b15 Implement the Virtual Authenticator testdriver API (#19579) The main goal is to make test_driver.set_permission() available outside WPT. Bug: 1030663 Change-Id: Ia605bbb1043f444854b44634d8f36cff4dcf28a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959974Reviewed-by:Luke Z <lpz@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#723380}
-
Mark Cogan authored
This CL updates FormInputAccessoryCoordinator to use the browser-based initializers, also updating all FallbackCoordinator subclasses. CardCoordinator and AddressCoordinator internally get the non-OTR browser state to load services; this matches the prior behavior where the non-OTR browser state was injected by calling code. Bug: 1029346 Change-Id: I72d13ecfa5f606db4130c4801d671f3700f6f88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944352Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#723379}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab26643258ad..732c49739fa5 git log ab26643258ad..732c49739fa5 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 nifong@google.com Return image address in image info so it can be shown in dropdown. Created with: gclient setdep -r src/third_party/skia@732c49739fa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ibe88affe77c0457eb330311424a867fd3b1a7882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960394Reviewed-by:
-
Greg Kerr authored
This syscall is required by the tracing code, which runs across process types. Bug: 1030576 Change-Id: I87aab67901a8ff211627052a7d562636034c2308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957843 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#723377}
-
Polina Bondarenko authored
Add last sent ArcPolicy JSON value and last received policy compliance report to a feedback report generated by Alt-Shift-I. Bug: b:62365936 Test: unit_tests Test: manual Alt-Shift-I Change-Id: I8783898102c88c250bf0e1b88018accd3d0f1731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932536Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#723376}
-
Kevin McNee authored
This test was converted from a test that was marked as flaky on Mac. It may be that the rewritten test is not flaky, so we attempt to enable it. Bug: 415949 Change-Id: I9381562c9370f66d7690c36256ac6e325f962f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958590 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#723375}
-
Kevin McNee authored
This aligns more closely with our current thinking around session history for portals. Maintaining a session history which is completely disconnected from the user's real session history is of dubious value. It's conceptually simpler to think of portals as not having a session history (or at least having a trivial one), as this better reflects how portals are represented to the user. Bug: 914108 Change-Id: Ifa8f26b5dfad20a465673985d1c39ca36b2fde0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954344Reviewed-by:
-
Mikel Astiz authored
Logic in model_type_worker.cc has grown to large already and is now moved to a separate file, with dedicated tests. The code is moved as-is with minor trivial naming changes and tests are newly added. Bug: 978430,1007199 Change-Id: Iba79cc3014ae631e1e2029e6fc8a0a9a832a38cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953729 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#723373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ee0ceeba07c..ab09a60e40ad Created with: gclient setdep -r src-internal@ab09a60e40ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I07837d981f0a1b69ea28d52ddb4d032f474717f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960393Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723372}
-
Stepan Khapugin authored
Subj, and fix remaining decoupling issues Change-Id: I1e8c57d5acb7ad34a7787982fffdc17c9896e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951014 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Nazerke authored
google_services_settings_egtest.mm This CL removed extra headers and deps from BUILD file in make the further eg2 conversion easier. Bug: none Change-Id: Ia96a3f877928b189a7063577d7dd5245fa73c23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959001 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#723370}
-
Weiliang Chen authored
This is a pretty straightforward splitting of OverlayProcessor interface and implementation. This splits out the interface to be shared with OverlayProcessor (Mac and Windows for now), and OverlayProcessorStrategy (Ozone and Android). The next step would to be further split subclass to be on different platforms. This is CL 5/? of overlay processor refactor. R=rjkroege TBR=kylechar Bug: 963597 Change-Id: I7571a9e13b7fc4cc5d2dcbfbc39699e7d03d06ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951654Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#723369}
-
Mark Cogan authored
PageInfoLegacyCoordinator had explicit CommandDispatcher and WebStateList properties. This CL updates it to use the preferred init for coordinators, which provides a Browser instance which includes those parameters. Bug: 1029346 Change-Id: I4dba47e5a737d001941cfff8049764324d59eb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942436 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This reverts commit 45b7e665. Reason for revert: compile failure Original change's description: > Roll src/third_party/perfetto 49d99fe889d2..78598b90be18 (3 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..78598b90be18 > > git log 49d99fe889d2..78598b90be18 --date=short --first-parent --format='%ad %ae %s' > 2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping" > 2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ... > 2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables > > Created with: > gclient setdep -r src/third_party/perfetto@78598b90be18 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:135177627 > Tbr: perfetto-bugs@google.com > Change-Id: Ifb16485d12c872534e9c9947a333bc1b338a3ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960386 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#723356} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I432ac756993a2a663b9b8ef22d8dbdf83fdc0d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:135177627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960452Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#723367}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce38cc10b0ba..f880a70cb757 git log ce38cc10b0ba..f880a70cb757 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 tvanderlippe@chromium.org Reland "Migrate test_runner/ to ESM" 2019-12-10 aerotwist@chromium.org Adds migration script for refs Created with: gclient setdep -r src/third_party/devtools-frontend/src@f880a70cb757 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1019182,chromium:1032477 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idc6cbb5895363e25b0e609ff02e12c644f696c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960392Reviewed-by:
-
Gauthier Ambard authored
This CL stops the NTP coordinator when the NTP should be hidden. This is necessary because crrev.com/c/1953764 remove the call to -stop in dealloc for the coordinators. Fixed: 1032191 Change-Id: Ibcd22388b0759ca1ba87cb302dbadb3f3a2277f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959002Reviewed-by:
-
Mohammad Refaat authored
SessionService has a savesession method which used to take a code block that creates a session and execute with a delay. The problem with that is it depended on TabModel existence to check if it can create a session for saving or not. Instead create a real SessionIOSFactory for now it's owned by TabModel, but later it will be owned by SessionRestorationAgent. The SessionIOSFactory will have a webStateList and will create a sessionIOS object serializing this webStateList when it's asked for. It's assuming that as long as the object for the SessionIOSFactory is alive, then the member webStateList will be alive. So it can use it directly to create a session whenever it needs to. SessionService now takes the factory as a weak pointer and it doesn't retain it. So if the owner is deallocated (now it's the TabModel, and it will be SessionRestorationAgent later) then the factory will be nil and it will not create a session. Bug: 1010164 Change-Id: Ie168fc26a57997be59e123f4ac449d063a3de929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953084Reviewed-by:
-
Christopher Grant authored
Bug: None Change-Id: Ied465ba1ddd300685376b8bded596cbcb7ba757f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958710 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723363}
-
Hajime Hoshi authored
R=yuzus@chromium.org NOTRY=true Change-Id: I1fe2e132c4f582fae0e33b450d1f31765d8a4b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954812Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#723362}
-
W. James MacLean authored
We can create a spurious MimeHandlerViewContainerManager (MHVCM) if we try to destroy a frame container where none exists (e.g. the AssociatedInterfaces framework instantiates a new MHVCM in order to dispatch the DestroyFrameContainer message). While this ideally should not happen (https://crbug.com/1027198), if it does we should remove the spurious MHVCM to avoid causing problems with print dialogs. Bug: 1013635 Change-Id: Iba6c1d8eaf1970b3bcdcb9e96c834ada7c0ed0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929399Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#723361}
-
Elly Fong-Jones authored
This change breaks deps on: * ExtensionInstalledBubble::options() * ExtensionInstalledBubble::browser() * ExtensionInstalledBubble::GetAnchorPoint() The options one is annoying - there is a function called `GetOptionsForExtension` that computed a bitfield here to be passed into the view itself. This change replaces that function and that bitfield with a bunch of free functions, each of which compute one of the option values. I think the overall result is easier to reason about. The browser one is straightforward. The GetAnchorPoint one was dead code in Views anyway - the implementation actually lives in this file in //cbui/v and not with the rest of the class, and it simply does: gfx::Point ExtensionInstalledBubble::GetAnchorPoint( gfx::NativeWindow window) const { NOTREACHED(); // There is always an anchor view. return gfx::Point(); } So the code now checks and relies on that assumption. Bug: 496955 Change-Id: Ic5d32d33bb6f50a02d95e46c4d937605f2aa88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958827 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723360}
-
Raphael Kubo da Costa authored
set_permission.html was renamed to set_permission.https.html in https://crrev.com/c/1958825, but for some reason this old expectation file was not removed. TBR=smcgruer Change-Id: Iba55d41cf45c3b15af1d2d0d7bd10e572bbefe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959972Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#723359}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cf92db35cb9..bb7c3388a50c git log 4cf92db35cb9..bb7c3388a50c --date=short --first-parent --format='%ad %ae %s' 2019-12-10 capn@google.com Remove Visual Studio Vulkan project files Created with: gclient setdep -r src/third_party/swiftshader@bb7c3388a50c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If32ba7c8d4a8bd0c52b1740bc542d78ad171014e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960387Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7dab0d16f191a89f955203c779bd4882a66594eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956971Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#723357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..78598b90be18 git log 49d99fe889d2..78598b90be18 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping" 2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ... 2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables Created with: gclient setdep -r src/third_party/perfetto@78598b90be18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Ifb16485d12c872534e9c9947a333bc1b338a3ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960386Reviewed-by:
-
Maksim Moskvitin authored
This reverts commit f2da03d5. Reason for revert: likely culprit for compare_build_artifacts failures on Deterministic Linux (dbg). See crbug.com/1032241 (#20-#23). Original change's description: > Roll clang n332890-c2443155-1 : n333441-a3839693-1. > > Ran `tools/clang/scripts/upload_revision.py a38396939c548f9ad8e94c9baa7198fdb26dedc2`. > > Bug: 1030664 > Change-Id: I75c3a43c4f66fe8d850902c60eead4ff6991fba1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958044 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723039} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Iefc4ab5e5b0afe379e3fabd174703baf57f8e3d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664, 1032241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960270Reviewed-by:
-
Justin Miron authored
This change introduces a new histogram, HeavyAds.NetworkBytesAtFrameUnload, which records a frame's network bytes when it is unloaded by the heavy ads intervention for network usage. This enables monitoring the discrepancy in network byte usage from the intervention limits due to asynchrony between the browser and renderer processes. BUG=985890 Change-Id: Ibf0cc400ada3423459e29a07d374e8a8b7ff33bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954736Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#723354}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I223cd0bf8be6b301f78bc431f594887a6aa1a0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960405Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723353}
-
